Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
Hello. On 14-03-2014 5:57, Peter Chen wrote: According to Power_ePAPR_APPROVED_v1.1.pdf ethernet-phy is the node name, it is the same with Sergei's suggestion. Nobody's talking about ehternet-phy here. Hmm, you take ethernet-phy as an example, and suggest changing to usb-phy at last email. Then it's a wrong mail. I'm not mixing nodes and properties. But you have changed the property name at this patch, in fact, fsl,usbphy is ok for property name, fsl,usb-phy may be better, but not worth a patch to change it. No, it's not better and both are not OK because they're still Freescale specific while the de-facto standard property usb-phy is already used by other USB drivers for the same purpose. Am I missing something, property name should be the same for all platforms? If they're doing the same standard thing, yes. Peter WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
Hello. On 13-03-2014 7:17, Peter Chen wrote: It also adapt the dts that uses it. Signed-off-by: Denis Carikli de...@eukrea.com [...] According to Power_ePAPR_APPROVED_v1.1.pdf ethernet-phy is the node name, it is the same with Sergei's suggestion. Nobody's talking about ehternet-phy here. But you have changed the property name at this patch, in fact, fsl,usbphy is ok for property name, fsl,usb-phy may be better, but not worth a patch to change it. No, it's not better and both are not OK because they're still Freescale specific while the de-facto standard property usb-phy is already used by other USB drivers for the same purpose. Peter WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
According to Power_ePAPR_APPROVED_v1.1.pdf ethernet-phy is the node name, it is the same with Sergei's suggestion. Nobody's talking about ehternet-phy here. Hmm, you take ethernet-phy as an example, and suggest changing to usb-phy at last email. But you have changed the property name at this patch, in fact, fsl,usbphy is ok for property name, fsl,usb-phy may be better, but not worth a patch to change it. No, it's not better and both are not OK because they're still Freescale specific while the de-facto standard property usb-phy is already used by other USB drivers for the same purpose. Am I missing something, property name should be the same for all platforms? At Power_ePAPR_APPROVED_v1.1, page 18, the example property name like below: fsl,channel-fifo-len ibm,ppc-interrupt-server#s linux,network-index Peter -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
This converts the Chipidea usbmisc driver to use the standard usb-phy property. It also adapt the dts that uses it. Signed-off-by: Denis Carikli de...@eukrea.com --- arch/arm/boot/dts/imx23.dtsi |2 +- arch/arm/boot/dts/imx27.dtsi |4 ++-- arch/arm/boot/dts/imx28.dtsi |4 ++-- arch/arm/boot/dts/imx51.dtsi |2 +- arch/arm/boot/dts/imx53.dtsi |4 ++-- arch/arm/boot/dts/imx6qdl.dtsi |4 ++-- arch/arm/boot/dts/imx6sl.dtsi |4 ++-- drivers/usb/chipidea/ci_hdrc_imx.c |2 +- 8 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi index bbcfb5a..e3c9924 100644 --- a/arch/arm/boot/dts/imx23.dtsi +++ b/arch/arm/boot/dts/imx23.dtsi @@ -522,7 +522,7 @@ compatible = fsl,imx23-usb, fsl,imx27-usb; reg = 0x8008 0x4; interrupts = 11; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; clocks = clks 40; status = disabled; }; diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 83a8247..94bcf1a 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -466,7 +466,7 @@ interrupts = 56; clocks = clks 15; fsl,usbmisc = usbmisc 0; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; status = disabled; }; @@ -485,7 +485,7 @@ interrupts = 55; clocks = clks 15; fsl,usbmisc = usbmisc 2; - fsl,usbphy = usbphy2; + usb-phy = usbphy2; status = disabled; }; diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 90a5795..52ad72f 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -1143,7 +1143,7 @@ reg = 0x8008 0x1; interrupts = 93; clocks = clks 60; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; status = disabled; }; @@ -1152,7 +1152,7 @@ reg = 0x8009 0x1; interrupts = 92; clocks = clks 61; - fsl,usbphy = usbphy1; + usb-phy = usbphy1; status = disabled; }; diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index cb3204a..b290947 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -249,7 +249,7 @@ interrupts = 18; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 0; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; status = disabled; }; diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index f0962e5..b10a3de 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -276,7 +276,7 @@ interrupts = 18; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 0; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; status = disabled; }; @@ -286,7 +286,7 @@ interrupts = 14; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 1; - fsl,usbphy = usbphy1; + usb-phy = usbphy1; status = disabled; }; diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index cfc85be..d2f0087 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -789,7 +789,7 @@ reg = 0x02184000 0x200; interrupts = 0 43 IRQ_TYPE_LEVEL_HIGH; clocks = clks 162; - fsl,usbphy = usbphy1; + usb-phy = usbphy1; fsl,usbmisc = usbmisc 0; status = disabled; }; @@ -799,7 +799,7 @@ reg = 0x02184200
Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
Hi,
Denis Carikli wrote:
This converts the Chipidea usbmisc driver to
use the standard usb-phy property.
[...]
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index c00f772..9a74100 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -130,7 +130,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
return ret;
}
- data-phy = devm_usb_get_phy_by_phandle(pdev-dev, fsl,usbphy, 0);
+ data-phy = devm_usb_get_phy_by_phandle(pdev-dev, usb-phy, 0);
if (IS_ERR(data-phy)) {
ret = PTR_ERR(data-phy);
goto err_clk;
How about accepting the old property too and print a warning, that it is
deprecated, rather than breaking all existing DT blobs?
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | i...@karo-electronics.de
___
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
Среда, 12 марта 2014, 11:19 +01:00 от Lothar Waßmann l...@karo-electronics.de:
Hi,
Denis Carikli wrote:
This converts the Chipidea usbmisc driver to
use the standard usb-phy property.
[...]
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index c00f772..9a74100 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -130,7 +130,7 @@ static int ci_hdrc_imx_probe(struct platform_device
*pdev)
return ret;
}
- data-phy = devm_usb_get_phy_by_phandle(pdev-dev, fsl,usbphy, 0);
+ data-phy = devm_usb_get_phy_by_phandle(pdev-dev, usb-phy, 0);
if (IS_ERR(data-phy)) {
ret = PTR_ERR(data-phy);
goto err_clk;
How about accepting the old property too and print a warning, that it is
deprecated, rather than breaking all existing DT blobs?
And this change should be reflected in the bindings documentation.
---
RE: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
It also adapt the dts that uses it. Signed-off-by: Denis Carikli de...@eukrea.com --- arch/arm/boot/dts/imx23.dtsi |2 +- arch/arm/boot/dts/imx27.dtsi |4 ++-- arch/arm/boot/dts/imx28.dtsi |4 ++-- arch/arm/boot/dts/imx51.dtsi |2 +- arch/arm/boot/dts/imx53.dtsi |4 ++-- arch/arm/boot/dts/imx6qdl.dtsi |4 ++-- arch/arm/boot/dts/imx6sl.dtsi |4 ++-- drivers/usb/chipidea/ci_hdrc_imx.c |2 +- 8 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi index bbcfb5a..e3c9924 100644 --- a/arch/arm/boot/dts/imx23.dtsi +++ b/arch/arm/boot/dts/imx23.dtsi @@ -522,7 +522,7 @@ compatible = fsl,imx23-usb, fsl,imx27-usb; reg = 0x8008 0x4; interrupts = 11; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; clocks = clks 40; status = disabled; }; diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index 83a8247..94bcf1a 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -466,7 +466,7 @@ interrupts = 56; clocks = clks 15; fsl,usbmisc = usbmisc 0; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; status = disabled; }; @@ -485,7 +485,7 @@ interrupts = 55; clocks = clks 15; fsl,usbmisc = usbmisc 2; - fsl,usbphy = usbphy2; + usb-phy = usbphy2; status = disabled; }; diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 90a5795..52ad72f 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -1143,7 +1143,7 @@ reg = 0x8008 0x1; interrupts = 93; clocks = clks 60; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; status = disabled; }; @@ -1152,7 +1152,7 @@ reg = 0x8009 0x1; interrupts = 92; clocks = clks 61; - fsl,usbphy = usbphy1; + usb-phy = usbphy1; status = disabled; }; diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index cb3204a..b290947 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -249,7 +249,7 @@ interrupts = 18; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 0; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; status = disabled; }; diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index f0962e5..b10a3de 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -276,7 +276,7 @@ interrupts = 18; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 0; - fsl,usbphy = usbphy0; + usb-phy = usbphy0; status = disabled; }; @@ -286,7 +286,7 @@ interrupts = 14; clocks = clks IMX5_CLK_USBOH3_GATE; fsl,usbmisc = usbmisc 1; - fsl,usbphy = usbphy1; + usb-phy = usbphy1; status = disabled; }; diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index cfc85be..d2f0087 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -789,7 +789,7 @@ reg = 0x02184000 0x200; interrupts = 0 43 IRQ_TYPE_LEVEL_HIGH; clocks = clks 162; - fsl,usbphy = usbphy1; + usb-phy = usbphy1; fsl,usbmisc = usbmisc 0; status = disabled; }; @@ -799,7 +799,7 @@ reg = 0x02184200 0x200; interrupts = 0 40 IRQ_TYPE_LEVEL_HIGH;
