[PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support
This series adds RZ/A1 gadget support to the renesas_usbhs driver. Basically, it's almost the same HW as the R-Car (and SH) parts. The only real difference is the some extra registers for the PHY. This was tested on an RSK board by connecting to a PC as an Ethernet CDC gadget. v3: * Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs" * Removed "renesas,usbhs-r7s72100" * Changed License of rza.c v2: * Node name is now generic 'usb@' * GIC_SPI (73-32) is now just GIC_SPI 41 * All hex number are lower case * Added Reviewed-by Chris Brandt (3): usb: renesas_usbhs: Add support for RZ/A1 dt-bindings: usb: renesas_usbhs: Add support for RZ/A1 ARM: dts: r7s72100: add USB device to device tree .../devicetree/bindings/usb/renesas_usbhs.txt | 1 + arch/arm/boot/dts/r7s72100.dtsi| 20 + drivers/usb/renesas_usbhs/Makefile | 2 +- drivers/usb/renesas_usbhs/common.c | 13 ++ drivers/usb/renesas_usbhs/common.h | 6 +++ drivers/usb/renesas_usbhs/rza.c| 52 ++ drivers/usb/renesas_usbhs/rza.h| 4 ++ include/linux/usb/renesas_usbhs.h | 1 + 8 files changed, 98 insertions(+), 1 deletion(-) create mode 100644 drivers/usb/renesas_usbhs/rza.c create mode 100644 drivers/usb/renesas_usbhs/rza.h -- 2.15.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support
Hi Chris,
On Fri, Jan 5, 2018 at 11:46 PM, Chris Brandt wrote:
> This series adds RZ/A1 gadget support to the renesas_usbhs driver.
> Basically, it's almost the same HW as the R-Car (and SH) parts.
> The only real difference is the some extra registers for the PHY.
>
> This was tested on an RSK board by connecting to a PC as an
> Ethernet CDC gadget.
>
> v3:
> * Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs"
> * Removed "renesas,usbhs-r7s72100"
> * Changed License of rza.c
Thanks for the update, but I think there has been a misunderstanding.
I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from
the matching in the driver.
Summarized:
1. DT bindings should document _all_ compatible values (SoC-specific,
and/or family-specific, generic, ...),
2. DTS should list _all applicable_ compatible values, ordered from
most-specific to least-specific,
3. Drivers should match against the least-specific compatible value to get
the job done.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support
Hi Geert and Simon,
On Monday, January 08, 2018, Geert Uytterhoeven wrote:
> Thanks for the update, but I think there has been a misunderstanding.
> I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from
> the matching in the driver.
Opps, I was all kinds of confused then.
So, before I submit a V4, here is my understanding:
drivers/.../common.c
* contains -only- '.compatible = "renesas,rza1-usbhs"'
Documentation/.../renesas_usbhs.txt
* contains both "renesas,usbhs-r7s72100" and "renesas,rza1-usbhs"
r7s72100.dtsi
* usbhs0: usb@e801 {
compatible = "renesas,usbhs-r7s72100", "renesas,rza1-usbhs";
Is this correct?
Thanks,
Chris
Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support
On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt wrote:
> Hi Geert and Simon,
>
>
> On Monday, January 08, 2018, Geert Uytterhoeven wrote:
>> Thanks for the update, but I think there has been a misunderstanding.
>> I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from
>> the matching in the driver.
>
>
> Opps, I was all kinds of confused then.
>
>
> So, before I submit a V4, here is my understanding:
>
>
> drivers/.../common.c
> * contains -only- '.compatible = "renesas,rza1-usbhs"'
>
>
> Documentation/.../renesas_usbhs.txt
> * contains both "renesas,usbhs-r7s72100" and "renesas,rza1-usbhs"
>
>
> r7s72100.dtsi
> * usbhs0: usb@e801 {
> compatible = "renesas,usbhs-r7s72100", "renesas,rza1-usbhs";
>
>
> Is this correct?
>
> Thanks,
> Chris
--
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support
Hi Chris,
On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt wrote:
> On Monday, January 08, 2018, Geert Uytterhoeven wrote:
>> Thanks for the update, but I think there has been a misunderstanding.
>> I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from
>> the matching in the driver.
>
> Opps, I was all kinds of confused then.
>
> So, before I submit a V4, here is my understanding:
>
> drivers/.../common.c
> * contains -only- '.compatible = "renesas,rza1-usbhs"'
OK.
> Documentation/.../renesas_usbhs.txt
> * contains both "renesas,usbhs-r7s72100" and "renesas,rza1-usbhs"
OK.
> r7s72100.dtsi
> * usbhs0: usb@e801 {
> compatible = "renesas,usbhs-r7s72100", "renesas,rza1-usbhs";
OK.
> Is this correct?
Yes.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support
On Mon, Jan 08, 2018 at 01:15:08PM +0100, Geert Uytterhoeven wrote:
> Hi Chris,
>
> On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt
> wrote:
> > On Monday, January 08, 2018, Geert Uytterhoeven wrote:
> >> Thanks for the update, but I think there has been a misunderstanding.
> >> I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from
> >> the matching in the driver.
> >
> > Opps, I was all kinds of confused then.
> >
> > So, before I submit a V4, here is my understanding:
> >
> > drivers/.../common.c
> > * contains -only- '.compatible = "renesas,rza1-usbhs"'
>
> OK.
>
> > Documentation/.../renesas_usbhs.txt
> > * contains both "renesas,usbhs-r7s72100" and "renesas,rza1-usbhs"
>
> OK.
>
> > r7s72100.dtsi
> > * usbhs0: usb@e801 {
> > compatible = "renesas,usbhs-r7s72100", "renesas,rza1-usbhs";
>
> OK.
>
> > Is this correct?
>
> Yes.
Ack.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
