[PATCH v3 2/3] usb: phy: remove phy-msm-usb.c

2017-10-31 Thread Alex Elder
No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
any more, so remove the code.

Suggested-by: Stephen Boyd 
Signed-off-by: Alex Elder 
Acked-by: Bjorn Andersson 
Acked-by: Andy Gross 
---
 drivers/usb/phy/Kconfig   |   15 -
 drivers/usb/phy/Makefile  |1 -
 drivers/usb/phy/phy-msm-usb.c | 2085 -
 3 files changed, 2101 deletions(-)
 delete mode 100644 drivers/usb/phy/phy-msm-usb.c

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index aff702c0eb9f..f5775e5c9f52 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -137,21 +137,6 @@ config USB_ISP1301
  To compile this driver as a module, choose M here: the
  module will be called phy-isp1301.
 
-config USB_MSM_OTG
-   tristate "Qualcomm on-chip USB OTG controller support"
-   depends on (USB || USB_GADGET) && (ARCH_QCOM || COMPILE_TEST)
-   depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 
'y'
-   depends on RESET_CONTROLLER
-   select USB_PHY
-   help
- Enable this to support the USB OTG transceiver on Qualcomm chips. It
- handles PHY initialization, clock management, and workarounds
- required after resetting the hardware and power management.
- This driver is required even for peripheral only or host only
- mode configurations.
- This driver is not supported on boards like trout which
- has an external PHY.
-
 config USB_QCOM_8X16_PHY
tristate "Qualcomm APQ8016/MSM8916 on-chip USB PHY controller support"
depends on ARCH_QCOM || COMPILE_TEST
diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
index e7c9ca8cafb0..61013f38abbe 100644
--- a/drivers/usb/phy/Makefile
+++ b/drivers/usb/phy/Makefile
@@ -18,7 +18,6 @@ obj-$(CONFIG_TWL6030_USB) += phy-twl6030-usb.o
 obj-$(CONFIG_USB_EHCI_TEGRA)   += phy-tegra-usb.o
 obj-$(CONFIG_USB_GPIO_VBUS)+= phy-gpio-vbus-usb.o
 obj-$(CONFIG_USB_ISP1301)  += phy-isp1301.o
-obj-$(CONFIG_USB_MSM_OTG)  += phy-msm-usb.o
 obj-$(CONFIG_USB_QCOM_8X16_PHY)+= phy-qcom-8x16-usb.o
 obj-$(CONFIG_USB_MV_OTG)   += phy-mv-usb.o
 obj-$(CONFIG_USB_MXS_PHY)  += phy-mxs-usb.o
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
deleted file mode 100644
index 3d0dd2f97415..
--- a/drivers/usb/phy/phy-msm-usb.c
+++ /dev/null
@@ -1,2085 +0,0 @@
-/* Copyright (c) 2009-2011, Code Aurora Forum. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 and
- * only version 2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
- * 02110-1301, USA.
- *
- */
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-/**
- * OTG control
- *
- * OTG_NO_CONTROL  Id/VBUS notifications not required. Useful in host
- *  only configuration.
- * OTG_PHY_CONTROL Id/VBUS notifications comes form USB PHY.
- * OTG_PMIC_CONTROLId/VBUS notifications comes from PMIC hardware.
- * OTG_USER_CONTROLId/VBUS notifcations comes from User via sysfs.
- *
- */
-enum otg_control_type {
-   OTG_NO_CONTROL = 0,
-   OTG_PHY_CONTROL,
-   OTG_PMIC_CONTROL,
-   OTG_USER_CONTROL,
-};
-
-/**
- * PHY used in
- *
- * INVALID_PHY Unsupported PHY
- * CI_45NM_INTEGRATED_PHY  Chipidea 45nm integrated PHY
- * SNPS_28NM_INTEGRATED_PHYSynopsis 28nm integrated PHY
- *
- */
-enum msm_usb_phy_type {
-   INVALID_PHY = 0,
-   CI_45NM_INTEGRATED_PHY,
-   SNPS_28NM_INTEGRATED_PHY,
-};
-
-#define IDEV_CHG_MAX   1500
-#define IUNIT  100
-
-/**
- * Different states involved in USB charger detection.
- *
- * USB_CHG_STATE_UNDEFINED USB charger is not connected or detection
- *  process is not yet started.
- * USB_CHG_STATE_WAIT_FOR_DCD  Waiting for Data pins contact.
- * USB_CHG_STATE_DCD_DONE  Data pin contact is detected.
- * USB_CHG_STATE_PRIMARY_DONE  Primary detection is completed (Detects
- *  between SDP and DCP/CDP).
- * USB_CHG_STATE_SECONDARY_DONESeco

Re: [PATCH v3 2/3] usb: phy: remove phy-msm-usb.c

2017-11-02 Thread Jack Pham
Hi Alex,

On Tue, Oct 31, 2017 at 08:11:30AM -0500, Alex Elder wrote:
> No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
> any more, so remove the code.
> 
> Suggested-by: Stephen Boyd 
> Signed-off-by: Alex Elder 
> Acked-by: Bjorn Andersson 
> Acked-by: Andy Gross 
> ---


> -#include 

This file and ehci-msm.c were the last consumers of this header, so it
too can now be deleted. Has your series been picked up yet? If so I or
someone can send a follow-up patch.

Jack
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 2/3] usb: phy: remove phy-msm-usb.c

2017-11-03 Thread Alex Elder
On 11/02/2017 07:02 PM, Jack Pham wrote:
> Hi Alex,
> 
> On Tue, Oct 31, 2017 at 08:11:30AM -0500, Alex Elder wrote:
>> No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
>> any more, so remove the code.
>>
>> Suggested-by: Stephen Boyd 
>> Signed-off-by: Alex Elder 
>> Acked-by: Bjorn Andersson 
>> Acked-by: Andy Gross 
>> ---
> 
> 
>> -#include 
> 
> This file and ehci-msm.c were the last consumers of this header, so it
> too can now be deleted. Has your series been picked up yet? If so I or
> someone can send a follow-up patch.

Thanks for pointing that out!  I'll post a new patch now
to remove it.

-Alex
> 
> Jack
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html