Re: [PATCH v3 7/9] phy: add Broadcom Kona USB2 PHY DT binding

2013-11-27 Thread Matt Porter 
On Tue, Nov 26, 2013 at 04:01:05PM +0530, Kishon Vijay Abraham I wrote:
 Hi,
 
 On Monday 25 November 2013 11:46 PM, Matt Porter wrote:
  Add a binding that describes the Broadcom Kona USB2 PHY found
  on the BCM281xx family of SoCs.
  
  Signed-off-by: Matt Porter matt.por...@linaro.org
  ---
   .../devicetree/bindings/phy/bcm-kona-usb2-phy.txt | 15 
  +++
   1 file changed, 15 insertions(+)
   create mode 100644 
  Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt
  
  diff --git a/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt 
  b/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt
  new file mode 100644
  index 000..3dc8b3d
  --- /dev/null
  +++ b/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt
 
 you should name this bcm-phy. Then you can add binding info of all (future) 
 PHY
 IP from broadcom here.
 
 other than that this looks fine..

Ok, sounds reasonable. I've noticed that convention with the TI USB
bindings...I'll do the same.

 Acked-by: Kishon Vijay Abraham I kis...@ti.com
 
 Thanks
 Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 7/9] phy: add Broadcom Kona USB2 PHY DT binding

2013-11-26 Thread Kishon Vijay Abraham I 
Hi,

On Monday 25 November 2013 11:46 PM, Matt Porter wrote:
 Add a binding that describes the Broadcom Kona USB2 PHY found
 on the BCM281xx family of SoCs.
 
 Signed-off-by: Matt Porter matt.por...@linaro.org
 ---
  .../devicetree/bindings/phy/bcm-kona-usb2-phy.txt | 15 
 +++
  1 file changed, 15 insertions(+)
  create mode 100644 
 Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt
 
 diff --git a/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt 
 b/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt
 new file mode 100644
 index 000..3dc8b3d
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt

you should name this bcm-phy. Then you can add binding info of all (future) PHY
IP from broadcom here.

other than that this looks fine..
Acked-by: Kishon Vijay Abraham I kis...@ti.com

Thanks
Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 7/9] phy: add Broadcom Kona USB2 PHY DT binding

2013-11-25 Thread Matt Porter 
Add a binding that describes the Broadcom Kona USB2 PHY found
on the BCM281xx family of SoCs.

Signed-off-by: Matt Porter matt.por...@linaro.org
---
 .../devicetree/bindings/phy/bcm-kona-usb2-phy.txt | 15 +++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt

diff --git a/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt 
b/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt
new file mode 100644
index 000..3dc8b3d
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/bcm-kona-usb2-phy.txt
@@ -0,0 +1,15 @@
+BROADCOM KONA USB2 PHY
+
+Required properties:
+ - compatible: brcm,kona-usb2-phy
+ - reg: offset and length of the PHY registers
+ - #phy-cells: must be 0
+Refer to phy/phy-bindings.txt for the generic PHY binding properties
+
+Example:
+
+   usbphy: usb-phy@3f13 {
+   compatible = brcm,kona-usb2-phy;
+   reg = 0x3f13 0x28;
+   #phy-cells = 0;
+   };
-- 
1.8.4

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html