Re: [PATCH v4 00/11] usb: musb: add back support for host mode
On 10.04.2013 21:55, Daniel Mack wrote:
Hi all,
here are some patches to separate the HCD and gadget part of the musb
driver so they can be deselected in Kconfig. They also make the driver
keep track of the configured port mode that is set from DT, so the
actual runtime configuration can be selected dynamically.
One thing that is still broken is that once pm_suspend() was called on
a musb device on a USB disconnect, the port won't wake up again when a
device is plugged back in. I doubt this is related to my patches, but I
might be wrong. If that effect rings a bell to anyone, please let me
know.
Felipe, is there anything you want me to fix up in this version, or can
you queue it up for 3.11?
Thanks,
Daniel
Changes from v3:
* removed unnecessary indirection level via struct musb_hdc_link
* fixed a typo in commit log of patch 10/11
(all reported by Peter Korsgaard, thanks!)
Changes from v2:
* simplified Makefile rework
* really remove musb_to_hcd
* fixed some types
(all reported by Peter Korsgaard, thanks!)
Changes from v1:
* fixed some typos in commit logs
* factor out musb_host_resume_root_hub and
musb_host_poke_root_hub()
* split some changes into separate patches
* some minor cosmetics fixed
Daniel Mack (11):
usb: gadget: drop unused USB_GADGET_MUSB_HDRC
usb: musb: move function declarations to musb_{host,gadget}.h
usb: musb: factor some host-specific functions
usb: musb: gadget: remove hcd initialization
usb: musb: move musb_start to musb_virthub.c
usb: musb: factor out hcd initalization
usb: musb: add Kconfig options for HOST, GAGDET or DUAL_ROLE modes
usb: musb: add musb_host_setup() and musb_host_cleanup()
usb: musb: re-introduce musb-port_mode
usb: musb: use musb-port_mode
usb: musb: eliminate musb_to_hcd
drivers/usb/gadget/Kconfig | 8 ---
drivers/usb/musb/Kconfig| 29 +
drivers/usb/musb/Makefile | 4 +-
drivers/usb/musb/musb_core.c| 127
+++-
drivers/usb/musb/musb_core.h| 26 +++-
drivers/usb/musb/musb_gadget.c | 10
drivers/usb/musb/musb_gadget.h | 38 ++--
drivers/usb/musb/musb_host.c| 82 +++---
drivers/usb/musb/musb_host.h| 57 ++
drivers/usb/musb/musb_virthub.c | 51 +++-
drivers/usb/musb/omap2430.c | 2 +-
11 files changed, 286 insertions(+), 148 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 00/11] usb: musb: add back support for host mode
Hi, On Fri, Apr 26, 2013 at 11:26:49AM +0200, Daniel Mack wrote: On 10.04.2013 21:55, Daniel Mack wrote: Hi all, here are some patches to separate the HCD and gadget part of the musb driver so they can be deselected in Kconfig. They also make the driver keep track of the configured port mode that is set from DT, so the actual runtime configuration can be selected dynamically. One thing that is still broken is that once pm_suspend() was called on a musb device on a USB disconnect, the port won't wake up again when a device is plugged back in. I doubt this is related to my patches, but I might be wrong. If that effect rings a bell to anyone, please let me know. Felipe, is there anything you want me to fix up in this version, or can you queue it up for 3.11? we didn't even open v3.10 merge window yet... wait a few weeks, then I'll queue it -- balbi signature.asc Description: Digital signature
Re: [PATCH v4 00/11] usb: musb: add back support for host mode
On 26.04.2013 11:33, Felipe Balbi wrote: Hi, On Fri, Apr 26, 2013 at 11:26:49AM +0200, Daniel Mack wrote: On 10.04.2013 21:55, Daniel Mack wrote: Hi all, here are some patches to separate the HCD and gadget part of the musb driver so they can be deselected in Kconfig. They also make the driver keep track of the configured port mode that is set from DT, so the actual runtime configuration can be selected dynamically. One thing that is still broken is that once pm_suspend() was called on a musb device on a USB disconnect, the port won't wake up again when a device is plugged back in. I doubt this is related to my patches, but I might be wrong. If that effect rings a bell to anyone, please let me know. Felipe, is there anything you want me to fix up in this version, or can you queue it up for 3.11? we didn't even open v3.10 merge window yet... wait a few weeks, then I'll queue it OK, great. Thanks for the update :) Daniel -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 00/11] usb: musb: add back support for host mode
On 10.04.2013 21:55, Daniel Mack wrote:
Hi all,
here are some patches to separate the HCD and gadget part of the musb
driver so they can be deselected in Kconfig. They also make the driver
keep track of the configured port mode that is set from DT, so the
actual runtime configuration can be selected dynamically.
One thing that is still broken is that once pm_suspend() was called on
a musb device on a USB disconnect, the port won't wake up again when a
device is plugged back in. I doubt this is related to my patches, but I
might be wrong. If that effect rings a bell to anyone, please let me
know.
Felipe, are you happy with this version?
Changes from v3:
* removed unnecessary indirection level via struct musb_hdc_link
* fixed a typo in commit log of patch 10/11
(all reported by Peter Korsgaard, thanks!)
Changes from v2:
* simplified Makefile rework
* really remove musb_to_hcd
* fixed some types
(all reported by Peter Korsgaard, thanks!)
Changes from v1:
* fixed some typos in commit logs
* factor out musb_host_resume_root_hub and
musb_host_poke_root_hub()
* split some changes into separate patches
* some minor cosmetics fixed
Daniel Mack (11):
usb: gadget: drop unused USB_GADGET_MUSB_HDRC
usb: musb: move function declarations to musb_{host,gadget}.h
usb: musb: factor some host-specific functions
usb: musb: gadget: remove hcd initialization
usb: musb: move musb_start to musb_virthub.c
usb: musb: factor out hcd initalization
usb: musb: add Kconfig options for HOST, GAGDET or DUAL_ROLE modes
usb: musb: add musb_host_setup() and musb_host_cleanup()
usb: musb: re-introduce musb-port_mode
usb: musb: use musb-port_mode
usb: musb: eliminate musb_to_hcd
drivers/usb/gadget/Kconfig | 8 ---
drivers/usb/musb/Kconfig| 29 +
drivers/usb/musb/Makefile | 4 +-
drivers/usb/musb/musb_core.c| 127
+++-
drivers/usb/musb/musb_core.h| 26 +++-
drivers/usb/musb/musb_gadget.c | 10
drivers/usb/musb/musb_gadget.h | 38 ++--
drivers/usb/musb/musb_host.c| 82 +++---
drivers/usb/musb/musb_host.h| 57 ++
drivers/usb/musb/musb_virthub.c | 51 +++-
drivers/usb/musb/omap2430.c | 2 +-
11 files changed, 286 insertions(+), 148 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 00/11] usb: musb: add back support for host mode
Hi all,
here are some patches to separate the HCD and gadget part of the musb
driver so they can be deselected in Kconfig. They also make the driver
keep track of the configured port mode that is set from DT, so the
actual runtime configuration can be selected dynamically.
One thing that is still broken is that once pm_suspend() was called on
a musb device on a USB disconnect, the port won't wake up again when a
device is plugged back in. I doubt this is related to my patches, but I
might be wrong. If that effect rings a bell to anyone, please let me
know.
Thanks,
Daniel
Changes from v3:
* removed unnecessary indirection level via struct musb_hdc_link
* fixed a typo in commit log of patch 10/11
(all reported by Peter Korsgaard, thanks!)
Changes from v2:
* simplified Makefile rework
* really remove musb_to_hcd
* fixed some types
(all reported by Peter Korsgaard, thanks!)
Changes from v1:
* fixed some typos in commit logs
* factor out musb_host_resume_root_hub and
musb_host_poke_root_hub()
* split some changes into separate patches
* some minor cosmetics fixed
Daniel Mack (11):
usb: gadget: drop unused USB_GADGET_MUSB_HDRC
usb: musb: move function declarations to musb_{host,gadget}.h
usb: musb: factor some host-specific functions
usb: musb: gadget: remove hcd initialization
usb: musb: move musb_start to musb_virthub.c
usb: musb: factor out hcd initalization
usb: musb: add Kconfig options for HOST, GAGDET or DUAL_ROLE modes
usb: musb: add musb_host_setup() and musb_host_cleanup()
usb: musb: re-introduce musb-port_mode
usb: musb: use musb-port_mode
usb: musb: eliminate musb_to_hcd
drivers/usb/gadget/Kconfig | 8 ---
drivers/usb/musb/Kconfig| 29 +
drivers/usb/musb/Makefile | 4 +-
drivers/usb/musb/musb_core.c| 127 +++-
drivers/usb/musb/musb_core.h| 26 +++-
drivers/usb/musb/musb_gadget.c | 10
drivers/usb/musb/musb_gadget.h | 38 ++--
drivers/usb/musb/musb_host.c| 82 +++---
drivers/usb/musb/musb_host.h| 57 ++
drivers/usb/musb/musb_virthub.c | 51 +++-
drivers/usb/musb/omap2430.c | 2 +-
11 files changed, 286 insertions(+), 148 deletions(-)
--
1.8.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
