Re: [PATCH v6 2/2] usb: gadget: pxa27x_udc: add devicetree support

[Linus Walleij]

On Wed, Sep 24, 2014 at 9:41 PM, Robert Jarzmik  wrote:

> Add support for device-tree device discovery. If devicetree is not
> provided, fallback to legacy platform data "discovery".
>
> Signed-off-by: Robert Jarzmik 
> Cc: devicet...@vger.kernel.org
(...)
> @@ -2417,6 +2425,8 @@ static int pxa_udc_probe(struct platform_device *pdev)
> if (mach) {
> udc->gpiod = gpio_to_desc(mach->gpio_pullup);
> udc->udc_command = mach->udc_command;
> +   } else {
> +   udc->gpiod = devm_gpiod_get(&pdev->dev, NULL);
> }

Aha OK there it is.

devm_gpiod_get() actually uses three arguments now, you're using
a deprecated version of the interface:

struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
  const char *con_id,
  enum gpiod_flags flags);

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v6 2/2] usb: gadget: pxa27x_udc: add devicetree support

[Robert Jarzmik]

Add support for device-tree device discovery. If devicetree is not
provided, fallback to legacy platform data "discovery".

Signed-off-by: Robert Jarzmik 
Cc: devicet...@vger.kernel.org

---
Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc
  This is a consequence of other DT reviews on the marvell
  namings.
Since V2: address Mark's comments:
- wildcard pxa27x becomes pxa270
- pullup gpio is described as standard dt gpio
- bool XXX_probe_dt becomes int XXX_probe_dt
Since v5: split out into 2 patches, this one being the true device-tree port
---
 drivers/usb/gadget/udc/pxa27x_udc.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c 
b/drivers/usb/gadget/udc/pxa27x_udc.c
index e11f9c5..8961530 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -27,6 +27,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include 
 #include 
@@ -2400,6 +2402,12 @@ static struct pxa_udc memory = {
}
 };
 
+static struct of_device_id udc_pxa_dt_ids[] = {
+   { .compatible = "marvell,pxa270-udc" },
+   {}
+};
+MODULE_DEVICE_TABLE(of, udc_pxa_dt_ids);
+
 /**
  * pxa_udc_probe - probes the udc device
  * @_dev: platform device
@@ -2417,6 +2425,8 @@ static int pxa_udc_probe(struct platform_device *pdev)
if (mach) {
udc->gpiod = gpio_to_desc(mach->gpio_pullup);
udc->udc_command = mach->udc_command;
+   } else {
+   udc->gpiod = devm_gpiod_get(&pdev->dev, NULL);
}
 
regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -2608,6 +2618,7 @@ static struct platform_driver udc_driver = {
.driver = {
.name   = "pxa27x-udc",
.owner  = THIS_MODULE,
+   .of_match_table = of_match_ptr(udc_pxa_dt_ids),
},
.probe  = pxa_udc_probe,
.remove = pxa_udc_remove,
-- 
2.0.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html