Re: [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support
Hi, On 01/17/2014 06:12 PM, Alan Stern wrote: On Thu, 16 Jan 2014, Florian Fainelli wrote: Le mercredi 15 janvier 2014, 15:26:21 Alan Stern a �crit : On Wed, 15 Jan 2014, Hans de Goede wrote: Hi All, This version of my ohci and ehci-platform clks, phy and dt support patch-set, really fixes the 2 small bugs Alan found. All okay -- this time I can't find anything to complain about. :-) There is one minor issue; which is that the ehci binding claims the driver supports the following optional boolean properties: - big-endian-regs : boolean, set this for hcds with big-endian registers - big-endian-desc : boolean, set this for hcds with big-endian descriptors - big-endian : boolean, for hcds with big-endian-regs + big-endian-desc while it does not (yet) so this is misleading. Can we at get that fixed before merging? Copy pasting the PPC ehci driver should do the job. I agree it needs to be fixed. This can be done in a follow-up patch, though. It doesn't have to be in this one because nobody is using ehci-platform with DT yet. A simple copy from the PPC driver isn't quite enough, because the platform data settings would override the DT values. ehci_platform_reset has to be changed so that it sets ehci-big_endian_desc and _mmio if the pdata flags are set, but otherwise leaves them alone. Hans, would you like to write another patch to take care of this? I already took a quick look at this, setting the ehci-big_endian* flags is easy, the problem is that they won't work unless we also define CONFIG_USB_EHCI_BIG_ENDIAN_DESC and CONFIG_USB_EHCI_BIG_ENDIAN_MMIO I would like to avoid doing something like the ugliness we've with USB_OHCI_HCD_PPC_OF_BE and USB_OHCI_HCD_PPC_OF_LE, which means just selecting these 2 config options whenever USB_EHCI_HCD_PLATFORM is enabled, but I'm not sure if that is acceptable. The same goes for the ohci code btw. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support
On Sat, 18 Jan 2014, Hans de Goede wrote: A simple copy from the PPC driver isn't quite enough, because the platform data settings would override the DT values. ehci_platform_reset has to be changed so that it sets ehci-big_endian_desc and _mmio if the pdata flags are set, but otherwise leaves them alone. Hans, would you like to write another patch to take care of this? I already took a quick look at this, setting the ehci-big_endian* flags is easy, the problem is that they won't work unless we also define CONFIG_USB_EHCI_BIG_ENDIAN_DESC and CONFIG_USB_EHCI_BIG_ENDIAN_MMIO That's right. The platforms have to define those symbols if they use big-endian values (or even worse, mixed endian). I would like to avoid doing something like the ugliness we've with USB_OHCI_HCD_PPC_OF_BE and USB_OHCI_HCD_PPC_OF_LE, which means just selecting these 2 config options whenever USB_EHCI_HCD_PLATFORM is enabled, but I'm not sure if that is acceptable. At the moment, I don't think it's so terrible. That ohci_ppc ugliness probably could have been avoided originally. It looks like an attempt to make sure you don't end up matching the hardware to a driver built with the wrong endianness. I imagine it would be less messy to detect that sort of problem at runtime. The same goes for the ohci code btw. Certainly. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support
On Thu, 16 Jan 2014, Florian Fainelli wrote: Le mercredi 15 janvier 2014, 15:26:21 Alan Stern a �crit : On Wed, 15 Jan 2014, Hans de Goede wrote: Hi All, This version of my ohci and ehci-platform clks, phy and dt support patch-set, really fixes the 2 small bugs Alan found. All okay -- this time I can't find anything to complain about. :-) There is one minor issue; which is that the ehci binding claims the driver supports the following optional boolean properties: - big-endian-regs : boolean, set this for hcds with big-endian registers - big-endian-desc : boolean, set this for hcds with big-endian descriptors - big-endian : boolean, for hcds with big-endian-regs + big-endian-desc while it does not (yet) so this is misleading. Can we at get that fixed before merging? Copy pasting the PPC ehci driver should do the job. I agree it needs to be fixed. This can be done in a follow-up patch, though. It doesn't have to be in this one because nobody is using ehci-platform with DT yet. A simple copy from the PPC driver isn't quite enough, because the platform data settings would override the DT values. ehci_platform_reset has to be changed so that it sets ehci-big_endian_desc and _mmio if the pdata flags are set, but otherwise leaves them alone. Hans, would you like to write another patch to take care of this? Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support
Le mercredi 15 janvier 2014, 15:26:21 Alan Stern a écrit : On Wed, 15 Jan 2014, Hans de Goede wrote: Hi All, This version of my ohci and ehci-platform clks, phy and dt support patch-set, really fixes the 2 small bugs Alan found. All okay -- this time I can't find anything to complain about. :-) There is one minor issue; which is that the ehci binding claims the driver supports the following optional boolean properties: - big-endian-regs : boolean, set this for hcds with big-endian registers - big-endian-desc : boolean, set this for hcds with big-endian descriptors - big-endian : boolean, for hcds with big-endian-regs + big-endian-desc while it does not (yet) so this is misleading. Can we at get that fixed before merging? Copy pasting the PPC ehci driver should do the job. -- Florian -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support
Hi All, This version of my ohci and ehci-platform clks, phy and dt support patch-set, really fixes the 2 small bugs Alan found. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support
On Wed, 15 Jan 2014, Hans de Goede wrote: Hi All, This version of my ohci and ehci-platform clks, phy and dt support patch-set, really fixes the 2 small bugs Alan found. All okay -- this time I can't find anything to complain about. :-) Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
