Re: [PATCH v7 7/9] rcar-phy: add platform data

2013-05-17 Thread Felipe Balbi
On Wed, May 01, 2013 at 03:00:30AM +0400, Sergei Shtylyov wrote:
> Currently the driver hard-codes  USBPCTRL0 register to 0. It is wrong since 
> this
> register contains board-specific USB ports configuration and so its value 
> should
> be somehow passed via the platform data.  Add the global header file 
> containing
> 'struct rcar_phy_platform_data' consisting of the various bit fields 
> describing
> USB ports' pin configuration.
> 
> Signed-off-by: Sergei Shtylyov 
> Acked-by: Kuninori Morimoto 
> Acked-by: Simon Horman 

Acked-by: Felipe Balbi 

-- 
balbi


signature.asc
Description: Digital signature


[PATCH v7 7/9] rcar-phy: add platform data

2013-04-30 Thread Sergei Shtylyov
Currently the driver hard-codes  USBPCTRL0 register to 0. It is wrong since this
register contains board-specific USB ports configuration and so its value should
be somehow passed via the platform data.  Add the global header file containing
'struct rcar_phy_platform_data' consisting of the various bit fields describing
USB ports' pin configuration.

Signed-off-by: Sergei Shtylyov 
Acked-by: Kuninori Morimoto 
Acked-by: Simon Horman 

---
Changes since version 6:
- renamed the header file into , renamed the
  guarding #define accordingly;
- rephrased the changelog.

Changes since version 3:
- moved USBPCTRL0 register bit #define's to patch #9;
- replaced USBPCTRL0 register value in the platform data structure by a set of
  bit fields describing the configuration of the board, rewrote changelog;

Changes since version 2:
- added #include ;
- added ACKs from Simon Horman and Kuninori Morimoto.

 include/linux/platform_data/usb-rcar-phy.h |   26 ++
 1 file changed, 26 insertions(+)

Index: renesas/include/linux/platform_data/usb-rcar-phy.h
===
--- /dev/null
+++ renesas/include/linux/platform_data/usb-rcar-phy.h
@@ -0,0 +1,26 @@
+/*
+ * Copyright (C) 2013 Renesas Solutions Corp.
+ * Copyright (C) 2013 Cogent Embedded, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __USB_RCAR_PHY_H
+#define __USB_RCAR_PHY_H
+
+#include 
+
+struct rcar_phy_platform_data {
+   bool port1_func:1;  /* true: port 1 used by function, false: host */
+   unsigned penc1:1;   /* Output of the PENC1 pin in function mode */
+   struct {/* Overcurrent pin control for ports 0..2 */
+   bool select_3_3v:1; /* true: USB_OVCn pin, false: OVCn pin */
+   /* Set to false on port 1 in function mode */
+   bool active_high:1; /* true: active  high, false: active low */
+   /* Set to true  on port 1 in function mode */
+   } ovc_pin[3];
+};
+
+#endif /* __USB_RCAR_PHY_H */

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html