Re: [PATCHv4] USB: serial: option: add support for Huawei E173s-6
On Sat, Nov 23, 2013 at 01:07:45PM +0100, Johan Hovold wrote: > On Mon, Nov 11, 2013 at 09:59:15AM -0300, Gustavo Zacarias wrote: > > Interface 1 on this device isn't for option to bind to otherwise an oops > > on usb_wwan with log flooding will happen when accessing the port: > > > > tty_release: ttyUSB1: read/write wait queue active! > > > > It doesn't seem to respond to QMI if it's added to qmi_wwan so don't add > > it there - it's likely used by the card reader. > > > > Signed-off-by: Gustavo Zacarias > > --- > > > > v4: > > - Unbreak v2 ID sort broken in v3 > > > > v3: > > - Focus define name on E173s -6 variant, there are others > > - Change msg to E173-s6 add suggested by Johan Hovold > > Could you resubmit this one with the original patch description (e.g. > "blacklisting" rather than "add")? > > Sorry about the confusion. No need, I can edit that by hand right now... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv4] USB: serial: option: add support for Huawei E173s-6
On Mon, Nov 11, 2013 at 09:59:15AM -0300, Gustavo Zacarias wrote: > Interface 1 on this device isn't for option to bind to otherwise an oops > on usb_wwan with log flooding will happen when accessing the port: > > tty_release: ttyUSB1: read/write wait queue active! > > It doesn't seem to respond to QMI if it's added to qmi_wwan so don't add > it there - it's likely used by the card reader. > > Signed-off-by: Gustavo Zacarias > --- > > v4: > - Unbreak v2 ID sort broken in v3 > > v3: > - Focus define name on E173s -6 variant, there are others > - Change msg to E173-s6 add suggested by Johan Hovold Could you resubmit this one with the original patch description (e.g. "blacklisting" rather than "add")? Sorry about the confusion. Thanks, Johan > v2: > - Sort define by id as pointed by Sergei Shtylyov -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCHv4] USB: serial: option: add support for Huawei E173s-6
Interface 1 on this device isn't for option to bind to otherwise an oops
on usb_wwan with log flooding will happen when accessing the port:
tty_release: ttyUSB1: read/write wait queue active!
It doesn't seem to respond to QMI if it's added to qmi_wwan so don't add
it there - it's likely used by the card reader.
Signed-off-by: Gustavo Zacarias
---
v4:
- Unbreak v2 ID sort broken in v3
v3:
- Focus define name on E173s -6 variant, there are others
- Change msg to E173-s6 add suggested by Johan Hovold
v2:
- Sort define by id as pointed by Sergei Shtylyov
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index acaee06..98a4a1c 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -85,6 +85,7 @@ static void option_instat_callback(struct urb *urb);
#define HUAWEI_PRODUCT_K4505 0x1464
#define HUAWEI_PRODUCT_K3765 0x1465
#define HUAWEI_PRODUCT_K4605 0x14C6
+#define HUAWEI_PRODUCT_E173S6 0x1C07
#define QUANTA_VENDOR_ID 0x0408
#define QUANTA_PRODUCT_Q1010xEA02
@@ -572,6 +573,8 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c23,
USB_CLASS_COMM, 0x02, 0xff) },
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E173,
0xff, 0xff, 0xff),
.driver_info = (kernel_ulong_t) &net_intf1_blacklist },
+ { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID,
HUAWEI_PRODUCT_E173S6, 0xff, 0xff, 0xff),
+ .driver_info = (kernel_ulong_t) &net_intf1_blacklist },
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E1750,
0xff, 0xff, 0xff),
.driver_info = (kernel_ulong_t) &net_intf2_blacklist },
{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1441,
USB_CLASS_COMM, 0x02, 0xff) },
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
