Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
On Fri, Aug 07, 2015 at 09:48:19PM +0300, Tal Shorer wrote: > On Fri, Aug 7, 2015 at 9:40 PM, Greg KH wrote: > > On Fri, Aug 07, 2015 at 09:16:00PM +0300, Tal Shorer wrote: > >> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/ > >> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and > >> GetPortErrorCount as: > >> > >> Request bmRequestType bRequest wValue wIndex wLength Data > >> SetHubDepth 0010B SET_HUB_DEPTH Hub Depth Zero Zero None > >> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of > >> Link Errors on this port > > > > Still does not look correct to me, how about you? > > > > Not sure what you mean. This is a simple copy-paste from the spec document. > Do you want me to put quotation marks around the multi-word Data column? I want the columns to line up so that they look sane and someone can understand what they mean :) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
On Fri, Aug 7, 2015 at 9:40 PM, Greg KH wrote: > On Fri, Aug 07, 2015 at 09:16:00PM +0300, Tal Shorer wrote: >> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/ >> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and >> GetPortErrorCount as: >> >> Request bmRequestType bRequest wValue wIndex wLength Data >> SetHubDepth 0010B SET_HUB_DEPTH Hub Depth Zero Zero None >> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link >> Errors on this port > > Still does not look correct to me, how about you? > Not sure what you mean. This is a simple copy-paste from the spec document. Do you want me to put quotation marks around the multi-word Data column? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
On Fri, Aug 07, 2015 at 09:16:00PM +0300, Tal Shorer wrote: > >From the usb 3.1 spec available at http://www.usb.org/developers/docs/ > table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and > GetPortErrorCount as: > > Request bmRequestType bRequest wValue wIndex wLength Data > SetHubDepth 0010B SET_HUB_DEPTH Hub Depth Zero Zero None > GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link > Errors on this port Still does not look correct to me, how about you? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
>From the usb 3.1 spec available at http://www.usb.org/developers/docs/ table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and GetPortErrorCount as: Request bmRequestType bRequest wValue wIndex wLength Data SetHubDepth 0010B SET_HUB_DEPTH Hub Depth Zero Zero None GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link Errors on this port Fix these two values to match the spec. Signed-off-by: Tal Shorer --- include/linux/usb/hcd.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h index c9aa779..d2784c1 100644 --- a/include/linux/usb/hcd.h +++ b/include/linux/usb/hcd.h @@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *); /*-*/ -/* class requests from USB 3.0 hub spec, table 10-5 */ -#define SetHubDepth(0x3000 | HUB_SET_DEPTH) -#define GetPortErrorCount (0x8000 | HUB_GET_PORT_ERR_COUNT) +/* class requests from USB 3.1 hub spec, table 10-7 */ +#define SetHubDepth(0x2000 | HUB_SET_DEPTH) +#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT) /* * Generic bandwidth allocation constants/support -- 2.4.6 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
