[PATCH v4 12/13] ARM: dts: r7s9210: Add USB Device support
Add USB Device support for RZ/A2.
Signed-off-by: Chris Brandt
Reviewed-by: Geert Uytterhoeven
---
v3:
* added reviewed-by
v2:
* changed to generic name usb@xxx
* Add space between compatible strings
---
arch/arm/boot/dts/r7s9210.dtsi | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/r7s9210.dtsi b/arch/arm/boot/dts/r7s9210.dtsi
index 066e6fed11aa..3d0bbc1f4543 100644
--- a/arch/arm/boot/dts/r7s9210.dtsi
+++ b/arch/arm/boot/dts/r7s9210.dtsi
@@ -362,6 +362,18 @@
status = "disabled";
};
+ usbhs0: usb@e8219000 {
+ compatible = "renesas,usbhs-r7s9210",
"renesas,rza2-usbhs";
+ reg = <0xe8219000 0x724>;
+ interrupts = ;
+ clocks = <&cpg CPG_MOD 61>;
+ renesas,buswait = <7>;
+ phys = <&usb2_phy0>;
+ phy-names = "usb";
+ power-domains = <&cpg>;
+ status = "disabled";
+ };
+
ohci1: usb@e821a000 {
compatible = "generic-ohci";
reg = <0xe821a000 0x100>;
@@ -395,6 +407,18 @@
status = "disabled";
};
+ usbhs1: usb@e821b000 {
+ compatible = "renesas,usbhs-r7s9210",
"renesas,rza2-usbhs";
+ reg = <0xe821b000 0x724>;
+ interrupts = ;
+ clocks = <&cpg CPG_MOD 60>;
+ renesas,buswait = <7>;
+ phys = <&usb2_phy1>;
+ phy-names = "usb";
+ power-domains = <&cpg>;
+ status = "disabled";
+ };
+
sdhi0: sd@e8228000 {
compatible = "renesas,sdhi-r7s9210";
reg = <0xe8228000 0x8c0>;
--
2.16.1
Re: [PATCH v3 14/15] ARM: dts: r7s9210: Add USB Device support
On Tue, May 14, 2019 at 4:58 PM Chris Brandt wrote:
> Add USB Device support for RZ/A2.
>
> Signed-off-by: Chris Brandt
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH v3 14/15] ARM: dts: r7s9210: Add USB Device support
Add USB Device support for RZ/A2.
Signed-off-by: Chris Brandt
---
v2:
* changed to generic name usb@xxx
* Add space between compatible strings
---
arch/arm/boot/dts/r7s9210.dtsi | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/r7s9210.dtsi b/arch/arm/boot/dts/r7s9210.dtsi
index c3a50206ff86..65a8d5b126b4 100644
--- a/arch/arm/boot/dts/r7s9210.dtsi
+++ b/arch/arm/boot/dts/r7s9210.dtsi
@@ -362,6 +362,18 @@
status = "disabled";
};
+ usbhs0: usb@e8219000 {
+ compatible = "renesas,usbhs-r7s9210",
"renesas,rza2-usbhs";
+ reg = <0xe8219000 0x724>;
+ interrupts = ;
+ clocks = <&cpg CPG_MOD 61>;
+ renesas,buswait = <7>;
+ phys = <&usb2_phy0>;
+ phy-names = "usb";
+ power-domains = <&cpg>;
+ status = "disabled";
+ };
+
ohci1: usb@e821a000 {
compatible = "generic-ohci";
reg = <0xe821a000 0x100>;
@@ -395,6 +407,18 @@
status = "disabled";
};
+ usbhs1: usb@e821b000 {
+ compatible = "renesas,usbhs-r7s9210",
"renesas,rza2-usbhs";
+ reg = <0xe821b000 0x724>;
+ interrupts = ;
+ clocks = <&cpg CPG_MOD 60>;
+ renesas,buswait = <7>;
+ phys = <&usb2_phy1>;
+ phy-names = "usb";
+ power-domains = <&cpg>;
+ status = "disabled";
+ };
+
sdhi0: sd@e8228000 {
compatible = "renesas,sdhi-r7s9210";
reg = <0xe8228000 0x8c0>;
--
2.16.1
[PATCH v4 3/3] ARM: dts: r7s72100: add USB device to device tree
Add USB device support.
Signed-off-by: Chris Brandt
Reviewed-by: Geert Uytterhoeven
---
v4:
* Changed to "renesas,usbhs-r7s72100", "renesas,rza1-usbhs"
v3:
* Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs"
v2:
* Node name is now generic 'usb@'
* GIC_SPI (73-32) is now just GIC_SPI 41
* All hex number are lower case
* Added Reviewed-by
---
arch/arm/boot/dts/r7s72100.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index ab9645a42eca..bd6366d1800b 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -667,4 +667,24 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ usbhs0: usb@e801 {
+ compatible = "renesas,usbhs-r7s72100", "renesas,rza1-usbhs";
+ reg = <0xe801 0x1a0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB0>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
+
+ usbhs1: usb@e8207000 {
+ compatible = "renesas,usbhs-r7s72100", "renesas,rza1-usbhs";
+ reg = <0xe8207000 0x1a0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB1>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
};
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 3/3] ARM: dts: r7s72100: add USB device to device tree
On Fri, Jan 05, 2018 at 05:46:47PM -0500, Chris Brandt wrote:
> Add USB device support.
>
> Signed-off-by: Chris Brandt
> Reviewed-by: Geert Uytterhoeven
> ---
> v3:
> * Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs"
I think you want both. The SoC-specific compat string followed by a fallback
compat string for something broader:
Like this:
compatible = "renesas,usbhs-r7s72100", "renesas,rza1-usbhs";
> v2:
> * Node name is now generic 'usb@'
> * GIC_SPI (73-32) is now just GIC_SPI 41
> * All hex number are lower case
> * Added Reviewed-by
> ---
> arch/arm/boot/dts/r7s72100.dtsi | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
> index ab9645a42eca..d94431767913 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -667,4 +667,24 @@
> power-domains = <&cpg_clocks>;
> status = "disabled";
> };
> +
> + usbhs0: usb@e801 {
> + compatible = "renesas,rza1-usbhs";
> + reg = <0xe801 0x1a0>;
> + interrupts = ;
> + clocks = <&mstp7_clks R7S72100_CLK_USB0>;
> + renesas,buswait = <4>;
> + power-domains = <&cpg_clocks>;
> + status = "disabled";
> + };
> +
> + usbhs1: usb@e8207000 {
> + compatible = "renesas,rza1-usbhs";
> + reg = <0xe8207000 0x1a0>;
> + interrupts = ;
> + clocks = <&mstp7_clks R7S72100_CLK_USB1>;
> + renesas,buswait = <4>;
> + power-domains = <&cpg_clocks>;
> + status = "disabled";
> + };
> };
> --
> 2.15.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 3/3] ARM: dts: r7s72100: add USB device to device tree
On Fri, Jan 5, 2018 at 11:46 PM, Chris Brandt wrote:
> Add USB device support.
>
> Signed-off-by: Chris Brandt
> Reviewed-by: Geert Uytterhoeven
> ---
> v3:
> * Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs"
Please use both, cfr. my reply to the cover letter.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 3/3] ARM: dts: r7s72100: add USB device to device tree
Add USB device support.
Signed-off-by: Chris Brandt
Reviewed-by: Geert Uytterhoeven
---
v3:
* Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs"
v2:
* Node name is now generic 'usb@'
* GIC_SPI (73-32) is now just GIC_SPI 41
* All hex number are lower case
* Added Reviewed-by
---
arch/arm/boot/dts/r7s72100.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index ab9645a42eca..d94431767913 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -667,4 +667,24 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ usbhs0: usb@e801 {
+ compatible = "renesas,rza1-usbhs";
+ reg = <0xe801 0x1a0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB0>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
+
+ usbhs1: usb@e8207000 {
+ compatible = "renesas,rza1-usbhs";
+ reg = <0xe8207000 0x1a0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB1>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
};
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/3] ARM: dts: r7s72100: add USB device to device tree
On Fri, Jan 5, 2018 at 7:46 PM, Chris Brandt wrote:
> Add USB device support.
>
> Signed-off-by: Chris Brandt
> Reviewed-by: Geert Uytterhoeven
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -667,4 +667,24 @@
> power-domains = <&cpg_clocks>;
> status = "disabled";
> };
> +
> + usbhs0: usb@e801 {
> + compatible = "renesas,usbhs-r7s72100";
+ "renesas,rza1-usbhs"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 3/3] ARM: dts: r7s72100: add USB device to device tree
Add USB device support.
Signed-off-by: Chris Brandt
Reviewed-by: Geert Uytterhoeven
---
v2:
* Node name is now generic 'usb@'
* GIC_SPI (73-32) is now just GIC_SPI 41
* All hex number are lower case
* Added Reviewed-by
---
arch/arm/boot/dts/r7s72100.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index ab9645a42eca..f863f74b1b30 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -667,4 +667,24 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ usbhs0: usb@e801 {
+ compatible = "renesas,usbhs-r7s72100";
+ reg = <0xe801 0x1a0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB0>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
+
+ usbhs1: usb@e8207000 {
+ compatible = "renesas,usbhs-r7s72100";
+ reg = <0xe8207000 0x1a0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB1>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
};
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree
Hi Geert, On Friday, January 05, 2018, Geert Uytterhoeven wrote: > > But then...the number goes back to '73' when you look at it in > > /proc/interrupts. > > Having an identical number in /proc/interrupts is a coincidence. > These numbers are virtual, and may change even across reboots. I'm not talking about the id number (the 1st column). I'm talking about the 4th column. $ uname -rs Linux 4.15.0-rc5-8-g366d22ea091b $ cat /proc/interrupts CPU0 17: 2365 GIC-0 135 Edge ostm 18: 0 GIC-0 230 Level e8008000.serial:rx err 19: 45 GIC-0 231 Level e8008000.serial:rx full 20:194 GIC-0 232 Level e8008000.serial:tx empty 21: 0 GIC-0 229 Level e8008000.serial:break 24: 0 GIC-0 189 Level riic-tend 25: 0 GIC-0 190 Edge riic-rdrf 26: 0 GIC-0 191 Edge riic-tdre 27: 0 GIC-0 192 Level riic-stop 29: 0 GIC-0 194 Level riic-nack 32:160 GIC-0 213 Level riic-tend 33:160 GIC-0 214 Edge riic-rdrf 34:480 GIC-0 215 Edge riic-tdre 35:240 GIC-0 216 Level riic-stop 37: 0 GIC-0 218 Level riic-nack 40: 0 GIC-0 139 Level fcff.timer 42: 0 GIC-0 305 Level e804e800.sd 43: 52 GIC-0 306 Level e804e800.sd 44: 0 GIC-0 307 Level e804e800.sd 45: 0 GIC-0 308 Edge sh-rtc period 46: 0 GIC-0 309 Edge sh-rtc carry 47: 0 GIC-0 310 Edge sh-rtc alarm 48: 0 GIC-0 73 Level e801.usbhs Err: 0 > > Any opinions > > Not really, except that no single .dts(i) file seems to have "- 32". Then I can be a pioneer of new software!! ;) I'll just change it back to a single number when I upstream code just to be consistent. Thanks, Chris
Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree
Hi Chris,
On Fri, Jan 5, 2018 at 1:54 PM, Chris Brandt wrote:
> On Friday, January 05, 2018, Geert Uytterhoeven wrote:
>> > + interrupts = ;
>>
>> "41", all other interrupt properties already have the SPI offset
>> subtracted?
>
> The actual HW vector number in the hardware manual is '73'.
> As you know, you need to subtract 32 for the number you use in the
> device tree.
> But then...the number goes back to '73' when you look at it in
> /proc/interrupts.
Having an identical number in /proc/interrupts is a coincidence.
These numbers are virtual, and may change even across reboots.
> So it was confusing to people on what number you needed to use.
>
> Therefore in the RZ/A1 BSP, I was doing (xx-32) so at least people could
> see the relationship between what's in the hardware manual and what
> gets put into the device tree.
>
> So, if doing (73-32) looks wrong, I can change it back to '41' for the
> upstream version.
>
> Any opinions
Not really, except that no single .dts(i) file seems to have "- 32".
Note that e.g. the R-Car Gen3 manuals do list both "interrupt ID"
and "SGI, PPI, or SPI No" in the documentation for INTC-AP.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree
Hi Geert, Thanks for the review. On Friday, January 05, 2018, Geert Uytterhoeven wrote: > > + interrupts = ; > > "41", all other interrupt properties already have the SPI offset > subtracted? The actual HW vector number in the hardware manual is '73'. As you know, you need to subtract 32 for the number you use in the device tree. But then...the number goes back to '73' when you look at it in /proc/interrupts. So it was confusing to people on what number you needed to use. Therefore in the RZ/A1 BSP, I was doing (xx-32) so at least people could see the relationship between what's in the hardware manual and what gets put into the device tree. So, if doing (73-32) looks wrong, I can change it back to '41' for the upstream version. Any opinions Chris
RE: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree
On Friday, January 05, 2018, Sergei Shtylyov wrote:
> > + usbhs0: usbhs@e801 {
>
> The node names should be generic, i.e "usb@e801".
>
> > + compatible = "renesas,usbhs-r7s72100";
> > + reg = <0xe801 0x1A0>;
>
> Lowercase in the hex values, please be consistent...
>
> > + interrupts = ;
> > + clocks = <&mstp7_clks R7S72100_CLK_USB0>;
> > + renesas,buswait = <4>;
> > + power-domains = <&cpg_clocks>;
> > + status = "disabled";
> > + };
> > +
> > + usbhs1: usbhs@e8207000 {
> > + compatible = "renesas,usbhs-r7s72100";
> > + reg = <0xe8207000 0x1A0>;
> > + interrupts = ;
> > + clocks = <&mstp7_clks R7S72100_CLK_USB1>;
> > + renesas,buswait = <4>;
> > + power-domains = <&cpg_clocks>;
> > + status = "disabled";
> > + };
> > };
>
> The same comments for the 2nd device.
Thank you for the review.
I'll make the changes and resubmit.
Chris
N�r��yb�X��ǧv�^�){.n�+{��^n�r���z���h�&�� �G���h�(�階�ݢj"���m��z�ޖ���f���h���~�m�
Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree
On Thu, Jan 04, 2018 at 03:01:50PM -0500, Chris Brandt wrote: > Add USB device support. > > Signed-off-by: Chris Brandt Hi Chris, it looks like there have been some requests for (minor) changes to this patch. Please consider addressing those and reposting. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree
Hello!
On 1/4/2018 11:01 PM, Chris Brandt wrote:
Add USB device support.
Signed-off-by: Chris Brandt
---
arch/arm/boot/dts/r7s72100.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index ab9645a42eca..eb414e735185 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -667,4 +667,24 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ usbhs0: usbhs@e801 {
The node names should be generic, i.e "usb@e801".
+ compatible = "renesas,usbhs-r7s72100";
+ reg = <0xe801 0x1A0>;
Lowercase in the hex values, please be consistent...
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB0>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
+
+ usbhs1: usbhs@e8207000 {
+ compatible = "renesas,usbhs-r7s72100";
+ reg = <0xe8207000 0x1A0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB1>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
};
The same comments for the 2nd device.
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree
On Thu, Jan 4, 2018 at 9:01 PM, Chris Brandt wrote:
> Add USB device support.
>
> Signed-off-by: Chris Brandt
Reviewed-by: Geert Uytterhoeven
Minor nits below.
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -667,4 +667,24 @@
> power-domains = <&cpg_clocks>;
> status = "disabled";
> };
> +
> + usbhs0: usbhs@e801 {
> + compatible = "renesas,usbhs-r7s72100";
> + reg = <0xe801 0x1A0>;
0x1a0
> + interrupts = ;
"41", all other interrupt properties already have the SPI offset subtracted?
> + clocks = <&mstp7_clks R7S72100_CLK_USB0>;
> + renesas,buswait = <4>;
> + power-domains = <&cpg_clocks>;
> + status = "disabled";
> + };
> +
> + usbhs1: usbhs@e8207000 {
> + compatible = "renesas,usbhs-r7s72100";
> + reg = <0xe8207000 0x1A0>;
0x1a0
> + interrupts = ;
"42", all other interrupt properties already have the SPI offset subtracted?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree
Add USB device support.
Signed-off-by: Chris Brandt
---
arch/arm/boot/dts/r7s72100.dtsi | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index ab9645a42eca..eb414e735185 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -667,4 +667,24 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ usbhs0: usbhs@e801 {
+ compatible = "renesas,usbhs-r7s72100";
+ reg = <0xe801 0x1A0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB0>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
+
+ usbhs1: usbhs@e8207000 {
+ compatible = "renesas,usbhs-r7s72100";
+ reg = <0xe8207000 0x1A0>;
+ interrupts = ;
+ clocks = <&mstp7_clks R7S72100_CLK_USB1>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
};
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node
On Mon, Nov 21, 2016 at 11:49 AM, Sekhar Nori wrote: > On Monday 21 November 2016 04:16 PM, Sekhar Nori wrote: In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci >> tree, the alias for the musb device is usb0. So, I think we should use >> usb1 >> here instead of ohci - or change the usb0 alias to musb. >> >> https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6 >>> > >>> > ok, i will change to usb1, since i will be resubmiting this. > >> I have already applied a version of this patch. Please re-base against >> linux-davinci/master and send a delta patch. > > Hmm, no. scratch that. I mixed this up with the musb patch I applied. > usb1 sounds good. Please also separate out the soc and board specific > dts additions for your next version. Ok will do. > > Thanks, > Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node
On Monday 21 November 2016 04:16 PM, Sekhar Nori wrote: >>> In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci >>> >> tree, the alias for the musb device is usb0. So, I think we should use >>> >> usb1 >>> >> here instead of ohci - or change the usb0 alias to musb. >>> >> >>> >> https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6 >> > >> > ok, i will change to usb1, since i will be resubmiting this. > I have already applied a version of this patch. Please re-base against > linux-davinci/master and send a delta patch. Hmm, no. scratch that. I mixed this up with the musb patch I applied. usb1 sounds good. Please also separate out the soc and board specific dts additions for your next version. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node
On Monday 21 November 2016 03:57 PM, Axel Haslam wrote:
> On Mon, Nov 21, 2016 at 3:42 AM, David Lechner wrote:
>> On 11/07/2016 02:39 PM, Axel Haslam wrote:
>>>
>>> This adds the ohci device node for the da850 soc.
>>> It also enables it for the omapl138 hawk board.
>>>
>>> Signed-off-by: Axel Haslam
>>> ---
>>> arch/arm/boot/dts/da850-lcdk.dts | 8
>>> arch/arm/boot/dts/da850.dtsi | 8
>>> 2 files changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/da850-lcdk.dts
>>> b/arch/arm/boot/dts/da850-lcdk.dts
>>> index 7b8ab21..aaf533e 100644
>>> --- a/arch/arm/boot/dts/da850-lcdk.dts
>>> +++ b/arch/arm/boot/dts/da850-lcdk.dts
>>> @@ -86,6 +86,14 @@
>>> };
>>> };
>>>
>>> +&usb_phy {
>>> + status = "okay";
>>> +};
>>> +
>>> +&ohci {
>>> + status = "okay";
>>> +};
>>> +
>>> &serial2 {
>>> pinctrl-names = "default";
>>> pinctrl-0 = <&serial2_rxtx_pins>;
>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>> index 2534aab..50e86da 100644
>>> --- a/arch/arm/boot/dts/da850.dtsi
>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>> @@ -405,6 +405,14 @@
>>> >;
>>> status = "disabled";
>>> };
>>> + ohci: usb@0225000 {
>>
>>
>> In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci
>> tree, the alias for the musb device is usb0. So, I think we should use usb1
>> here instead of ohci - or change the usb0 alias to musb.
>>
>> https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6
>
> ok, i will change to usb1, since i will be resubmiting this.
I have already applied a version of this patch. Please re-base against
linux-davinci/master and send a delta patch.
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node
On Mon, Nov 21, 2016 at 3:42 AM, David Lechner wrote:
> On 11/07/2016 02:39 PM, Axel Haslam wrote:
>>
>> This adds the ohci device node for the da850 soc.
>> It also enables it for the omapl138 hawk board.
>>
>> Signed-off-by: Axel Haslam
>> ---
>> arch/arm/boot/dts/da850-lcdk.dts | 8
>> arch/arm/boot/dts/da850.dtsi | 8
>> 2 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/da850-lcdk.dts
>> b/arch/arm/boot/dts/da850-lcdk.dts
>> index 7b8ab21..aaf533e 100644
>> --- a/arch/arm/boot/dts/da850-lcdk.dts
>> +++ b/arch/arm/boot/dts/da850-lcdk.dts
>> @@ -86,6 +86,14 @@
>> };
>> };
>>
>> +&usb_phy {
>> + status = "okay";
>> +};
>> +
>> +&ohci {
>> + status = "okay";
>> +};
>> +
>> &serial2 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&serial2_rxtx_pins>;
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index 2534aab..50e86da 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>> @@ -405,6 +405,14 @@
>> >;
>> status = "disabled";
>> };
>> + ohci: usb@0225000 {
>
>
> In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci
> tree, the alias for the musb device is usb0. So, I think we should use usb1
> here instead of ohci - or change the usb0 alias to musb.
>
> https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6
ok, i will change to usb1, since i will be resubmiting this.
>
>> + compatible = "ti,da830-ohci";
>> + reg = <0x225000 0x1000>;
>> + interrupts = <59>;
>> + phys = <&usb_phy 1>;
>> + phy-names = "usb-phy";
>> + status = "disabled";
>> + };
>> gpio: gpio@226000 {
>> compatible = "ti,dm6441-gpio";
>> gpio-controller;
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node
On 11/07/2016 02:39 PM, Axel Haslam wrote:
This adds the ohci device node for the da850 soc.
It also enables it for the omapl138 hawk board.
Signed-off-by: Axel Haslam
---
arch/arm/boot/dts/da850-lcdk.dts | 8
arch/arm/boot/dts/da850.dtsi | 8
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index 7b8ab21..aaf533e 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -86,6 +86,14 @@
};
};
+&usb_phy {
+ status = "okay";
+};
+
+&ohci {
+ status = "okay";
+};
+
&serial2 {
pinctrl-names = "default";
pinctrl-0 = <&serial2_rxtx_pins>;
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 2534aab..50e86da 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -405,6 +405,14 @@
>;
status = "disabled";
};
+ ohci: usb@0225000 {
In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci
tree, the alias for the musb device is usb0. So, I think we should use
usb1 here instead of ohci - or change the usb0 alias to musb.
https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6
+ compatible = "ti,da830-ohci";
+ reg = <0x225000 0x1000>;
+ interrupts = <59>;
+ phys = <&usb_phy 1>;
+ phy-names = "usb-phy";
+ status = "disabled";
+ };
gpio: gpio@226000 {
compatible = "ti,dm6441-gpio";
gpio-controller;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] ARM: dts: da850: add usb device node
Hi Axel, [auto build test ERROR on usb/usb-testing] [also build test ERROR on next-20161108] [cannot apply to robh/for-next v4.9-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Axel-Haslam/USB-ohci-da8xx-Add-devicetree-bindings/20161109-031338 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: arm-at91_dt_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All errors (new ones prefixed by >>): >> Error: arch/arm/boot/dts/da850-lcdk.dts:89.1-9 Label or path usb_phy not >> found FATAL ERROR: Syntax error parsing input tree --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[PATCH 3/3] ARM: dts: da850: add usb device node
This adds the ohci device node for the da850 soc.
It also enables it for the omapl138 hawk board.
Signed-off-by: Axel Haslam
---
arch/arm/boot/dts/da850-lcdk.dts | 8
arch/arm/boot/dts/da850.dtsi | 8
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index 7b8ab21..aaf533e 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -86,6 +86,14 @@
};
};
+&usb_phy {
+ status = "okay";
+};
+
+&ohci {
+ status = "okay";
+};
+
&serial2 {
pinctrl-names = "default";
pinctrl-0 = <&serial2_rxtx_pins>;
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 2534aab..c74f1a6 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -405,6 +405,14 @@
>;
status = "disabled";
};
+ ohci: usb@225000 {
+ compatible = "ti,da830-ohci";
+ reg = <0x225000 0x1000>;
+ interrupts = <59>;
+ phys = <&usb_phy 1>;
+ phy-names = "usb-phy";
+ status = "disabled";
+ };
gpio: gpio@226000 {
compatible = "ti,dm6441-gpio";
gpio-controller;
--
2.10.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 10/10] ARM: dts: da850: add usb device node
This adds the ohci device node for the da850 soc.
It also enables it for the omapl138 hawk board.
Signed-off-by: Axel Haslam
---
arch/arm/boot/dts/da850-lcdk.dts | 8
arch/arm/boot/dts/da850.dtsi | 8
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index 7b8ab21..aaf533e 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -86,6 +86,14 @@
};
};
+&usb_phy {
+ status = "okay";
+};
+
+&ohci {
+ status = "okay";
+};
+
&serial2 {
pinctrl-names = "default";
pinctrl-0 = <&serial2_rxtx_pins>;
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 2534aab..50e86da 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -405,6 +405,14 @@
>;
status = "disabled";
};
+ ohci: usb@0225000 {
+ compatible = "ti,da830-ohci";
+ reg = <0x225000 0x1000>;
+ interrupts = <59>;
+ phys = <&usb_phy 1>;
+ phy-names = "usb-phy";
+ status = "disabled";
+ };
gpio: gpio@226000 {
compatible = "ti,dm6441-gpio";
gpio-controller;
--
2.10.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFT v2 17/17] ARM: dts: da850: add usb device node
On Tue, Oct 25, 2016 at 2:48 AM, David Lechner wrote:
> On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote:
>>
>> From: Axel Haslam
>>
>> This adds the usb (ohci) device node for the da850 soc.
>> Also it enables it for the lcdk board
>>
>> Signed-off-by: Axel Haslam
>> ---
>> arch/arm/boot/dts/da850-lcdk.dts | 8
>> arch/arm/boot/dts/da850.dtsi | 8
>> 2 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/da850-lcdk.dts
>> b/arch/arm/boot/dts/da850-lcdk.dts
>> index 7b8ab21..fa91339 100644
>> --- a/arch/arm/boot/dts/da850-lcdk.dts
>> +++ b/arch/arm/boot/dts/da850-lcdk.dts
>> @@ -86,6 +86,14 @@
>> };
>> };
>>
>> +&usb_phy {
>> + status = "okay";
>> +};
>> +
>> +&usb {
>> + status = "okay";
>
>
> Don't you need to specify a regulator here using the vbus-supply property?
its is not mandatory, the regulator framework is giving a dummy supply
on regulator_get if it does not find a regulator on device tree. That is
what i could understand from: _regulator_get in regulator/core.c
Also, in the case of platform based boot, if the board init calls
regulator_has_full_constraints which is anyways needed for the phy to probe
correctly it will also return a dummy regulator.
>
>> +};
>> +
>> &serial2 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&serial2_rxtx_pins>;
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index 33fcdce..ec2cec3 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>> @@ -381,6 +381,14 @@
>> #phy-cells = <1>;
>> status = "disabled";
>> };
>> + usb: usb@0225000 {
>
>
> Don't need the leading 0 on usb@225000
>
> The alias (usb:) might need to be more specific since there is a second usb
> device that will be added later for musb. (The comments in the previous
> review only referred to the "usb" in "usb@", not the alias.)
ok.
>
>> + compatible = "ti,da830-ohci";
>> + reg = <0x225000 0x1000>;
>> + interrupts = <59>;
>> + phys = <&usb_phy 1>;
>> + phy-names = "usb-phy";
>> + status = "disabled";
>> + };
>> gpio: gpio@226000 {
>> compatible = "ti,dm6441-gpio";
>> gpio-controller;
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFT v2 17/17] ARM: dts: da850: add usb device node
On 10/24/2016 11:46 AM, ahas...@baylibre.com wrote:
From: Axel Haslam
This adds the usb (ohci) device node for the da850 soc.
Also it enables it for the lcdk board
Signed-off-by: Axel Haslam
---
arch/arm/boot/dts/da850-lcdk.dts | 8
arch/arm/boot/dts/da850.dtsi | 8
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index 7b8ab21..fa91339 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -86,6 +86,14 @@
};
};
+&usb_phy {
+ status = "okay";
+};
+
+&usb {
+ status = "okay";
Don't you need to specify a regulator here using the vbus-supply property?
+};
+
&serial2 {
pinctrl-names = "default";
pinctrl-0 = <&serial2_rxtx_pins>;
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 33fcdce..ec2cec3 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -381,6 +381,14 @@
#phy-cells = <1>;
status = "disabled";
};
+ usb: usb@0225000 {
Don't need the leading 0 on usb@225000
The alias (usb:) might need to be more specific since there is a second
usb device that will be added later for musb. (The comments in the
previous review only referred to the "usb" in "usb@", not the alias.)
+ compatible = "ti,da830-ohci";
+ reg = <0x225000 0x1000>;
+ interrupts = <59>;
+ phys = <&usb_phy 1>;
+ phy-names = "usb-phy";
+ status = "disabled";
+ };
gpio: gpio@226000 {
compatible = "ti,dm6441-gpio";
gpio-controller;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH/RFT v2 17/17] ARM: dts: da850: add usb device node
From: Axel Haslam
This adds the usb (ohci) device node for the da850 soc.
Also it enables it for the lcdk board
Signed-off-by: Axel Haslam
---
arch/arm/boot/dts/da850-lcdk.dts | 8
arch/arm/boot/dts/da850.dtsi | 8
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index 7b8ab21..fa91339 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -86,6 +86,14 @@
};
};
+&usb_phy {
+ status = "okay";
+};
+
+&usb {
+ status = "okay";
+};
+
&serial2 {
pinctrl-names = "default";
pinctrl-0 = <&serial2_rxtx_pins>;
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 33fcdce..ec2cec3 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -381,6 +381,14 @@
#phy-cells = <1>;
status = "disabled";
};
+ usb: usb@0225000 {
+ compatible = "ti,da830-ohci";
+ reg = <0x225000 0x1000>;
+ interrupts = <59>;
+ phys = <&usb_phy 1>;
+ phy-names = "usb-phy";
+ status = "disabled";
+ };
gpio: gpio@226000 {
compatible = "ti,dm6441-gpio";
gpio-controller;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/12] Add USB Device Controller for USB/IP protocol
On Tue, Mar 08, 2016 at 09:48:55PM +0100, Krzysztof Opasiak wrote: > Hi, > > This series extends USB/IP support in Kernel by adding an emulated > USB Device Controller. This allows to virtually connect USB gadget > created on a server to some remote machine as if it would be a fully > functional USB device. This is "crazy", nice idea, and good work, I've merged it now. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/12] Add USB Device Controller for USB/IP protocol
Hi, This series extends USB/IP support in Kernel by adding an emulated USB Device Controller. This allows to virtually connect USB gadget created on a server to some remote machine as if it would be a fully functional USB device. -- Current design: -- - -- | USB Device |---USB---> | Stub Driver | ---Ethernet---> | vHCI | - -- Currently USB/IP protocol allows to pass some real USB device connected to one computer to another one over the net. - New possibilities: - - -- | USB Device |---USB---> | Stub Driver | ---Ethernet---> | vHCI | - -- ^ --| | USB Gadget |> | vUDC | --Ethernet -- This series extends USB/IP abilities with possibility to pass not only the physical device connected to some computer but also some USB gadget composed on that machine. New interface is fully compatible with the USB/IP itself. Why is it useful? First of all this allows us to improve phone emulation in qemu environment. Such an emulated phone can be now connected to developer's machine or another virtual machine as if it would be a physical phone. Of course this is suitable for any emulated linux machine not only for mobile systems. This also provides additional help in testing USB functions and drivers. We may say that it's the next step of testing between dummy_hcd and real hardware as it allows to split device and host software and check how they are working in independent environment with some latencies, emulated connection and disconnection etc. It is also worth mention that if there are some problems they can be easily analyzed using usbmon (dump USB traffic) or Wireshark (dump usbip traffic) instead of buying expensive USB sniffers. vUDC is also very useful for educational purposes. It allows to create a two virtual machine (called host and device) and emulate that they are connected with USB cable. This is much more easier to understand than dummy_hcd and having both host and device on the same machine. --- Why not dummy_hcd + stub driver? --- It is possible to achieve quite similar functionality using dummy_hcd and a stub driver. So we get something like this: ------ | USB Gadget | ---> | dummy_udc | ---> | dummy_hcd | ---emulated--- ------ - -- ---USB---> | Stub Driver | ---Ethernet---> | vHCI | - -- But there is another unnecessary abstraction layer which makes this setup more complex and generates some noise as there is a moment in which our device is connected to the same system via dummy_hcd. This may be very annoying esp when debugging. Thanks to vUDC we eliminate this step and connect directly to a remote host without any additional noise on device system. Moreover in this setup it is impossible to easily emulate USB cable connection and disconnection as dummy_udc is always connected to dummy_hcd. In addition vUDC should be also a little bit more resource efficient. University Collaboration This driver has been created mostly by students from The Open Operating Systems Student Society at University of Warsaw with my support. The whole suff is a part of collaboration between Samsung R&D Institute Poland and mentioned students society. The goal of this collaboration is to learn and encourage young people to contribute to Linux kernel and other open source project. To achieve this the whole process consist of two parts: In first part, Samsung as a company provides some additional lectures for university students which are conducted by chosen employees. They are mostly related to open source contribution process, kernel programing and topics closely related to chosen project (for example USB). In second part students implement a project chosen from Samsung's proposals. In this part company ensures cotinuous (of course not full time but as a side task) spupport for students by one of employees. Below students took a part in creating this driver: Igor Kotrasinski Karol Kosik Ewelina Kosmider <3w3l...@gmail.com> Dawid Lazarczyk Piotr Szulc >From Samsung's side I'm theirs tutor and I have also done some final preparation and fixing before sending this driver. I have to also credit Igor Kotrasinski for doing the commit split and a lot of cleanups in this driver during his internship
[PATCH 02/13] MIPS: BCM63XX: add USB device clock enable delay to clock code
This patch adds the required 10 micro seconds delay to the USB device
clock enable operation. Put this where the correct clock knowledege is,
which is in the clock code, and remove this delay from the bcm63xx_udc
gadget driver where it was before.
Signed-off-by: Florian Fainelli
---
arch/mips/bcm63xx/clk.c |5 +
drivers/usb/gadget/bcm63xx_udc.c |1 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
index a39aeb8..1f1a6c1 100644
--- a/arch/mips/bcm63xx/clk.c
+++ b/arch/mips/bcm63xx/clk.c
@@ -182,6 +182,11 @@ static void usbd_set(struct clk *clk, int enable)
bcm_hwclock_set(CKCTL_6328_USBD_EN, enable);
else if (BCMCPU_IS_6368())
bcm_hwclock_set(CKCTL_6368_USBD_EN, enable);
+ else
+ return;
+
+ if (enable)
+ udelay(10);
}
static struct clk clk_usbd = {
diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget/bcm63xx_udc.c
index 47a4993..ad17533 100644
--- a/drivers/usb/gadget/bcm63xx_udc.c
+++ b/drivers/usb/gadget/bcm63xx_udc.c
@@ -386,7 +386,6 @@ static inline void set_clocks(struct bcm63xx_udc *udc, bool
is_enabled)
if (is_enabled) {
clk_enable(udc->usbh_clk);
clk_enable(udc->usbd_clk);
- udelay(10);
} else {
clk_disable(udc->usbd_clk);
clk_disable(udc->usbh_clk);
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Add USB Device
On Fri, Jan 25, 2013 at 12:41:21PM -0500, Hoyt Duff wrote: > It would be helpful if the website provided that direction (or > provided that direction in a more clear manner if it already does) > instead of implying that one needs to join the mail list. Again, you are going to have to be more specific, exactly what web site says that you should email this mailing list? And you never need to join a vger.kernel.org mailing list in order to post something to it, it handles non-subscribers just fine (as long as you don't post html email, it hates that.) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Add USB Device
It would be helpful if the website provided that direction (or provided that direction in a more clear manner if it already does) instead of implying that one needs to join the mail list. Thanks. On 1/25/13, Greg KH wrote: > On Fri, Jan 25, 2013 at 12:18:36PM -0500, Hoyt Duff wrote: >> usb.ids > > The top of the usb.ids file says how to have it updated, please read > that and follow the directions there. > > thanks, > > greg k-h > -- Hoyt -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Add USB Device
On Fri, Jan 25, 2013 at 12:18:36PM -0500, Hoyt Duff wrote: > usb.ids The top of the usb.ids file says how to have it updated, please read that and follow the directions there. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Add USB Device
usb.ids On 1/25/13, Greg KH wrote: > On Fri, Jan 25, 2013 at 11:31:00AM -0500, Hoyt Duff wrote: >> On 1/25/13, Greg KH wrote: >> > On Fri, Jan 25, 2013 at 09:30:25AM -0500, Hoyt Duff wrote: >> >> Vendor ID: 0x04b4 >> >> Device ID: 0x6830 >> >> Cypress Semiconductor >> >> USB2.0 Storage Device >> >> >> >> # uname -a >> >> Linux titan.maximumhoyt.com 3.4.24-desktop-3.mga2 #1 SMP Sat Jan 5 >> >> 02:42:54 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux >> >> >> >> # cat /proc/bus/usb/devices >> > >> > Why do we need to "add" this device? Does it not work properly with >> > the >> > existing kernel driver? >> > >> > confused, >> > >> > greg k-h >> > >> >> Thanks for the reply. >> It appears to work fine, but it's not on the list. Is that not a valid >> reason to add it? > > I'm confused, what "list" are you referring to? > > thanks, > > greg k-h > -- Hoyt -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Add USB Device
On Fri, Jan 25, 2013 at 11:31:00AM -0500, Hoyt Duff wrote: > On 1/25/13, Greg KH wrote: > > On Fri, Jan 25, 2013 at 09:30:25AM -0500, Hoyt Duff wrote: > >> Vendor ID: 0x04b4 > >> Device ID: 0x6830 > >> Cypress Semiconductor > >> USB2.0 Storage Device > >> > >> # uname -a > >> Linux titan.maximumhoyt.com 3.4.24-desktop-3.mga2 #1 SMP Sat Jan 5 > >> 02:42:54 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux > >> > >> # cat /proc/bus/usb/devices > > > > Why do we need to "add" this device? Does it not work properly with the > > existing kernel driver? > > > > confused, > > > > greg k-h > > > > Thanks for the reply. > It appears to work fine, but it's not on the list. Is that not a valid > reason to add it? I'm confused, what "list" are you referring to? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Add USB Device
On 1/25/13, Greg KH wrote: > On Fri, Jan 25, 2013 at 09:30:25AM -0500, Hoyt Duff wrote: >> Vendor ID: 0x04b4 >> Device ID: 0x6830 >> Cypress Semiconductor >> USB2.0 Storage Device >> >> # uname -a >> Linux titan.maximumhoyt.com 3.4.24-desktop-3.mga2 #1 SMP Sat Jan 5 >> 02:42:54 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux >> >> # cat /proc/bus/usb/devices > > Why do we need to "add" this device? Does it not work properly with the > existing kernel driver? > > confused, > > greg k-h > Thanks for the reply. It appears to work fine, but it's not on the list. Is that not a valid reason to add it? If it is not, then ignore the request. -- Hoyt -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Add USB Device
On Fri, Jan 25, 2013 at 09:30:25AM -0500, Hoyt Duff wrote: > Vendor ID: 0x04b4 > Device ID: 0x6830 > Cypress Semiconductor > USB2.0 Storage Device > > # uname -a > Linux titan.maximumhoyt.com 3.4.24-desktop-3.mga2 #1 SMP Sat Jan 5 > 02:42:54 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux > > # cat /proc/bus/usb/devices Why do we need to "add" this device? Does it not work properly with the existing kernel driver? confused, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: How to add USB device ID
On 12/21/12 10:22 PM, "Greg KH" wrote: >On Fri, Dec 21, 2012 at 05:54:33PM -0600, Kevin K wrote: >> I use an USB device that looks like a serial port to the kernel. >>However, >> since the Device ID is unknown, I have to either modprobe usbserial with >> the vendor/id codes as parameters, or modify generic.c so it knows to >> handle the device. I have been going with the code modification since >> there are 2 versions of this device with different numbers, and you can >> only do 1 on the command line. >> >> What is the "right" way to see if it can be pushed into mainline >>support? >> It seems overkill to write another driver that essentially wraps around >> generic.c. > >No it isn't overkill, we have a few drivers like this. What type of USB >serial chip is this device? Perhaps we should just add the device ids >to an existing driver? > >thanks, > >greg k-h Sorry to not respond until now. I missed some time due to a cold and the holiday. I don't know the actual serial chip, but I went and ran lsusb -v on a system with it. What I guess makes it complicated is that the device is a multifunction device. Depending on configuration, it can appear as both a serial port and a rndis_host based network device. On Red Hat EL 6, lsusb shows the following: Bus 003 Device 002: ID 229c: Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 ? bDeviceProtocol 1 Interface Association bMaxPacketSize064 idVendor 0x229c idProduct 0x bcdDevice1.00 iManufacturer 1 Raytheon iProduct2 TacLink 3300 COM iSerial 3 1197 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 75 bNumInterfaces 2 bConfigurationValue 1 iConfiguration 4 CDC ADM W/IAD bmAttributes 0x80 (Bus Powered) MaxPower 400mA Interface Association: bLength 8 bDescriptorType11 bFirstInterface 0 bInterfaceCount 2 bFunctionClass 2 Communications bFunctionSubClass 2 Abstract (modem) bFunctionProtocol 0 None iFunction 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber0 bAlternateSetting 0 bNumEndpoints 1 bInterfaceClass 2 Communications bInterfaceSubClass 2 Abstract (modem) bInterfaceProtocol 0 None iInterface 6 HOST COM INTERFACE CDC Header: bcdCDC 1.10 CDC Call Management: bmCapabilities 0x00 bDataInterface 1 CDC ACM: bmCapabilities 0x00 CDC Union: bMasterInterface0 bSlaveInterface 1 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes3 Transfer TypeInterrupt Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 32 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber1 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass10 CDC Data bInterfaceSubClass 0 Unused bInterfaceProtocol 0 iInterface 6 HOST COM INTERFACE Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x02 EP 2 OUT bmAttributes2 Transfer TypeBulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 1 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x83 EP 3 IN bmAttributes2 Transfer TypeBulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 1 Device Status: 0x (Bus Powered) When the RNDIS mode is enabled, the ID changes to 229c:0001, and the rndis_host mode works without any kernel change other than making sure the module is loaded. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: How to add USB device ID
On Fri, Dec 21, 2012 at 05:54:33PM -0600, Kevin K wrote: > I use an USB device that looks like a serial port to the kernel. However, > since the Device ID is unknown, I have to either modprobe usbserial with > the vendor/id codes as parameters, or modify generic.c so it knows to > handle the device. I have been going with the code modification since > there are 2 versions of this device with different numbers, and you can > only do 1 on the command line. > > What is the "right" way to see if it can be pushed into mainline support? > It seems overkill to write another driver that essentially wraps around > generic.c. No it isn't overkill, we have a few drivers like this. What type of USB serial chip is this device? Perhaps we should just add the device ids to an existing driver? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
How to add USB device ID
I use an USB device that looks like a serial port to the kernel. However, since the Device ID is unknown, I have to either modprobe usbserial with the vendor/id codes as parameters, or modify generic.c so it knows to handle the device. I have been going with the code modification since there are 2 versions of this device with different numbers, and you can only do 1 on the command line. What is the "right" way to see if it can be pushed into mainline support? It seems overkill to write another driver that essentially wraps around generic.c. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
