Re: Potential USB PHY error handling fix for stable
On Wed, Oct 29, 2014 at 10:10:12PM +, Mark Brown wrote: Hi, One of the Linaro stable kernel users has suggested 2c4e3dbf63b39d (usb: phy: return -ENODEV on failure of try_module_get) as a fix for the stable kernel. While it's error handling that's being fixed this does seem like a reasonable candidate, it's a very simple fix and the behaviour without the change is to return a NULL pointer rather than an error pointer which callers will interpret as success which isn't good. Does this seem reasonable? Thanks, Mark Thank you, I'll queue this fix for the 3.16 extended stable. Cheers, -- Luís -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Potential USB PHY error handling fix for stable
Hi, One of the Linaro stable kernel users has suggested 2c4e3dbf63b39d (usb: phy: return -ENODEV on failure of try_module_get) as a fix for the stable kernel. While it's error handling that's being fixed this does seem like a reasonable candidate, it's a very simple fix and the behaviour without the change is to return a NULL pointer rather than an error pointer which callers will interpret as success which isn't good. Does this seem reasonable? Thanks, Mark signature.asc Description: Digital signature
Re: Potential USB PHY error handling fix for stable
On Wed, Oct 29, 2014 at 10:10:12PM +, Mark Brown wrote: Hi, One of the Linaro stable kernel users has suggested 2c4e3dbf63b39d (usb: phy: return -ENODEV on failure of try_module_get) as a fix for the stable kernel. While it's error handling that's being fixed this does seem like a reasonable candidate, it's a very simple fix and the behaviour without the change is to return a NULL pointer rather than an error pointer which callers will interpret as success which isn't good. Does this seem reasonable? What stable kernel are you referring to? This patch is in 3.17 already, and 3.16 is now end-of-life after this next release in a few hours. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Potential USB PHY error handling fix for stable
On Wed, Oct 29, 2014 at 03:30:18PM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 29, 2014 at 10:10:12PM +, Mark Brown wrote: One of the Linaro stable kernel users has suggested 2c4e3dbf63b39d (usb: phy: return -ENODEV on failure of try_module_get) as a fix for the stable kernel. While it's error handling that's being fixed this does seem like a reasonable candidate, it's a very simple fix and the behaviour without the change is to return a NULL pointer rather than an error pointer which callers will interpret as success which isn't good. Does this seem reasonable? What stable kernel are you referring to? This patch is in 3.17 already, and 3.16 is now end-of-life after this next release in a few hours. It applies to v3.14 as well, I didn't check further back. signature.asc Description: Digital signature
Re: Potential USB PHY error handling fix for stable
On Wed, Oct 29, 2014 at 10:54:35PM +, Mark Brown wrote: On Wed, Oct 29, 2014 at 03:30:18PM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 29, 2014 at 10:10:12PM +, Mark Brown wrote: One of the Linaro stable kernel users has suggested 2c4e3dbf63b39d (usb: phy: return -ENODEV on failure of try_module_get) as a fix for the stable kernel. While it's error handling that's being fixed this does seem like a reasonable candidate, it's a very simple fix and the behaviour without the change is to return a NULL pointer rather than an error pointer which callers will interpret as success which isn't good. Does this seem reasonable? What stable kernel are you referring to? This patch is in 3.17 already, and 3.16 is now end-of-life after this next release in a few hours. It applies to v3.14 as well, I didn't check further back. It goes further back than that, but since nobody complained so far, I'm ok with v3.14 only if Greg accepts that. -- balbi signature.asc Description: Digital signature
