RE: [PATCH 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-07-21 Thread Paul Zimmerman
 From: dingu...@altera.com [mailto:dingu...@altera.com]
 Sent: Wednesday, July 16, 2014 1:33 PM
 
 Update DWC2 kconfig and makefile to support dual-role mode. The platform
 file will always get compiled for the case where the controller is directly
 connected to the CPU. So for loadable modules, only dwc2.ko is needed.
 
 Signed-off-by: Dinh Nguyen dingu...@altera.com
 ---
  drivers/usb/dwc2/Kconfig  |   59 
 ++---
  drivers/usb/dwc2/Makefile |   21 
  2 files changed, 45 insertions(+), 35 deletions(-)
 
 diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig
 index f93807b..5f32e62 100644
 --- a/drivers/usb/dwc2/Kconfig
 +++ b/drivers/usb/dwc2/Kconfig
 @@ -1,40 +1,31 @@
  config USB_DWC2
 - bool DesignWare USB2 DRD Core Support
 + tristate DesignWare USB2 DRD Core Support
   depends on USB
   help
 Say Y here if your system has a Dual Role Hi-Speed USB
 controller based on the DesignWare HSOTG IP Core.
 
 -   For host mode, if you choose to build the driver as dynamically
 -   linked modules, the core module will be called dwc2.ko, the PCI
 -   bus interface module (if you have a PCI bus system) will be
 -   called dwc2_pci.ko, and the platform interface module (for
 -   controllers directly connected to the CPU) will be called
 -   dwc2_platform.ko. For gadget mode, there will be a single
 -   module called dwc2_gadget.ko.
 +   If you choose to build the driver as dynamically
 +   linked modules, a single dwc2.ko(regardless of mode of operation)
 +   will get built for both platform IPs and PCI.
 
 -   NOTE: The s3c-hsotg driver is now renamed to dwc2_gadget. The
 -   host and gadget drivers are still currently separate drivers.
 -   There are plans to merge the dwc2_gadget driver with the dwc2
 -   host driver in the near future to create a dual-role driver.
 +   NOTE: The s3c-hsotg driver is now renamed to dwc2_gadget.

Looks like this line is incorrect, dwc2_gadget.ko no longer exists,
right?

-- 
Paul

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-07-21 Thread Dinh Nguyen
On Mon, 2014-07-21 at 21:39 +, Paul Zimmerman wrote:
  From: dingu...@altera.com [mailto:dingu...@altera.com]
  Sent: Wednesday, July 16, 2014 1:33 PM
  
  Update DWC2 kconfig and makefile to support dual-role mode. The platform
  file will always get compiled for the case where the controller is directly
  connected to the CPU. So for loadable modules, only dwc2.ko is needed.
  
  Signed-off-by: Dinh Nguyen dingu...@altera.com
  ---
   drivers/usb/dwc2/Kconfig  |   59 
  ++---
   drivers/usb/dwc2/Makefile |   21 
   2 files changed, 45 insertions(+), 35 deletions(-)
  
  diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig
  index f93807b..5f32e62 100644
  --- a/drivers/usb/dwc2/Kconfig
  +++ b/drivers/usb/dwc2/Kconfig
  @@ -1,40 +1,31 @@
   config USB_DWC2
  -   bool DesignWare USB2 DRD Core Support
  +   tristate DesignWare USB2 DRD Core Support
  depends on USB
  help
Say Y here if your system has a Dual Role Hi-Speed USB
controller based on the DesignWare HSOTG IP Core.
  
  - For host mode, if you choose to build the driver as dynamically
  - linked modules, the core module will be called dwc2.ko, the PCI
  - bus interface module (if you have a PCI bus system) will be
  - called dwc2_pci.ko, and the platform interface module (for
  - controllers directly connected to the CPU) will be called
  - dwc2_platform.ko. For gadget mode, there will be a single
  - module called dwc2_gadget.ko.
  + If you choose to build the driver as dynamically
  + linked modules, a single dwc2.ko(regardless of mode of operation)
  + will get built for both platform IPs and PCI.
  
  - NOTE: The s3c-hsotg driver is now renamed to dwc2_gadget. The
  - host and gadget drivers are still currently separate drivers.
  - There are plans to merge the dwc2_gadget driver with the dwc2
  - host driver in the near future to create a dual-role driver.
  + NOTE: The s3c-hsotg driver is now renamed to dwc2_gadget.
 
 Looks like this line is incorrect, dwc2_gadget.ko no longer exists,
 right?
 
Yes, that is correct.

Thanks,
Dinh


--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html