RE: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

[Jun Li]

Hi Rob

> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Jun Li
> Sent: Monday, December 18, 2017 4:36 PM
> To: Rob Herring <r...@kernel.org>
> Cc: mathias.ny...@intel.com; gre...@linuxfoundation.org;
> mark.rutl...@arm.com; linux-usb@vger.kernel.org;
> devicet...@vger.kernel.org
> Subject: RE: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas
> property
> 
> > -Original Message-
> > From: Rob Herring [mailto:r...@kernel.org]
> > Sent: Saturday, December 16, 2017 6:26 AM
> > To: Jun Li <jun...@nxp.com>
> > Cc: mathias.ny...@intel.com; gre...@linuxfoundation.org;
> > mark.rutl...@arm.com; linux-usb@vger.kernel.org;
> > devicet...@vger.kernel.org
> > Subject: Re: [PATCH 1/2] dt-bindings: usb-xhci: add
> > usb3-resume-missing-cas property
> >
> > On Tue, Dec 12, 2017 at 11:57:17AM +0800, Li Jun wrote:
> > > Adding 'usb3-resume-missing-cas' property to enable XHCI_MISSING_CAS
> > > quirk flag in case there is CAS missing if device plugged in S3.
> > >
> > > Signed-off-by: Li Jun <jun...@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > index e2ea59b..c413e188 100644
> > > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > @@ -32,6 +32,8 @@ Optional properties:
> > >- usb3-lpm-capable: determines if platform is USB3 LPM capable
> > >- quirk-broken-port-ped: set if the controller has broken port
> > > disable
> > mechanism
> > >- imod-interval-ns: default interrupt moderation interval is
> > > 5000ns
> > > +  - usb3-resume-missing-cas: set if the CAS(Cold Attach Status) may
> > > + lose in
> > case
> > > +usb3 device plugged in while system sleep.
> >
> > This should be implied by an SoC specific compatible string for the XHCI 
> > block.
> 
> The quirk is already using on some PCI platforms(xhci-pci.c), so I think it 
> will be
> possible used for other SoCs as well in future.

Do you still think I should add SoC specific compatible string for this?

Jun Li
> 
> thanks
> Jun Li
> 
> >
> > Rob
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in the 
> body of
> a message to majord...@vger.kernel.org More majordomo info at
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.ke
> rnel.org%2Fmajordomo-
> info.html=02%7C01%7Cjun.li%40nxp.com%7C4ab4c3f3e85e475b06f808d
> 545f2615a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636491829
> 682216310=8YEh55OxgmvsQAi5mtZS%2B5wdcWTRiXuKsfyoxmCjILQ%3D
> =0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

[Jun Li]

> -Original Message-
> From: Rob Herring [mailto:r...@kernel.org]
> Sent: Saturday, December 16, 2017 6:26 AM
> To: Jun Li <jun...@nxp.com>
> Cc: mathias.ny...@intel.com; gre...@linuxfoundation.org;
> mark.rutl...@arm.com; linux-usb@vger.kernel.org;
> devicet...@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas
> property
> 
> On Tue, Dec 12, 2017 at 11:57:17AM +0800, Li Jun wrote:
> > Adding 'usb3-resume-missing-cas' property to enable XHCI_MISSING_CAS
> > quirk flag in case there is CAS missing if device plugged in S3.
> >
> > Signed-off-by: Li Jun <jun...@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > index e2ea59b..c413e188 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > @@ -32,6 +32,8 @@ Optional properties:
> >- usb3-lpm-capable: determines if platform is USB3 LPM capable
> >- quirk-broken-port-ped: set if the controller has broken port disable
> mechanism
> >- imod-interval-ns: default interrupt moderation interval is 5000ns
> > +  - usb3-resume-missing-cas: set if the CAS(Cold Attach Status) may lose in
> case
> > +usb3 device plugged in while system sleep.
> 
> This should be implied by an SoC specific compatible string for the XHCI 
> block.

The quirk is already using on some PCI platforms(xhci-pci.c), so I think it will
be possible used for other SoCs as well in future.

thanks
Jun Li

> 
> Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

[Rob Herring]

On Tue, Dec 12, 2017 at 11:57:17AM +0800, Li Jun wrote:
> Adding 'usb3-resume-missing-cas' property to enable XHCI_MISSING_CAS
> quirk flag in case there is CAS missing if device plugged in S3.
> 
> Signed-off-by: Li Jun 
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt 
> b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index e2ea59b..c413e188 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -32,6 +32,8 @@ Optional properties:
>- usb3-lpm-capable: determines if platform is USB3 LPM capable
>- quirk-broken-port-ped: set if the controller has broken port disable 
> mechanism
>- imod-interval-ns: default interrupt moderation interval is 5000ns
> +  - usb3-resume-missing-cas: set if the CAS(Cold Attach Status) may lose in 
> case
> +usb3 device plugged in while system sleep.

This should be implied by an SoC specific compatible string for the XHCI 
block.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html