RE: [PATCH v2 0/4] libusbg: Fix potential issues found with coverity
Hi, I have just go through you patches once again and test it. Each commit is able to build. I have also tested it on my board and didn't find any regression. Please update commit messages according to my comments and patches will look good to me. -- BR's Krzysztof Opasiak > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Philippe De Swert > Sent: Tuesday, May 13, 2014 4:13 PM > To: Krzysztof Opasiak; linux-usb@vger.kernel.org > Cc: mpor...@linaro.org; Philippe De Swert > Subject: [PATCH v2 0/4] libusbg: Fix potential issues found with > coverity > > This patch series fixes a number of issues found with coverity in > libusbg > A pull request has also be made: > https://github.com/libusbg/libusbg/pull/4 > > This is the second version where we use a different fix for the > readlink, > actually use the right USB_MAX_STR_LENGTH define. I also fixed an > issue > I missed first time around. > > Philippe De Swert (4): > libusbg: Fix readlink/buffer overrun issue. CID#56130, CID#56129 > libusbg: Fix buffer overrun issue. CID#56128 > libusbg: Do not try to dereference func when it is NULL. > CID#56127 > libusbg: Do not dereference usb config attributes when they are > NULL. > CID#56126 > > src/usbg.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > -- > 1.8.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux- > usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/4] libusbg: Fix potential issues found with coverity
Hi, On 16/05/14 11:35, Krzysztof Opasiak wrote: I have just go through you patches once again and test it. Each commit is able to build. I have also tested it on my board and didn't find any regression. Please update commit messages according to my comments and patches will look good to me. Excellent! Will update those comments and resend later. Thanks, Philippe This patch series fixes a number of issues found with coverity in libusbg A pull request has also be made: https://github.com/libusbg/libusbg/pull/4 This is the second version where we use a different fix for the readlink, actually use the right USB_MAX_STR_LENGTH define. I also fixed an issue I missed first time around. Philippe De Swert (4): libusbg: Fix readlink/buffer overrun issue. CID#56130, CID#56129 libusbg: Fix buffer overrun issue. CID#56128 libusbg: Do not try to dereference func when it is NULL. CID#56127 libusbg: Do not dereference usb config attributes when they are NULL. CID#56126 src/usbg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux- usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/4] libusbg: Fix potential issues found with coverity
On Tue, May 13, 2014 at 05:13:18PM +0300, Philippe De Swert wrote: > This patch series fixes a number of issues found with coverity in libusbg > A pull request has also be made: > https://github.com/libusbg/libusbg/pull/4 > > This is the second version where we use a different fix for the readlink, > actually use the right USB_MAX_STR_LENGTH define. I also fixed an issue > I missed first time around. Thanks, applied to master. -Matt > Philippe De Swert (4): > libusbg: Fix readlink/buffer overrun issue. CID#56130, CID#56129 > libusbg: Fix buffer overrun issue. CID#56128 > libusbg: Do not try to dereference func when it is NULL. CID#56127 > libusbg: Do not dereference usb config attributes when they are NULL. > CID#56126 > > src/usbg.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
