Re: [PATCH v7 00/11] usb: musb: adding multi instance support
On Thu, Aug 02, 2012 at 05:42:43PM +0530, Ravi Babu wrote: This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API devm_usb_get_phy_by_phandle() to get the PHY of same type. This API support is being added by Kishon's patch discussed at [1] The series applies to linux-omap (master branch) + Vaibhav baseport patches on his tree at [3] + Kishon's multi phy patches on Felipe's branch 'xceiv' + Kishon's patch on phandle at [1] + AM33xx musb glue compile and bugfix patches at [4], [5], [6] and [7] + Damodar's recent patch at [2] and have been tested on Beaglebone board. Any hints as to if or when this will be applied to the following repository? http://arago-project.org/git/projects/linux-omap3.git?p=projects/linux-omap3.git;a=summary thanks, Chris -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 00/11] usb: musb: adding multi instance support
On Mon, Aug 06, 2012 at 01:22:53, Daniel Mack wrote: On 03.08.2012 17:48, Hiremath, Vaibhav wrote: On Fri, Aug 03, 2012 at 17:11:38, Daniel Mack wrote: On 03.08.2012 11:07, Hiremath, Vaibhav wrote: I have just pushed the code (V7 which Ravi submitted), so can you please try with below branch? https://github.com/hvaibhav/am335x-linux/tree/am335x-upstream-staging-usb Thanks for doing this, but I'm unfortunately getting tons of merge conflicts when I try to put this on top of 3.6-rc1. Still pondering which way around is the easiest to get this solved. OTOH, I wonder whether your staging branches would need to rebased sooner or later anyway? I have already pushed branch based on v3.6-rc1 (boot tested), https://github.com/hvaibhav/am335x-linux/tree/am335x-linux-next-master Sorry, I don't get it yet. Your am335x-linux-next-master can be merged into v3.6-rc1 without problems, but it doesn't contain Ravi's patches. And am335x-upstream-staging-usb doesn't apply on top of either am335x-linux-next-master or v3.6-rc1. Maybe I just miss a detail here. Could you again explain which branch will you publish for merging in the 3.7 merge window, and what are its dependencies? Daniel, Every developer is supposed to submit the patches on top of their maintainer's repository, which may or may not be in-sync with latest linux- next or Linus's tree at given time OR their could be some extra dependency from framework. For example, linux-omap is still not updated to v3.6-rc1, but I have to use linux-omap/master for all patch submissions. It becomes extra work for each developers to maintain branch for both, one against their maintainer HEAD and one against linux-next/master. So I am just pushing the branch which is being tested/validated (on BeagleBone) before submitting patches to the list. I hope this clarifies all your confusion. Thanks, Vaibhav Thanks for your work, Daniel -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 00/11] usb: musb: adding multi instance support
On 03.08.2012 02:54, B, Ravi wrote: On 02.08.2012 14:12, Ravi Babu wrote: This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API devm_usb_get_phy_by_phandle() to get the PHY of same type. This API support is being added by Kishon's patch discussed at [1] The series applies to linux-omap (master branch) + Vaibhav baseport patches on his tree at [3] + Kishon's multi phy patches on Felipe's branch 'xceiv' + Kishon's patch on phandle at [1] + AM33xx musb glue compile and bugfix patches at [4], [5], [6] and [7] + Damodar's recent patch at [2] and have been tested on Beaglebone board. Have you applied the above patches before applying these patches. Somehow, I was missing some of Ajay's patches. I resolved that, and now the series applied. However, I needed to add a phandle usb0-phy = usb0_phy to the usb_otg_hs DTSI block, otherwise devm_usb_get_phy_by_phandle() in drivers/usb/musb/musb_dsps.c would fail. Is that correct? I can't seem to find that in your patches. With this addition, I see the following: [1.782180] musb-hdrc: version 6.0, ?dma?, otg (peripheral+host) [1.809966] musb-hdrc musb-hdrc.0: MUSB HDRC host driver [1.819068] musb-hdrc musb-hdrc.0: new USB bus registered, assigned bus number 1 [1.827970] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002 [1.835184] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [1.842818] usb usb1: Product: MUSB HDRC host driver [1.848031] usb usb1: Manufacturer: Linux 3.6.0-rc1-00038-g8a1ec8f-dirty musb-hcd [1.855933] usb usb1: SerialNumber: musb-hdrc.0 [1.866913] hub 1-0:1.0: USB hub found [1.871192] hub 1-0:1.0: 1 port detected [1.878106] musb-hdrc musb-hdrc.0: USB Host mode controller at d08c using PIO, IRQ 18 ... but no USB functions. Also, every two seconds, the following message is printed: [ 11.036608] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active [ 13.044811] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active [ 15.052196] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active Anything obvious that I'm missing? Thanks, Daniel -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 00/11] usb: musb: adding multi instance support
Hi, On 03.08.2012 02:54, B, Ravi wrote: On 02.08.2012 14:12, Ravi Babu wrote: This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API devm_usb_get_phy_by_phandle() to get the PHY of same type. This API support is being added by Kishon's patch discussed at [1] The series applies to linux-omap (master branch) + Vaibhav baseport patches on his tree at [3] + Kishon's multi phy patches on Felipe's branch 'xceiv' + Kishon's patch on phandle at [1] + AM33xx musb glue compile and bugfix patches at [4], [5], [6] and [7] + Damodar's recent patch at [2] and have been tested on Beaglebone board. Have you applied the above patches before applying these patches. Somehow, I was missing some of Ajay's patches. I resolved that, and now the series applied. However, I needed to add a phandle usb0-phy = usb0_phy to the usb_otg_hs DTSI block, otherwise devm_usb_get_phy_by_phandle() in drivers/usb/musb/musb_dsps.c would fail. Is that correct? I can't seem to find that in your patches. It's getting done in patch 11/11. With this addition, I see the following: [1.782180] musb-hdrc: version 6.0, ?dma?, otg (peripheral+host) [1.809966] musb-hdrc musb-hdrc.0: MUSB HDRC host driver [1.819068] musb-hdrc musb-hdrc.0: new USB bus registered, assigned bus number 1 [1.827970] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002 [1.835184] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [1.842818] usb usb1: Product: MUSB HDRC host driver [1.848031] usb usb1: Manufacturer: Linux 3.6.0-rc1-00038-g8a1ec8f-dirty musb-hcd [1.855933] usb usb1: SerialNumber: musb-hdrc.0 [1.866913] hub 1-0:1.0: USB hub found [1.871192] hub 1-0:1.0: 1 port detected [1.878106] musb-hdrc musb-hdrc.0: USB Host mode controller at d08c using PIO, IRQ 18 ... but no USB functions. Also, every two seconds, the following message is printed: [ 11.036608] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active [ 13.044811] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active [ 15.052196] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active Do you see them even when you connect a device to port? Ajay Anything obvious that I'm missing? Thanks, Daniel -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 00/11] usb: musb: adding multi instance support
Hi Daniel This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API devm_usb_get_phy_by_phandle() to get the PHY of same type. This API support is being added by Kishon's patch discussed at [1] The series applies to linux-omap (master branch) + Vaibhav baseport patches on his tree at [3] + Kishon's multi phy patches on Felipe's branch 'xceiv' + Kishon's patch on phandle at [1] + AM33xx musb glue compile and bugfix patches at [4], [5], [6] and [7] + Damodar's recent patch at [2] and have been tested on Beaglebone board. Have you applied the above patches before applying these patches. Somehow, I was missing some of Ajay's patches. I resolved that, and now the series applied. However, I needed to add a phandle usb0-phy = usb0_phy to the usb_otg_hs DTSI block, otherwise devm_usb_get_phy_by_phandle() in drivers/usb/musb/musb_dsps.c would fail. Is that correct? I can't seem to find that in your patches. It's getting done in patch 11/11. Refer patch 11/11 available at http://marc.info/?l=linux-usbm=134390988804627w=2 Ravi Babu With this addition, I see the following: [1.782180] musb-hdrc: version 6.0, ?dma?, otg (peripheral+host) [1.809966] musb-hdrc musb-hdrc.0: MUSB HDRC host driver [1.819068] musb-hdrc musb-hdrc.0: new USB bus registered, assigned bus number 1 [1.827970] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002 [1.835184] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [1.842818] usb usb1: Product: MUSB HDRC host driver [1.848031] usb usb1: Manufacturer: Linux 3.6.0-rc1-00038-g8a1ec8f-dirty musb-hcd [1.855933] usb usb1: SerialNumber: musb-hdrc.0 [1.866913] hub 1-0:1.0: USB hub found [1.871192] hub 1-0:1.0: 1 port detected [1.878106] musb-hdrc musb-hdrc.0: USB Host mode controller at d08c using PIO, IRQ 18 ... but no USB functions. Also, every two seconds, the following message is printed: [ 11.036608] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active [ 13.044811] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active [ 15.052196] musb_bus_suspend 2308: trying to suspend as a_wait_vrise while active Do you see them even when you connect a device to port? Ajay Anything obvious that I'm missing? Thanks, Daniel -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- - This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -- - -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 00/11] usb: musb: adding multi instance support
On 03.08.2012 11:07, Hiremath, Vaibhav wrote: I have just pushed the code (V7 which Ravi submitted), so can you please try with below branch? https://github.com/hvaibhav/am335x-linux/tree/am335x-upstream-staging-usb Thanks for doing this, but I'm unfortunately getting tons of merge conflicts when I try to put this on top of 3.6-rc1. Still pondering which way around is the easiest to get this solved. OTOH, I wonder whether your staging branches would need to rebased sooner or later anyway? Daniel -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 00/11] usb: musb: adding multi instance support
Op 3 aug. 2012, om 13:41 heeft Daniel Mack zon...@gmail.com het volgende geschreven: On 03.08.2012 11:07, Hiremath, Vaibhav wrote: I have just pushed the code (V7 which Ravi submitted), so can you please try with below branch? https://github.com/hvaibhav/am335x-linux/tree/am335x-upstream-staging-usb Thanks for doing this, but I'm unfortunately getting tons of merge conflicts when I try to put this on top of 3.6-rc1. Still pondering which way around is the easiest to get this solved. A number of those patches are already in 3.6rc1 (the first 10 or so). I use this set: https://github.com/beagleboard/kernel/tree/beaglebone-3.6/patches/usb Those where pulled from the staging branch and refreshed this morning. Matching git branch (will get rebased): https://github.com/koenkooi/linux/commits/beaglebone-3.6-dont-use That gives me rootfs on USB on beaglebone port1 and g_ether gadget on beaglebone port0. Hopefully this will work on your custom board as well. regards, Koen-- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 00/11] usb: musb: adding multi instance support
On Fri, Aug 03, 2012 at 17:11:38, Daniel Mack wrote: On 03.08.2012 11:07, Hiremath, Vaibhav wrote: I have just pushed the code (V7 which Ravi submitted), so can you please try with below branch? https://github.com/hvaibhav/am335x-linux/tree/am335x-upstream-staging-usb Thanks for doing this, but I'm unfortunately getting tons of merge conflicts when I try to put this on top of 3.6-rc1. Still pondering which way around is the easiest to get this solved. OTOH, I wonder whether your staging branches would need to rebased sooner or later anyway? I have already pushed branch based on v3.6-rc1 (boot tested), https://github.com/hvaibhav/am335x-linux/tree/am335x-linux-next-master Thanks, Vaibhav -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 00/11] usb: musb: adding multi instance support
Op 3 aug. 2012, om 17:48 heeft Hiremath, Vaibhav hvaib...@ti.com het volgende geschreven: On Fri, Aug 03, 2012 at 17:11:38, Daniel Mack wrote: On 03.08.2012 11:07, Hiremath, Vaibhav wrote: I have just pushed the code (V7 which Ravi submitted), so can you please try with below branch? https://github.com/hvaibhav/am335x-linux/tree/am335x-upstream-staging-usb Thanks for doing this, but I'm unfortunately getting tons of merge conflicts when I try to put this on top of 3.6-rc1. Still pondering which way around is the easiest to get this solved. OTOH, I wonder whether your staging branches would need to rebased sooner or later anyway? I have already pushed branch based on v3.6-rc1 (boot tested), https://github.com/hvaibhav/am335x-linux/tree/am335x-linux-next-master I think Daniel meant without the linux-next stuff in between. E.g. on top of the v3.6-rc1 tag. I can see that such a tree is not of much use for you, since you now need to target the 3.7 merge window for new patches. But I can't and won't speak for both of you :) regards, Koen-- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
