RE: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3 nod

2017-08-11 Thread Leo Li


> -Original Message-
> From: linux-devel-boun...@gforge.freescale.net [mailto:linux-devel-
> boun...@gforge.freescale.net] On Behalf Of yinbo@nxp.com
> Sent: Friday, August 11, 2017 4:30 AM
> To: linux-de...@gforge.freescale.net; Yinbo Zhu ; Rob
> Herring ; Mark Rutland ;
> Russell King ; Felipe Balbi 
> Cc: open list ; Laurent Pinchart
> ; Catalin Marinas
> ; open list ; open list
> ; Doug Ledford ;
> Stefano Stabellini ; Greg Kroah-Hartman
> ; Bart Van Assche
> ; moderated list  ker...@lists.infradead.org>
> Subject: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to
> USB3 nod
> 
> From: "yinbo.zhu" 
> 

There is no device tree binding for this property.  You need to add the binding 
first before you add it to the dts.  And normally you need to describe why the 
change is needed in the commit message.

> Signed-off-by: yinbo.zhu 
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index ffbf3cf..f525297 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -731,6 +731,8 @@
>   interrupts = ;
>   dr_mode = "host";
>   snps,quirk-frame-length-adjustment = <0x20>;
> + configure-gfladj;
> + dma-coherent;

This change is not aligned with your patch title.

>   snps,dis_rxdet_inp3_quirk;
>   };
> 
> --
> 2.1.0.27.g96db324
> 
> ___
> linux-devel mailing list
> linux-de...@gforge.freescale.net
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgforge.
> freescale.net%2Fmailman%2Flistinfo%2Flinux-
> devel&data=01%7C01%7Cleoyang.li%40nxp.com%7C015b054c76ad48399ea408
> d4e09de91d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=7ioU%2Bb
> QUP4X%2F8%2BFpcQZICVDHugioStScbrHc0XOqaQs%3D&reserved=0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to USB3 nod

2017-08-11 Thread Sriram Dash
>From: linux-devel-boun...@gforge.freescale.net [mailto:linux-devel-
>boun...@gforge.freescale.net] On Behalf Of yinbo@nxp.com
>Subject: [linux-devel] [PATCH 1/3] dts: usb3: Add configure-gfladj property to 
>USB3
>nod
>
>From: "yinbo.zhu" 
>
>Signed-off-by: yinbo.zhu 
>---
> arch/arm/boot/dts/ls1021a.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi 
>index
>ffbf3cf..f525297 100644
>--- a/arch/arm/boot/dts/ls1021a.dtsi
>+++ b/arch/arm/boot/dts/ls1021a.dtsi
>@@ -731,6 +731,8 @@
>   interrupts = ;
>   dr_mode = "host";
>   snps,quirk-frame-length-adjustment = <0x20>;
>+  configure-gfladj;

I reckon the "configure-gfladj" is replaced with 
"snps,quirk-frame-length-adjustment"
in open source, which sets fladj reg value.
Please verify.

>+  dma-coherent;

>   snps,dis_rxdet_inp3_quirk;
>   };
>
>--
>2.1.0.27.g96db324
>
>___
>linux-devel mailing list
>linux-de...@gforge.freescale.net
>http://gforge.freescale.net/mailman/listinfo/linux-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html