Re: [PATCH] usb: typec: include linux/device.h in ucsi.h
On 06/30/2017 08:46 AM, Arnd Bergmann wrote: The new driver causes a build failure in some configurations: In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0, from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2: drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] This includes the required header file. Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface") Signed-off-by: Arnd Bergmann Reviewed-by: Guenter Roeck --- drivers/usb/typec/ucsi/ucsi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h index 6b0d2f0918c6..8a88f45822e3 100644 --- a/drivers/usb/typec/ucsi/ucsi.h +++ b/drivers/usb/typec/ucsi/ucsi.h @@ -3,6 +3,7 @@ #define __DRIVER_USB_TYPEC_UCSI_H #include +#include #include /* -- */ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: typec: include linux/device.h in ucsi.h
On Fri, Jun 30, 2017 at 05:46:16PM +0200, Arnd Bergmann wrote: > The new driver causes a build failure in some configurations: > > In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0, > from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2: > drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside > parameter list will not be visible outside of this definition or declaration > [-Werror] > > This includes the required header file. > > Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface") > Signed-off-by: Arnd Bergmann Acked-by: Heikki Krogerus > --- > drivers/usb/typec/ucsi/ucsi.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h > index 6b0d2f0918c6..8a88f45822e3 100644 > --- a/drivers/usb/typec/ucsi/ucsi.h > +++ b/drivers/usb/typec/ucsi/ucsi.h > @@ -3,6 +3,7 @@ > #define __DRIVER_USB_TYPEC_UCSI_H > > #include > +#include > #include > > /* > -- */ > -- > 2.9.0 -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html