Re: [PATCH 1/1] usb: misc: usbtest: add bulk queue test

[Felipe Balbi]

Hi,

Peter Chen  writes:
> The bulk queue tests are used to show 'best performance' for bulk
> transfer, we are often asked this question by users. The implementation
> is the same with iso test, that is queue request at interrupt completion,
> so we reuse the iso structures, and rename them as common one.
>
> It's result should be very close to IC simulation, in order
> to get that, the device side should also need to prepare enough
> queue.
>
> We have got the 'best performance' (IN: 41MB, OUT: 39MB) at i.mx platform
> (USB2, ARM Cortex A9, stream mode need to enable) with below command:
>
> Host side:
> modprobe usbtest
> ./testusb -a -t 27 -g 64 -s 16384
> ./testusb -a -t 28 -g 64 -s 16384
> Gadget side:
> modprobe g_zero loopdefault=1 qlen=64 buflen=16384
>
> Signed-off-by: Peter Chen 

please fix the following:

WARNING: please, no space before tabs
#49: FILE: drivers/usb/misc/usbtest.c:244:
+^Iusb_complete_t ^I^Icomplete_fn)$

WARNING: line over 80 characters
#206: FILE: drivers/usb/misc/usbtest.c:2019:
+ else if (context.errors > (context.is_iso ? context.packet_count /
10 : 0))

ERROR: need consistent spacing around '/' (ctx:VxW)
#267: FILE: drivers/usb/misc/usbtest.c:2536:
+   param->sglen * param->length)/ (1024 * 1024));
^

ERROR: need consistent spacing around '/' (ctx:VxW)
#276: FILE: drivers/usb/misc/usbtest.c:2545:
+   param->sglen * param->length)/ (1024 * 1024));


-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH 1/1] usb: misc: usbtest: add bulk queue test

[Peter Chen]

On Sun, Oct 04, 2015 at 10:47:58AM +0100, Greg KH wrote:
> On Mon, Sep 07, 2015 at 02:13:57PM +0800, Peter Chen wrote:
> > The bulk queue tests are used to show 'best performance' for bulk
> > transfer, we are often asked this question by users. The implementation
> > is the same with iso test, that is queue request at interrupt completion,
> > so we reuse the iso structures, and rename them as common one.
> > 
> > It's result should be very close to IC simulation, in order
> > to get that, the device side should also need to prepare enough
> > queue.
> > 
> > We have got the 'best performance' (IN: 41MB, OUT: 39MB) at i.mx platform
> > (USB2, ARM Cortex A9, stream mode need to enable) with below command:
> > 
> > Host side:
> > modprobe usbtest
> > ./testusb -a -t 27 -g 64 -s 16384
> > ./testusb -a -t 28 -g 64 -s 16384
> > Gadget side:
> > modprobe g_zero loopdefault=1 qlen=64 buflen=16384
> > 
> > Signed-off-by: Peter Chen 
> > ---
> >  drivers/usb/misc/usbtest.c | 104 
> > +++--
> >  1 file changed, 73 insertions(+), 31 deletions(-)
> 
> Doesn't apply to the usb-next branch :(

The other usb-test changes are applied at Felipe's tree, this one
is based on those change.

Felipe, would you please help to queue it?

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] usb: misc: usbtest: add bulk queue test

[Greg KH]

On Mon, Sep 07, 2015 at 02:13:57PM +0800, Peter Chen wrote:
> The bulk queue tests are used to show 'best performance' for bulk
> transfer, we are often asked this question by users. The implementation
> is the same with iso test, that is queue request at interrupt completion,
> so we reuse the iso structures, and rename them as common one.
> 
> It's result should be very close to IC simulation, in order
> to get that, the device side should also need to prepare enough
> queue.
> 
> We have got the 'best performance' (IN: 41MB, OUT: 39MB) at i.mx platform
> (USB2, ARM Cortex A9, stream mode need to enable) with below command:
> 
> Host side:
> modprobe usbtest
> ./testusb -a -t 27 -g 64 -s 16384
> ./testusb -a -t 28 -g 64 -s 16384
> Gadget side:
> modprobe g_zero loopdefault=1 qlen=64 buflen=16384
> 
> Signed-off-by: Peter Chen 
> ---
>  drivers/usb/misc/usbtest.c | 104 
> +++--
>  1 file changed, 73 insertions(+), 31 deletions(-)

Doesn't apply to the usb-next branch :(
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html