Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > f_phonet's ->set_alt() method will call usb_ep_disable() > potentially on an endpoint which is already disabled. That's > something the gadget/function driver must guarantee that it's > always balanced. > > In order to balance the calls, just make sure the endpoint > was enabled before by means of checking the validity of > driver_data. > > Reported-by: Pali Rohár > Signed-off-by: Felipe Balbi > --- Your patches cause that kernel does not print any error message to n900 screen anymore and reboot device in 10 seconds. I did not loaded any external modules. In qemu I see this crash in early boot: [0.500549] Unable to handle kernel NULL pointer dereference at virtual address [0.501068] pgd = c0004000 [0.501281] [] *pgd= [0.501800] Internal error: Oops: 8005 [#1] PREEMPT ARM [0.502197] Modules linked in: [0.502593] CPU: 0 PID: 1 Comm: swapper Not tainted 3.19.0-rc5+ #300 [0.502990] Hardware name: Nokia RX-51 board [0.503295] task: cf8a8000 ti: cf8ac000 task.ti: cf8ac000 [0.503692] PC is at 0x0 [0.503906] LR is at omap2430_runtime_resume+0x30/0x68 [0.504333] pc : [<>]lr : []psr: a113 [0.504333] sp : cf8adda0 ip : 0001 fp : c0059824 [0.505004] r10: cf8adde8 r9 : cf9b5884 r8 : cf9b58cc [0.505340] r7 : 0004 r6 : cf93ee10 r5 : c068944c r4 : cf83a010 [0.505767] r3 : r2 : r1 : 0414 r0 : fa0ab000 [0.506195] Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel [0.506683] Control: 10c53c7d Table: 80004059 DAC: 0015 [0.507049] Process swapper (pid: 1, stack limit = 0xcf8ac238) [0.507476] Stack: (0xcf8adda0 to 0xcf8ae000) [0.507812] dda0: c02c90dc c0021ff4 cf9b5810 c0267de4 c0269680 cf9b5810 [0.508331] ddc0: c0269740 cf9b5810 cf9b5810 c026ac44 c0428350 cfa29410 [0.508819] dde0: cfb36800 c0428350 cfa29410 cfa2a540 6113 cfa2a500 cfa29410 [0.509307] de00: c063e9f8 006c c05fe9f4 c05bc6d4 c026b114 cfa2c100 cfa29410 [0.509826] de20: cfa2a500 c026b174 cf83a010 c02c1698 cfa29410 006c fa0ab000 ffed [0.510314] de40: cfa29410 c063e9f8 c063e9f8 c060af98 c05fe9f4 c05bc6d4 c0263d78 [0.510833] de60: cfa29410 c02624ec cfa29410 c063e9f8 c063e9f8 [0.511322] de80: c0262718 cfa29410 cfa29444 c0262790 c063e9f8 cf8adea8 [0.511810] dea0: c0262730 c0261070 cf88cb8c cfa2c230 c063e9f8 c063e9f8 cfb27a80 c0638848 [0.512298] dec0: c0261e20 c04281ec c04281ed c063e9f8 cfb3b200 [0.512786] dee0: c060af98 c02630c8 c0263cd8 c05e390c cfb3b200 c0008798 c05bc6d4 c004aa44 [0.513336] df00: c058c09c cfcb6e13 c0546eb9 a113 c058c09c 0006 0065 [0.513854] df20: 0006 c004aae8 0065 0006 0006 c05bc6d4 cfcb6e03 cfcb6e12 [0.514373] df40: 0006 c05f1fb8 0006 c05f1fbc c05f1f9c c064d2c0 0065 [0.514862] df60: c05fe9f4 c05bccfc 0006 0006 c05bc6d4 c0626858 c05fe5c0 c05fe5c0 [0.515350] df80: c05bcd94 cf8ac000 [0.515869] dfa0: c03e1094 c03e109c c000dc78 [0.516387] dfc0: [0.516906] dfe0: 0013 [0.517791] [] (omap2430_runtime_resume) from [] (pm_generic_runtime_resume+0x2c/0x40) [0.518432] [] (pm_generic_runtime_resume) from [] (__rpm_callback+0x8c/0xdc) [0.518981] [] (__rpm_callback) from [] (rpm_callback+0x70/0x88) [0.519470] [] (rpm_callback) from [] (rpm_resume+0x514/0x704) [0.519927] [] (rpm_resume) from [] (__pm_runtime_resume+0x4c/0x90) [0.520446] [] (__pm_runtime_resume) from [] (pm_runtime_irq_safe+0x1c/0x74) [0.520996] [] (pm_runtime_irq_safe) from [] (musb_init_controller+0x50/0x60c) [0.521545] [] (musb_init_controller) from [] (platform_drv_probe+0x48/0x90) [0.522094] [] (platform_drv_probe) from [] (really_probe+0xac/0x1e0) [0.522583] [] (really_probe) from [] (driver_probe_device+0x30/0x48) [0.523101] [] (driver_probe_device) from [] (__driver_attach+0x60/0x84) [0.523590] [] (__driver_attach) from [] (bus_for_each_dev+0x50/0x84) [0.524078] [] (bus_for_each_dev) from [] (bus_add_driver+0xac/0x1bc) [0.524566] [] (bus_add_driver) from [] (driver_register+0x9c/0xe0) [0.525054] [] (driver_register) from [] (do_one_initcall+0x100/0x1b0) [0.525573] [] (do_one_initcall) from [] (do_basic_setup+0x88/0xc0) [0.526062] [] (do_basic_setup) from [] (kernel_init_freeable+0x60/0xfc) [0.526580] [] (kernel_init_freeable) from [] (kernel_init+0x8/0xe4) [0.527160] [] (kernel_init) from [] (ret_from_fork+0
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > f_phonet's ->set_alt() method will call usb_ep_disable() > > potentially on an endpoint which is already disabled. That's > > something the gadget/function driver must guarantee that it's > > always balanced. > > > > In order to balance the calls, just make sure the endpoint > > was enabled before by means of checking the validity of > > driver_data. > > > > Reported-by: Pali Rohár > > Signed-off-by: Felipe Balbi > > --- > > Your patches cause that kernel does not print any error message to > n900 screen anymore and reboot device in 10 seconds. I did not loaded > any external modules. > > In qemu I see this crash in early boot: alright, so n900's working fine. I'll wait until you debug qemu a little more, thank you -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > Hi, > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > f_phonet's ->set_alt() method will call usb_ep_disable() > > > potentially on an endpoint which is already disabled. > > > That's something the gadget/function driver must > > > guarantee that it's always balanced. > > > > > > In order to balance the calls, just make sure the endpoint > > > was enabled before by means of checking the validity of > > > driver_data. > > > > > > Reported-by: Pali Rohár > > > Signed-off-by: Felipe Balbi > > > --- > > > > Your patches cause that kernel does not print any error > > message to n900 screen anymore and reboot device in 10 > > seconds. I did not loaded any external modules. > > > In qemu I see this crash in early boot: > alright, so n900's working fine. I'll wait until you debug > qemu a little more, thank you NO! It does not working, see . It break n900 totally! -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > Hi, > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > f_phonet's ->set_alt() method will call usb_ep_disable() > > > > potentially on an endpoint which is already disabled. > > > > That's something the gadget/function driver must > > > > guarantee that it's always balanced. > > > > > > > > In order to balance the calls, just make sure the endpoint > > > > was enabled before by means of checking the validity of > > > > driver_data. > > > > > > > > Reported-by: Pali Rohár > > > > Signed-off-by: Felipe Balbi > > > > --- > > > > > > Your patches cause that kernel does not print any error > > > message to n900 screen anymore and reboot device in 10 > > > seconds. I did not loaded any external modules. > > > > > In qemu I see this crash in early boot: > > alright, so n900's working fine. I'll wait until you debug > > qemu a little more, thank you > > NO! It does not working, see . It break n900 totally! settle down a bit more. I don't have the HW you have and things are working fine on boards I _do_ have, there's not much more I can do to help without you doing your homework. Debug a bit more and bring more information as to what's going on, until then you're on your own. -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > > f_phonet's ->set_alt() method will call > > > > > usb_ep_disable() potentially on an endpoint which is > > > > > already disabled. That's something the > > > > > gadget/function driver must guarantee that it's > > > > > always balanced. > > > > > > > > > > In order to balance the calls, just make sure the > > > > > endpoint was enabled before by means of checking the > > > > > validity of driver_data. > > > > > > > > > > Reported-by: Pali Rohár > > > > > Signed-off-by: Felipe Balbi > > > > > --- > > > > > > > > Your patches cause that kernel does not print any error > > > > message to n900 screen anymore and reboot device in 10 > > > > seconds. I did not loaded any external modules. > > > > > > > In qemu I see this crash in early boot: > > > alright, so n900's working fine. I'll wait until you debug > > > qemu a little more, thank you > > > > NO! It does not working, see . It break n900 totally! > > settle down a bit more. I don't have the HW you have and > things are working fine on boards I _do_ have, there's not > much more I can do to help without you doing your homework. > Debug a bit more and bring more information as to what's > going on, until then you're on your own. And what more do you need? It crash on my n900 and also in qemu. I sent you kernel crash dump from qemu which introduced *your* patches. Before applying your patches there was no crash in early boot stage. In current state I review all 3 patches as: Rejected-by: Pali Rohár [It breaks booting Nokia N900 device] -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > > > f_phonet's ->set_alt() method will call > > > > > > usb_ep_disable() potentially on an endpoint which is > > > > > > already disabled. That's something the > > > > > > gadget/function driver must guarantee that it's > > > > > > always balanced. > > > > > > > > > > > > In order to balance the calls, just make sure the > > > > > > endpoint was enabled before by means of checking the > > > > > > validity of driver_data. > > > > > > > > > > > > Reported-by: Pali Rohár > > > > > > Signed-off-by: Felipe Balbi > > > > > > --- > > > > > > > > > > Your patches cause that kernel does not print any error > > > > > message to n900 screen anymore and reboot device in 10 > > > > > seconds. I did not loaded any external modules. > > > > > > > > > In qemu I see this crash in early boot: > > > > alright, so n900's working fine. I'll wait until you debug > > > > qemu a little more, thank you > > > > > > NO! It does not working, see . It break n900 totally! > > > > settle down a bit more. I don't have the HW you have and > > things are working fine on boards I _do_ have, there's not > > much more I can do to help without you doing your homework. > > Debug a bit more and bring more information as to what's > > going on, until then you're on your own. > > And what more do you need? It crash on my n900 and also in qemu. > I sent you kernel crash dump from qemu which introduced *your* > patches. Before applying your patches there was no crash in early > boot stage. > > In current state I review all 3 patches as: > > Rejected-by: Pali Rohár > [It breaks booting Nokia N900 device] next step, figure why it's broken. Working just fine here on AM335x which has the same musb IP. -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tue, Feb 03, 2015 at 01:35:25PM -0600, Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > > > Hi, > > > > > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > usb_ep_disable() potentially on an endpoint which is > > > > > > > already disabled. That's something the > > > > > > > gadget/function driver must guarantee that it's > > > > > > > always balanced. > > > > > > > > > > > > > > In order to balance the calls, just make sure the > > > > > > > endpoint was enabled before by means of checking the > > > > > > > validity of driver_data. > > > > > > > > > > > > > > Reported-by: Pali Rohár > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > --- > > > > > > > > > > > > Your patches cause that kernel does not print any error > > > > > > message to n900 screen anymore and reboot device in 10 > > > > > > seconds. I did not loaded any external modules. > > > > > > > > > > > In qemu I see this crash in early boot: > > > > > alright, so n900's working fine. I'll wait until you debug > > > > > qemu a little more, thank you > > > > > > > > NO! It does not working, see . It break n900 totally! > > > > > > settle down a bit more. I don't have the HW you have and > > > things are working fine on boards I _do_ have, there's not > > > much more I can do to help without you doing your homework. > > > Debug a bit more and bring more information as to what's > > > going on, until then you're on your own. > > > > And what more do you need? It crash on my n900 and also in qemu. > > I sent you kernel crash dump from qemu which introduced *your* > > patches. Before applying your patches there was no crash in early > > boot stage. > > > > In current state I review all 3 patches as: > > > > Rejected-by: Pali Rohár > > [It breaks booting Nokia N900 device] > > next step, figure why it's broken. Working just fine here on AM335x > which has the same musb IP. in any case, .config will help. -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > > > Hi, > > > > > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > usb_ep_disable() potentially on an endpoint which > > > > > > > is already disabled. That's something the > > > > > > > gadget/function driver must guarantee that it's > > > > > > > always balanced. > > > > > > > > > > > > > > In order to balance the calls, just make sure the > > > > > > > endpoint was enabled before by means of checking > > > > > > > the validity of driver_data. > > > > > > > > > > > > > > Reported-by: Pali Rohár > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > --- > > > > > > > > > > > > Your patches cause that kernel does not print any > > > > > > error message to n900 screen anymore and reboot > > > > > > device in 10 seconds. I did not loaded any external > > > > > > modules. > > > > > > > > > > > In qemu I see this crash in early boot: > > > > > alright, so n900's working fine. I'll wait until you > > > > > debug qemu a little more, thank you > > > > > > > > NO! It does not working, see . It break n900 > > > > totally! > > > > > > settle down a bit more. I don't have the HW you have and > > > things are working fine on boards I _do_ have, there's not > > > much more I can do to help without you doing your > > > homework. Debug a bit more and bring more information as > > > to what's going on, until then you're on your own. > > > > And what more do you need? It crash on my n900 and also in > > qemu. I sent you kernel crash dump from qemu which > > introduced *your* patches. Before applying your patches > > there was no crash in early boot stage. > > > > In current state I review all 3 patches as: > > > > Rejected-by: Pali Rohár > > [It breaks booting Nokia N900 device] > > next step, figure why it's broken. Working just fine here on > AM335x which has the same musb IP. Why is broken? That is easy. You send 3 patches which broke it. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
Hi, On Tue, Feb 03, 2015 at 08:57:11PM +0100, Pali Rohár wrote: > > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > > usb_ep_disable() potentially on an endpoint which > > > > > > > > is already disabled. That's something the > > > > > > > > gadget/function driver must guarantee that it's > > > > > > > > always balanced. > > > > > > > > > > > > > > > > In order to balance the calls, just make sure the > > > > > > > > endpoint was enabled before by means of checking > > > > > > > > the validity of driver_data. > > > > > > > > > > > > > > > > Reported-by: Pali Rohár > > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > > --- > > > > > > > > > > > > > > Your patches cause that kernel does not print any > > > > > > > error message to n900 screen anymore and reboot > > > > > > > device in 10 seconds. I did not loaded any external > > > > > > > modules. > > > > > > > > > > > > > In qemu I see this crash in early boot: > > > > > > alright, so n900's working fine. I'll wait until you > > > > > > debug qemu a little more, thank you > > > > > > > > > > NO! It does not working, see . It break n900 > > > > > totally! > > > > > > > > settle down a bit more. I don't have the HW you have and > > > > things are working fine on boards I _do_ have, there's not > > > > much more I can do to help without you doing your > > > > homework. Debug a bit more and bring more information as > > > > to what's going on, until then you're on your own. > > > > > > And what more do you need? It crash on my n900 and also in > > > qemu. I sent you kernel crash dump from qemu which > > > introduced *your* patches. Before applying your patches > > > there was no crash in early boot stage. > > > > > > In current state I review all 3 patches as: > > > > > > Rejected-by: Pali Rohár > > > [It breaks booting Nokia N900 device] > > > > next step, figure why it's broken. Working just fine here on > > AM335x which has the same musb IP. > > Why is broken? That is easy. You send 3 patches which broke it. as I said, working just fine here: http://hastebin.com/zolunekepo -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tuesday 03 February 2015 20:51:34 Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 01:35:25PM -0600, Felipe Balbi wrote: > > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > > > > Hi, > > > > > > > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > > usb_ep_disable() potentially on an endpoint > > > > > > > > which is already disabled. That's something the > > > > > > > > gadget/function driver must guarantee that it's > > > > > > > > always balanced. > > > > > > > > > > > > > > > > In order to balance the calls, just make sure > > > > > > > > the endpoint was enabled before by means of > > > > > > > > checking the validity of driver_data. > > > > > > > > > > > > > > > > Reported-by: Pali Rohár > > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > > --- > > > > > > > > > > > > > > Your patches cause that kernel does not print any > > > > > > > error message to n900 screen anymore and reboot > > > > > > > device in 10 seconds. I did not loaded any > > > > > > > external modules. > > > > > > > > > > > > > In qemu I see this crash in early boot: > > > > > > alright, so n900's working fine. I'll wait until you > > > > > > debug qemu a little more, thank you > > > > > > > > > > NO! It does not working, see . It break n900 > > > > > totally! > > > > > > > > settle down a bit more. I don't have the HW you have and > > > > things are working fine on boards I _do_ have, there's > > > > not much more I can do to help without you doing your > > > > homework. Debug a bit more and bring more information > > > > as to what's going on, until then you're on your own. > > > > > > And what more do you need? It crash on my n900 and also in > > > qemu. I sent you kernel crash dump from qemu which > > > introduced *your* patches. Before applying your patches > > > there was no crash in early boot stage. > > > > > > In current state I review all 3 patches as: > > > > > > Rejected-by: Pali Rohár > > > [It breaks booting Nokia N900 device] > > > > next step, figure why it's broken. Working just fine here on > > AM335x which has the same musb IP. > > in any case, .config will help. # # Automatically generated file; DO NOT EDIT. # Linux/arm 3.19.0-rc5 Kernel Configuration # CONFIG_ARM=y CONFIG_ARM_HAS_SG_CHAIN=y CONFIG_NEED_SG_DMA_LENGTH=y CONFIG_ARM_DMA_USE_IOMMU=y CONFIG_ARM_DMA_IOMMU_ALIGNMENT=8 CONFIG_MIGHT_HAVE_PCI=y CONFIG_SYS_SUPPORTS_APM_EMULATION=y CONFIG_HAVE_PROC_CPU=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_TRACE_IRQFLAGS_SUPPORT=y CONFIG_RWSEM_XCHGADD_ALGORITHM=y CONFIG_ARCH_HAS_BANDGAP=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_NEED_DMA_MAP_STATE=y CONFIG_ARCH_SUPPORTS_UPROBES=y CONFIG_VECTORS_BASE=0x CONFIG_ARM_PATCH_PHYS_VIRT=y CONFIG_GENERIC_BUG=y CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" CONFIG_IRQ_WORK=y CONFIG_BUILDTIME_EXTABLE_SORT=y # # General setup # CONFIG_BROKEN_ON_SMP=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_CROSS_COMPILE="" # CONFIG_COMPILE_TEST is not set CONFIG_LOCALVERSION="" # CONFIG_LOCALVERSION_AUTO is not set CONFIG_HAVE_KERNEL_GZIP=y CONFIG_HAVE_KERNEL_LZMA=y CONFIG_HAVE_KERNEL_XZ=y CONFIG_HAVE_KERNEL_LZO=y CONFIG_HAVE_KERNEL_LZ4=y CONFIG_KERNEL_GZIP=y # CONFIG_KERNEL_LZMA is not set # CONFIG_KERNEL_XZ is not set # CONFIG_KERNEL_LZO is not set # CONFIG_KERNEL_LZ4 is not set CONFIG_DEFAULT_HOSTNAME="(none)" CONFIG_SWAP=y CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y CONFIG_POSIX_MQUEUE=y CONFIG_POSIX_MQUEUE_SYSCTL=y CONFIG_CROSS_MEMORY_ATTACH=y # CONFIG_FHANDLE is not set CONFIG_USELIB=y # CONFIG_AUDIT is not set CONFIG_HAVE_ARCH_AUDITSYSCALL=y # # IRQ subsystem # CONFIG_GENERIC_IRQ_PROBE=y CONFIG_GENERIC_IRQ_SHOW=y CONFIG_HARDIRQS_SW_RESEND=y CONFIG_GENERIC_IRQ_CHIP=y CONFIG_IRQ_DOMAIN=y CONFIG_HANDLE_DOMAIN_IRQ=y # CONFIG_IRQ_DOMAIN_DEBUG is not set CONFIG_IRQ_FORCED_THREADING=y CONFIG_SPARSE_IRQ=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BUILD=y # # Timers subsystem # CONFIG_TICK_ONESHOT=y CONFIG_NO_HZ_COMMON=y # CONFIG_HZ_PERIODIC is not set CONFIG_NO_HZ_IDLE=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y # # CPU/Task time and stats accounting # CONFIG_TICK_CPU_ACCOUNTING=y # CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set # CONFIG_IRQ_TIME_ACCOUNTING is not set CONFIG_BSD_PROCESS_ACCT=y # CONFIG_BSD_PROCESS_ACCT_V3 is not set CONFIG_TASKSTATS=y CONFIG_TASK_DELAY_ACCT=y CONFIG_TASK_XACCT=y CONFIG_TASK_IO_ACCOUNTING=y # # RCU Subsystem # CONFIG_PREEMPT_RCU=y # CONFIG_TASKS_RCU is not set CONFIG_RCU_STALL_COMMON=y CONFIG_RCU_FANOUT=32 CONFIG_RCU_FANOUT_LEAF=16 # CONFIG_RCU_FANOUT_EXACT is not set #
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tue 2015-02-03 13:18:59, Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > > f_phonet's ->set_alt() method will call usb_ep_disable() > > > > > potentially on an endpoint which is already disabled. > > > > > That's something the gadget/function driver must > > > > > guarantee that it's always balanced. > > > > > > > > > > In order to balance the calls, just make sure the endpoint > > > > > was enabled before by means of checking the validity of > > > > > driver_data. > > > > > > > > > > Reported-by: Pali Rohár > > > > > Signed-off-by: Felipe Balbi > > > > > --- > > > > > > > > Your patches cause that kernel does not print any error > > > > message to n900 screen anymore and reboot device in 10 > > > > seconds. I did not loaded any external modules. > > > > > > > In qemu I see this crash in early boot: > > > alright, so n900's working fine. I'll wait until you debug > > > qemu a little more, thank you > > > > NO! It does not working, see . It break n900 totally! > > settle down a bit more. I don't have the HW you have and things are > working fine on boards I _do_ have, there's not much more I can do to > help without you doing your homework. Debug a bit more and bring more > information as to what's going on, until then you're on your own. I'm not sure what you are smoking, but Pali is doing more then enough of his homework. No, it is not okay for you to break n900, and it is not okay for you to break qemu. In fact, you should do _your_ homework and install n900 qemu now. It is not Pali's homework to debug your stuff for you. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Tuesday 03 February 2015 20:57:11 Pali Rohár wrote: > On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: > > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > > > > Hi, > > > > > > > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár > > wrote: > > > > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi > > wrote: > > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > > usb_ep_disable() potentially on an endpoint > > > > > > > > which is already disabled. That's something the > > > > > > > > gadget/function driver must guarantee that it's > > > > > > > > always balanced. > > > > > > > > > > > > > > > > In order to balance the calls, just make sure > > > > > > > > the endpoint was enabled before by means of > > > > > > > > checking the validity of driver_data. > > > > > > > > > > > > > > > > Reported-by: Pali Rohár > > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > > --- > > > > > > > > > > > > > > Your patches cause that kernel does not print any > > > > > > > error message to n900 screen anymore and reboot > > > > > > > device in 10 seconds. I did not loaded any > > > > > > > external modules. > > > > > > > > > > > > > In qemu I see this crash in early boot: > > > > > > alright, so n900's working fine. I'll wait until you > > > > > > debug qemu a little more, thank you > > > > > > > > > > NO! It does not working, see . It break n900 > > > > > totally! > > > > > > > > settle down a bit more. I don't have the HW you have and > > > > things are working fine on boards I _do_ have, there's > > > > not much more I can do to help without you doing your > > > > homework. Debug a bit more and bring more information > > > > as to what's going on, until then you're on your own. > > > > > > And what more do you need? It crash on my n900 and also in > > > qemu. I sent you kernel crash dump from qemu which > > > introduced *your* patches. Before applying your patches > > > there was no crash in early boot stage. > > > > > > In current state I review all 3 patches as: > > > > > > Rejected-by: Pali Rohár > > > [It breaks booting Nokia N900 device] > > > > next step, figure why it's broken. Working just fine here on > > AM335x which has the same musb IP. > > Why is broken? That is easy. You send 3 patches which broke > it. Actually when I reverted only that patch which adds line: pm_runtime_irq_safe(musb->controller) then early boot crash disappeared. But other two patches did not fixed support for external .ko gadget modules. State is same -- crash after modprobe. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Thursday 05 February 2015 13:38:58 Pali Rohár wrote: > On Tuesday 03 February 2015 20:57:11 Pali Rohár wrote: > > On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: > > > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár > > wrote: > > > > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi > > wrote: > > > > > > > Hi, > > > > > > > > > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali > > > > > > > Rohár > > > > wrote: > > > > > > > > On Tuesday 03 February 2015 00:15:19 Felipe > > > > > > > > Balbi > > > > wrote: > > > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > > > usb_ep_disable() potentially on an endpoint > > > > > > > > > which is already disabled. That's something > > > > > > > > > the gadget/function driver must guarantee > > > > > > > > > that it's always balanced. > > > > > > > > > > > > > > > > > > In order to balance the calls, just make sure > > > > > > > > > the endpoint was enabled before by means of > > > > > > > > > checking the validity of driver_data. > > > > > > > > > > > > > > > > > > Reported-by: Pali Rohár > > > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > > > --- > > > > > > > > > > > > > > > > Your patches cause that kernel does not print > > > > > > > > any error message to n900 screen anymore and > > > > > > > > reboot device in 10 seconds. I did not loaded > > > > > > > > any external modules. > > > > > > > > > > > > > > > In qemu I see this crash in early boot: > > > > > > > alright, so n900's working fine. I'll wait until > > > > > > > you debug qemu a little more, thank you > > > > > > > > > > > > NO! It does not working, see . It break n900 > > > > > > totally! > > > > > > > > > > settle down a bit more. I don't have the HW you have > > > > > and things are working fine on boards I _do_ have, > > > > > there's not much more I can do to help without you > > > > > doing your homework. Debug a bit more and bring more > > > > > information as to what's going on, until then you're > > > > > on your own. > > > > > > > > And what more do you need? It crash on my n900 and also > > > > in qemu. I sent you kernel crash dump from qemu which > > > > introduced *your* patches. Before applying your patches > > > > there was no crash in early boot stage. > > > > > > > > In current state I review all 3 patches as: > > > > > > > > Rejected-by: Pali Rohár > > > > [It breaks booting Nokia N900 device] > > > > > > next step, figure why it's broken. Working just fine here > > > on AM335x which has the same musb IP. > > > > Why is broken? That is easy. You send 3 patches which broke > > it. > > Actually when I reverted only that patch which adds line: > > pm_runtime_irq_safe(musb->controller) > > then early boot crash disappeared. > > But other two patches did not fixed support for external .ko > gadget modules. State is same -- crash after modprobe. Here is crash from qemu when musb is compiled into kernel: [0.641662] Unable to handle kernel NULL pointer dereference at virtual address [0.642211] pgd = c0004000 [0.642425] [] *pgd= [0.642913] Internal error: Oops: 8005 [#1] PREEMPT ARM [0.643371] Modules linked in: [0.643737] CPU: 0 PID: 1 Comm: swapper Not tainted 3.19.0-rc5+ #329 [0.644195] Hardware name: Nokia RX-51 board [0.644531] task: cf8a8000 ti: cf8ac000 task.ti: cf8ac000 [0.644958] PC is at 0x0 [0.645263] LR is at omap2430_runtime_resume+0x80/0x100 [0.645660] pc : [<>]lr : []psr: 6113 [0.645660] sp : cf8adda0 ip : 0001 fp : c0059c64 [0.646423] r10: cf8adde8 r9 : cf9b5884 r8 : cf9b58cc [0.646789] r7 : 0004 r6 : cf93ee10 r5 : c06ac84c r4 : cf83a010 [0.647216] r3 : r2 : c0565716 r1 : 0414 r0 : fa0ab000 [0.647735] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel [0.648254] Control: 10c53c7d Table: 80004059 DAC: 0015 [0.648651] Process swapper (pid: 1, stack limit = 0xcf8ac238) [0.649078] Stack: (0xcf8adda0 to 0xcf8ae000) [0.649444] dda0: c0022428 cf9b5810 cf93ee10 c026bb44 0001 c026d3e0 cf9b5810 [0.650085] ddc0: c026d4a0 cf9b5810 cf9b5810 c026e9a4 c0441790 cfa29410 [0.650634] dde0: cfb33800 c0441790 cfa29410 cfa2b700 6113 cfa2b6c0 cfa29410 [0.651153] de00: c0660c80 006c c06210c4 c05de6d4 c026ee74 cfa2c180 cfa29410 [0.651702] de20: cfa2b6c0 c026eed4 cf83a010 c02c53f8 cfa29410 006c fa0ab000 ffed [0.652252] de40: cfa29410 c0660c80 c0660c80 c062cfe0 c06210c4 c05de6d4 c0267ad8 [0.652770] de60: cfa29410 c026624c cfa29410 c0660c80 c0660c80 [0.653320] de80: c0266478 cfa29410 cfa29444 c02664f0 c0660c80 cf8adea8 [0.653839] dea0: c0266490 c0264dd0 cf
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Fri, Feb 20, 2015 at 01:09:48AM +0100, Pali Rohár wrote: > On Thursday 05 February 2015 13:38:58 Pali Rohár wrote: > > On Tuesday 03 February 2015 20:57:11 Pali Rohár wrote: > > > On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: > > > > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > > > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár > > > > wrote: > > > > > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi > > > > wrote: > > > > > > > > Hi, > > > > > > > > > > > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali > > > > > > > > Rohár > > > > > > wrote: > > > > > > > > > On Tuesday 03 February 2015 00:15:19 Felipe > > > > > > > > > Balbi > > > > > > wrote: > > > > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > > > > usb_ep_disable() potentially on an endpoint > > > > > > > > > > which is already disabled. That's something > > > > > > > > > > the gadget/function driver must guarantee > > > > > > > > > > that it's always balanced. > > > > > > > > > > > > > > > > > > > > In order to balance the calls, just make sure > > > > > > > > > > the endpoint was enabled before by means of > > > > > > > > > > checking the validity of driver_data. > > > > > > > > > > > > > > > > > > > > Reported-by: Pali Rohár > > > > > > > > > > Signed-off-by: Felipe Balbi > > > > > > > > > > --- > > > > > > > > > > > > > > > > > > Your patches cause that kernel does not print > > > > > > > > > any error message to n900 screen anymore and > > > > > > > > > reboot device in 10 seconds. I did not loaded > > > > > > > > > any external modules. > > > > > > > > > > > > > > > > > In qemu I see this crash in early boot: > > > > > > > > alright, so n900's working fine. I'll wait until > > > > > > > > you debug qemu a little more, thank you > > > > > > > > > > > > > > NO! It does not working, see . It break n900 > > > > > > > totally! > > > > > > > > > > > > settle down a bit more. I don't have the HW you have > > > > > > and things are working fine on boards I _do_ have, > > > > > > there's not much more I can do to help without you > > > > > > doing your homework. Debug a bit more and bring more > > > > > > information as to what's going on, until then you're > > > > > > on your own. > > > > > > > > > > And what more do you need? It crash on my n900 and also > > > > > in qemu. I sent you kernel crash dump from qemu which > > > > > introduced *your* patches. Before applying your patches > > > > > there was no crash in early boot stage. > > > > > > > > > > In current state I review all 3 patches as: > > > > > > > > > > Rejected-by: Pali Rohár > > > > > [It breaks booting Nokia N900 device] > > > > > > > > next step, figure why it's broken. Working just fine here > > > > on AM335x which has the same musb IP. > > > > > > Why is broken? That is easy. You send 3 patches which broke > > > it. > > > > Actually when I reverted only that patch which adds line: > > > > pm_runtime_irq_safe(musb->controller) > > > > then early boot crash disappeared. > > > > But other two patches did not fixed support for external .ko > > gadget modules. State is same -- crash after modprobe. > > Here is crash from qemu when musb is compiled into kernel: > > [0.641662] Unable to handle kernel NULL pointer dereference at virtual > address > [0.642211] pgd = c0004000 > [0.642425] [] *pgd= > [0.642913] Internal error: Oops: 8005 [#1] PREEMPT ARM > [0.643371] Modules linked in: > [0.643737] CPU: 0 PID: 1 Comm: swapper Not tainted 3.19.0-rc5+ #329 > [0.644195] Hardware name: Nokia RX-51 board > [0.644531] task: cf8a8000 ti: cf8ac000 task.ti: cf8ac000 > [0.644958] PC is at 0x0 > [0.645263] LR is at omap2430_runtime_resume+0x80/0x100 > [0.645660] pc : [<>]lr : []psr: 6113 > [0.645660] sp : cf8adda0 ip : 0001 fp : c0059c64 > [0.646423] r10: cf8adde8 r9 : cf9b5884 r8 : cf9b58cc > [0.646789] r7 : 0004 r6 : cf93ee10 r5 : c06ac84c r4 : cf83a010 > [0.647216] r3 : r2 : c0565716 r1 : 0414 r0 : fa0ab000 > [0.647735] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment > kernel > [0.648254] Control: 10c53c7d Table: 80004059 DAC: 0015 > [0.648651] Process swapper (pid: 1, stack limit = 0xcf8ac238) > [0.649078] Stack: (0xcf8adda0 to 0xcf8ae000) > [0.649444] dda0: c0022428 cf9b5810 cf93ee10 c026bb44 0001 c026d3e0 > cf9b5810 > [0.650085] ddc0: c026d4a0 cf9b5810 cf9b5810 c026e9a4 > c0441790 cfa29410 > [0.650634] dde0: cfb33800 c0441790 cfa29410 cfa2b700 6113 > cfa2b6c0 cfa29410 > [0.651153] de00: c0660c80 006c c06210c4 c05de6d4 c026ee74 > cfa2c180 cfa29410 > [0.651702] de20: cfa2b6c0 c026eed4 cf83a010 c02c53f8 cfa29410 006c > fa0ab000 ffed > [0.652252] de40: cfa29410 c0660c8
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
> > > > > > In current state I review all 3 patches as: > > > > > > > > > > > > Rejected-by: Pali Rohár > > > > > > [It breaks booting Nokia N900 device] > > > > > > > > > > next step, figure why it's broken. Working just fine here > > > > > on AM335x which has the same musb IP. > > > > > > > > Why is broken? That is easy. You send 3 patches which broke > > > > it. > > > > > > Actually when I reverted only that patch which adds line: > > > > > > pm_runtime_irq_safe(musb->controller) > > > > > > then early boot crash disappeared. > > > > > > But other two patches did not fixed support for external .ko > > > gadget modules. State is same -- crash after modprobe. > > > > Here is crash from qemu when musb is compiled into kernel: > > > > [0.641662] Unable to handle kernel NULL pointer dereference at virtual > > address > > [0.642211] pgd = c0004000 ... > > [0.672882] ---[ end Kernel panic - not syncing: Attempted to kill init! > > exitcode=0x000b > > [0.672882] > > > > Reason why it crashes is because when function > > omap2430_runtime_resume() is called pointer to functions > > musb_readl and musb_writel are both NULL. And so NULL pointer > > dereference. > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=1861a2c60351a390272b3395f4d88480cdfd9e58 > So you commit a fix to your internal branch without telling Pali, who is actively debugging same problem at the same time, and then you just send him url without at least saying "sorry"? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: > > > > > > > In current state I review all 3 patches as: > > > > > > > > > > > > > > Rejected-by: Pali Rohár > > > > > > > [It breaks booting Nokia N900 device] > > > > > > > > > > > > next step, figure why it's broken. Working just fine here > > > > > > on AM335x which has the same musb IP. > > > > > > > > > > Why is broken? That is easy. You send 3 patches which broke > > > > > it. > > > > > > > > Actually when I reverted only that patch which adds line: > > > > > > > > pm_runtime_irq_safe(musb->controller) > > > > > > > > then early boot crash disappeared. > > > > > > > > But other two patches did not fixed support for external .ko > > > > gadget modules. State is same -- crash after modprobe. > > > > > > Here is crash from qemu when musb is compiled into kernel: > > > > > > [0.641662] Unable to handle kernel NULL pointer dereference at > > > virtual address > > > [0.642211] pgd = c0004000 > ... > > > [0.672882] ---[ end Kernel panic - not syncing: Attempted to kill > > > init! exitcode=0x000b > > > [0.672882] > > > > > > Reason why it crashes is because when function > > > omap2430_runtime_resume() is called pointer to functions > > > musb_readl and musb_writel are both NULL. And so NULL pointer > > > dereference. > > > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=1861a2c60351a390272b3395f4d88480cdfd9e58 > > > > So you commit a fix to your internal branch without telling Pali, who > is actively debugging same problem at the same time, and then you just > send him url without at least saying "sorry"? grow up... why do I have to say sorry for fixing a problem ? Why do I have to let you know I committed something to my branch ? It's the middle of the merge window, nothing will happen until -rc1 is out, at which point I'll send this to the mailing list before sending a pull request to Greg. -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: > On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: > > > > > > > > In current state I review all 3 patches as: > > > > > > > > > > > > > > > > Rejected-by: Pali Rohár > > > > > > > > [It breaks booting Nokia N900 device] > > > > > > > > > > > > > > next step, figure why it's broken. Working just fine here > > > > > > > on AM335x which has the same musb IP. > > > > > > > > > > > > Why is broken? That is easy. You send 3 patches which broke > > > > > > it. > > > > > > > > > > Actually when I reverted only that patch which adds line: > > > > > > > > > > pm_runtime_irq_safe(musb->controller) > > > > > > > > > > then early boot crash disappeared. > > > > > > > > > > But other two patches did not fixed support for external .ko > > > > > gadget modules. State is same -- crash after modprobe. > > > > > > > > Here is crash from qemu when musb is compiled into kernel: > > > > > > > > [0.641662] Unable to handle kernel NULL pointer dereference at > > > > virtual address > > > > [0.642211] pgd = c0004000 > > ... > > > > [0.672882] ---[ end Kernel panic - not syncing: Attempted to kill > > > > init! exitcode=0x000b > > > > [0.672882] > > > > > > > > Reason why it crashes is because when function > > > > omap2430_runtime_resume() is called pointer to functions > > > > musb_readl and musb_writel are both NULL. And so NULL pointer > > > > dereference. > > > > > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=1861a2c60351a390272b3395f4d88480cdfd9e58 > > > > > > > So you commit a fix to your internal branch without telling Pali, who > > is actively debugging same problem at the same time, and then you just > > send him url without at least saying "sorry"? > > grow up... why do I have to say sorry for fixing a problem ? Why do I > have to let you know I committed something to my branch ? It's the Because that's polite thing to do when you break someone elses system? I see politeness is not your great strength. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
Hi, On Fri, Feb 20, 2015 at 10:15:52PM +0100, Pavel Machek wrote: > On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: > > On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: > > > > > > > > > In current state I review all 3 patches as: > > > > > > > > > > > > > > > > > > Rejected-by: Pali Rohár > > > > > > > > > [It breaks booting Nokia N900 device] > > > > > > > > > > > > > > > > next step, figure why it's broken. Working just fine here > > > > > > > > on AM335x which has the same musb IP. > > > > > > > > > > > > > > Why is broken? That is easy. You send 3 patches which broke > > > > > > > it. > > > > > > > > > > > > Actually when I reverted only that patch which adds line: > > > > > > > > > > > > pm_runtime_irq_safe(musb->controller) > > > > > > > > > > > > then early boot crash disappeared. > > > > > > > > > > > > But other two patches did not fixed support for external .ko > > > > > > gadget modules. State is same -- crash after modprobe. > > > > > > > > > > Here is crash from qemu when musb is compiled into kernel: > > > > > > > > > > [0.641662] Unable to handle kernel NULL pointer dereference at > > > > > virtual address > > > > > [0.642211] pgd = c0004000 > > > ... > > > > > [0.672882] ---[ end Kernel panic - not syncing: Attempted to kill > > > > > init! exitcode=0x000b > > > > > [0.672882] > > > > > > > > > > Reason why it crashes is because when function > > > > > omap2430_runtime_resume() is called pointer to functions > > > > > musb_readl and musb_writel are both NULL. And so NULL pointer > > > > > dereference. > > > > > > > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=1861a2c60351a390272b3395f4d88480cdfd9e58 > > > > > > > > > > So you commit a fix to your internal branch without telling Pali, who > > > is actively debugging same problem at the same time, and then you just > > > send him url without at least saying "sorry"? > > > > grow up... why do I have to say sorry for fixing a problem ? Why do I > > have to let you know I committed something to my branch ? It's the > > Because that's polite thing to do when you break someone elses system? when did I break anything from you ? I sent you a patch to test which you tested and reported it didn't work and the patch was removed from my queue because of that. After that you completely refused to do any work/debug related to an itch only *you* had to start with. Seen as you just don't care to help yourself, why should I ? You're 100% capable of debugging the problems you reported which I ended up debugging even without having any HW which reproduced the failured. Not to mention that since the beginning *you* have been the unpolite one, completely reluctant to test anything or find logs because, aparently, that's a waste of your o-so-valuable time. So no, you DO NOT deserve any politeness. When you change your attitude and start scratching your own itches, then we can talk about politeness; until then, get used to a similarly aggressive attitude towards you. -- balbi signature.asc Description: Digital signature
Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls
On Sat, Feb 21, 2015 at 01:14:00AM -0600, Felipe Balbi wrote: > Hi, > > On Fri, Feb 20, 2015 at 10:15:52PM +0100, Pavel Machek wrote: > > On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: > > > On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: > > > > > > > > > > In current state I review all 3 patches as: > > > > > > > > > > > > > > > > > > > > Rejected-by: Pali Rohár > > > > > > > > > > [It breaks booting Nokia N900 device] > > > > > > > > > > > > > > > > > > next step, figure why it's broken. Working just fine here > > > > > > > > > on AM335x which has the same musb IP. > > > > > > > > > > > > > > > > Why is broken? That is easy. You send 3 patches which broke > > > > > > > > it. > > > > > > > > > > > > > > Actually when I reverted only that patch which adds line: > > > > > > > > > > > > > > pm_runtime_irq_safe(musb->controller) > > > > > > > > > > > > > > then early boot crash disappeared. > > > > > > > > > > > > > > But other two patches did not fixed support for external .ko > > > > > > > gadget modules. State is same -- crash after modprobe. > > > > > > > > > > > > Here is crash from qemu when musb is compiled into kernel: > > > > > > > > > > > > [0.641662] Unable to handle kernel NULL pointer dereference at > > > > > > virtual address > > > > > > [0.642211] pgd = c0004000 > > > > ... > > > > > > [0.672882] ---[ end Kernel panic - not syncing: Attempted to > > > > > > kill init! exitcode=0x000b > > > > > > [0.672882] > > > > > > > > > > > > Reason why it crashes is because when function > > > > > > omap2430_runtime_resume() is called pointer to functions > > > > > > musb_readl and musb_writel are both NULL. And so NULL pointer > > > > > > dereference. > > > > > > > > > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=1861a2c60351a390272b3395f4d88480cdfd9e58 > > > > > > > > > > > > > So you commit a fix to your internal branch without telling Pali, who > > > > is actively debugging same problem at the same time, and then you just > > > > send him url without at least saying "sorry"? > > > > > > grow up... why do I have to say sorry for fixing a problem ? Why do I > > > have to let you know I committed something to my branch ? It's the > > > > Because that's polite thing to do when you break someone elses system? > > when did I break anything from you ? I sent you a patch to test which > you tested and reported it didn't work and the patch was removed from my > queue because of that. After that you completely refused to do any > work/debug related to an itch only *you* had to start with. > > Seen as you just don't care to help yourself, why should I ? > > You're 100% capable of debugging the problems you reported which I ended > up debugging even without having any HW which reproduced the failured. > > Not to mention that since the beginning *you* have been the unpolite > one, completely reluctant to test anything or find logs because, > aparently, that's a waste of your o-so-valuable time. > > So no, you DO NOT deserve any politeness. When you change your attitude > and start scratching your own itches, then we can talk about politeness; > until then, get used to a similarly aggressive attitude towards you. not to mention that you (actually Pali) even reported the crash on a completely unrelated patch. That phonet patch is still correct, and could have been merged during v3.20 merge window. -- balbi signature.asc Description: Digital signature
