Re: [PATCH 1/4] usb: musb: add helper function musb_ep_xfertype_string

[Bin Liu]

On Tue, Jul 18, 2017 at 07:33:07PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 07/18/2017 06:13 PM, Bin Liu wrote:
> 
> >Add helper function musb_ep_xfertype_string() to return the ep transfer
> >type string.
> >
> >Signed-off-by: Bin Liu 
> 
>Doesn't this belong to USB core? What's MUSB specific about it?

This was my first thought, because many drivers do this conversion
without using a helper function. But everyone returns different spelling
of the string (for example, for the Control type, the return is any of
"Control", "CONTROL", "control", "ctrl", and "CTL"), I am not sure how
to unify it without breaking backward compatibility.

Regards,
-Bin.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] usb: musb: add helper function musb_ep_xfertype_string

[Sergei Shtylyov]

Hello!

On 07/18/2017 06:13 PM, Bin Liu wrote:


Add helper function musb_ep_xfertype_string() to return the ep transfer
type string.

Signed-off-by: Bin Liu 


   Doesn't this belong to USB core? What's MUSB specific about it?


---
 drivers/usb/musb/musb_core.h   | 24 
 drivers/usb/musb/musb_gadget.c |  6 +-
 2 files changed, 25 insertions(+), 5 deletions(-)


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html