Re: [PATCH 13/14] usb: dwc2: host: fix descriptor list address masking
On Mon, Oct 12, 2015 at 03:06:32PM +0800, kbuild test robot wrote:
> Hi Mian,
>
> [auto build test WARNING on balbi-usb/next -- if it's inappropriate base,
> please suggest rules for selecting the more suitable base]
>
> config: i386-randconfig-x002-201541 (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All warnings (new ones prefixed by >>):
>
>In file included from include/linux/dma-mapping.h:5:0,
> from drivers/usb/dwc2/core.c:47:
>drivers/usb/dwc2/core.c: In function 'dwc2_hc_start_transfer_ddma':
>drivers/usb/dwc2/core.c:1949:24: warning: format '%x' expects argument of
> type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long
> unsigned int}' [-Wformat=]
> dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
>^
>include/linux/device.h:1175:30: note: in definition of macro 'dev_dbg'
> dev_printk(KERN_DEBUG, dev, format, ##arg)
> ^
> >> drivers/usb/dwc2/core.c:1949:3: note: in expansion of macro 'dev_vdbg'
> dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
> ^
I will fix it with following patch when I will resend:
- dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
-chan->desc_list_addr, chan->hc_num);
+ dev_vdbg(hsotg->dev, "Wrote %pad to HCDMA(%d)\n",
+&chan->desc_list_addr, chan->hc_num);
>
> vim +/dev_vdbg +1949 drivers/usb/dwc2/core.c
>
> b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 1933
> }
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1934
> 95c8bc36 drivers/usb/dwc2/core.c Antti Seppälä 2015-08-20 1935
> dwc2_writel(hctsiz, hsotg->regs + HCTSIZ(chan->hc_num));
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1936
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1937
> /* Sync frame list only for periodics channels */
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1938
> if (chan->ep_type == USB_ENDPOINT_XFER_ISOC ||
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1939
> chan->ep_type == USB_ENDPOINT_XFER_INT)
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1940
> dma_sync_single_for_device(hsotg->dev, hsotg->frame_list_dma,
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1941
>hsotg->frame_list_sz, DMA_TO_DEVICE);
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1942
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1943
> dma_sync_single_for_device(hsotg->dev, chan->desc_list_addr,
> 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1944
>chan->desc_list_sz, DMA_TO_DEVICE);
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1945
> 5f02f76d drivers/usb/dwc2/core.c Mian Yousaf Kaukab 2015-10-12 1946
> dwc2_writel(chan->desc_list_addr, hsotg->regs + HCDMA(chan->hc_num));
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1947
> b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 1948
> if (dbg_hc(chan))
> b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 @1949
> dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
> 5f02f76d drivers/usb/dwc2/core.c Mian Yousaf Kaukab 2015-10-12 1950
> chan->desc_list_addr, chan->hc_num);
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1951
> 95c8bc36 drivers/usb/dwc2/core.c Antti Seppälä 2015-08-20 1952
> hcchar = dwc2_readl(hsotg->regs + HCCHAR(chan->hc_num));
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1953
> hcchar &= ~HCCHAR_MULTICNT_MASK;
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1954
> hcchar |= chan->multi_count << HCCHAR_MULTICNT_SHIFT &
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1955
> HCCHAR_MULTICNT_MASK;
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1956
> 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1957
> if (hcchar & HCCHAR_CHDIS)
>
> :: The code at line 1949 was first introduced by commit
> :: b49977a60dff529c1242f2d427774ea55885bc0b staging: dwc2: toggle
> periodic debugging output separately
>
> :: TO: Matthijs Kooijman
> :: CC: Greg Kroah-Hartman
>
> ---
> 0-DAY kernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.
Re: [PATCH 13/14] usb: dwc2: host: fix descriptor list address masking
Hi Mian, [auto build test WARNING on balbi-usb/next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] config: tile-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=tile All warnings (new ones prefixed by >>): drivers/usb/dwc2/core.c: In function 'dwc2_hc_start_transfer_ddma': >> drivers/usb/dwc2/core.c:1949:3: warning: format '%x' expects argument of >> type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat] vim +1949 drivers/usb/dwc2/core.c b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 1933 } 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1934 95c8bc36 drivers/usb/dwc2/core.c Antti Seppälä 2015-08-20 1935 dwc2_writel(hctsiz, hsotg->regs + HCTSIZ(chan->hc_num)); 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1936 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1937 /* Sync frame list only for periodics channels */ 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1938 if (chan->ep_type == USB_ENDPOINT_XFER_ISOC || 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1939 chan->ep_type == USB_ENDPOINT_XFER_INT) 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1940 dma_sync_single_for_device(hsotg->dev, hsotg->frame_list_dma, 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1941 hsotg->frame_list_sz, DMA_TO_DEVICE); 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1942 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1943 dma_sync_single_for_device(hsotg->dev, chan->desc_list_addr, 3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1944 chan->desc_list_sz, DMA_TO_DEVICE); 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1945 5f02f76d drivers/usb/dwc2/core.c Mian Yousaf Kaukab 2015-10-12 1946 dwc2_writel(chan->desc_list_addr, hsotg->regs + HCDMA(chan->hc_num)); 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1947 b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 1948 if (dbg_hc(chan)) b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 @1949 dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n", 5f02f76d drivers/usb/dwc2/core.c Mian Yousaf Kaukab 2015-10-12 1950 chan->desc_list_addr, chan->hc_num); 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1951 95c8bc36 drivers/usb/dwc2/core.c Antti Seppälä 2015-08-20 1952 hcchar = dwc2_readl(hsotg->regs + HCCHAR(chan->hc_num)); 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1953 hcchar &= ~HCCHAR_MULTICNT_MASK; 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1954 hcchar |= chan->multi_count << HCCHAR_MULTICNT_SHIFT & 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1955 HCCHAR_MULTICNT_MASK; 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1956 56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1957 if (hcchar & HCCHAR_CHDIS) :: The code at line 1949 was first introduced by commit :: b49977a60dff529c1242f2d427774ea55885bc0b staging: dwc2: toggle periodic debugging output separately :: TO: Matthijs Kooijman :: CC: Greg Kroah-Hartman --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
Re: [PATCH 13/14] usb: dwc2: host: fix descriptor list address masking
Hi Mian,
[auto build test WARNING on balbi-usb/next -- if it's inappropriate base,
please suggest rules for selecting the more suitable base]
config: x86_64-randconfig-x013-201541 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/linux/dma-mapping.h:5:0,
from drivers/usb/dwc2/core.c:47:
drivers/usb/dwc2/core.c: In function 'dwc2_hc_start_transfer_ddma':
>> drivers/usb/dwc2/core.c:1949:24: warning: format '%x' expects argument of
>> type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long
>> unsigned int}' [-Wformat=]
dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
^
include/linux/device.h:1275:31: note: in definition of macro 'dev_vdbg'
dev_printk(KERN_DEBUG, dev, format, ##arg); \
^
vim +1949 drivers/usb/dwc2/core.c
b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 1933
}
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1934
95c8bc36 drivers/usb/dwc2/core.c Antti Seppälä 2015-08-20 1935
dwc2_writel(hctsiz, hsotg->regs + HCTSIZ(chan->hc_num));
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1936
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1937
/* Sync frame list only for periodics channels */
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1938
if (chan->ep_type == USB_ENDPOINT_XFER_ISOC ||
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1939
chan->ep_type == USB_ENDPOINT_XFER_INT)
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1940
dma_sync_single_for_device(hsotg->dev, hsotg->frame_list_dma,
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1941
hsotg->frame_list_sz, DMA_TO_DEVICE);
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1942
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1943
dma_sync_single_for_device(hsotg->dev, chan->desc_list_addr,
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1944
chan->desc_list_sz, DMA_TO_DEVICE);
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1945
5f02f76d drivers/usb/dwc2/core.c Mian Yousaf Kaukab 2015-10-12 1946
dwc2_writel(chan->desc_list_addr, hsotg->regs + HCDMA(chan->hc_num));
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1947
b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 1948
if (dbg_hc(chan))
b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 @1949
dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
5f02f76d drivers/usb/dwc2/core.c Mian Yousaf Kaukab 2015-10-12 1950
chan->desc_list_addr, chan->hc_num);
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1951
95c8bc36 drivers/usb/dwc2/core.c Antti Seppälä 2015-08-20 1952
hcchar = dwc2_readl(hsotg->regs + HCCHAR(chan->hc_num));
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1953
hcchar &= ~HCCHAR_MULTICNT_MASK;
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1954
hcchar |= chan->multi_count << HCCHAR_MULTICNT_SHIFT &
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1955
HCCHAR_MULTICNT_MASK;
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1956
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1957
if (hcchar & HCCHAR_CHDIS)
:: The code at line 1949 was first introduced by commit
:: b49977a60dff529c1242f2d427774ea55885bc0b staging: dwc2: toggle periodic
debugging output separately
:: TO: Matthijs Kooijman
:: CC: Greg Kroah-Hartman
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: Binary data
Re: [PATCH 13/14] usb: dwc2: host: fix descriptor list address masking
Hi Mian,
[auto build test WARNING on balbi-usb/next -- if it's inappropriate base,
please suggest rules for selecting the more suitable base]
config: i386-randconfig-x002-201541 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from include/linux/dma-mapping.h:5:0,
from drivers/usb/dwc2/core.c:47:
drivers/usb/dwc2/core.c: In function 'dwc2_hc_start_transfer_ddma':
drivers/usb/dwc2/core.c:1949:24: warning: format '%x' expects argument of
type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long
unsigned int}' [-Wformat=]
dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
^
include/linux/device.h:1175:30: note: in definition of macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, format, ##arg)
^
>> drivers/usb/dwc2/core.c:1949:3: note: in expansion of macro 'dev_vdbg'
dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
^
vim +/dev_vdbg +1949 drivers/usb/dwc2/core.c
b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 1933
}
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1934
95c8bc36 drivers/usb/dwc2/core.c Antti Seppälä 2015-08-20 1935
dwc2_writel(hctsiz, hsotg->regs + HCTSIZ(chan->hc_num));
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1936
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1937
/* Sync frame list only for periodics channels */
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1938
if (chan->ep_type == USB_ENDPOINT_XFER_ISOC ||
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1939
chan->ep_type == USB_ENDPOINT_XFER_INT)
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1940
dma_sync_single_for_device(hsotg->dev, hsotg->frame_list_dma,
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1941
hsotg->frame_list_sz, DMA_TO_DEVICE);
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1942
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1943
dma_sync_single_for_device(hsotg->dev, chan->desc_list_addr,
3c55d5e2 drivers/usb/dwc2/core.c Gregory Herrero2015-10-12 1944
chan->desc_list_sz, DMA_TO_DEVICE);
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1945
5f02f76d drivers/usb/dwc2/core.c Mian Yousaf Kaukab 2015-10-12 1946
dwc2_writel(chan->desc_list_addr, hsotg->regs + HCDMA(chan->hc_num));
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1947
b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 1948
if (dbg_hc(chan))
b49977a6 drivers/staging/dwc2/core.c Matthijs Kooijman 2013-04-10 @1949
dev_vdbg(hsotg->dev, "Wrote %08x to HCDMA(%d)\n",
5f02f76d drivers/usb/dwc2/core.c Mian Yousaf Kaukab 2015-10-12 1950
chan->desc_list_addr, chan->hc_num);
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1951
95c8bc36 drivers/usb/dwc2/core.c Antti Seppälä 2015-08-20 1952
hcchar = dwc2_readl(hsotg->regs + HCCHAR(chan->hc_num));
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1953
hcchar &= ~HCCHAR_MULTICNT_MASK;
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1954
hcchar |= chan->multi_count << HCCHAR_MULTICNT_SHIFT &
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1955
HCCHAR_MULTICNT_MASK;
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1956
56f5b1cf drivers/staging/dwc2/core.c Paul Zimmerman 2013-03-11 1957
if (hcchar & HCCHAR_CHDIS)
:: The code at line 1949 was first introduced by commit
:: b49977a60dff529c1242f2d427774ea55885bc0b staging: dwc2: toggle periodic
debugging output separately
:: TO: Matthijs Kooijman
:: CC: Greg Kroah-Hartman
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: Binary data
