Re: [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-23 Thread Alistair Popple 
On Fri, 21 Feb 2014 15:16:52 Arnd Bergmann wrote:
 On Friday 21 February 2014 17:31:29 Alistair Popple wrote:
  +static const struct of_device_id ohci_of_match[] = {
  +   { .compatible = usb-ohci, },
  +   {},
  +};
  +
  
   static const struct platform_device_id ohci_platform_table[] = {
   
  { ohci-platform, 0 },
  { }
  
  @@ -198,6 +209,7 @@ static struct platform_driver ohci_platform_driver = {
  
  .owner  = THIS_MODULE,
  .name   = ohci-platform,
  .pm = ohci_platform_pm_ops,
  
  +   .of_match_table = ohci_of_match,
  
  }
   
   };
 
 Linux-next already has a patch to add an of_match_table in this driver,
 using
 
 static const struct of_device_id ohci_platform_ids[] = {
 { .compatible = generic-ohci, },
 { }
 };
 
 I think you should just use that string on your platform.

Excellent! I will drop this patch and use generic-ohci instead. Thanks for 
pointing this out.

- Alistair

   Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-21 Thread Arnd Bergmann 
On Friday 21 February 2014 17:31:29 Alistair Popple wrote:
 
 +static const struct of_device_id ohci_of_match[] = {
 +   { .compatible = usb-ohci, },
 +   {},
 +};
 +
  static const struct platform_device_id ohci_platform_table[] = {
 { ohci-platform, 0 },
 { }
 @@ -198,6 +209,7 @@ static struct platform_driver ohci_platform_driver = {
 .owner  = THIS_MODULE,
 .name   = ohci-platform,
 .pm = ohci_platform_pm_ops,
 +   .of_match_table = ohci_of_match,
 }
  };
  
 

Linux-next already has a patch to add an of_match_table in this driver,
using 

static const struct of_device_id ohci_platform_ids[] = {
{ .compatible = generic-ohci, },
{ }
};

I think you should just use that string on your platform.

Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-21 Thread Alan Stern 
On Fri, 21 Feb 2014, Alistair Popple wrote:

 The IBM Akebono board uses the PPC476GTR SoC which has a OHCI
 compliant USB host interface. This patch adds support for it to the
 OHCI platform driver.
 
 As we use device tree to pass platform specific data instead of
 platform data we remove the check for platform data and instead
 provide reasonable defaults if no platform data is present. This is
 similar to what is currently done in ehci-platform.c.
 
 Signed-off-by: Alistair Popple alist...@popple.id.au
 Acked-by: Alan Stern st...@rowland.harvard.edu

As Arnd pointed out, this patch is out of date.  See

https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/ohci-platform.c?h=usb-nextid=ca52a17ba975dbf47e87c9bc63086aca0cf92806

and

https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/ohci-platform.c?h=usb-nextid=ce149c30b9f89d0c9addd1d71ccdb57c1051553b

Alan Stern

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html