Re: [PATCH 4/9] usb: add device descriptor for usb 3.1 root hub

2015-12-09 Thread Sergei Shtylyov 

Hello.

On 12/09/2015 09:22 PM, Mathias Nyman wrote:


Signed-off-by: Mathias Nyman 
---
  drivers/usb/core/hcd.c | 23 +++
  1 file changed, 23 insertions(+)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index ff3073d..fb0a9c2 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -128,6 +128,27 @@ static inline int is_root_hub(struct usb_device *udev)
  #define KERNEL_RELbin2bcd(((LINUX_VERSION_CODE >> 16) & 0x0ff))
  #define KERNEL_VERbin2bcd(((LINUX_VERSION_CODE >> 8) & 0x0ff))

+/* usb 3.1 root hub device descriptor */
+static const u8 usb31_rh_dev_descriptor[18] = {
+   0x12,   /*  __u8  bLength; */
+   0x01,   /*  __u8  bDescriptorType; Device */


   Please use USB_DT_DEVICE here as is now done in all the other such places 
in this file.


[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/9] usb: add device descriptor for usb 3.1 root hub

2015-12-09 Thread Mathias Nyman 

On 09.12.2015 20:35, Sergei Shtylyov wrote:

Hello.

On 12/09/2015 09:22 PM, Mathias Nyman wrote:


Signed-off-by: Mathias Nyman 
---
  drivers/usb/core/hcd.c | 23 +++
  1 file changed, 23 insertions(+)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index ff3073d..fb0a9c2 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -128,6 +128,27 @@ static inline int is_root_hub(struct usb_device *udev)
  #define KERNEL_RELbin2bcd(((LINUX_VERSION_CODE >> 16) & 0x0ff))
  #define KERNEL_VERbin2bcd(((LINUX_VERSION_CODE >> 8) & 0x0ff))

+/* usb 3.1 root hub device descriptor */
+static const u8 usb31_rh_dev_descriptor[18] = {
+0x12,   /*  __u8  bLength; */
+0x01,   /*  __u8  bDescriptorType; Device */


Please use USB_DT_DEVICE here as is now done in all the other such places 
in this file.

[...]

MBR, Sergei



Sure, will resend

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html