Re: [PATCH v2] HID: add support for Sony RF receiver with USB product id 0x0374
Hi Jiri, On Tue, 2013-01-15 at 17:02 +0100, Jiri Kosina wrote: On Tue, 15 Jan 2013, Fernando Luis Vázquez Cao wrote: Some Vaio desktop computers, among them the VGC-LN51JGB multimedia PC, have a RF receiver, multi-interface USB device 054c:0374, that is used to connect a wireless keyboard and a wireless mouse. The keyboard works flawlessly, but the mouse (VGP-WMS3 in my case) does not seem to be generating any pointer events. The problem is that the mouse pointer is wrongly declared as a constant non-data variable in the report descriptor (see lsusb and usbhid-dump output below), with the consequence that it is ignored by the HID code. Add this device to the have-special-driver list and fix up the report descriptor in the Sony-specific driver which happens to already have a fixup for a similar firmware bug. Applied, thanks. It looks like after the merge of the the sony and steelseries branches the hid core hunk was left out, which means that this fix-up is never applied. I will be replying to this email with a fix. Thanks, Fernando -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] HID: add support for Sony RF receiver with USB product id 0x0374
On Tue, 22 Jan 2013, Fernando Luis Vazquez Cao wrote: If possible, I would like to get it backported to 3.7-stable (and possibly 3.2 stable), since without it a whole family of Sony desktop computers is unusable under Linux out of the box. Should I do it myself or do you have a process in place for HID stable patches? If the patch had Cc: sta...@vger.kernel.org in it, it'd be picked for -stable queue automatically. I considered doing that but I thought and upstream commit ID was needed. Yes, that's necessary in case you are cherry-picking a commit already present in Linus' tree that doesn't have explicit Cc: sta...@vger.kernel.org. Otherwise, -stable tree maintainer is automatically picking up commits that appear in Linus tree with this tag. Otherwise, anyone is free to take it once it's in Linus' tree and sent to to sta...@vger.kernel.org for inclusion. So it is the standard procedure. I just wanted to make sure whether you wanted to have all the -stable patches funnelled through you. It's not strictly necessary. I get copied on them when they are queued in -stable queue anyway. By the way, I will be replying to this email with a follow-up patch that I forgot to send the last time around. It is just documentation for the quirk. Ok, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] HID: add support for Sony RF receiver with USB product id 0x0374
On Wed, 2013-01-16 at 11:44 +0100, Jiri Kosina wrote: On Wed, 16 Jan 2013, Fernando Luis Vazquez Cao wrote: I noticed that the patch was tagged for-3.9. Does this mean that it is too late to get it merged during the current release cycle? I currently don't have anything queued for 3.8, and this particular patch doesn't justify a separate pull request. Once it's in Linus' tree, it can be easily pushed out to all existing -stable branches (including 3.8-stable, once it's created). If I am gfoing to be sending pull request for 3.8 to Linus still due to some important bugfix, I will be including this. Ok, thank you for the explanation. I really appreciate it. If possible, I would like to get it backported to 3.7-stable (and possibly 3.2 stable), since without it a whole family of Sony desktop computers is unusable under Linux out of the box. Should I do it myself or do you have a process in place for HID stable patches? If the patch had Cc: sta...@vger.kernel.org in it, it'd be picked for -stable queue automatically. I considered doing that but I thought and upstream commit ID was needed. Otherwise, anyone is free to take it once it's in Linus' tree and sent to to sta...@vger.kernel.org for inclusion. So it is the standard procedure. I just wanted to make sure whether you wanted to have all the -stable patches funnelled through you. I will send the patch to -stable directly and Cc you as soon as it makes it into Linus' tree. By the way, I will be replying to this email with a follow-up patch that I forgot to send the last time around. It is just documentation for the quirk. Thanks, Fernando -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] HID: add support for Sony RF receiver with USB product id 0x0374
On Wed, 16 Jan 2013, Fernando Luis Vazquez Cao wrote: I noticed that the patch was tagged for-3.9. Does this mean that it is too late to get it merged during the current release cycle? I currently don't have anything queued for 3.8, and this particular patch doesn't justify a separate pull request. Once it's in Linus' tree, it can be easily pushed out to all existing -stable branches (including 3.8-stable, once it's created). If I am gfoing to be sending pull request for 3.8 to Linus still due to some important bugfix, I will be including this. If possible, I would like to get it backported to 3.7-stable (and possibly 3.2 stable), since without it a whole family of Sony desktop computers is unusable under Linux out of the box. Should I do it myself or do you have a process in place for HID stable patches? If the patch had Cc: sta...@vger.kernel.org in it, it'd be picked for -stable queue automatically. Otherwise, anyone is free to take it once it's in Linus' tree and sent to to sta...@vger.kernel.org for inclusion. Hope this helps, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] HID: add support for Sony RF receiver with USB product id 0x0374
On Tue, 15 Jan 2013, Fernando Luis Vázquez Cao wrote: Some Vaio desktop computers, among them the VGC-LN51JGB multimedia PC, have a RF receiver, multi-interface USB device 054c:0374, that is used to connect a wireless keyboard and a wireless mouse. The keyboard works flawlessly, but the mouse (VGP-WMS3 in my case) does not seem to be generating any pointer events. The problem is that the mouse pointer is wrongly declared as a constant non-data variable in the report descriptor (see lsusb and usbhid-dump output below), with the consequence that it is ignored by the HID code. Add this device to the have-special-driver list and fix up the report descriptor in the Sony-specific driver which happens to already have a fixup for a similar firmware bug. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] HID: add support for Sony RF receiver with USB product id 0x0374
Hi Jiri, On 2013/01/16 01:02, Jiri Kosina wrote: On Tue, 15 Jan 2013, Fernando Luis Vázquez Cao wrote: Some Vaio desktop computers, among them the VGC-LN51JGB multimedia PC, have a RF receiver, multi-interface USB device 054c:0374, that is used to connect a wireless keyboard and a wireless mouse. The keyboard works flawlessly, but the mouse (VGP-WMS3 in my case) does not seem to be generating any pointer events. The problem is that the mouse pointer is wrongly declared as a constant non-data variable in the report descriptor (see lsusb and usbhid-dump output below), with the consequence that it is ignored by the HID code. Add this device to the have-special-driver list and fix up the report descriptor in the Sony-specific driver which happens to already have a fixup for a similar firmware bug. Applied, thanks. Thank you. I noticed that the patch was tagged for-3.9. Does this mean that it is too late to get it merged during the current release cycle? If possible, I would like to get it backported to 3.7-stable (and possibly 3.2 stable), since without it a whole family of Sony desktop computers is unusable under Linux out of the box. Should I do it myself or do you have a process in place for HID stable patches? Regards, Fernando -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
