Re: [PATCH v3 7/7] USB: OHCI: avoid conflicting platform drivers
On Sat, 30 Mar 2013, Arnd Bergmann wrote: > > I guess this means the onus is now on me to split up ohci-hcd into a > > central library and separate bus drivers, like ehci-hcd... > > The original plan in my teams was that Manjunath would do that after > he was done with the simple conversion of the EHCI drivers. I think we > can all agree now that it's better if you at least the groundwork instead. Yes, it would be better for me to prepare for the general split-up. > Please let us know if you would like Manjunath to continue with splitting > out the OHCI back-ends into separate drivers, or if you think that there > is no point given the quality of the earlier patches. This is how people learn. After I have taken care of the initial steps and converted a couple of the drivers, Manjunath can work on the rest. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 7/7] USB: OHCI: avoid conflicting platform drivers
On Friday 29 March 2013, Alan Stern wrote: > I have not checked the details of all the changes; however, the basic > idea is okay as a stop-gap measure. Ok, thanks. > I guess this means the onus is now on me to split up ohci-hcd into a > central library and separate bus drivers, like ehci-hcd... The original plan in my teams was that Manjunath would do that after he was done with the simple conversion of the EHCI drivers. I think we can all agree now that it's better if you at least the groundwork instead. Please let us know if you would like Manjunath to continue with splitting out the OHCI back-ends into separate drivers, or if you think that there is no point given the quality of the earlier patches. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 7/7] USB: OHCI: avoid conflicting platform drivers
On Thu, 28 Mar 2013, Arnd Bergmann wrote: > Like the EHCI driver, OHCI supports a large number of different platform > glue drivers by directly including them, which causes problems with > conflicting macro definitions in some cases. As more ARM architecture > specific back-ends are required to coexist in a single build, we should > split those out into separate drivers. Unfortunately, the infrastructure > for that is still under development, so to give us more time, this uses > a separate *_PLATFORM_DRIVER macro for each ARM specific OHCI backend, > just like we already do on PowerPC and some of the other ARM platforms. > > In linux-3.10, only the SPEAr and CNS3xxx back-ends would actually conflict > without this patch, but over time we would get more of them, so this > is a way to avoid having to patch the driver every time it breaks. We > should still split out all back-ends into separate loadable modules, > but that work is only needed to improve code size and cleanliness after > this patch, not for correctness. > > While we're here, this fixes the incorrectly sorted error path > for the OMAP1 and OMAP3 backends to ensure we always unregister > the exact set of drivers that were registered before erroring out. I have not checked the details of all the changes; however, the basic idea is okay as a stop-gap measure. I guess this means the onus is now on me to split up ohci-hcd into a central library and separate bus drivers, like ehci-hcd... Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
