Re: [Resend] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Felipe Balbi 
On Wed, Mar 13, 2013 at 03:57:59PM +0800, Bo Shen wrote:
 fix typo error in commit ea0e6276 cause the following build warning

maybe I should've been more explicit, but when you 'blame' a commit you
also add the commit subject is parentheses:

fix typo error introduced by commit ea0e6276 (usb: gadget: add multiple
definition guards) which causes the following build warning:

   warning: pr_vdebug redefined
 
 Signed-off-by: Bo Shen voice.s...@atmel.com
 ---
 Resend:
   Add which commit let this slip in
 ---
  drivers/usb/gadget/u_serial.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
 index c5034d9..b369292 100644
 --- a/drivers/usb/gadget/u_serial.c
 +++ b/drivers/usb/gadget/u_serial.c
 @@ -136,7 +136,7 @@ static struct portmaster {
   pr_debug(fmt, ##arg)
  #endif /* pr_vdebug */
  #else
 -#ifndef pr_vdebig
 +#ifndef pr_vdebug
  #define pr_vdebug(fmt, arg...) \
   ({ if (0) pr_debug(fmt, ##arg); })
  #endif /* pr_vdebug */
 -- 
 1.7.9.5
 

-- 
balbi


signature.asc
Description: Digital signature

Re: [Resend] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Bo Shen 

Hi Felipe,

On 3/13/2013 16:19, Felipe Balbi wrote:

On Wed, Mar 13, 2013 at 03:57:59PM +0800, Bo Shen wrote:

fix typo error in commit ea0e6276 cause the following build warning


maybe I should've been more explicit, but when you 'blame' a commit you
also add the commit subject is parentheses:

fix typo error introduced by commit ea0e6276 (usb: gadget: add multiple
definition guards) which causes the following build warning:


Thanks.

I will send the patch with this again.


   warning: pr_vdebug redefined

Signed-off-by: Bo Shen voice.s...@atmel.com
---
Resend:
   Add which commit let this slip in
---
  drivers/usb/gadget/u_serial.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
index c5034d9..b369292 100644
--- a/drivers/usb/gadget/u_serial.c
+++ b/drivers/usb/gadget/u_serial.c
@@ -136,7 +136,7 @@ static struct portmaster {
pr_debug(fmt, ##arg)
  #endif /* pr_vdebug */
  #else
-#ifndef pr_vdebig
+#ifndef pr_vdebug
  #define pr_vdebug(fmt, arg...) \
({ if (0) pr_debug(fmt, ##arg); })
  #endif /* pr_vdebug */
--
1.7.9.5



Best Regards,
Bo Shen

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Resend] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Bo Shen 

Hi Sergei,

On 3/13/2013 21:35, Sergei Shtylyov wrote:

Hello.

On 13-03-2013 11:57, Bo Shen wrote:


fix typo error in commit ea0e6276 cause the following build warning


Pleas ealso specify that commit's summary line in parens (or however
you like).


Thanks for you information.

With Felipe's hint, I have sent out v2 version 
(http://article.gmane.org/gmane.linux.usb.general/82260) with commit id 
and subject. Please check it, if any other suggestion will appreciate.



   warning: pr_vdebug redefined



Signed-off-by: Bo Shen voice.s...@atmel.com


WBR, Sergei




Best Regards,
Bo Shen

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html