Re: Logitech G27 leds no more supported

2018-10-17 Thread Greg KH 
On Wed, Oct 17, 2018 at 02:44:51PM +, elrond...@protonmail.com wrote:
> 
> 
> Hi,
> 
> No more leds subdirectory for this wheel, someone reports me G29 leds stays 
> supported correctly.
> 
> No more path: /sys/class/leds/logitechwheelpath, just my keyboard leds are 
> detected. Force feedback are correctly supported.
> 
> Please fix this
> 
> Cheer
> 
> Elrondo
> 
> INFO: Kernel 4.18 and older affected

What kernel version did this work properly on?

And I think the linux-input mailing list would want to know about this,
this isn't a usb-core specific issue.  I've added them to the cc: here.
thanks,

greg k-h

Re: Logitech G27 leds no more supported

2018-10-19 Thread Simon Wood 
On Wed, October 17, 2018 11:21 pm, Greg KH wrote:
> On Wed, Oct 17, 2018 at 02:44:51PM +, elrond...@protonmail.com wrote:
>> No more leds subdirectory for this wheel, someone reports me G29 leds
>> stays supported correctly.
>>
>> No more path: /sys/class/leds/logitechwheelpath, just my keyboard leds
>> are detected. Force feedback are correctly supported.
>>

> What kernel version did this work properly on?
>
>
> And I think the linux-input mailing list would want to know about this,
> this isn't a usb-core specific issue.  I've added them to the cc: here.
> thanks,

Thanks for the report, and yes it does seem broken. I tried on 4.17.0-rc5+
and it seems that the 'hid-logitech' module does not know the device ID of
the G29 anymore.

Support was originally added in 29fae1c85166ef525b8b6518e749295e0c9d1e20,
but that was a long time ago and it seems that the 'hid-core.c' stuff has
somewhat changed

Will continue looking for cause.
Simon
Syslog on insert
--
Oct 19 16:16:04 thevoid kernel: [33656.156644] usb 1-2: new full-speed USB 
device number 12 using xhci_hcd
Oct 19 16:16:05 thevoid kernel: [33656.306093] usb 1-2: New USB device found, 
idVendor=046d, idProduct=c260, bcdDevice=89.00
Oct 19 16:16:05 thevoid kernel: [33656.306106] usb 1-2: New USB device strings: 
Mfr=1, Product=2, SerialNumber=0
Oct 19 16:16:05 thevoid kernel: [33656.306114] usb 1-2: Product: G29 Driving 
Force Racing Wheel
Oct 19 16:16:05 thevoid kernel: [33656.306122] usb 1-2: Manufacturer: Logitech
Oct 19 16:16:05 thevoid kernel: [33656.314487] input: Logitech G29 Driving 
Force Racing Wheel as 
/devices/pci:00/:00:14.0/usb1/1-2/1-2:1.0/0003:046D:C260.0006/input/input22
Oct 19 16:16:05 thevoid kernel: [33656.373288] hid-generic 0003:046D:C260.0006: 
input,hiddev3,hidraw5: USB HID v1.10 Joystick [Logitech G29 Driving Force 
Racing Wheel] on usb-:00:14.0-2/input0
Oct 19 16:16:05 thevoid mtp-probe: checking bus 1, device 12: 
"/sys/devices/pci:00/:00:14.0/usb1/1-2"
Oct 19 16:16:05 thevoid mtp-probe: bus: 1, device: 12 was not an MTP device
Oct 19 16:16:05 thevoid upowerd[1405]: unhandled action 'bind' on 
/sys/devices/pci:00/:00:14.0/usb1/1-2/1-2:1.0/0003:046D:C260.0006
Oct 19 16:16:05 thevoid upowerd[1405]: unhandled action 'bind' on 
/sys/devices/pci:00/:00:14.0/usb1/1-2/1-2:1.0
Oct 19 16:16:05 thevoid upowerd[1405]: unhandled action 'bind' on 
/sys/devices/pci:00/:00:14.0/usb1/1-2
--

lsusb -vv
--
Bus 001 Device 012: ID 046d:c260 Logitech, Inc. 
Device Descriptor:
  bLength18
  bDescriptorType 1
  bcdUSB   1.00
  bDeviceClass0 (Defined at Interface level)
  bDeviceSubClass 0 
  bDeviceProtocol 0 
  bMaxPacketSize064
  idVendor   0x046d Logitech, Inc.
  idProduct  0xc260 
  bcdDevice   89.00
  iManufacturer   1 
  iProduct2 
  iSerial 0 
  bNumConfigurations  1
  Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength   41
bNumInterfaces  1
bConfigurationValue 1
iConfiguration  0 
bmAttributes 0x80
  (Bus Powered)
MaxPower  200mA
Interface Descriptor:
  bLength 9
  bDescriptorType 4
  bInterfaceNumber0
  bAlternateSetting   0
  bNumEndpoints   2
  bInterfaceClass 3 Human Interface Device
  bInterfaceSubClass  0 No Subclass
  bInterfaceProtocol  0 None
  iInterface  0 
HID Device Descriptor:
  bLength 9
  bDescriptorType33
  bcdHID   1.10
  bCountryCode0 Not supported
  bNumDescriptors 1
  bDescriptorType34 Report
  wDescriptorLength 160
 Report Descriptors: 
   ** UNAVAILABLE **
  Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x03  EP 3 OUT
bmAttributes3
  Transfer TypeInterrupt
  Synch Type   None
  Usage Type   Data
wMaxPacketSize 0x0040  1x 64 bytes
bInterval   5
  Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84  EP 4 IN
bmAttributes3
  Transfer TypeInterrupt
  Synch Type   None
  Usage Type   Data
wMaxPacketSize 0x0040  1x 64 bytes
bInterval   5
--

uname -a
--
Linux thevoid 4.17.0-rc5+ #11 SMP Sat May 19 11:08:23 MDT 2018 x86_64 x86_64 
x86_64 GNU/Linux
--
filename:   /lib/modules/4.17.0-rc5+/kernel/drivers/hid/hid-logitech.ko
license:GPL
srcversion: D51DE1425C46A412C85BBE4
alias:

Re: Logitech G27 leds no more supported

2018-10-19 Thread Simon Wood 
On Fri, October 19, 2018 4:46 pm, Simon Wood wrote:

> Thanks for the report, and yes it does seem broken. I tried on
> 4.17.0-rc5+
> and it seems that the 'hid-logitech' module does not know the device ID of
>  the G29 anymore.

Oh, how easily we forget things... there's a switch on the top wheel
(close to LEDs) which changes the wheel into a compatibility mode.

Flipping this get wheel recognized and working on 4.17.0-rc5+
--
root@thevoid:/sys/class/leds# ls
0003:046D:C24F.0009::RPM1  0003:046D:C24F.0009::RPM4  input3::numlock
input8::compose  input8::scrolllock
0003:046D:C24F.0009::RPM2  0003:046D:C24F.0009::RPM5  input3::scrolllock 
input8::kana
0003:046D:C24F.0009::RPM3  input3::capslock   input8::capslock   
input8::numlock
root@thevoid:/sys/class/leds# cd 0003\:046D\:C24F.0009\:\:RPM4
root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# ls
brightness  device  max_brightness  power  subsystem  trigger  uevent
root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# cat max_brightness
> brightness
--

I'll rebuild HEAD to confirm it still works.
Simon.

PS. We should maybe pick up that other USB Id.

Re: Logitech G27 leds no more supported

2018-10-20 Thread elrondo46 
Can you fix it for Logitech G27 too ?

How can I make a special kmod to have it functionnal in my current kernel, I'm 
on manjaro (arch based) ?, thanks for say thnk you for my report


Elrondo



‐‐‐ Original Message ‐‐‐
Le samedi 20 octobre 2018 01:03, Simon Wood  a écrit :

> On Fri, October 19, 2018 4:46 pm, Simon Wood wrote:
>
> > Thanks for the report, and yes it does seem broken. I tried on
> > 4.17.0-rc5+
> > and it seems that the 'hid-logitech' module does not know the device ID of
> > the G29 anymore.
>
> Oh, how easily we forget things... there's a switch on the top wheel
> (close to LEDs) which changes the wheel into a compatibility mode.
>
> Flipping this get wheel recognized and working on 4.17.0-rc5+
>
> -
>
> root@thevoid:/sys/class/leds# ls
> 0003:046D:C24F.0009::RPM1 0003:046D:C24F.0009::RPM4 input3::numlock
> input8::compose input8::scrolllock
> 0003:046D:C24F.0009::RPM2 0003:046D:C24F.0009::RPM5 input3::scrolllock
> input8::kana
> 0003:046D:C24F.0009::RPM3 input3::capslock input8::capslock
> input8::numlock
> root@thevoid:/sys/class/leds# cd 0003\:046D\:C24F.0009\:\:RPM4
> root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# ls
> brightness device max_brightness power subsystem trigger uevent
> root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# cat max_brightness
>
> > brightness
>
> --
>
> I'll rebuild HEAD to confirm it still works.
> Simon.
>
> PS. We should maybe pick up that other USB Id.

Re: Logitech G27 leds no more supported

2018-10-20 Thread elrondo46 
Or just a patch file to patch and rebuild my Manjaro kernel. I can add it to 
PKGBUILD file and make a new kernel package with included patch

Thanks

elrondo


‐‐‐ Original Message ‐‐‐
Le samedi 20 octobre 2018 10:32,  a écrit :

> Can you fix it for Logitech G27 too ?
>
> How can I make a special kmod to have it functionnal in my current kernel, 
> I'm on manjaro (arch based) ?, thanks for say thnk you for my report
>
> Elrondo
>
> ‐‐‐ Original Message ‐‐‐
> Le samedi 20 octobre 2018 01:03, Simon Wood si...@mungewell.org a écrit :
>
> > On Fri, October 19, 2018 4:46 pm, Simon Wood wrote:
> >
> > > Thanks for the report, and yes it does seem broken. I tried on
> > > 4.17.0-rc5+
> > > and it seems that the 'hid-logitech' module does not know the device ID of
> > > the G29 anymore.
> >
> > Oh, how easily we forget things... there's a switch on the top wheel
> > (close to LEDs) which changes the wheel into a compatibility mode.
> > Flipping this get wheel recognized and working on 4.17.0-rc5+
> >
> > root@thevoid:/sys/class/leds# ls
> > 0003:046D:C24F.0009::RPM1 0003:046D:C24F.0009::RPM4 input3::numlock
> > input8::compose input8::scrolllock
> > 0003:046D:C24F.0009::RPM2 0003:046D:C24F.0009::RPM5 input3::scrolllock
> > input8::kana
> > 0003:046D:C24F.0009::RPM3 input3::capslock input8::capslock
> > input8::numlock
> > root@thevoid:/sys/class/leds# cd 0003\:046D\:C24F.0009\:\:RPM4
> > root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# ls
> > brightness device max_brightness power subsystem trigger uevent
> > root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# cat max_brightness
> >
> > > brightness
> >
> > --
> > I'll rebuild HEAD to confirm it still works.
> > Simon.
> > PS. We should maybe pick up that other USB Id.

Re: Logitech G27 leds no more supported

2018-10-20 Thread elrondo46 
There is no switch in G27, it's a pure PC wheel, and leds are not recognized


Sent with ProtonMail Secure Email.

‐‐‐ Original Message ‐‐‐
Le samedi 20 octobre 2018 01:03, Simon Wood  a écrit :

> On Fri, October 19, 2018 4:46 pm, Simon Wood wrote:
>
> > Thanks for the report, and yes it does seem broken. I tried on
> > 4.17.0-rc5+
> > and it seems that the 'hid-logitech' module does not know the device ID of
> > the G29 anymore.
>
> Oh, how easily we forget things... there's a switch on the top wheel
> (close to LEDs) which changes the wheel into a compatibility mode.
>
> Flipping this get wheel recognized and working on 4.17.0-rc5+
>
> -
>
> root@thevoid:/sys/class/leds# ls
> 0003:046D:C24F.0009::RPM1 0003:046D:C24F.0009::RPM4 input3::numlock
> input8::compose input8::scrolllock
> 0003:046D:C24F.0009::RPM2 0003:046D:C24F.0009::RPM5 input3::scrolllock
> input8::kana
> 0003:046D:C24F.0009::RPM3 input3::capslock input8::capslock
> input8::numlock
> root@thevoid:/sys/class/leds# cd 0003\:046D\:C24F.0009\:\:RPM4
> root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# ls
> brightness device max_brightness power subsystem trigger uevent
> root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# cat max_brightness
>
> > brightness
>
> --
>
> I'll rebuild HEAD to confirm it still works.
> Simon.
>
> PS. We should maybe pick up that other USB Id.

Re: Logitech G27 leds no more supported

2018-10-21 Thread elrondo46 
SOLVED that's due to this is compiled as modules:
CONFIG_LEDS_SYSCON
CONFIG_LEDS_SYSCON

and not as YES option

Thnaks

‐‐‐ Original Message ‐‐‐
Le dimanche 21 octobre 2018 08:16,  a écrit :

> There is no switch in G27, it's a pure PC wheel, and leds are not recognized
>
> Sent with ProtonMail Secure Email.
>
> ‐‐‐ Original Message ‐‐‐
> Le samedi 20 octobre 2018 01:03, Simon Wood si...@mungewell.org a écrit :
>
> > On Fri, October 19, 2018 4:46 pm, Simon Wood wrote:
> >
> > > Thanks for the report, and yes it does seem broken. I tried on
> > > 4.17.0-rc5+
> > > and it seems that the 'hid-logitech' module does not know the device ID of
> > > the G29 anymore.
> >
> > Oh, how easily we forget things... there's a switch on the top wheel
> > (close to LEDs) which changes the wheel into a compatibility mode.
> > Flipping this get wheel recognized and working on 4.17.0-rc5+
> >
> > root@thevoid:/sys/class/leds# ls
> > 0003:046D:C24F.0009::RPM1 0003:046D:C24F.0009::RPM4 input3::numlock
> > input8::compose input8::scrolllock
> > 0003:046D:C24F.0009::RPM2 0003:046D:C24F.0009::RPM5 input3::scrolllock
> > input8::kana
> > 0003:046D:C24F.0009::RPM3 input3::capslock input8::capslock
> > input8::numlock
> > root@thevoid:/sys/class/leds# cd 0003\:046D\:C24F.0009\:\:RPM4
> > root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# ls
> > brightness device max_brightness power subsystem trigger uevent
> > root@thevoid:/sys/class/leds/0003:046D:C24F.0009::RPM4# cat max_brightness
> >
> > > brightness
> >
> > --
> > I'll rebuild HEAD to confirm it still works.
> > Simon.
> > PS. We should maybe pick up that other USB Id.

Re: Logitech G27 leds no more supported

2018-10-23 Thread Simon Wood 
On Sun, October 21, 2018 10:43 am, elrond...@protonmail.com wrote:
> SOLVED that's due to this is compiled as modules:
> CONFIG_LEDS_SYSCON
> CONFIG_LEDS_SYSCON
>
>
> and not as YES option

I'm not seeing the connection between this being a module and breaking
(specifically) the Logitech driver. We're only checking
'CONFIG_LEDS_CLASS'.

Did you have 'CONFIG_LEDS_CLASS' compiled as a module as well?

I did a workaround for this in the SteelSeries driver...
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/hid/hid-steelseries.c?h=v4.19#n20
--
#if IS_BUILTIN(CONFIG_LEDS_CLASS) || \
(IS_MODULE(CONFIG_LEDS_CLASS) && IS_MODULE(CONFIG_HID_STEELSERIES))
#define SRWS1_NUMBER_LEDS 15
struct steelseries_srws1_data {
__u16 led_state;
/* the last element is used for setting all leds simultaneously */
struct led_classdev *led[SRWS1_NUMBER_LEDS + 1];
};
#endif
--

Cheers,
Simon


https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/Kconfig?h=v4.19
--
config LEDS_SYSCON
bool "LED support for LEDs on system controllers"
depends on LEDS_CLASS=y
depends on MFD_SYSCON
depends on OF
help
  This option enables support for the LEDs on syscon type
  devices. This will only work with device tree enabled
  devices.
--

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/hid/Kconfig?h=v4.19#n548
--
config LOGIWHEELS_FF
bool "Logitech wheels configuration and force feedback support"
depends on HID_LOGITECH
select INPUT_FF_MEMLESS
default LOGITECH_FF
help
  Say Y here if you want to enable force feedback and range setting(*)
  support for following Logitech wheels:
  - Logitech G25 (*)
  - Logitech G27 (*)
  - Logitech G29 (*)
  - Logitech Driving Force
  - Logitech Driving Force Pro (*)
  - Logitech Driving Force GT (*)
  - Logitech Driving Force EX/RX
  - Logitech Driving Force Wireless
  - Logitech Speed Force Wireless
  - Logitech MOMO Force
  - Logitech MOMO Racing Force
  - Logitech Formula Force GP
  - Logitech Formula Force EX/RX
  - Logitech Wingman Formula Force GP
--


https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/hid/hid-lg4ff.c?h=v4.19#n1087
--
#ifdef CONFIG_LEDS_CLASS
static void lg4ff_set_leds(struct hid_device *hid, u8 leds)
{
--