Re: Renesas sparse errors
Hi Felipe On Wed, Mar 27, 2013 at 06:21:19PM -0700, Kuninori Morimoto wrote: linux/drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:322:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:384:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:524:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:545:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:574:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:606:9: error: incompatible types in conditional expression (different base types) (snip) CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/common.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/mod.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/pipe.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/fifo.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/mod_host.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/mod_gadget.c CC drivers/usb/renesas_usbhs/mod.o CC drivers/usb/renesas_usbhs/pipe.o CC drivers/usb/renesas_usbhs/fifo.o drivers/usb/renesas_usbhs/mod_gadget.c:233:28: warning: symbol 'req_clear_feature' was not declared. Should it be static? drivers/usb/renesas_usbhs/mod_gadget.c:274:28: warning: symbol 'req_set_feature' was not declared. Should it be static? drivers/usb/renesas_usbhs/mod_gadget.c:375:28: warning: symbol 'req_get_status' was not declared. Should it be static? drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible types in conditional expression (different base types) CC drivers/usb/renesas_usbhs/mod_gadget.o drivers/usb/renesas_usbhs/common.c:322:17: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:384:17: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:524:9: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:545:9: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:574:9: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:606:9: error: incompatible types in conditional expression (different base types) CC drivers/usb/renesas_usbhs/common.o CC drivers/usb/renesas_usbhs/mod_host.o LD drivers/usb/renesas_usbhs/renesas_usbhs.o LD drivers/usb/renesas_usbhs/built-in.o Thank you. I could understand. I send fixup patch in next email. It solve above error. But renesas_usbhs common.c still has warning... Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Renesas sparse errors
Hi, On Thu, Mar 28, 2013 at 11:18:11AM +0200, Felipe Balbi wrote: Hi, On Wed, Mar 27, 2013 at 06:21:19PM -0700, Kuninori Morimoto wrote: linux/drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:322:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:384:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:524:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:545:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:574:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:606:9: error: incompatible types in conditional expression (different base types) Could you look into fixing them for v3.10 or v3.11 ? That would be great as it would make my build-testing scripts a lot happier :-p Hmmm... strange... I can't get this error. I tried x86(32bit/64bit)/sh/arm compiler on your next and master branch. 1b0563f888d14f877ef0b5602ba240f3e857df06 (Merge branch 'next') 6b0cfc656f8a649fbfbe11e76e0aa301ee26879e (usb: musb: ux500_dma: fix sparse warning) my all result are.. ... CC drivers/usb/renesas_usbhs/common.o CC drivers/usb/renesas_usbhs/mod.o CC drivers/usb/renesas_usbhs/pipe.o CC drivers/usb/renesas_usbhs/fifo.o CC drivers/usb/renesas_usbhs/mod_host.o LD drivers/usb/renesas_usbhs/renesas_usbhs.o LD drivers/usb/renesas_usbhs/built-in.o I don't see the CHECKs here, you need to ask sparse to run :-) try make C=2. Please be sure 'sparse' is in your PATH. should look like this: CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/common.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/mod.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/pipe.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/fifo.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/mod_host.c CHECK /home/balbi/workspace/linux/drivers/usb/renesas_usbhs/mod_gadget.c CC drivers/usb/renesas_usbhs/mod.o CC drivers/usb/renesas_usbhs/pipe.o CC drivers/usb/renesas_usbhs/fifo.o drivers/usb/renesas_usbhs/mod_gadget.c:233:28: warning: symbol 'req_clear_feature' was not declared. Should it be static? drivers/usb/renesas_usbhs/mod_gadget.c:274:28: warning: symbol 'req_set_feature' was not declared. Should it be static? drivers/usb/renesas_usbhs/mod_gadget.c:375:28: warning: symbol 'req_get_status' was not declared. Should it be static? drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible types in conditional expression (different base types) CC drivers/usb/renesas_usbhs/mod_gadget.o drivers/usb/renesas_usbhs/common.c:322:17: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:384:17: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:524:9: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:545:9: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:574:9: error: incompatible types in conditional expression (different base types) drivers/usb/renesas_usbhs/common.c:606:9: error: incompatible types in conditional expression (different base types) CC drivers/usb/renesas_usbhs/common.o CC drivers/usb/renesas_usbhs/mod_host.o LD drivers/usb/renesas_usbhs/renesas_usbhs.o LD drivers/usb/renesas_usbhs/built-in.o (errors aren't following CHECKs because I run 18 build jobs) -- balbi signature.asc Description: Digital signature
Renesas sparse errors
Hi Kuninori, Renesas USB driver constantly gives me sparse errors: linux/drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:322:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:384:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:524:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:545:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:574:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:606:9: error: incompatible types in conditional expression (different base types) Could you look into fixing them for v3.10 or v3.11 ? That would be great as it would make my build-testing scripts a lot happier :-p -- balbi signature.asc Description: Digital signature
Re: Renesas sparse errors
Hi Felipe linux/drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:322:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:384:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:524:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:545:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:574:9: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:606:9: error: incompatible types in conditional expression (different base types) Could you look into fixing them for v3.10 or v3.11 ? That would be great as it would make my build-testing scripts a lot happier :-p Hmmm... strange... I can't get this error. I tried x86(32bit/64bit)/sh/arm compiler on your next and master branch. 1b0563f888d14f877ef0b5602ba240f3e857df06 (Merge branch 'next') 6b0cfc656f8a649fbfbe11e76e0aa301ee26879e (usb: musb: ux500_dma: fix sparse warning) my all result are.. ... CC drivers/usb/renesas_usbhs/common.o CC drivers/usb/renesas_usbhs/mod.o CC drivers/usb/renesas_usbhs/pipe.o CC drivers/usb/renesas_usbhs/fifo.o CC drivers/usb/renesas_usbhs/mod_host.o LD drivers/usb/renesas_usbhs/renesas_usbhs.o LD drivers/usb/renesas_usbhs/built-in.o ... Could you please teach me - which branch or commit are you using ? - which compiler are you using ? Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
