Re: dwc3 gadget broken on 4.10-rc1 + Andy's Edison patches

2017-01-02 Thread Andy Shevchenko 
On Sat, 2016-12-31 at 08:34 +0100, Vincent Pelletier wrote:
> ...and I should have checked balbi/usb.git:testing/fixes, which
> already has a fix for it:
>   https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h
> =testing/fixes=a3543b33edc746870a540d40bda2916a1d107185
> 
> Sorry for the noise.

I'm about to include this one to my branch.
Thanks for pointing out.

-- 
Andy Shevchenko 
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: dwc3 gadget broken on 4.10-rc1 + Andy's Edison patches

2016-12-30 Thread Vincent Pelletier 
...and I should have checked balbi/usb.git:testing/fixes, which
already has a fix for it:
  
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes=a3543b33edc746870a540d40bda2916a1d107185

Sorry for the noise.
-- 
Vincent Pelletier
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

dwc3 gadget broken on 4.10-rc1 + Andy's Edison patches

2016-12-30 Thread Vincent Pelletier 
Hello,

While testing Andy's current Edison kernel[1], I notice a regression
compared to the 4.9-rc8:
loading dwc3 module emits:
  [ 1637.327602] dwc3 dwc3.1.auto: can't allocate event buffer
  [ 1637.333201] dwc3 dwc3.1.auto: failed to allocate event buffers
  [ 1637.341101] dwc3: probe of dwc3.1.auto failed with error -12

A quick kgdb session finds:
  Thread 121 hit Breakpoint 3, dma_alloc_from_coherent
(dev=0xf4e6440c, size=256, dma_handle=0xf4901eac, ret=0xf4895cd8) at
drivers/base/dma-coherent.c:165
  165 int order = get_order(size);
  (gdb) print dev->dma_mem
  $8 = (struct dma_coherent_mem *) 0x0

Which I traced back to:
  commit d64ff406e51e4f359afedbf2468a10440d6d8cef
  Author: Arnd Bergmann 
  Date:   Thu Nov 17 17:13:47 2016 +0530

 usb: dwc3: use bus->sysdev for DMA configuration

I am not sure where to go from here: I believe there is no specific
change in Andy's tree related to the dwc3, but I'm not familiar with
how devices are discovered (and even less how dma memory is assigned).
I did not (yet) tried with this commit (and the one following it)
reverted.

[1] https://github.com/andy-shev/linux/tree/eds as of
3cfd6f93b96355542e044240f2daf11840dda0b2

Regards,
-- 
Vincent Pelletier
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html