[linux-usb-devel] can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]
On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/ Hello, on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting is becoming troublesome as different sets have slightly different problems. At one point (with the GREGKH usb stuff built) I had the kernel reporting it cannot stop the usb-storage thread so I guess that something later in the series made things worse (freezable workqueues?). Clues? -- mattia :wq! - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] [PATCH] Don't autosuspend Blackberry devices.
Am Mittwoch, 20. Juni 2007 schrieb Jeremy Katz: > On Wed, 2007-06-20 at 00:12 +0200, Oliver Neukum wrote: > > Am Dienstag, 19. Juni 2007 schrieb Jeremy Katz: > > > Blackberry devices charge over USB. By autosuspending the port, they are > > > not able to charge reliably. > > > > We made autosuspend configurable on a per device basis through > > sysfs precisely for such cases. The blacklist is only for devices which > > crash when they are suspended. This patch is not a good idea. > > But this basically means that either > a) users have to know that they need to twiddle a bit, or they get "my > device doesn't work" > or > b) distros have to maintain a list of "these devices need to have the > bit twiddled". Which either ends up being done not at all, on a per > distro basis or based on having to have yet another callout whenever a > device is loaded. We have udev running usually. A callout always happens when a USB device is attached. Therefore that list should live in udev, not the kernel. > As opposed to having the patch, in which case things work for the user > as they are going to expect. No, this patch will prevent laptops from using runtime power management at all times, while a user space solution gives full control over when the device should be charged or not be charged. Whether the laptop's or the blackberry's battery should be conserved is not a decision the kernel can make. Regards Oliver - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Question about usb sg handling
Calm down. We should discuss this problem in a rational way. I believe there should be more stories behind this mail. Even though I am not quite clear about what happened before, but I guess probably you argued on this some time back. So what are the current status? Regards Jason Xiao On 6/20/07, Oliver Neukum <[EMAIL PROTECTED]> wrote: > Am Dienstag, 19. Juni 2007 schrieb Pete Zaitcev: > > On Tue, 19 Jun 2007 09:26:15 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > > > > > The main problem is that the URB does not have an s/g list. If it > > > > did, the whole library would be unnecessary. Nonetheless, we still > > > > > > And that from the man who complained about 24 more bytes in struct urb ;-) > > > > I think your irony falls flat. Why do you think I haven't submitted > > a patch to add it yet? Of course there's always a tradeoff and linear > > URBs served us well so far. I am merely stating the reason why the > > library exists. > > But it hasn't. It can do a lot of things nobody needs and can't do > things like scatter/gather that are needed. It allocates a lot of memory > in every submission. It is too large because of unneeded features. > It works, it doesn't work well. > >Regards >Oliver > - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] [PATCH] Don't autosuspend Blackberry devices.
On Wed, 2007-06-20 at 00:12 +0200, Oliver Neukum wrote: > Am Dienstag, 19. Juni 2007 schrieb Jeremy Katz: > > Blackberry devices charge over USB. By autosuspending the port, they are > > not able to charge reliably. > > We made autosuspend configurable on a per device basis through > sysfs precisely for such cases. The blacklist is only for devices which > crash when they are suspended. This patch is not a good idea. But this basically means that either a) users have to know that they need to twiddle a bit, or they get "my device doesn't work" or b) distros have to maintain a list of "these devices need to have the bit twiddled". Which either ends up being done not at all, on a per distro basis or based on having to have yet another callout whenever a device is loaded. As opposed to having the patch, in which case things work for the user as they are going to expect. Jeremy - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] [PATCH] Don't autosuspend Blackberry devices.
Am Dienstag, 19. Juni 2007 schrieb Jeremy Katz: > Blackberry devices charge over USB. By autosuspending the port, they are > not able to charge reliably. We made autosuspend configurable on a per device basis through sysfs precisely for such cases. The blacklist is only for devices which crash when they are suspended. This patch is not a good idea. Regards Oliver - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] [PATCH] Printer Gadget Driver v0.2.0 (kernel
From: Craig W. Nadler <[EMAIL PROTECTED]> G_PRINTER: Adds a USB printer gadget driver for use in printer firmware. This patch adds a USB printer gadget driver for use in printer firmware. The printer gadget channels data between the USB host and a userspace program driving the print engine. The user space program reads and writes the device file /dev/g_printer to receive or send printer data. It can use ioctl calls to the device file to get or set printer status. Signed-off-by: Craig W. Nadler <[EMAIL PROTECTED]> --- This is an updated patch with a fix for a problem found with sparse. - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] [PATCH] Add URB_FREE_BUFFER flag
On Tue, Jun 19, 2007 at 04:44:33PM +0200, Marcel Holtmann wrote: > Hi Greg, > > > here is the patch to add the URB_FREE_BUFFER flag for freeing the > > transfer buffer together with the URB itself. Please apply. > > anything wrong with this patch? No, sorry, it's in my to-apply queue, was traveling last week and trying to get ready for OLS right now... I'll get to it by the end of this week, sorry for the delay. thanks, greg k-h - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[linux-usb-devel] [PATCH] Don't autosuspend Blackberry devices.
Blackberry devices charge over USB. By autosuspending the port, they are
not able to charge reliably.
Signed-off-by: Jeremy Katz <[EMAIL PROTECTED]>
---
drivers/usb/core/quirks.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 739f520..7cbfc58 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -34,7 +34,10 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x04b8, 0x011f), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
/* Elsa MicroLink 56k (V.250) */
{ USB_DEVICE(0x05cc, 0x2267), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
-
+ /* RIM Blackberry */
+ { USB_DEVICE(0x0fca, 0x0001), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
+ { USB_DEVICE(0x0fca, 0x0004), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
+ { USB_DEVICE(0x0fca, 0x0006), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
{ } /* terminating entry must be last */
};
--
1.5.2.2
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[linux-usb-devel] [PATCH] Support Blackberry Pearl with berry_charge
The Blackberry Pearl (8100) needs similar tweaks as older Blackberry models
to be able to charge when connected via USB. The Pearl also adds an
additional need to go into a separate mode for fully accessing the device;
do that by default as well.
Changes based on the changes from bcharge in the barry project
(http://barry.sf.net)
Signed-off-by: Jeremy Katz <[EMAIL PROTECTED]>
---
drivers/usb/misc/berry_charge.c | 35 +++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/misc/berry_charge.c b/drivers/usb/misc/berry_charge.c
index b15f2fd..886a280 100644
--- a/drivers/usb/misc/berry_charge.c
+++ b/drivers/usb/misc/berry_charge.c
@@ -26,8 +26,11 @@
#define RIM_VENDOR 0x0fca
#define BLACKBERRY 0x0001
+#define BLACKBERRY_PEARL_DUAL 0x0004
+#define BLACKBERRY_PEARL0x0006
static int debug;
+static int pearl_dual_mode = 1;
#ifdef dbg
#undef dbg
@@ -38,6 +41,8 @@ static int debug;
static struct usb_device_id id_table [] = {
{ USB_DEVICE(RIM_VENDOR, BLACKBERRY) },
+ { USB_DEVICE(RIM_VENDOR, BLACKBERRY_PEARL) },
+ { USB_DEVICE(RIM_VENDOR, BLACKBERRY_PEARL_DUAL) },
{ },/* Terminating entry */
};
MODULE_DEVICE_TABLE(usb, id_table);
@@ -86,6 +91,30 @@ static int magic_charge(struct usb_device *udev)
return retval;
}
+static int magic_dual_mode(struct usb_device *udev)
+{
+ char *dummy_buffer = kzalloc(2, GFP_KERNEL);
+ int retval;
+
+ if (!dummy_buffer)
+ return -ENOMEM;
+
+/* send magic command so that the Blackberry Pearl device exposes
+ * two interfaces: both the USB mass-storage one and one which can
+ * be used for database access. */
+ dbg(&udev->dev, "Sending magic pearl command\n");
+ retval = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
+0xa9, 0xc0, 1, 1, dummy_buffer, 2, 100);
+dbg(&udev->dev, "Magic pearl command returned %d\n", retval);
+
+ dbg(&udev->dev, "Calling set_configuration\n");
+ retval = usb_driver_set_configuration(udev, 1);
+ if (retval)
+ dev_err(&udev->dev, "Set Configuration failed :%d.\n", retval);
+
+ return retval;
+}
+
static int berry_probe(struct usb_interface *intf,
const struct usb_device_id *id)
{
@@ -105,6 +134,10 @@ static int berry_probe(struct usb_interface *intf,
/* turn the power on */
magic_charge(udev);
+if ((le16_to_cpu(udev->descriptor.idProduct) == BLACKBERRY_PEARL) &&
+pearl_dual_mode)
+magic_dual_mode(udev);
+
/* we don't really want to bind to the device, userspace programs can
* handle the syncing just fine, so get outta here. */
return -ENODEV;
@@ -138,3 +171,5 @@ MODULE_LICENSE("GPL");
MODULE_AUTHOR("Greg Kroah-Hartman <[EMAIL PROTECTED]>");
module_param(debug, bool, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(debug, "Debug enabled or not");
+module_param(pearl_dual_mode, bool, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(pearl_dual_mode, "Change Blackberry Pearl to run in dual
mode");
--
1.5.2.2
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] [PATCH] Add URB_FREE_BUFFER flag
Hi Greg, > here is the patch to add the URB_FREE_BUFFER flag for freeing the > transfer buffer together with the URB itself. Please apply. anything wrong with this patch? Regards Marcel - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] [2/2] 2.6.22-rc5: known regressions with patches
On Sun, 17 Jun 2007 16:24:00 +0200 Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Hi all, > > Here is a list of some known regressions in 2.6.22-rc5 > with patches available. > > Feel free to add new regressions/remove fixed etc. > http://kernelnewbies.org/known_regressions > > > > Memory management > > Subject: bug in i386 MTRR initialization > References : http://lkml.org/lkml/2007/5/19/93 > Submitter : Andrea Righi <[EMAIL PROTECTED]> > Status : patch available > > > > Networking > Subject: commit 9093bbb2d96d0184f037cea9b4e952a44ebe7c32 broke the > bonding driver > References : http://lkml.org/lkml/2007/6/13/65 > Submitter : Dan Aloni <[EMAIL PROTECTED]> > Handled-By : Stephen Hemminger <[EMAIL PROTECTED]> > Status : patch available > (I cannot find it in archives. Stephen, please resend the patch) > http://www.mail-archive.com/[EMAIL PROTECTED]/msg40352.html - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] rx errors reported by usbnet
On Tue, 19 Jun 2007, Yum Rayan wrote:
> Following is the patch that we received from our h/w vendor. It seems
> to correct the issue where we are seeing the ethernet interface
> accumulate RX errors while USB device is not actually used.
What do you mean by "not actually used"? If it really were not being
used then no errors could occur.
Evidently you mean that you encounter receive errors at times when the
device isn't transmitting. It's not clear how relevant that is to the
problem...
> We have been testing this for a while and it seems to work. Comments
> appreciated.
>
> Patch is against 2.6.16
>
> Thanks.
> + if (cc == TD_PIDCHECKFAIL || cc == TD_DEVNOTRESP) {
> + urbpriv = td->urb->hcpriv;
> +
> + td->ed->hwHeadP &= ~cpu_to_hc32(ohci, ED_H);
> + td->hwINFO &= ~cpu_to_hc32(ohci, TD_CC);
> + td->hwINFO &= ~cpu_to_hc32(ohci, TD_EC);
> + urb = td->urb;
> + for (count = 0; count < urbpriv->length; count++) {
> + td = urbpriv->td[count];
> + if (td) {
> + list_del(&td->td_list);
> + td_dma =
> + hc32_to_cpup(ohci, &td->hwNextTD);
> + }
> + }
> + list_del(&urbpriv->pending);
> + td_submit_urb(ohci, urb);
My impression is that this would lead to an infinite loop when you try
to communicate with a non-responding device.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Error -71 on device descriptor read/all
On Tue, 19 Jun 2007, Paul Walmsley wrote: > On Tue, 19 Jun 2007, Oliver Neukum wrote: > > > Am Dienstag, 19. Juni 2007 schrieb Chuck Ebbert: > > > >> Try disabling CONFIG_USB_SUSPEND > >> > >> [usb developers: what are the drawbacks of doing this?] > > > > Increased power consumption. > > speaking of CONFIG_USB_SUSPEND, I've encountered at least one device -- a > Canon EOS 5D camera -- that, after the bus suspends, must be powercycled > in order to return the camera's interrupt endpoints to a functional state. > How are these types of problems handled, currently? Is this something for > a blacklist? There are a few possible approaches. One is indeed a blacklist, to prevent the camera from automatically being suspended. Another is to prevent it by changing a device parameter in sysfs. Note that neither of these will help if you do a suspend-to-RAM. That suspends everything. Alan Stern - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] ALi M5273 not working reliably
On Tue, 19 Jun 2007, Guillaume Bedot wrote: > Hello, > > I've just tried a PCI to USB2 card with a "ALi M5273 A1" chip. > Transferring a big file (a few hundreds MB) to an USB stick fails. > > Is this chip supposed to be supported ? > Is there some sonfig trick to use ? > > How can I help ? > Three things come to my mind. I can make some tests, or give / mail > the card to someone who has interest in fixing this (or for the card > ???), or throw it through a window. This may not be a problem with the PCI card; it could be a problem with the USB stick. Have you tried using the stick in other computers with high-speed USB controllers? Have you tried using other devices with the PCI card? Alan Stern - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Error -71 on device descriptor read/all
On Tue, 19 Jun 2007, Jiri Kosina wrote: > [ OK, it probably seems like a faulty hardware (controller or the device > itself), which is not able to run at high speed, but runs nicely on full > speed. Do you have a chance to try another high speed device in this > machine to check whether it works? > > Adding linux-usb-devel into CC , just in case, and leaving the full > original message below ] > > On Tue, 19 Jun 2007, Renato S. Yamane wrote: > > > Jiri Kosina wrote: > > > On Tue, 19 Jun 2007, Renato S. Yamane wrote: > > > > I see this in dmesg: > > > > usb 1-1: device descriptor read/all, error -71 > > > > > > Is this a USB 2.0 high-speed device? > > > > lspci -v | grep 1d.7 > > 00:1d.7 USB Controller: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 > > Family) > > USB2 EHCI Controller (rev 04) (prog-if 20 [EHCI]) > > > > My machine is a Laptop Toshiba M45-S355 > > > > > Don't you for example have USB extension cable too long to work on-high > > > speed? > > > > My only USB device is a mouse (Microsoft Notebook Optical Mouse) without > > extension cable (I use original cable, with less than 3 feets). > > > > > I guess the situation improves when you force USB 1.1 (i.e. rmmod > > > ehci_hcd), > > > right? > > > > #rmmode ehci_hcd > > #tail /var/log/messages > > > > kernel: ehci_hcd :00:1d.7: remove, state 4 > > kernel: usb usb5: USB disconnect, address 1 > > kernel: ehci_hcd :00:1d.7: USB bus 5 deregistered > > kernel: ACPI: PCI interrupt for device :00:1d.7 disabled > > > > I don't see any error (-71). > > > > #modprobe ehci_hcd > > #tail /var/log/messages > > kernel: ACPI: PCI Interrupt :00:1d.7[A] -> Link [LNKH] -> GSI 10 (level, > > low) -> IRQ 10 > > kernel: ehci_hcd :00:1d.7: EHCI Host Controller > > kernel: ehci_hcd :00:1d.7: new USB bus registered, assigned bus number 5 > > kernel: ehci_hcd :00:1d.7: debug port 1 > > kernel: ehci_hcd :00:1d.7: irq 10, io mem 0xf400 > > kernel: ehci_hcd :00:1d.7: USB 2.0 started, EHCI 1.00, driver 10 Dec > > 2004 > > kernel: usb usb5: configuration #1 chosen from 1 choice > > kernel: hub 5-0:1.0: USB hub found > > kernel: hub 5-0:1.0: 8 ports detected > > kernel: usb 1-1: USB disconnect, address 4 > > kernel: usb 1-1: new low speed USB device using uhci_hcd and address 5 > > kernel: usb 1-1: configuration #1 chosen from 1 choice > > kernel: input: Microsoft Microsoft 3-Button Mouse with IntelliEye? as > > /class/input/input8 > > kernel: input: USB HID v1.00 Mouse [Microsoft Microsoft 3-Button Mouse with > > IntelliEye?] on usb-:00:1d.0-1 > > > > This error is present only in dmesg, see below (line 8): > > > > PCI: Setting latency timer of device :00:1d.7 to 64 > > ehci_hcd :00:1d.7: EHCI Host Controller > > ehci_hcd :00:1d.7: new USB bus registered, assigned bus number 5 > > ehci_hcd :00:1d.7: debug port 1 > > PCI: cache line size of 32 is not supported by device :00:1d.7 > > ehci_hcd :00:1d.7: irq 10, io mem 0xf400 > > ehci_hcd :00:1d.7: USB 2.0 started, EHCI 1.00, driver 10 Dec 2004 > > usb 1-1: device descriptor read/all, error -71 > > usb usb5: configuration #1 chosen from 1 choice > > hub 5-0:1.0: USB hub found > > hub 5-0:1.0: 8 ports detected > > Clocksource tsc unstable (delta = -194969704 ns) > > ACPI: PCI Interrupt Link [LNKG] enabled at IRQ 6 > > PCI: setting IRQ 6 as level-triggered Does the mouse work correctly, even with ehci-hcd loaded? If it does then don't worry about the -71 error. It appears to be transient and it's not necessarily fatal. Alan Stern - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Error -71 on device descriptor read/all
Am Dienstag, 19. Juni 2007 schrieb Paul Walmsley: > On Tue, 19 Jun 2007, Oliver Neukum wrote: > > > Am Dienstag, 19. Juni 2007 schrieb Chuck Ebbert: > > > >> Try disabling CONFIG_USB_SUSPEND > >> > >> [usb developers: what are the drawbacks of doing this?] > > > > Increased power consumption. > > speaking of CONFIG_USB_SUSPEND, I've encountered at least one device -- a > Canon EOS 5D camera -- that, after the bus suspends, must be powercycled > in order to return the camera's interrupt endpoints to a functional state. > How are these types of problems handled, currently? Is this something for > a blacklist? drivers/usb/core/quirks.c Please try the reset-resume quirk before you use the no-autosuspend quirk. Regards Oliver - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[linux-usb-devel] Help tracking down chipset manufacturer for Kingsun KS-959 USB IrDA dongle
Sorry if this is not the correct forum for this particular question, but
here it goes:
I am currently trying to get documentation on the protocol format for
the Kingsun KS-959 USB IrDA (07d0:4959) dongle. This dongle is
non-standard in many ways. See this post by me to see what I mean:
http://sourceforge.net/mailarchive/forum.php?thread_name=4651EDD0.4060504%40ceibo.fiec.espol.edu.ec&forum_name=irda-users
I have previously written an IrDA driver for a Kingsun/Donshine dongle,
with help from linux-usb-devel, and it has finally been accepted for the
2.6.22 kernel. Now I want to write the driver for this other dongle, but
its obfuscated protocol is so strange that I have not been able (yet) to
figure it out. So I want to locate the manufacturer of the chipset, in
order to ask them for the documentation for the protocol. There are many
Kingsun references on Google, but of the two selling USB devices I have
tried so far, none have answered my emails (if they even manufacture
this particular USB dongle). So I thought I would ask you on whether you
have stumbled on the precise manufacturer website (if any), or whether
you know where to find documentation on this dongle.
This blog post was made by Manuel F. Argüelles, who also has one of
those dongles:
http://p4c0.wordpress.com/2007/02/11/usb-to-irda/
Alex Villacís Lasso
--
perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] rx errors reported by usbnet
Following is the patch that we received from our h/w vendor. It seems
to correct the issue where we are seeing the ethernet interface
accumulate RX errors while USB device is not actually used.
We have been testing this for a while and it seems to work. Comments
appreciated.
Patch is against 2.6.16
Thanks.
--- ohci-q.c.old2007-05-31 09:18:26.569155000 -0700
+++ ohci-q.c2007-06-19 11:08:44.678144000 -0700
@@ -872,7 +872,11 @@ static struct td *dl_reverse_done_list (
struct td *td_rev = NULL;
struct td *td = NULL;
- td_dma = hc32_to_cpup (ohci, &ohci->hcca->done_head);
+ urb_priv_t *urbpriv;
+ int count;
+ struct urb *urb;
+
+ td_dma = hc32_to_cpup(ohci, &ohci->hcca->done_head);
ohci->hcca->done_head = 0;
wmb();
@@ -891,18 +895,38 @@ static struct td *dl_reverse_done_list (
td->hwINFO |= cpu_to_hc32 (ohci, TD_DONE);
cc = TD_CC_GET (hc32_to_cpup (ohci, &td->hwINFO));
- /* Non-iso endpoints can halt on error; un-halt,
-* and dequeue any other TDs from this urb.
-* No other TD could have caused the halt.
-*/
- if (cc != TD_CC_NOERROR
- && (td->ed->hwHeadP & cpu_to_hc32 (ohci, ED_H)))
- td_rev = ed_halted (ohci, td, cc, td_rev);
-
- td->next_dl_td = td_rev;
- td_rev = td;
- td_dma = hc32_to_cpup (ohci, &td->hwNextTD);
- }
+
+ if (cc == TD_PIDCHECKFAIL || cc == TD_DEVNOTRESP) {
+ urbpriv = td->urb->hcpriv;
+
+ td->ed->hwHeadP &= ~cpu_to_hc32(ohci, ED_H);
+ td->hwINFO &= ~cpu_to_hc32(ohci, TD_CC);
+ td->hwINFO &= ~cpu_to_hc32(ohci, TD_EC);
+ urb = td->urb;
+ for (count = 0; count < urbpriv->length; count++) {
+ td = urbpriv->td[count];
+ if (td) {
+ list_del(&td->td_list);
+ td_dma =
+ hc32_to_cpup(ohci, &td->hwNextTD);
+ }
+ }
+ list_del(&urbpriv->pending);
+ td_submit_urb(ohci, urb);
+ } else {
+ /* Non-iso endpoints can halt on error; un-halt,
+* and dequeue any other TDs from this urb.
+* No other TD could have caused the halt.
+*/
+ if (cc != TD_CC_NOERROR &&
+ (td->ed->hwHeadP & cpu_to_hc32(ohci, ED_H)))
+ td_rev = ed_halted(ohci, td, cc, td_rev);
+
+ td->next_dl_td = td_rev;
+ td_rev = td;
+ td_dma = hc32_to_cpup(ohci, &td->hwNextTD);
+ }
+ }
return td_rev;
}
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Question about usb sg handling
Am Dienstag, 19. Juni 2007 schrieb Pete Zaitcev: > On Tue, 19 Jun 2007 09:26:15 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > > > The main problem is that the URB does not have an s/g list. If it > > > did, the whole library would be unnecessary. Nonetheless, we still > > > > And that from the man who complained about 24 more bytes in struct urb ;-) > > I think your irony falls flat. Why do you think I haven't submitted > a patch to add it yet? Of course there's always a tradeoff and linear > URBs served us well so far. I am merely stating the reason why the > library exists. But it hasn't. It can do a lot of things nobody needs and can't do things like scatter/gather that are needed. It allocates a lot of memory in every submission. It is too large because of unneeded features. It works, it doesn't work well. Regards Oliver - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] ALi M5273 not working reliably
Am Dienstag, 19. Juni 2007 schrieb Guillaume Bedot: > Hello, > > I've just tried a PCI to USB2 card with a "ALi M5273 A1" chip. > Transferring a big file (a few hundreds MB) to an USB stick fails. You are not the first to report a failure with ALi chips. > Is this chip supposed to be supported ? Yes. > Is there some sonfig trick to use ? No. > How can I help ? Does it fail with -EPROTO (-71) and a subsequent reset? Regards Oliver - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Question about usb sg handling
On Tue, 19 Jun 2007 09:26:15 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > The main problem is that the URB does not have an s/g list. If it > > did, the whole library would be unnecessary. Nonetheless, we still > > And that from the man who complained about 24 more bytes in struct urb ;-) I think your irony falls flat. Why do you think I haven't submitted a patch to add it yet? Of course there's always a tradeoff and linear URBs served us well so far. I am merely stating the reason why the library exists. -- Pete - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] FX2: Device not accepting address (dmesg/usbmon output incl.)
I solved this problem, not linux-specific at all, but figured I'll post the solution here anyways: The Cypress FX2LP chip has a pin labeled RESERVED, on my PCB this pin was left floating but should have been tied to GND (as per documentation). - Stephan > Hi, > > you get that message if nothing but the speed-resistor is connected to > the host. The host detects the presence of the resistor and thus expects > a device to be present. It then tries to enumerate it and that fails. > > You'd even get this message if you completely remove the FX2 from your > PCB ... > > Till > > Am Samstag 16 Juni 2007 schrieb Stephan Esterhuizen: > > I just finished a PCB design with the Cypress FX2LP (CY7C68013A-100AC). > > When I plug the device into a linux box, I get "device not accepting > > address" errors. > > > > Since this is such a simple interface: Power up FX2 and connect D+/D-/GND > > to host controller, I suspect that the problem might be with my D- and D+ > > traces, but would like other people's input. Please see below for dmesg > > and usbmon output. > > > > I have a few questions: > > > > 1) I tried decoding the setup packets but it is not a 'standard device > > request' but a 'class request', shouldn't it be the former or am I missing > > something? > > > > 2) Is the fx2lp actually working? I suspect it is because according to > > usbmon, the fx2lp responded to the first setup packet with: > > > > e89de2c0 1532923663 C Ci:001:00 0 4 = 01050100 > > > > 3) If the fx2lp is actually responding to usb requests, why is it not > > accepting the address the host is trying to assign to it? > > > > I have a slew of other fx2lp devices which all work, this is the first > > one that is on a custom PCB. When examining D-/D+ on a scope, things look > > fine. > > > > Any insight will be greatly appreciated. > > > > -- dmesg - > > Jun 13 13:29:15 toga2 kernel: usb 1-1: device not accepting address 15, > > error -71 > > Jun 13 13:29:15 toga2 kernel: usb 1-1: new full speed USB device using > > uhci_hcd and address 16 > > Jun 13 13:29:15 toga2 kernel: usb 1-1: uhci_result_common: failed with > > status 44 > > Jun 13 13:29:15 toga2 kernel: usb 1-1: uhci_result_common: failed with > > status 44 > > Jun 13 13:29:15 toga2 kernel: usb 1-1: device not accepting address 16, > > error -71 > > Jun 13 13:29:15 toga2 kernel: hub 1-0:1.0: state 7 ports 2 chg evt > > 0002 > > -- > > > > -- dmesg (high verbosity) - > > Jun 16 09:49:18 toga2 kernel: usb 1-1: uhci_result_common: failed with > > status 44 Jun 16 09:49:18 toga2 kernel: [f78f46c0] CTL QH link > > (378f4422) element (37dd5240) Jun 16 09:49:18 toga2 kernel: urb_priv > > [e37b4330] urb [f77ce1c0] qh [f78f46c0] Dev=0 EP=0(IN) CTL Actlen=0 Jun 16 > > 09:49:18 toga2 kernel: 1: [f7dd5240] link (37dd51b0) e0 Stalled > > CRC/Timeo Length=7 MaxLen=7 DT0 EndPt=0 Dev=0, PID=2d(SETUP) (buf=35e87d80) > > Jun 16 09:49:18 toga2 kernel: 2: [f7dd51b0] link (37dd51e0) e3 SPD > > Active Length=0 MaxLen=3f DT1 EndPt=0 Dev=0, PID=69(IN) (buf=37a53e80) Jun > > 16 09:49:18 toga2 kernel: 3: [f7dd51e0] link (37dd5270) e3 IOC Active > > Length=0 MaxLen=7ff DT1 EndPt=0 Dev=0, PID=e1(OUT) (buf=) Jun 16 > > 09:49:18 toga2 kernel: Dummy TD > > Jun 16 09:49:18 toga2 kernel: [f7dd5270] link (37dd51b0) e0 Length=0 > > MaxLen=7ff DT0 EndPt=0 Dev=0, PID=e1(OUT) (buf=) > > > > -- > > > > - usbmon - > > f7dd8840 1483781836 C Ii:001:01 0 2 = 0200 > > f7dd8840 1483781854 S Ii:001:01 -115 2 < > > e89deac0 1483781878 S Ci:001:00 s a3 00 0001 0004 4 < > > e89deac0 1483781892 C Ci:001:00 0 4 = 01050100 > > e89deac0 1483781897 S Co:001:00 s 23 01 0010 0001 0 > > e89deac0 1483781902 C Co:001:00 0 0 > > e89deac0 1483781909 S Ci:001:00 s a3 00 0001 0004 4 < > > e89deac0 1483781913 C Ci:001:00 0 4 = 0105 > > e89deac0 1483813891 S Ci:001:00 s a3 00 0001 0004 4 < > > e89deac0 1483813900 C Ci:001:00 0 4 = 0105 > > e89deac0 1483845835 S Ci:001:00 s a3 00 0001 0004 4 < > > e89deac0 1483845843 C Ci:001:00 0 4 = 0105 > > e89deac0 1483877834 S Ci:001:00 s a3 00 0001 0004 4 < > > e89deac0 1483877841 C Ci:001:00 0 4 = 0105 > > e89deac0 1483909898 S Ci:001:00 s a3 00 0001 0004 4 < > > e89deac0 1483909906 C Ci:001:00 0 4 = 0105 > > e89deac0 1483909927 S Co:001:00 s 23 03 0004 0001 0 > > e89deac0 1483909933 C Co:001:00 0 0 > > e89deac0 1483965835 S Ci:001:00 s a3 00 0001 0004 4 < > > e89deac0 1483966025 C Ci:001:00 0 4 = 1000 > > e89deac0 1483966030 S Co:001:00 s 23 01 0014 0001 0 > > e89deac0 1483966034 C Co:001:00 0 0 > > e89deac0 1483966038 S Co:001:00 s 23 01 0001 0001 0 > > e89deac0 1483966042 C Co:001:00 0 0 > > e89deac0 1483966050 S Co:001:00 s 23 01 0001 0001 0 > > e89deac0 1483966053 C Co:001:00 0 0 > > > > - > > > > And as an example of what usbmon displa
Re: [linux-usb-devel] Zonet ZUN2210
On 6/18/07, James Painter <[EMAIL PROTECTED]> wrote: > Jon Smirl wrote: > > Has anyone tried the Zonet ZUN2210 USB to Ethernet adapter? What > > chipset is it using? > > http://www.zonetusa.com/DispProduct.asp?ProductID=81 > > > > Googling doesn't give a conclusive answer if it works with Linux. > > > > Based on the vendor/product info in the windows driver .inf file, I'd > say it uses a moschip 7830 and the mcs7830 driver. Zonet ZUN2210 came in the mail today. It is a Moschip 7830 and works plug and play with the driver in the kernel. Where should this be recorded since the vendor doesn't claim the device supports Linux? I'll add a comment on Newegg. -- Jon Smirl [EMAIL PROTECTED] - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Error -71 on device descriptor read/all
On Tue, 19 Jun 2007, Oliver Neukum wrote: > Am Dienstag, 19. Juni 2007 schrieb Chuck Ebbert: > >> Try disabling CONFIG_USB_SUSPEND >> >> [usb developers: what are the drawbacks of doing this?] > > Increased power consumption. speaking of CONFIG_USB_SUSPEND, I've encountered at least one device -- a Canon EOS 5D camera -- that, after the bus suspends, must be powercycled in order to return the camera's interrupt endpoints to a functional state. How are these types of problems handled, currently? Is this something for a blacklist? - Paul - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[linux-usb-devel] ALi M5273 not working reliably
Hello, I've just tried a PCI to USB2 card with a "ALi M5273 A1" chip. Transferring a big file (a few hundreds MB) to an USB stick fails. Is this chip supposed to be supported ? Is there some sonfig trick to use ? How can I help ? Three things come to my mind. I can make some tests, or give / mail the card to someone who has interest in fixing this (or for the card ???), or throw it through a window. Other ideas are welcome. Best regards, Guillaume B. PS: i'm not a list subscriber. - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Error -71 on device descriptor read/all
Am Dienstag, 19. Juni 2007 schrieb Chuck Ebbert: > Try disabling CONFIG_USB_SUSPEND > > [usb developers: what are the drawbacks of doing this?] Increased power consumption. Regards Oliver - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Error -71 on device descriptor read/all
[ OK, it probably seems like a faulty hardware (controller or the device itself), which is not able to run at high speed, but runs nicely on full speed. Do you have a chance to try another high speed device in this machine to check whether it works? Adding linux-usb-devel into CC , just in case, and leaving the full original message below ] On Tue, 19 Jun 2007, Renato S. Yamane wrote: > Jiri Kosina wrote: > > On Tue, 19 Jun 2007, Renato S. Yamane wrote: > > > I see this in dmesg: > > > usb 1-1: device descriptor read/all, error -71 > > > > Is this a USB 2.0 high-speed device? > > lspci -v | grep 1d.7 > 00:1d.7 USB Controller: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) > USB2 EHCI Controller (rev 04) (prog-if 20 [EHCI]) > > My machine is a Laptop Toshiba M45-S355 > > > Don't you for example have USB extension cable too long to work on-high > > speed? > > My only USB device is a mouse (Microsoft Notebook Optical Mouse) without > extension cable (I use original cable, with less than 3 feets). > > > I guess the situation improves when you force USB 1.1 (i.e. rmmod ehci_hcd), > > right? > > #rmmode ehci_hcd > #tail /var/log/messages > > kernel: ehci_hcd :00:1d.7: remove, state 4 > kernel: usb usb5: USB disconnect, address 1 > kernel: ehci_hcd :00:1d.7: USB bus 5 deregistered > kernel: ACPI: PCI interrupt for device :00:1d.7 disabled > > I don't see any error (-71). > > #modprobe ehci_hcd > #tail /var/log/messages > kernel: ACPI: PCI Interrupt :00:1d.7[A] -> Link [LNKH] -> GSI 10 (level, > low) -> IRQ 10 > kernel: ehci_hcd :00:1d.7: EHCI Host Controller > kernel: ehci_hcd :00:1d.7: new USB bus registered, assigned bus number 5 > kernel: ehci_hcd :00:1d.7: debug port 1 > kernel: ehci_hcd :00:1d.7: irq 10, io mem 0xf400 > kernel: ehci_hcd :00:1d.7: USB 2.0 started, EHCI 1.00, driver 10 Dec > 2004 > kernel: usb usb5: configuration #1 chosen from 1 choice > kernel: hub 5-0:1.0: USB hub found > kernel: hub 5-0:1.0: 8 ports detected > kernel: usb 1-1: USB disconnect, address 4 > kernel: usb 1-1: new low speed USB device using uhci_hcd and address 5 > kernel: usb 1-1: configuration #1 chosen from 1 choice > kernel: input: Microsoft Microsoft 3-Button Mouse with IntelliEye? as > /class/input/input8 > kernel: input: USB HID v1.00 Mouse [Microsoft Microsoft 3-Button Mouse with > IntelliEye?] on usb-:00:1d.0-1 > > This error is present only in dmesg, see below (line 8): > > PCI: Setting latency timer of device :00:1d.7 to 64 > ehci_hcd :00:1d.7: EHCI Host Controller > ehci_hcd :00:1d.7: new USB bus registered, assigned bus number 5 > ehci_hcd :00:1d.7: debug port 1 > PCI: cache line size of 32 is not supported by device :00:1d.7 > ehci_hcd :00:1d.7: irq 10, io mem 0xf400 > ehci_hcd :00:1d.7: USB 2.0 started, EHCI 1.00, driver 10 Dec 2004 > usb 1-1: device descriptor read/all, error -71 > usb usb5: configuration #1 chosen from 1 choice > hub 5-0:1.0: USB hub found > hub 5-0:1.0: 8 ports detected > Clocksource tsc unstable (delta = -194969704 ns) > ACPI: PCI Interrupt Link [LNKG] enabled at IRQ 6 > PCI: setting IRQ 6 as level-triggered > > Best regards, > Renato > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Jiri Kosina - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] Error -71 on device descriptor read/all
On 06/19/2007 10:45 AM, Renato S. Yamane wrote: > Hi, > I see this in dmesg: > usb 1-1: device descriptor read/all, error -71 > > Using 2.6.21.1 > > Someone know what it is? > Try disabling CONFIG_USB_SUSPEND [usb developers: what are the drawbacks of doing this?] - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[linux-usb-devel] [PATCH] fsl_usb2_udc: fix bug for portsc bit masking
Fix a bug that PORT_TYPE and PORT_WIDTH aren't masked correctly in portsc.
Signed-off-by: Christopher Cason <[EMAIL PROTECTED]>
Signed-off-by: Li Yang <[EMAIL PROTECTED]>
---
drivers/usb/gadget/fsl_usb2_udc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/fsl_usb2_udc.c
b/drivers/usb/gadget/fsl_usb2_udc.c
index bb90a1d..36be6ee 100644
--- a/drivers/usb/gadget/fsl_usb2_udc.c
+++ b/drivers/usb/gadget/fsl_usb2_udc.c
@@ -228,7 +228,7 @@ static int dr_controller_setup(struct fsl_udc *udc)
/* Config PHY interface */
portctrl = fsl_readl(&dr_regs->portsc1);
- portctrl &= ~(PORTSCX_PHY_TYPE_SEL & PORTSCX_PORT_WIDTH);
+ portctrl &= ~(PORTSCX_PHY_TYPE_SEL | PORTSCX_PORT_WIDTH);
switch (udc->phy_mode) {
case FSL_USB2_PHY_ULPI:
portctrl |= PORTSCX_PTS_ULPI;
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] [usb-storage] Question about usb sg handling
Am Dienstag, 19. Juni 2007 schrieb Pete Zaitcev: > On Tue, 19 Jun 2007 11:11:18 +0800, "jidong xiao" <[EMAIL PROTECTED]> wrote: > > > But I remember, the reason we use sg is that, we can transfer > > several buffers in one DMA operation, thus we can speed things up > > accordingly because we turned multiple operations into a single DMA. > > That's the benefit. However, in above situation, we use sg, but we > > still perform multiple DMA operations, how to explain this? > > The main problem is that the URB does not have an s/g list. If it > did, the whole library would be unnecessary. Nonetheless, we still And that from the man who complained about 24 more bytes in struct urb ;-) If I understand your position correctly, you think that an URB should either have all bells and whistles regardless of its size or it should be lean and provide only the bare minimum. Just the current compromise is bad. Is that correct? Regards Oliver - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
