Re: [PATCH] iwlwifi: Move each system tracepoints to their own header
On Sun, Apr 12, 2015 at 8:37 PM, Emmanuel Grumbach wrote: > On Wed, Apr 8, 2015 at 10:44 AM, Johannes Berg > wrote: >> On Tue, 2015-04-07 at 12:13 -0400, Steven Rostedt wrote: >>> Every tracing file must have its own TRACE_SYSTEM defined. >>> The iwlwifi tracepoint header broke this and added in the middle >>> of the file: >> [...] >>> Unfortunately, this broke new code in the ftrace infrastructure. >>> Moving each of these TRACE_SYSTEMs into their own trace file with >>> just one TRACE_SYSTEM per file fixes the issue. >>> >>> Cc: Johannes Berg >>> Signed-off-by: Steven Rostedt >> >> >>> drivers/net/wireless/iwlwifi/iwl-devtrace-data.h | 79 >>> drivers/net/wireless/iwlwifi/iwl-devtrace-io.h | 155 >>> .../net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h| 200 ++ >>> drivers/net/wireless/iwlwifi/iwl-devtrace-msg.h| 97 + >>> drivers/net/wireless/iwlwifi/iwl-devtrace-ucode.h | 81 >>> drivers/net/wireless/iwlwifi/iwl-devtrace.h| 438 >>> + >>> 6 files changed, 618 insertions(+), 432 deletions(-) >>> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-data.h >>> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-io.h >>> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h >>> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-msg.h >>> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-ucode.h >> >> Looks good to me. >> >> Reviewed-by: Johannes Berg >> > > I had to make quite a few modifications since this patch was not based > on iwlwifi-next, but I picked it up in our internal tree. Wait - you seemed to want to apply that on your tree because of dependencies (which I can understand). So how do you suggest to proceed? You can apply your original version of the patch on your tree, but then it'll collapse when it'll meet iwlwifi-next.git. I can try to have the modified version of the patch into 4.1 but I doubt I'll make it. If I do make it, it'd allow you to work on top of 4.1 whenever that'll be ready? What is your timeline? Or maybe you can pull iwlwifi-next (which would be odd I have to say)? What do you suggest? FWIW - I am talking about: commit 7e1223b50089ab5901215d2fd8c61b42c7cfe034 Author: Emmanuel Grumbach Date: Tue Feb 3 20:11:48 2015 +0200 iwlwifi: mvm: new Alive / error table API The new API slightly changes the layout of the version of the firmware - prepare for that. Signed-off-by: Emmanuel Grumbach -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
http://worldfreedom.ch/
http://worldfreedom.ch/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: DRIVER FOR INTEL2200BG
Hi,
On Mon, Apr 13, 2015 at 10:39 AM, J.H. Schmidt wrote:
> My IBM(Lenovo) laptop running XP crashed a year ago and I changed to Lupuplus
> which
> runs on RAM.No problems with older Sprint modem and D link router running Wi
> Fi.Enter
> a nearby lightning strike which killed the router.Century link gave us a new
> modem router
> combo which works fine with with 2 computes r running 7 and 2 IMacs.I can't
> get the
> Linux machine to work with the new Century Link combo modem router-Any ideas?
I'm not sure I understand your problem.
1. You're running some RAM based Linux distro on your Thinkpad
2. It has an Intel 2200bg card
3. You've gotten a new router
4. Now it doesn't connect
If you were connecting to the old router using WiFi, your card is
already working.
I'm guessing your new router is much newer than the old one. Is it an
"n" router? (I.e. supports 802.11n, WiFi speeds above 54Mbit/s) Some
of them default to "n" only operation and need a setting turned on to
allow "b" or "g" devices to connect.
I'd investigate the settings of the router and ensure that
compatibility for older ("g") devices is turned on.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull-request: mac80211-next 2015-04-10
From: Johannes Berg Date: Fri, 10 Apr 2015 13:18:58 +0200 > I realize it's late, but what I've got right now has so many fixes that > I'd be sending even after the merge window, so it felt like there was > little point in holding it up until after then. The new "intermediate > queue" feature is unused right now so seems safe enough also, and having > it in will help modify drivers to use it. > There's also some rate control refactoring that, as far as I can tell, > is uncontroversial and over the last couple of weeks has been has been > reviewed and tested by people who use it, so I'm including it. > > Let me know if you want me to change anything here or if there are any > other problems. Pulled, thanks Johannes. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
DRIVER FOR INTEL2200BG
My IBM(Lenovo) laptop running XP crashed a year ago and I changed to Lupuplus which runs on RAM.No problems with older Sprint modem and D link router running Wi Fi.Enter a nearby lightning strike which killed the router.Century link gave us a new modem router combo which works fine with with 2 computes r running 7 and 2 IMacs.I can't get the Linux machine to work with the new Century Link combo modem router-Any ideas?-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/5 v4] netfilter: Fix format string of nfnetlink_log proc file
The printed values are all of type unsigned integer, therefore use
%u instead of %d. Otherwise an user can face negative values.
Signed-off-by: Richard Weinberger
---
net/netfilter/nfnetlink_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index 5c79735..3ad9126 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -1007,7 +1007,7 @@ static int seq_show(struct seq_file *s, void *v)
{
const struct nfulnl_instance *inst = v;
- seq_printf(s, "%5d %6d %5d %1d %5d %6d %2d\n",
+ seq_printf(s, "%5u %6u %5u %1u %5u %6u %2u\n",
inst->group_num,
inst->peer_portid, inst->qlen,
inst->copy_mode, inst->copy_range,
--
1.8.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/5 v4] netlink: Fix portid type in netlink_notify
portid is an unsigned integer. Fix netlink_notify to
match all other portid user in the kernel.
Signed-off-by: Richard Weinberger
---
include/linux/netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netlink.h b/include/linux/netlink.h
index 02fc86d..6835c12 100644
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -134,7 +134,7 @@ struct netlink_callback {
struct netlink_notify {
struct net *net;
- int portid;
+ u32 portid;
int protocol;
};
--
1.8.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/5 v4] netfilter: Fix format string of nfnetlink_queue proc file
The printed values are all of type unsigned integer, therefore use
%u instead of %d. Otherwise an user can face negative values.
Fixes:
$ cat /proc/net/netfilter/nfnetlink_queue
0 29508 278 2 65531 0 2004213241 -2129885586 1
1 -27747 0 2 65531 0 00 1
2 -27748 0 2 65531 0 00 1
Signed-off-by: Richard Weinberger
---
net/netfilter/nfnetlink_queue_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nfnetlink_queue_core.c
b/net/netfilter/nfnetlink_queue_core.c
index 49267f8..0b98c74 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -1251,7 +1251,7 @@ static int seq_show(struct seq_file *s, void *v)
{
const struct nfqnl_instance *inst = v;
- seq_printf(s, "%5d %6d %5d %1d %5d %5d %5d %8d %2d\n",
+ seq_printf(s, "%5u %6u %5u %1u %5u %5u %5u %8u %2d\n",
inst->queue_num,
inst->peer_portid, inst->queue_total,
inst->copy_mode, inst->copy_range,
--
1.8.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/5 v4] netfilter: Fix portid types
The netlink portid is an unsigned integer, use this type
also in netfilter.
Signed-off-by: Richard Weinberger
---
net/netfilter/nfnetlink_log.c| 4 ++--
net/netfilter/nfnetlink_queue_core.c | 7 +++
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index 51afea4..5c79735 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -63,7 +63,7 @@ struct nfulnl_instance {
struct timer_list timer;
struct net *net;
struct user_namespace *peer_user_ns;/* User namespace of the peer
process */
- int peer_portid;/* PORTID of the peer process */
+ u32 peer_portid;/* PORTID of the peer process */
/* configurable parameters */
unsigned int flushtimeout; /* timeout until queue flush */
@@ -152,7 +152,7 @@ static void nfulnl_timer(unsigned long data);
static struct nfulnl_instance *
instance_create(struct net *net, u_int16_t group_num,
- int portid, struct user_namespace *user_ns)
+ u32 portid, struct user_namespace *user_ns)
{
struct nfulnl_instance *inst;
struct nfnl_log_net *log = nfnl_log_pernet(net);
diff --git a/net/netfilter/nfnetlink_queue_core.c
b/net/netfilter/nfnetlink_queue_core.c
index 628afc3..49267f8 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -55,7 +55,7 @@ struct nfqnl_instance {
struct hlist_node hlist;/* global list of queues */
struct rcu_head rcu;
- int peer_portid;
+ u32 peer_portid;
unsigned int queue_maxlen;
unsigned int copy_range;
unsigned int queue_dropped;
@@ -110,8 +110,7 @@ instance_lookup(struct nfnl_queue_net *q, u_int16_t
queue_num)
}
static struct nfqnl_instance *
-instance_create(struct nfnl_queue_net *q, u_int16_t queue_num,
- int portid)
+instance_create(struct nfnl_queue_net *q, u_int16_t queue_num, u32 portid)
{
struct nfqnl_instance *inst;
unsigned int h;
@@ -870,7 +869,7 @@ static const struct nla_policy
nfqa_verdict_batch_policy[NFQA_MAX+1] = {
};
static struct nfqnl_instance *
-verdict_instance_lookup(struct nfnl_queue_net *q, u16 queue_num, int nlportid)
+verdict_instance_lookup(struct nfnl_queue_net *q, u16 queue_num, u32 nlportid)
{
struct nfqnl_instance *queue;
--
1.8.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/5 v4] nfc: Fix portid type in urelease_work
portid is an unsigned integer. Fix urelease_work to
match all other portid user in the kernel.
Signed-off-by: Richard Weinberger
---
net/nfc/netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 14a2d11..3763036 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -1584,7 +1584,7 @@ static const struct genl_ops nfc_genl_ops[] = {
struct urelease_work {
struct work_struct w;
- int portid;
+ u32 portid;
};
static void nfc_urelease_event_work(struct work_struct *work)
--
1.8.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] iwlwifi: Move each system tracepoints to their own header
On Wed, Apr 8, 2015 at 10:44 AM, Johannes Berg wrote: > On Tue, 2015-04-07 at 12:13 -0400, Steven Rostedt wrote: >> Every tracing file must have its own TRACE_SYSTEM defined. >> The iwlwifi tracepoint header broke this and added in the middle >> of the file: > [...] >> Unfortunately, this broke new code in the ftrace infrastructure. >> Moving each of these TRACE_SYSTEMs into their own trace file with >> just one TRACE_SYSTEM per file fixes the issue. >> >> Cc: Johannes Berg >> Signed-off-by: Steven Rostedt > > >> drivers/net/wireless/iwlwifi/iwl-devtrace-data.h | 79 >> drivers/net/wireless/iwlwifi/iwl-devtrace-io.h | 155 >> .../net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h| 200 ++ >> drivers/net/wireless/iwlwifi/iwl-devtrace-msg.h| 97 + >> drivers/net/wireless/iwlwifi/iwl-devtrace-ucode.h | 81 >> drivers/net/wireless/iwlwifi/iwl-devtrace.h| 438 >> + >> 6 files changed, 618 insertions(+), 432 deletions(-) >> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-data.h >> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-io.h >> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h >> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-msg.h >> create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-ucode.h > > Looks good to me. > > Reviewed-by: Johannes Berg > I had to make quite a few modifications since this patch was not based on iwlwifi-next, but I picked it up in our internal tree. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V2] rtlwifi: misspelled code and comments corrected.
Signed-off-by: Cheolhyun Park
---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index f5ee67c..1273997 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct
ieee80211_hw *hw)
struct dig_t *digtable = &rtlpriv->dm_digtable;
u32 isbt;
- /* modify DIG lower bound, deal with abnorally large false alarm */
+ /* modify DIG lower bound, deal with abnormally large false alarm */
if (rtlpriv->falsealm_cnt.cnt_all > 1) {
digtable->large_fa_hit++;
if (digtable->forbidden_igi < digtable->cur_igvalue) {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
index a1be5a6..f209cda 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
@@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
"dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
de_digtable->recover_cnt, de_digtable->rx_gain_min);
- /* deal with abnorally large false alarm */
+ /* deal with abnormally large false alarm */
if (falsealm_cnt->cnt_all > 1) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
"dm_DIG(): Abnormally false alarm case\n");
diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
index 0b2082d..342678d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
@@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
if (rtlpriv->falsealm_cnt.cnt_all > 1) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
-"Abnornally false alarm case.\n");
+"Abnormally false alarm case.\n");
if (dm_digtable->large_fa_hit != 3)
dm_digtable->large_fa_hit++;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] rtlwifi: misspelled code and comments corrected.
On 04/12/2015 11:04 AM, Cheolhyun Park wrote:
Signed-off-by: Cheolhyun Park
When you send a corrected patch, it is common to indicate that this is a
corrected patch by putting the version number inside the [] in the subject, and
to indicate the changes inside the patch, but after the --- line. Neither of
these annotations will be included in the commit message, but they help the
maintainer keep track of the patch, and whether you have satisfied the
reviewer's comments. Thus this patch should have had the subject "[PATCH V2]
rtlwifi: ..." and you should have had the lines below after the ---:
---
V2 - Fixed the typo introduced in V1 as noted by Julia Lawall.
---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index f5ee67c..1273997 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct
ieee80211_hw *hw)
struct dig_t *digtable = &rtlpriv->dm_digtable;
u32 isbt;
- /* modify DIG lower bound, deal with abnorally large false alarm */
+ /* modify DIG lower bound, deal with abnormally large false alarm */
if (rtlpriv->falsealm_cnt.cnt_all > 1) {
digtable->large_fa_hit++;
if (digtable->forbidden_igi < digtable->cur_igvalue) {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
index a1be5a6..f209cda 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
@@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
"dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
de_digtable->recover_cnt, de_digtable->rx_gain_min);
- /* deal with abnorally large false alarm */
+ /* deal with abnormally large false alarm */
if (falsealm_cnt->cnt_all > 1) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
"dm_DIG(): Abnormally false alarm case\n");
diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
index 0b2082d..342678d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
@@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
if (rtlpriv->falsealm_cnt.cnt_all > 1) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
-"Abnornally false alarm case.\n");
+"Abnormally false alarm case.\n");
if (dm_digtable->large_fa_hit != 3)
dm_digtable->large_fa_hit++;
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] rtlwifi: misspelled code and comments corrected.
Signed-off-by: Cheolhyun Park
---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index f5ee67c..1273997 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct
ieee80211_hw *hw)
struct dig_t *digtable = &rtlpriv->dm_digtable;
u32 isbt;
- /* modify DIG lower bound, deal with abnorally large false alarm */
+ /* modify DIG lower bound, deal with abnormally large false alarm */
if (rtlpriv->falsealm_cnt.cnt_all > 1) {
digtable->large_fa_hit++;
if (digtable->forbidden_igi < digtable->cur_igvalue) {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
index a1be5a6..f209cda 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
@@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
"dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
de_digtable->recover_cnt, de_digtable->rx_gain_min);
- /* deal with abnorally large false alarm */
+ /* deal with abnormally large false alarm */
if (falsealm_cnt->cnt_all > 1) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
"dm_DIG(): Abnormally false alarm case\n");
diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
index 0b2082d..342678d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
@@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
if (rtlpriv->falsealm_cnt.cnt_all > 1) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
-"Abnornally false alarm case.\n");
+"Abnormally false alarm case.\n");
if (dm_digtable->large_fa_hit != 3)
dm_digtable->large_fa_hit++;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] rtlwifi: misspelled code and comments corrected.
On Sun, 12 Apr 2015, Cheolhyun Park wrote:
> Signed-off-by: Cheolhyun Park
> ---
> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> index f5ee67c..1273997 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> @@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct
> ieee80211_hw *hw)
> struct dig_t *digtable = &rtlpriv->dm_digtable;
> u32 isbt;
>
> - /* modify DIG lower bound, deal with abnorally large false alarm */
> + /* modify DIG lower bound, deal with abnormally arge false alarm */
You have converted large to arge.
julia
> if (rtlpriv->falsealm_cnt.cnt_all > 1) {
> digtable->large_fa_hit++;
> if (digtable->forbidden_igi < digtable->cur_igvalue) {
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> index a1be5a6..f209cda 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> @@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
>"dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
>de_digtable->recover_cnt, de_digtable->rx_gain_min);
>
> - /* deal with abnorally large false alarm */
> + /* deal with abnormally large false alarm */
> if (falsealm_cnt->cnt_all > 1) {
> RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
>"dm_DIG(): Abnormally false alarm case\n");
> diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> index 0b2082d..342678d 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> @@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
>
> if (rtlpriv->falsealm_cnt.cnt_all > 1) {
> RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
> - "Abnornally false alarm case.\n");
> + "Abnormally false alarm case.\n");
>
> if (dm_digtable->large_fa_hit != 3)
> dm_digtable->large_fa_hit++;
> --
> 1.9.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] rtlwifi: misspelled code and comments corrected.
Signed-off-by: Cheolhyun Park
---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index f5ee67c..1273997 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct
ieee80211_hw *hw)
struct dig_t *digtable = &rtlpriv->dm_digtable;
u32 isbt;
- /* modify DIG lower bound, deal with abnorally large false alarm */
+ /* modify DIG lower bound, deal with abnormally arge false alarm */
if (rtlpriv->falsealm_cnt.cnt_all > 1) {
digtable->large_fa_hit++;
if (digtable->forbidden_igi < digtable->cur_igvalue) {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
index a1be5a6..f209cda 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
@@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
"dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
de_digtable->recover_cnt, de_digtable->rx_gain_min);
- /* deal with abnorally large false alarm */
+ /* deal with abnormally large false alarm */
if (falsealm_cnt->cnt_all > 1) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
"dm_DIG(): Abnormally false alarm case\n");
diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
index 0b2082d..342678d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
@@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
if (rtlpriv->falsealm_cnt.cnt_all > 1) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
-"Abnornally false alarm case.\n");
+"Abnormally false alarm case.\n");
if (dm_digtable->large_fa_hit != 3)
dm_digtable->large_fa_hit++;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
