date:20150622

RE: [PATCH 2/3] ath9k: make rxfilter per HW

2015-06-22 Thread Otcheretianski, Andrei

> -Original Message-
> From: Johannes Berg [mailto:johan...@sipsolutions.net]
> Sent: Monday, June 22, 2015 15:00
> To: Janusz Dziedzic
> Cc: linux-wireless@vger.kernel.org; ath9k-de...@venema.h4ckr.net;
> n...@openwrt.org; suj...@msujith.org; Otcheretianski, Andrei
> Subject: Re: [PATCH 2/3] ath9k: make rxfilter per HW
> 
> On Mon, 2015-06-22 at 13:58 +0200, Johannes Berg wrote:
> > On Mon, 2015-06-22 at 13:43 +0200, Janusz Dziedzic wrote:
> > > mac80211 configure rxfilter per HW,
> > > so we don't need this per channel.
> >
> > As I said before, I think there's value in mac80211 doing it per
> > chanctx or even per vif, and it should be more efficient to do so.
> >
> > It's tempting to do it per vif and leave the chanctx work up to the
> > driver, but perhaps with CSA and all that it gets complicated enough
> > that doing it per chanctx in mac80211 would make sense?

I don't think that it makes sense to do it per chanctx in mac80211.
The cfg80211 API to configure filter isn't aware about chanctx's and also
vifs that share same chanctx may have different filters etc..

Andrei
> 
> On the other hand, I think our device requires it per vif, so we'd probably
> have to do both.
> 
> +Andrei, who was looking into this.
> 
> johannes

N�r��yb�X��ǧv�^�)޺{.n�+{��*ޕ�,�

Re: [PATCH v2 8/8] ath10k: configure frag desc memory to target for qca99X0

2015-06-22 Thread rmani


On 06/23/2015 05:11 AM, Peter Oh wrote:

Hi Raja,

On 06/22/2015 07:52 AM, Raja Mani wrote:

Pre qca99X0 chipsets follows the model where dynamically allocate
memory for frag desc on getting new skb for TX. But, this is not
going to be the case in qca99X0. It expects frag desc memory to be
allocated at boot time and let the driver to reuse allocated memory
after every TX completion. So there won't be any dynamic frag memory
memory allocation in qca99X0 during data transmission.

qca99X0 hardware doesn't need fragment desc address to be programmed
in msdu descriptor for every data transaction. It needs to know only
starting address of fragment descriptor at the time of the boot.
During data transmission, qca99X0 hardware can retrieve corresponding
frag addr by adding programmed frag desc base addr + msdu id.

Allocate continuous fragment descriptor memory (same size as number of
descriptor) at the time of target initialization and configure allocated
dma address to the target via HTT_H2T_MSG_TYPE_FRAG_DESC_BANK_CFG.

How this is allocated continuous memory is going to be used is not
covered in this patch. It just allocates memory and hand over to
firmware.
If we don't do it at init time, qca99X0 will stall when firmware tries
to do TX.

Signed-off-by: Raja Mani 
---
  drivers/net/wireless/ath/ath10k/core.c   |  1 +
  drivers/net/wireless/ath/ath10k/core.h   |  6 +++
  drivers/net/wireless/ath/ath10k/htt.c|  4 ++
  drivers/net/wireless/ath/ath10k/htt.h| 11 +
  drivers/net/wireless/ath/ath10k/htt_tx.c | 76
+++-
  5 files changed, 96 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/core.c
b/drivers/net/wireless/ath/ath10k/core.c
index 3c8d5c5..be5f01c 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -111,6 +111,7 @@ static const struct ath10k_hw_params
ath10k_hw_params_list[] = {
  .patch_load_addr = QCA99X0_HW_2_0_PATCH_LOAD_ADDR,
  .uart_pin = 7,
  .otp_exe_param = 0x0700,
+.continuous_frag_desc = true,
  .fw = {
  .dir = QCA99X0_HW_2_0_FW_DIR,
  .fw = QCA99X0_HW_2_0_FW_FILE,
diff --git a/drivers/net/wireless/ath/ath10k/core.h
b/drivers/net/wireless/ath/ath10k/core.h
index f0811d0..2e5c935 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -582,6 +582,12 @@ struct ath10k {
   */
  bool has_shifted_cc_wraparound;
+/* Some of chip expects fragment descriptor to be
continuous
+ * memory for any TX operation. Set continuous_frag_desc
flag
+ * for the hardware which have such requirement.
+ */
+bool continuous_frag_desc;
+
  struct ath10k_hw_params_fw {
  const char *dir;
  const char *fw;
diff --git a/drivers/net/wireless/ath/ath10k/htt.c
b/drivers/net/wireless/ath/ath10k/htt.c
index 6f71f94..4474c3e 100644
--- a/drivers/net/wireless/ath/ath10k/htt.c
+++ b/drivers/net/wireless/ath/ath10k/htt.c
@@ -249,5 +249,9 @@ int ath10k_htt_setup(struct ath10k_htt *htt)
  if (status)
  return status;
+status = ath10k_htt_send_frag_desc_bank_cfg(htt);
+if (status)
+return status;
+
  return ath10k_htt_send_rx_ring_cfg_ll(htt);
  }
diff --git a/drivers/net/wireless/ath/ath10k/htt.h
b/drivers/net/wireless/ath/ath10k/htt.h
index 8e64ace..8bdf1e7 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -87,6 +87,11 @@ struct htt_data_tx_desc_frag {
  __le32 len;
  } __packed;
+struct htt_msdu_ext_desc {
+__le32 tso_flag[4];
+struct htt_data_tx_desc_frag frags[6];
+};
+
  enum htt_data_tx_desc_flags0 {
  HTT_DATA_TX_DESC_FLAGS0_MAC_HDR_PRESENT = 1 << 0,
  HTT_DATA_TX_DESC_FLAGS0_NO_AGGR = 1 << 1,
@@ -1466,6 +1471,11 @@ struct ath10k_htt {
  /* rx_status template */
  struct ieee80211_rx_status rx_status;
+
+struct {
+dma_addr_t paddr;
+struct htt_msdu_ext_desc *vaddr;

Defining structure htt_msdu_ext_desc for vaddr instead of void * which
will be used as base address to get offset address of msdu data could
lead unexpected address assignment when we manipulate msdu address
pointer based on vaddr variable.
For example vaddr variable will be used at ath10k_htt_tx like below to
have msdu external link descriptor.
struct htt_msdu_ext_desc *frags_ext;
frags_ext = htt->frag_desc.vaddr + (sizeof(struct htt_msdu_ext_desc) *
msdu_id);
If we assume vaddr is 0xde81 and msdu_id is 1, we expect frags_ext
has 0xde810040, but linux memory management system could assign
0xde811000 to frags_ext to use continuous memory block for structure
htt_msdu_ext_desc and it will cause data traffic failure.
To avoid this scenario, we have to use void * for vaddr.



Here we know the type of memory what for we are allocating, thats why
i kept it as struct htt_msdu_ext_desc *. We can type cast base addr
to u8 * i

[PATCH 1/4] staging: wilc1000: wilc_wfi_netdevice.c: remove commented codes

2015-06-22 Thread Chaehyun Lim

Remove commented codes.

Signed-off-by: Chaehyun Lim 
---
 drivers/staging/wilc1000/wilc_wfi_netdevice.c | 21 -
 1 file changed, 21 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c 
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
index 170ca65..478cd2b 100644
--- a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
+++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
@@ -325,7 +325,6 @@ void WILC_WFI_Rx(struct net_device *dev, struct 
WILC_WFI_packet *pkt)
PRINT_INFO(RX_DBG, "In monitor device name %s\n", dev->name);
priv = wiphy_priv(priv->dev->ieee80211_ptr->wiphy);
PRINT_D(RX_DBG, "VALUE PASSED IN OF HRWD %p\n", 
priv->hWILCWFIDrv);
-   /* host_int_get_rssi(priv->hWILCWFIDrv, &(rssi)); */
if (INFO) {
for (i = 14; i < skb->len; i++)
PRINT_INFO(RX_DBG, "RXdata[%d] %02x\n", i, 
skb->data[i]);
@@ -600,12 +599,6 @@ int WILC_WFI_Tx(struct sk_buff *skb, struct net_device 
*dev)
char *data, shortpkt[ETH_ZLEN];
struct WILC_WFI_priv *priv = netdev_priv(dev);
 
-   /* priv = wiphy_priv(priv->dev->ieee80211_ptr->wiphy); */
-
-   /*  if(priv->monitor_flag) */
-   /*   mac80211_hwsim_monitor_rx(skb); */
-
-
data = skb->data;
len = skb->len;
 
@@ -836,12 +829,6 @@ void WILC_WFI_Cleanup(void)
int i;
struct WILC_WFI_priv *priv[2];
 
-   /*if(hwsim_mon!=NULL)
-* {
-*  PRINT_D(RX_DBG, "Freeing monitor interface\n");
-*  unregister_netdev(hwsim_mon);
-*  free_netdev(hwsim_mon);
-* }*/
for (i = 0; i < 2; i++) {
priv[i] = netdev_priv(WILC_WFI_devs[i]);
 
@@ -897,7 +884,6 @@ int WILC_WFI_InitModule(void)
WILC_WFI_Init);
if (WILC_WFI_devs[i] == NULL)
goto out;
-   /* priv[i] = netdev_priv(WILC_WFI_devs[i]); */
 
wdev = WILC_WFI_WiphyRegister(WILC_WFI_devs[i]);
WILC_WFI_devs[i]->ieee80211_ptr = wdev;
@@ -921,9 +907,6 @@ int WILC_WFI_InitModule(void)
priv[1] = netdev_priv(WILC_WFI_devs[1]);
 
if (priv[1]->dev->ieee80211_ptr->wiphy->interface_modes && 
BIT(NL80211_IFTYPE_MONITOR)) {
-   /* snprintf(buf, IFNAMSIZ, "mon.%s",  priv[1]->dev->name); */
-   /*  WILC_WFI_init_mon_interface(); */
-   /*  priv[1]->monitor_flag = 1; */
 
}
priv[0]->bCfgScanning = false;
@@ -931,10 +914,6 @@ int WILC_WFI_InitModule(void)
 
WILC_memset(priv[0]->au8AssociatedBss, 0xFF, ETH_ALEN);
 
-
-   /* ret = host_int_init(&priv[0]->hWILCWFIDrv); */
-   /*copy handle to the other driver*/
-   /* priv[1]->hWILCWFIDrv = priv[0]->hWILCWFIDrv; */
if (ret)
PRINT_ER("Error Init Driver\n");
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

[PATCH 2/4] staging: wilc1000: wilc_wfi_netdevice.c: remove unused codes

2015-06-22 Thread Chaehyun Lim

Remove if statement that has no any codes.

Signed-off-by: Chaehyun Lim 
---
 drivers/staging/wilc1000/wilc_wfi_netdevice.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c 
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
index 478cd2b..d5facb4 100644
--- a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
+++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
@@ -906,9 +906,6 @@ int WILC_WFI_InitModule(void)
priv[0] = netdev_priv(WILC_WFI_devs[0]);
priv[1] = netdev_priv(WILC_WFI_devs[1]);
 
-   if (priv[1]->dev->ieee80211_ptr->wiphy->interface_modes && 
BIT(NL80211_IFTYPE_MONITOR)) {
-
-   }
priv[0]->bCfgScanning = false;
priv[0]->u32RcvdChCount = 0;
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

[PATCH 4/4] staging: wilc1000: wilc_wfi_netdevice.c: remove blank lines

2015-06-22 Thread Chaehyun Lim

Remove multiple blank lines.

Signed-off-by: Chaehyun Lim 
---
 drivers/staging/wilc1000/wilc_wfi_netdevice.c | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c 
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
index c2e92c0..af9b858 100644
--- a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
+++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
@@ -12,11 +12,9 @@
 #include "wilc_wfi_cfgoperations.h"
 #include "host_interface.h"
 
-
 MODULE_AUTHOR("Mai Daftedar");
 MODULE_LICENSE("Dual BSD/GPL");
 
-
 struct net_device *WILC_WFI_devs[2];
 
 /*
@@ -34,7 +32,6 @@ module_param(timeout, int, 0);
 static int use_napi;
 module_param(use_napi, int, 0);
 
-
 /*
  * A structure representing an in-flight packet.
  */
@@ -45,12 +42,9 @@ struct WILC_WFI_packet {
u8 data[ETH_DATA_LEN];
 };
 
-
-
 int pool_size = 8;
 module_param(pool_size, int, 0);
 
-
 static void WILC_WFI_TxTimeout(struct net_device *dev);
 static void (*WILC_WFI_Interrupt)(int, void *, struct pt_regs *);
 
@@ -252,7 +246,6 @@ int WILC_WFI_Open(struct net_device *dev)
 int WILC_WFI_Release(struct net_device *dev)
 {
/* release ports, irq and such -- like fops->close */
-
netif_stop_queue(dev); /* can't transmit any more */
 
return 0;
@@ -512,7 +505,6 @@ void WILC_WFI_HwTx(char *buf, int len, struct net_device 
*dev)
u32 *saddr, *daddr;
struct WILC_WFI_packet *tx_buffer;
 
-
/* I am paranoid. Ain't I? */
if (len < sizeof(struct ethhdr) + sizeof(struct iphdr)) {
PRINT_D(RX_DBG, "WILC_WFI: Hmm... packet too short (%i 
octets)\n",
@@ -580,7 +572,6 @@ void WILC_WFI_HwTx(char *buf, int len, struct net_device 
*dev)
(unsigned long) priv->stats.tx_packets);
} else
WILC_WFI_Interrupt(0, dev, NULL);
-
 }
 
 /**
@@ -785,7 +776,6 @@ void WILC_WFI_Init(struct net_device *dev)
 {
struct WILC_WFI_priv *priv;
 
-
/*
 * Then, assign other fields in dev, using ether_setup() and some
 * hand assignments
@@ -851,12 +841,6 @@ void WILC_WFI_Cleanup(void)
 
 void StartConfigSim(void);
 
-
-
-
-
-
-
 /**
  *  @brief  WILC_WFI_Stat
  *  @detailsReturn statistics to the caller
@@ -877,7 +861,6 @@ int WILC_WFI_InitModule(void)
WILC_WFI_Interrupt = use_napi ? WILC_WFI_NapiInterrupt : 
WILC_WFI_RegularInterrupt;
 
for (i = 0; i < 2; i++) {
-
/* Allocate the net devices */
WILC_WFI_devs[i] = alloc_netdev(sizeof(struct WILC_WFI_priv), 
"wlan%d",
WILC_WFI_Init);
@@ -900,7 +883,6 @@ int WILC_WFI_InitModule(void)
ret = 0;
}
 
-
/*init atmel driver */
priv[0] = netdev_priv(WILC_WFI_devs[0]);
priv[1] = netdev_priv(WILC_WFI_devs[1]);
@@ -921,7 +903,6 @@ out:
 
 }
 
-
 module_init(WILC_WFI_InitModule);
 module_exit(WILC_WFI_Cleanup);
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

[PATCH 3/4] staging: wilc1000: wilc_wfi_netdevice.c: remove unused variable

2015-06-22 Thread Chaehyun Lim

Remove variable that is defined but never used.

Signed-off-by: Chaehyun Lim 
---
 drivers/staging/wilc1000/wilc_wfi_netdevice.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c 
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
index d5facb4..c2e92c0 100644
--- a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
+++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
@@ -873,7 +873,6 @@ int WILC_WFI_InitModule(void)
int result, i, ret = -ENOMEM;
struct WILC_WFI_priv *priv[2], *netpriv;
struct wireless_dev *wdev;
-   char buf[IFNAMSIZ];
 
WILC_WFI_Interrupt = use_napi ? WILC_WFI_NapiInterrupt : 
WILC_WFI_RegularInterrupt;
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

Re: [PATCH v2 8/8] ath10k: configure frag desc memory to target for qca99X0

2015-06-22 Thread Peter Oh


Hi Raja,

On 06/22/2015 07:52 AM, Raja Mani wrote:

Pre qca99X0 chipsets follows the model where dynamically allocate
memory for frag desc on getting new skb for TX. But, this is not
going to be the case in qca99X0. It expects frag desc memory to be
allocated at boot time and let the driver to reuse allocated memory
after every TX completion. So there won't be any dynamic frag memory
memory allocation in qca99X0 during data transmission.

qca99X0 hardware doesn't need fragment desc address to be programmed
in msdu descriptor for every data transaction. It needs to know only
starting address of fragment descriptor at the time of the boot.
During data transmission, qca99X0 hardware can retrieve corresponding
frag addr by adding programmed frag desc base addr + msdu id.

Allocate continuous fragment descriptor memory (same size as number of
descriptor) at the time of target initialization and configure allocated
dma address to the target via HTT_H2T_MSG_TYPE_FRAG_DESC_BANK_CFG.

How this is allocated continuous memory is going to be used is not
covered in this patch. It just allocates memory and hand over to firmware.
If we don't do it at init time, qca99X0 will stall when firmware tries
to do TX.

Signed-off-by: Raja Mani 
---
  drivers/net/wireless/ath/ath10k/core.c   |  1 +
  drivers/net/wireless/ath/ath10k/core.h   |  6 +++
  drivers/net/wireless/ath/ath10k/htt.c|  4 ++
  drivers/net/wireless/ath/ath10k/htt.h| 11 +
  drivers/net/wireless/ath/ath10k/htt_tx.c | 76
+++-
  5 files changed, 96 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/core.c
b/drivers/net/wireless/ath/ath10k/core.c
index 3c8d5c5..be5f01c 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -111,6 +111,7 @@ static const struct ath10k_hw_params
ath10k_hw_params_list[] = {
.patch_load_addr = QCA99X0_HW_2_0_PATCH_LOAD_ADDR,
.uart_pin = 7,
.otp_exe_param = 0x0700,
+   .continuous_frag_desc = true,
.fw = {
.dir = QCA99X0_HW_2_0_FW_DIR,
.fw = QCA99X0_HW_2_0_FW_FILE,
diff --git a/drivers/net/wireless/ath/ath10k/core.h
b/drivers/net/wireless/ath/ath10k/core.h
index f0811d0..2e5c935 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -582,6 +582,12 @@ struct ath10k {
 */
bool has_shifted_cc_wraparound;
  
+		/* Some of chip expects fragment descriptor to be

continuous
+* memory for any TX operation. Set continuous_frag_desc
flag
+* for the hardware which have such requirement.
+*/
+   bool continuous_frag_desc;
+
struct ath10k_hw_params_fw {
const char *dir;
const char *fw;
diff --git a/drivers/net/wireless/ath/ath10k/htt.c
b/drivers/net/wireless/ath/ath10k/htt.c
index 6f71f94..4474c3e 100644
--- a/drivers/net/wireless/ath/ath10k/htt.c
+++ b/drivers/net/wireless/ath/ath10k/htt.c
@@ -249,5 +249,9 @@ int ath10k_htt_setup(struct ath10k_htt *htt)
if (status)
return status;
  
+	status = ath10k_htt_send_frag_desc_bank_cfg(htt);

+   if (status)
+   return status;
+
return ath10k_htt_send_rx_ring_cfg_ll(htt);
  }
diff --git a/drivers/net/wireless/ath/ath10k/htt.h
b/drivers/net/wireless/ath/ath10k/htt.h
index 8e64ace..8bdf1e7 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -87,6 +87,11 @@ struct htt_data_tx_desc_frag {
__le32 len;
  } __packed;
  
+struct htt_msdu_ext_desc {

+   __le32 tso_flag[4];
+   struct htt_data_tx_desc_frag frags[6];
+};
+
  enum htt_data_tx_desc_flags0 {
HTT_DATA_TX_DESC_FLAGS0_MAC_HDR_PRESENT = 1 << 0,
HTT_DATA_TX_DESC_FLAGS0_NO_AGGR = 1 << 1,
@@ -1466,6 +1471,11 @@ struct ath10k_htt {
  
  	/* rx_status template */

struct ieee80211_rx_status rx_status;
+
+   struct {
+   dma_addr_t paddr;
+   struct htt_msdu_ext_desc *vaddr;
Defining structure htt_msdu_ext_desc for vaddr instead of void * which 
will be used as base address to get offset address of msdu data could 
lead unexpected address assignment when we manipulate msdu address 
pointer based on vaddr variable.
For example vaddr variable will be used at ath10k_htt_tx like below to 
have msdu external link descriptor.

struct htt_msdu_ext_desc *frags_ext;
frags_ext = htt->frag_desc.vaddr + (sizeof(struct htt_msdu_ext_desc) * 
msdu_id);
If we assume vaddr is 0xde81 and msdu_id is 1, we expect frags_ext 
has 0xde810040, but linux memory management system could assign 
0xde811000 to frags_ext to use continuous memory block for structure 
htt_msdu_ext_desc and it will cause data traffic failure.

To avoid this scenario, we have to use void * for vaddr.

+   }

Best Dual Band Linux Drivers

2015-06-22 Thread Redkey, Curtis

What linux driver has the ability to set the preference for the 5 GHz over the
2.4 GHz range? The current one I have does not allow it.

I posted this question online and since the SSID's are the same for the 2.4GHz
and 5GHz, it has been difficult to setup the 5 GHz wireless connectivity.

How do I set a preference for 5GHz over 2.4GHz Wifi in Lubuntu 12.04
http://askubuntu.com/questions/635358/how-do-i-set-a-preference-for-5ghz-over-2-4ghz-wifi-in-lubuntu-12-04

Any solutions or suggestions would be greatly appreciated.

Thank you,

Curtis Redkey
Information Services | Systems Administrator | Loma Linda University Medical
Center
Telephone : 909.558.5068 |Email : cred...@llu.edu |Pager: cred...@my2way.com

But the fruit of the Spirit is love, joy, peace, forbearance, kindness,
goodness, faithfulness, gentleness and self-control. Against such things there
is no law.
Galatians 5:22-23 (NIV)

CONFIDENTIALITY NOTICE: This e-mail communication and any attachments may
contain confidential and privileged information for the use of the designated
recipients named above. If you are not the intended recipient, you are hereby
notified that you have received this communication in error and that any
review, disclosure, dissemination, distribution or copying of it or its
contents is prohibited. If you have received this communication in error,
please notify me immediately by replying to this message and destroy all copies
of this communication and any attachments. Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

Re: [PATCH] staging:rtl8723au:odm.c:Removing trailing whitespaces

2015-06-22 Thread Jes Sorensen

"Joglekar, Tejas (T.)"  writes:
> From: Joglekar Tejas 
>
> This patch removes the trailing whitespace error given
> by checkpatch.pl
>
> Signed-off-by: Joglekar Tejas 
> ---
>  drivers/staging/rtl8723au/hal/odm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks straight forward.

Acked-by: Jes Sorensen 

Jes


> diff --git a/drivers/staging/rtl8723au/hal/odm.c 
> b/drivers/staging/rtl8723au/hal/odm.c
> index f354f5e..6b9dbef 100644
> --- a/drivers/staging/rtl8723au/hal/odm.c
> +++ b/drivers/staging/rtl8723au/hal/odm.c
> @@ -985,7 +985,7 @@ void ODM_RF_Saving23a(struct dm_odm_t *pDM_Odm, u8 
> bForceInNormal)
>   val32 = rtl8723au_read32(adapter, 0x874);
>   val32 |= pDM_PSTable->Reg874;
>   rtl8723au_write32(adapter, 0x874, val32);
> - 
> +
>   val32 = rtl8723au_read32(adapter, 0xc70);
>   val32 |= pDM_PSTable->RegC70;
>   rtl8723au_write32(adapter, 0xc70, val32);
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

Re: [PATCH 2/3] ath9k: make rxfilter per HW

2015-06-22 Thread Felix Fietkau

On 2015-06-22 13:59, Johannes Berg wrote:
> On Mon, 2015-06-22 at 13:58 +0200, Johannes Berg wrote:
>> On Mon, 2015-06-22 at 13:43 +0200, Janusz Dziedzic wrote:
>> > mac80211 configure rxfilter per HW,
>> > so we don't need this per channel.
>> 
>> As I said before, I think there's value in mac80211 doing it per chanctx
>> or even per vif, and it should be more efficient to do so.
>> 
>> It's tempting to do it per vif and leave the chanctx work up to the
>> driver, but perhaps with CSA and all that it gets complicated enough
>> that doing it per chanctx in mac80211 would make sense?
> 
> On the other hand, I think our device requires it per vif, so we'd
> probably have to do both.
> 
> +Andrei, who was looking into this.
There's value in it, but I think it makes more sense to fix this bug
now, and rework the code again later when mac80211 has support for
per-vif or per-chanctx rxfilter.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

66 matches

Mail list logo