[PATCH] staging: rtl8723au: Fix line longer than 80 columns.
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Edward Lipinsky --- drivers/staging/rtl8723au/core/rtw_ap.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c index ce4b589..03202df 100644 --- a/drivers/staging/rtl8723au/core/rtw_ap.c +++ b/drivers/staging/rtl8723au/core/rtw_ap.c @@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter) } spin_unlock_bh(&pacl_node_q->lock); - DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num); + DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, + pacl_list->num); rtw_sta_flush23a(padapter); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.
On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote: > This patch fixes the checkpatch.pl warning: > WARNING: line over 80 characters [] > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c > b/drivers/staging/rtl8723au/core/rtw_ap.c [] > @@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter) > } > spin_unlock_bh(&pacl_node_q->lock); > > - DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, > pacl_list->num); > + DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, > + pacl_list->num); It's generally nicer to break the line at the end of the format sting like: DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num); though it'd be even better to convert all of these DBG_8723A uses to pr_debug $ git ls-files drivers/staging/rtl8723au/ | \ xargs sed -r -i \ -e 's/\bDBG_8723A\b/pr_debug/g' \ -e 's/\bMSG|8723A\b/pr_debug/g' -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
carl1970: stops working at random periods on Ubuntu 15.05
I'm using TP-LINK TL-WN821N and encountering very annoying behaviour - adapter 'hangs' at random period of time - sometimes it is 1 hour, sometimes 2. After it hangs Network manager does not see any wireless networks and the only way to make it work is to reboot system (also tried unplugging/plugging adapter and removing/adding module but it did not work) Heres lsusb -v: Bus 004 Device 004: ID 0cf3:1002 Atheros Communications, Inc. TP-Link TL-WN821N v2 / TL-WN822N v1 802.11n [Atheros AR9170] And here what i have in syslog right before the hang: Feb 28 01:23:45 evren kernel: [ 3590.458890] [ cut here ] Feb 28 01:23:45 evren kernel: [ 3590.458919] WARNING: CPU: 0 PID: 3749 at /build/linux-PoTihC/linux-4.2.0/drivers/net/wireless/ath/carl9170/main.c:1012 carl9170_op_configure_filter+0x191/0x1a0 [carl9170]() Feb 28 01:23:45 evren kernel: [ 3590.458925] Modules linked in: drbg ansi_cprng ctr ccm binfmt_misc fglrx(POE) arc4 snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi carl9170 snd_hda_intel snd_hda_codec snd_hda_core ath mac80211 snd_hwdep snd_pcm snd_seq_midi snd_seq_midi_event cfg80211 kvm_amd kvm snd_rawmidi snd_seq input_leds joydev snd_seq_device snd_timer edac_core serio_raw edac_mce_amd snd soundcore k10temp asus_atk0110 amd_iommu_v2 8250_fintek i2c_piix4 shpchp mac_hid cuse parport_pc ppdev lp parport autofs4 pata_acpi hid_generic usbhid hid r8169 psmouse pata_jmicron firewire_ohci mii firewire_core pata_atiixp crc_itu_t ahci libahci wmi Feb 28 01:23:45 evren kernel: [ 3590.459018] CPU: 0 PID: 3749 Comm: kworker/u16:0 Tainted: PW OE 4.2.0-30-generic #36-Ubuntu Feb 28 01:23:45 evren kernel: [ 3590.459024] Hardware name: System manufacturer System Product Name/M4A89GTD-PRO/USB3, BIOS 3029 07/05/2012 Feb 28 01:23:45 evren kernel: [ 3590.459063] Workqueue: phy1 ieee80211_reconfig_filter [mac80211] Feb 28 01:23:45 evren kernel: [ 3590.459068] d9cf9215 8800b240fce8 817ebf13 Feb 28 01:23:45 evren kernel: [ 3590.459075] 8800b240fd28 8107b9d6 Feb 28 01:23:45 evren kernel: [ 3590.459082] 8001 8800c88b5440 8800b240fdac 8001 Feb 28 01:23:45 evren kernel: [ 3590.459089] Call Trace: Feb 28 01:23:45 evren kernel: [ 3590.459102] [] dump_stack+0x45/0x57 Feb 28 01:23:45 evren kernel: [ 3590.459112] [] warn_slowpath_common+0x86/0xc0 Feb 28 01:23:45 evren kernel: [ 3590.459120] [] warn_slowpath_null+0x1a/0x20 Feb 28 01:23:45 evren kernel: [ 3590.459130] [] carl9170_op_configure_filter+0x191/0x1a0 [carl9170] Feb 28 01:23:45 evren kernel: [ 3590.459163] [] ieee80211_configure_filter+0x149/0x2a0 [mac80211] Feb 28 01:23:45 evren kernel: [ 3590.459196] [] ieee80211_reconfig_filter+0x15/0x20 [mac80211] Feb 28 01:23:45 evren kernel: [ 3590.459205] [] process_one_work+0x1aa/0x440 Feb 28 01:23:45 evren kernel: [ 3590.459213] [] worker_thread+0x4b/0x4c0 Feb 28 01:23:45 evren kernel: [ 3590.459221] [] ? process_one_work+0x440/0x440 Feb 28 01:23:45 evren kernel: [ 3590.459228] [] kthread+0xd8/0xf0 Feb 28 01:23:45 evren kernel: [ 3590.459236] [] ? kthread_create_on_node+0x1f0/0x1f0 Feb 28 01:23:45 evren kernel: [ 3590.459243] [] ret_from_fork+0x3f/0x70 Feb 28 01:23:45 evren kernel: [ 3590.459249] [] ? kthread_create_on_node+0x1f0/0x1f0 Feb 28 01:23:45 evren kernel: [ 3590.459255] ---[ end trace fe0c60ee5cb8db9a ]--- Feb 28 01:23:46 evren kernel: [ 3591.459129] [ cut here ] Following messages are also relevant to adapter failure but i guess it will be to long to post it here. Also after unplugging/pluggin i see following: Feb 28 01:46:44 evren kernel: [ 4970.256337] usb 4-1.4: USB disconnect, device number 13 Feb 28 01:46:52 evren kernel: [ 4977.878803] usb 4-1.4: new high-speed USB device number 14 using ehci-pci Feb 28 01:46:52 evren kernel: [ 4978.023152] usb 4-1.4: New USB device found, idVendor=0cf3, idProduct=1002 Feb 28 01:46:52 evren kernel: [ 4978.023166] usb 4-1.4: New USB device strings: Mfr=16, Product=32, SerialNumber=48 Feb 28 01:46:52 evren kernel: [ 4978.023173] usb 4-1.4: Product: USB2.0 WLAN Feb 28 01:46:52 evren kernel: [ 4978.023179] usb 4-1.4: Manufacturer: ATHER Feb 28 01:46:52 evren kernel: [ 4978.023185] usb 4-1.4: SerialNumber: 12345 Feb 28 01:46:52 evren kernel: [ 4978.098854] usb 4-1.4: reset high-speed USB device number 14 using ehci-pci Feb 28 01:46:52 evren kernel: [ 4978.232174] usb 4-1.4: driver API: 1.9.7 2012-12-15 [1-1] Feb 28 01:46:52 evren kernel: [ 4978.232187] usb 4-1.4: firmware API: 1.9.6 2012-07-07 Feb 28 01:46:52 evren kernel: [ 4978.569953] ath: EEPROM regdomain: 0x809c Feb 28 01:46:52 evren kernel: [ 4978.569962] ath: EEPROM indicates we should expect a country code Feb 28 01:46:52 evren kernel: [ 4978.569967] ath: doing EEPROM country->regdmn map search Feb 28 01:46:52 evren kernel: [ 4978.569971] ath: country maps to regdmn code: 0x52 Feb 28 01:46:52 evren kernel: [ 4978.569975] ath