[PATCH v3] bcma:Adjust block comments
use * for block comments in multiple lines according to kernel coding style Reported by: checkpatch.pl Signed-off-by: Ashish Kalra <eashishka...@gmail.com> --- Change log: -v3: Improvement on commit message as per review from Morgan Freeman <morganfreeman6...@gmail.com> -v2: Improvement on commit message as per review from Morgan Freeman <morganfreeman6...@gmail.com>(https://lkml.org/lkml/2017/11/27/1259) -v1: https://lkml.org/lkml/2017/11/26/85 drivers/bcma/driver_pcie2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c index b1a6e327cb23..cf889fc62ac7 100644 --- a/drivers/bcma/driver_pcie2.c +++ b/drivers/bcma/driver_pcie2.c @@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2) bcma_core_pcie2_set_ltr_vals(pcie2); /* TODO: - si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ +*si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); +*/ /* enable the LTR */ devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB; -- 2.14.1
[PATCH v2] drivers: bcma: driver_pcie2.c: Comment format correction & moving trailing */ to a separate line as per checkpatch
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines + /* TODO: + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ WARNING: Block comments use a trailing */ on a separate line + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ total: 0 errors, 2 warnings, 200 lines checked Signed-off-by: Ashish Kalra <eashishka...@gmail.com> --- changes from v1 (https://lkml.org/lkml/2017/11/26/85) v2: Improved commit message as per review from Morgan Freeman <morganfreeman6...@gmail.com> drivers/bcma/driver_pcie2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c index b1a6e327cb23..cf889fc62ac7 100644 --- a/drivers/bcma/driver_pcie2.c +++ b/drivers/bcma/driver_pcie2.c @@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2) bcma_core_pcie2_set_ltr_vals(pcie2); /* TODO: - si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ +*si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); +*/ /* enable the LTR */ devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB; -- 2.14.1
[PATCH] Removed Warning shown in checkpatch.pl for comment and white space
checkpatch.pl was showing warnings due to incorrected space at the end of line and also not using * at start of second comment line, Corrected the same and now there is zero warning Signed-off-by: Ashish Kalra <eashishka...@gmail.com> --- drivers/bcma/driver_pcie2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c index b1a6e327cb23..cf889fc62ac7 100644 --- a/drivers/bcma/driver_pcie2.c +++ b/drivers/bcma/driver_pcie2.c @@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2) bcma_core_pcie2_set_ltr_vals(pcie2); /* TODO: - si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ +*si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); +*/ /* enable the LTR */ devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB; -- 2.14.1
