Re: [PATCH v2 02/49] ath11k: add Kconfig
On 2019-10-20 03:03, Kalle Valo wrote: [...snip...] +config ATH11K_TRACING + bool "ath11k tracing support" + depends on ATH11K && EVENT_TRACING + ---help--- + Select this to ath11k use tracing infrastructure. Help text does not parse
Re: [PATCH] cfg80211: Add new helper function for channels
On 2019-08-30 04:03, Arend Van Spriel wrote: On 8/30/2019 12:41 PM, Johannes Berg wrote: On Fri, 2019-08-30 at 12:40 +0200, Arend Van Spriel wrote: +EXPORT_SYMBOL(ieee80211_channel_op_class_to_frequency); The function ieee80211_operating_class_to_band() uses ranges within switch statement, eg.: case 128 ... 130: *band = NL80211_BAND_5GHZ; return true; No that you remind me - how is this new function not just a composition of the existing ones? i.e. just convert the op_class to band first, and then (band, channel) to freq? yup. that would have my preference actually. Sigh. I had the same guidance in pre-review: we already have ieee80211_operating_class_to_band() and ieee80211_channel_to_frequency() so all this function should be is return ieee80211_channel_to_frequency(chan, ieee80211_operating_class_to_band(op_class)) but then again if anybody needs this functionality they can simply call those same functions
Re: [RFC 0/1] Allow MAC change on up interface
On 2019-08-15 11:57, James Prestwood wrote: - Adds a new NL80211_ATTR for including a "random mac" to CMD_CONNECT. This MAC is passed down the stack and gets set to the net_device's address. My initial reaction is that I'd avoid using the term "random". For some use cases the address may truly be random, but for other use cases it may be derived, perhaps in an AP-specific manner. Other terms which may be more appropriate are "spoofed mac", "administered mac", etc. It is a shame that due to backward compatibility we can't use NL80211_ATTR_MAC while shifting the current usage over to using NL80211_ATTR_BSSID.
Re: [PATCH] cfg80211: VLAN offload support for set_key and set_sta_vlan
On 2019-08-15 06:38, Jouni Malinen wrote: From: Gurumoorthi Gnanasambandhan [...] By setting NL80211_EXT_FEATURE_VLAN_OFFLOAD flag the driver indicates support for a single netdev with VLAN tagged frames. Separate VLAN-specific netdevs are added using vcongig similar to Ethernet. nit: s/vcongig/vconfig/
Re: [RFC 1/8] nl80211: add 6GHz band definition to enum nl80211_band
On 2019-05-30 09:07, Arend Van Spriel wrote: Sigh! Obviously that is a concern. Johannes already mentioned it. Sorry, overlooked his comment on the [0/8] patch. I'll climb back under my rock.
Re: [RFC 1/8] nl80211: add 6GHz band definition to enum nl80211_band
On 2019-05-20 05:00, Arend van Spriel wrote:
[...snip...]
enum nl80211_band {
NL80211_BAND_2GHZ,
NL80211_BAND_5GHZ,
+ NL80211_BAND_6GHZ,
NL80211_BAND_60GHZ,
NUM_NL80211_BANDS,
Is it not a concern that this changes the value of NL80211_BAND_60GHZ
and hence will break any ABI which expects the current value?
Re: [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event
On 2018-05-17 06:25, Dedy Lansky wrote: From: Dedy Lansky Allocation size of nlmsg in cfg80211_ft_event is based on ric_ies_len and doesn't take into account ies_len. This leads to NL80211_CMD_FT_EVENT message construction failure in case ft_event contains large enough ies buffer. Add ies_len to the nlmsg allocation size. Signed-off-by: Dedy Lansky --- net/wireless/nl80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index afbe510..64afd04 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -15755,7 +15755,8 @@ void cfg80211_ft_event(struct net_device *netdev, if (!ft_event->target_ap) return; - msg = nlmsg_new(100 + ft_event->ric_ies_len, GFP_KERNEL); + msg = nlmsg_new(100 + ft_event->ies_len + ft_event->ric_ies_len, + GFP_KERNEL); if (!msg) return; should these really be nla_total_size(ft_event->ies_len) + nla_total_size(ft_event->ric_ies_len) to properly account for the NLA header + padding? or do we consider that to be noise captured by the "100"?
Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)
On 2018-05-17 04:32, Ramon Fried wrote:
From: Eyal Ilsar
...
+int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn,
+ struct ieee80211_vif *vif, void *ptt_msg,
size_t len,
+ void **ptt_rsp_msg)
+{
+ struct wcn36xx_hal_process_ptt_msg_req_msg *p_msg_body;
+ int ret = 0;
+
+ mutex_lock(&wcn->hal_mutex);
+ p_msg_body = kmalloc(
+ sizeof(struct wcn36xx_hal_process_ptt_msg_req_msg) + len,
+ GFP_ATOMIC);
NULL check required?
+ INIT_HAL_PTT_MSG(p_msg_body, len);
+
Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)
On 2018-05-17 04:32, Ramon Fried wrote:
From: Eyal Ilsar
...
+static int wcn36xx_smd_process_ptt_msg_rsp(void *buf, size_t len,
+ void **p_ptt_rsp_msg)
+{
+ struct wcn36xx_hal_process_ptt_msg_rsp_msg *rsp;
+ int ret = 0;
why initialize 'ret' when you immediately overwrite?
+ ret = wcn36xx_smd_rsp_status_check(buf, len);
...
+ if (rsp->header.len > 0) {
+ *p_ptt_rsp_msg = kmalloc(rsp->header.len, GFP_ATOMIC);
NULL check required?
+ memcpy(*p_ptt_rsp_msg, rsp->ptt_msg, rsp->header.len);
+ }
+ return ret;
+}
+
+int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn,
+ struct ieee80211_vif *vif, void *ptt_msg,
size_t len,
+ void **ptt_rsp_msg)
+{
+ struct wcn36xx_hal_process_ptt_msg_req_msg *p_msg_body;
+ int ret = 0;
why initialize 'ret' when it is always overwritten before use?
+ ret = wcn36xx_smd_send_and_wait(wcn, p_msg_body->header.len);
Re: [PATCH 1/3] ath10k: Add ath10k-ct firmware feature flags and descriptions.
On 2018-05-11 14:42, gree...@candelatech.com wrote: From: Ben Greear These feature flags are used by ath10k-ct firmware. Add these so we can use them in future patches and so there are no warings typo: warings => warnings
Re: [PATCH] ssb: Fix regression caused by disabling PCI cores on non-MIPS architecture
On 2018-05-09 09:42, Larry Finger wrote: Some MPIS-based SoCs use chips driven by b43 for wireless capability. typo: MPIS=>MIPS
Re: [PATCH v2] ath10k: remove variables which set but not used
On 2018-05-07 02:39, Kenneth Lu wrote: Variable buf_len and num_vdev_stats are bging assigned but never read. typo: bging => being
[PATCH] ath10k: Cleanup ath10k_mac_register() error handling
The logic in the error-handling path of ath10k_mac_register() is
divergent from the logic in ath10k_mac_unregister(). Update the
ath10k_mac_register() error handling logic to align with the
ath10k_mac_unregister() logic.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/mac.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c
b/drivers/net/wireless/ath/ath10k/mac.c
index 79490ad..a37aad3c 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -7301,7 +7301,7 @@ int ath10k_mac_register(struct ath10k *ar)
ath10k_reg_notifier);
if (ret) {
ath10k_err(ar, "failed to initialise regulatory: %i\n", ret);
- goto err_free;
+ goto err_dfs_detector_exit;
}
ar->hw->wiphy->cipher_suites = cipher_suites;
@@ -7310,7 +7310,7 @@ int ath10k_mac_register(struct ath10k *ar)
ret = ieee80211_register_hw(ar->hw);
if (ret) {
ath10k_err(ar, "failed to register ieee80211: %d\n", ret);
- goto err_free;
+ goto err_dfs_detector_exit;
}
if (!ath_is_world_regd(&ar->ath_common.regulatory)) {
@@ -7324,10 +7324,16 @@ int ath10k_mac_register(struct ath10k *ar)
err_unregister:
ieee80211_unregister_hw(ar->hw);
+
+err_dfs_detector_exit:
+ if (config_enabled(CONFIG_ATH10K_DFS_CERTIFIED) && ar->dfs_detector)
+ ar->dfs_detector->exit(ar->dfs_detector);
+
err_free:
kfree(ar->mac.sbands[IEEE80211_BAND_2GHZ].channels);
kfree(ar->mac.sbands[IEEE80211_BAND_5GHZ].channels);
+ SET_IEEE80211_DEV(ar->hw, NULL);
return ret;
}
--
1.8.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
