Re: Anyone have a clone of wireless-legacy.git?
On Fri, Jun 03, 2016 at 09:06:23AM +0200, Johannes Berg wrote: > > > http://www.filewatcher.com/_/?q=wireless-legacy.git, maybe ? > > > > Seems to work - both have the same branches: > > adm8211 72c942ed694e [PATCH] adm8211: fix build breakage > from skb->mac.raw > at76279f8592e428 cfg80211: keep track of supported > interface modes (at76) > ath5k 8584ac94e3bb [PATCH] ath5k: Internalize Atheros > Turbo modes > ath5k-2008-01-215b8ca29e11b5 ath5k: remove duplicate bssid variable > mac80211-attic 2bc68d999610 [PATCH] mac80211: remove scan struct > from hostapd_param > mac80211-dungeonad097a32e9ad [PATCH] mac80211 [HT] 802.11 code > compiles under CONFIG_MAC80211_HT > prism54usb 101e59f5e18a prism54usb: more fix for wireless > Kconfig changes > rtl8180-2008-01-21 55fc0e806a93 rtl8180: remove calibration error > message for rtl8225z2 > tiacx d6a6811c508b [PATCH] TI acx100/acx111: Make debug > level selectable in configuration > wireless-dev-2007-08-10 ca29ec8f05c1 Merge ../wireless-dev-legacy into > wireless-dev-2007-08-10 > wireless-dev-2007-09-24 cd799e167394 Merge branch 'p54' into everything > > johannes I got them both from the two FTP sites, and both git repos appear to be identical. It would be best if someone had an actual record of the commit hash values, but this might be the best I/we can do...? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Anyone have a clone of wireless-legacy.git?
On Thu, Jun 02, 2016 at 06:18:27PM -0700, Guenter Roeck wrote: > On Thu, Jun 02, 2016 at 02:38:04PM -0400, John W. Linville wrote: > > It has recently come to my attention that the old wireless-legacy.git > > tree is no longer available on kernel.org. I honestly have no idea > > what happened to it -- for all I know I fat-fingered it some time > > ago or whatever. Anyway, apparently there are some references in it > > "out there" and it would be good if we had a copy available somewhere > > public. > > > > If you have an old clone of wireless-legacy.git, PLEASE DO NOT DELETE > > IT! Please let me know that you've got it and I will arrange to get > > a copy of it from you in order to make it available publicly again. > > > > I appreciate your support! > > > http://www.filewatcher.com/_/?q=wireless-legacy.git, maybe ? Awesome...thanks for the tip! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Anyone have a clone of wireless-legacy.git?
On Thu, Jun 02, 2016 at 08:48:08PM +0100, One Thousand Gnomes wrote: > On Thu, 2 Jun 2016 14:38:04 -0400 > "John W. Linville" <linvi...@tuxdriver.com> wrote: > > > It has recently come to my attention that the old wireless-legacy.git > > tree is no longer available on kernel.org. I honestly have no idea > > what happened to it -- for all I know I fat-fingered it some time > > ago or whatever. Anyway, apparently there are some references in it > > "out there" and it would be good if we had a copy available somewhere > > public. > > > > If you have an old clone of wireless-legacy.git, PLEASE DO NOT DELETE > > IT! Please let me know that you've got it and I will arrange to get > > a copy of it from you in order to make it available publicly again. > > Before you do that please make sure you get multiple copies from > unconnected sources and confirm none of them are trojanned. I will endeavour to ensurance provenance, certainly. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Anyone have a clone of wireless-legacy.git?
It has recently come to my attention that the old wireless-legacy.git tree is no longer available on kernel.org. I honestly have no idea what happened to it -- for all I know I fat-fingered it some time ago or whatever. Anyway, apparently there are some references in it "out there" and it would be good if we had a copy available somewhere public. If you have an old clone of wireless-legacy.git, PLEASE DO NOT DELETE IT! Please let me know that you've got it and I will arrange to get a copy of it from you in order to make it available publicly again. I appreciate your support! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: wireless-drivers: random cleanup patches piling up
On Fri, Jan 22, 2016 at 02:21:20PM +0200, Kalle Valo wrote: > Joe Perches <j...@perches.com> writes: > > > On Thu, 2016-01-21 at 16:58 +0200, Kalle Valo wrote: > >> Hi, > >> > >> I have quite a lot of random cleanup patches from new developers waiting > >> in my queue: > >> > >> https://patchwork.kernel.org/project/linux-wireless/list/?state=10=25621=date > >> > >> (Not all of them are cleanup patches, there are also few patches > >> deferred due to other reasons, but you get the idea.) > >> > >> These cleanup patches usually take quite a lot of my time and I'm > >> starting to doubt the benefit, compared to the time needed to dig > >> through them and figuring out what to apply. And this is of course time > >> away from other patches, so it's slowing down "real" development. > >> > >> I really don't know what to do. Part of me is saying that I just should > >> drop them unless it's reviewed by a more experienced developer but on > >> the other hand this is a good way get new developers onboard. > >> > >> What others think? Are these kind of patches useful? > > > > Some yes, mostly not really. > > > > While whitespace style patches have some small value, > > very few of the new contributors that use tools like > > "scripts/checkpatch.pl -f" on various kernel files > > actually continue on to submit actual defect fixing > > or optimization or code clarity patches. > > That's also my experience from maintaining wireless-drivers for a year, > this seems to be a "hit and run" type of phenomenon. Should we be looking for someone to run a "wireless-driver-cleanups" tree? They could handle the cleanups and trivial stuff, and send you a pull request a couple of times per release...? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] New location for wireless-testing tree
On Wed, Dec 16, 2015 at 12:32:23PM -0500, Bob Copeland wrote: > As reported previously[1], John Linville will be moving on from maintenance > of the wireless-testing[2] tree at the end of the year. A huge thank you to > John for doing all this work for so many years! > > We now have a shared wireless directory on kernel.org where we (currently > myself and Kalle as backup) will continue to maintain this tree going > forward. The new tree can be found at: > > git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-testing.git > > Note: unlike John's tree, we are going to try rebasing this tree on every > build (like linux-next) instead of merging the downstream trees, in order > to avoid certain merge problems when those trees are rebased. > > This means that if you are working directly off of wireless-testing, use > 'git pull --rebase' to sync, instead of just 'git pull'. > > We'll see how this goes and reassess after a couple of cycles. > > Please let me know of any issues. > > [1] http://comments.gmane.org/gmane.linux.kernel.wireless.general/145291 > > [2] wireless-testing is an integration testing tree, consisting of: > > * Linus's latest -rc > * patches in mac80211 and wireless-drivers (for the upcoming release) > * patches in mac80211-next and wireless-drivers-next (for the next release) > > It is not pulled into any upstream tree, but it should be a pretty good > indication of what is baking in Linux wireless for the next release, without > having unrelated changes from all the other subsystems as in linux-next. Given this most welcome announcement, I will hereby cease maintenance of the predecessor wireless-testing tree in favor of this new canonical source. Thanks guys! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
wireless-testing rebased, new HEAD commit f5feec4244464225c03ccc9ddad615cb43a044cc
All, An earlier pull got a version of mac80211.git that was later reverted. Unfortunately, the intervening merges got things so screwed-up I couldn't reasonably unravel them. So, I have taken the somewhat unusual step of rebasing wireless-testing here in the middle of the 4.4 stream. The current wireless-testing HEAD is commit f5feec4244464225c03ccc9ddad615cb43a044cc. Consumers of wireless-testing, please make the necessary adjustment. I apologize for the inconvenience... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: wireless-testing regression: Could not configure driver mode
Sorry for the merge damage. I was (and still am) trying to deal with some merge conflicts when pulling the mac80211 tree, FWIW... On Thu, Dec 03, 2015 at 08:54:16AM +0200, Kalle Valo wrote: > Hi John, > > with latest wireless-testing[1] I noticed that I cannot start AP mode > anymore with ath10k: > > nl80211: Subscribe to mgmt frames with AP handle 0x9e5b410 > nl80211: Register frame type=0xb0 nl_handle=0x9e5b410 match= > nl80211: Register frame command failed (type=176): ret=-95 (Operation not > supported) > nl80211: Register frame match - hexdump(len=0): [NULL] > nl80211: Could not configure driver mode > > With help of Johannes we find out that there are odd changes in > wireless-testing[2]. Reverting the change in cfg.c fixed my regression, > but I don't know really know what has happened. > > Kalle > > [1] To be exact I was using ath.git master branch but that's just > wireless-testing plus latest ath patches so should affect here. > > [2] $ git diff master-2015-11-27..master-2015-11-30 -- net/mac80211 > diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > index 2d1c4c35186d..b3a708366a5a 100644 > --- a/net/mac80211/cfg.c > +++ b/net/mac80211/cfg.c > @@ -3384,8 +3384,6 @@ const struct cfg80211_ops mac80211_config_ops = { > .set_bitrate_mask = ieee80211_set_bitrate_mask, > .remain_on_channel = ieee80211_remain_on_channel, > .cancel_remain_on_channel = ieee80211_cancel_remain_on_channel, > - .mgmt_tx = ieee80211_mgmt_tx, > - .mgmt_tx_cancel_wait = ieee80211_mgmt_tx_cancel_wait, > .set_cqm_rssi_config = ieee80211_set_cqm_rssi_config, > .mgmt_frame_register = ieee80211_mgmt_frame_register, > .set_antenna = ieee80211_set_antenna, > diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c > index ce8e1a6c7281..cfd3356e26fd 100644 > --- a/net/mac80211/offchannel.c > +++ b/net/mac80211/offchannel.c > @@ -916,6 +916,13 @@ int ieee80211_mgmt_tx(struct wiphy *wiphy, struct > wireless_dev *wdev, > kfree_skb(skb); > goto out_unlock; > } > + } else { > + /* Assign a dummy non-zero cookie, it's not sent to > +* userspace in this case but we rely on its value > +* internally in the need_offchan case to distinguish > +* mgmt-tx from remain-on-channel. > +*/ > + *cookie = 0x; > } > > if (!need_offchan) { > > -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: wireless-testing repo
On Mon, Nov 23, 2015 at 12:38:29PM +0100, Arend van Spriel wrote: > On 11/23/2015 12:31 PM, Johannes Berg wrote: > >On Mon, 2015-11-23 at 12:19 +0100, Arend van Spriel wrote: > >>Hi John, > >> > >>We have been using the wireless-testing repo in our nightly testing > >>and as such appreciated the on-going support for it. I noticed your > >>announcement (and misplaced it) and as I prefer to keep the nightly > >>testing will have to do the work over here. Can you provide details > >>on what trees are merged into wireless-testing. Is it > >>wireless-drivers{,-next} and mac80211{,-next} or is there more to > >>consider. > > > >I believe it was also the latest rc from Linus. > > Indeed. Yes, latest -rc plus those 4 trees is what I have been pulling for some time. I used to include Bluetooth and NFC, but stopped doing that early this year. > >If you're testing with backports you could also use the latest linux- > >next with a restricted backport - I've added mac80211(-next) to that > >now. > > We have some setups running on wl-testing kernel and some running distro > kernel using backports. I believe the Bob Copeland is considering taking on this mantle... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
linux-wireless rebased (probably for the last time) on 4.4-rc1
The wireless-testing tree has been rebased on top of 4.4-rc1. The current head of the tree is eced3b090878ddba643bbed599e6edea4ad90f49. Please update any downstream trees accordingly! It has been almost a year since I turned-over wireless maintenance duties to Johannes and Kalle. At that time I agreed to continue maintaining the wireless-testing tree for the duration of 2015 to help those that were still relying on it. The end of 2015 is coming soon, and with it I intend to stop maintaining wireless-testing. If you are still relying on wireless-testing, then I implore you to find another option to satisfy your needs. If someone would like to continue maintaining wireless-testing yourself, then please contact me and I will attempt to assist you in such a transition. Thanks for all the fish! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] orinoco_usb: return error in ezusb_probe when alloc_orinocodev fails
The current code exits after alloc_orinocodev, but fails to change the return value to something that indicates the failure. This patch changes the return value to -ENOMEM. https://bugzilla.kernel.org/show_bug.cgi?id=106181 Signed-off-by: John W. Linville <linvi...@tuxdriver.com> --- drivers/net/wireless/orinoco/orinoco_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c b/drivers/net/wireless/orinoco/orinoco_usb.c index 26a57d773d30..f2cd513d54b2 100644 --- a/drivers/net/wireless/orinoco/orinoco_usb.c +++ b/drivers/net/wireless/orinoco/orinoco_usb.c @@ -1576,6 +1576,7 @@ static int ezusb_probe(struct usb_interface *interface, ezusb_hard_reset, NULL); if (!priv) { err("Couldn't allocate orinocodev"); + retval = -ENOMEM; goto exit; } -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mwl8k: refactor some conditionals for clarity
CC [M] drivers/net/wireless/mwl8k.o drivers/net/wireless/mwl8k.c: In function ‘mwl8k_bss_info_changed’: drivers/net/wireless/mwl8k.c:3290:2: warning: ‘ap_mcs_rates’ may be used uninitialized in this function [-Wmaybe-uninitialized] memcpy(cmd-mcs_set, mcs_rates, 16); ^ drivers/net/wireless/mwl8k.c:4987:5: note: ‘ap_mcs_rates’ was declared here u8 ap_mcs_rates[16]; ^ The warning was bogus. But the conditionals were rather complicated, with multiple redundant checks. This consolidates the checking and makes it more readable IMHO. Signed-off-by: John W. Linville linvi...@tuxdriver.com --- Compile tested only. Sorry for any duplicates -- I sent the first one to the wrong list address! drivers/net/wireless/mwl8k.c | 49 ++-- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c index 77361af68b18..9420fc61c2e6 100644 --- a/drivers/net/wireless/mwl8k.c +++ b/drivers/net/wireless/mwl8k.c @@ -5019,35 +5019,36 @@ mwl8k_bss_info_changed_sta(struct ieee80211_hw *hw, struct ieee80211_vif *vif, memcpy(ap_mcs_rates, ap-ht_cap.mcs.rx_mask, 16); rcu_read_unlock(); - } - if ((changed BSS_CHANGED_ASSOC) vif-bss_conf.assoc - !priv-ap_fw) { - rc = mwl8k_cmd_set_rate(hw, vif, ap_legacy_rates, ap_mcs_rates); - if (rc) - goto out; + if (changed BSS_CHANGED_ASSOC) { + if (!priv-ap_fw) { + rc = mwl8k_cmd_set_rate(hw, vif, + ap_legacy_rates, + ap_mcs_rates); + if (rc) + goto out; - rc = mwl8k_cmd_use_fixed_rate_sta(hw); - if (rc) - goto out; - } else { - if ((changed BSS_CHANGED_ASSOC) vif-bss_conf.assoc - priv-ap_fw) { - int idx; - int rate; + rc = mwl8k_cmd_use_fixed_rate_sta(hw); + if (rc) + goto out; + } else { + int idx; + int rate; - /* Use AP firmware specific rate command. -*/ - idx = ffs(vif-bss_conf.basic_rates); - if (idx) - idx--; + /* Use AP firmware specific rate command. +*/ + idx = ffs(vif-bss_conf.basic_rates); + if (idx) + idx--; - if (hw-conf.chandef.chan-band == IEEE80211_BAND_2GHZ) - rate = mwl8k_rates_24[idx].hw_value; - else - rate = mwl8k_rates_50[idx].hw_value; + if (hw-conf.chandef.chan-band == + IEEE80211_BAND_2GHZ) + rate = mwl8k_rates_24[idx].hw_value; + else + rate = mwl8k_rates_50[idx].hw_value; - mwl8k_cmd_use_fixed_rate_ap(hw, rate, rate); + mwl8k_cmd_use_fixed_rate_ap(hw, rate, rate); + } } } -- 2.4.3 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ipw2x00: Adding active 11a wireless band support for Intel 2915abg (ZZJ:Japan)
, LIBIPW_CH_PASSIVE_ONLY}, +{5700, 140, LIBIPW_CH_PASSIVE_ONLY}}, }, { /* Rest of World */ -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ath10k: remove NULL ptr deref in variable init of ath10k_monitor_vdev_start
On Tue, Jul 28, 2015 at 10:41:11AM +0530, Vasanthakumar Thiagarajan wrote: On Tuesday 28 July 2015 12:52 AM, John W. Linville wrote: In ath10k_monitor_vdev_start, chandef is initialized to NULL and then channel is immediately thereafter initialized to chandef-chan (i.e. NULL-chan). This appears to be some sort of cut-n-paste error, since the same assignment is done later (i.e. after chandef has been properly assigned to a non-NULL value). So, let's just remove this brown paper bag typo/thinko... :-) Coverity CID #1309505 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index c9a7d5b5dffc..2823222dea92 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -836,7 +836,7 @@ static inline int ath10k_vdev_setup_sync(struct ath10k *ar) static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id) { struct cfg80211_chan_def *chandef = NULL; -struct ieee80211_channel *channel = chandef-chan; +struct ieee80211_channel *channel; struct wmi_vdev_start_request_arg arg = {}; int ret = 0; There is a similar change integrated recently, https://github.com/kvalo/ath/commit/19be9e9a7ac7e6050eab426283d2a87593cf6e82 OK. I don't see much point in the NULL assignment for channel, but the main point is to avoide the chandef-chan part. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ath10k: remove NULL ptr deref in variable init of ath10k_monitor_vdev_start
In ath10k_monitor_vdev_start, chandef is initialized to NULL and then channel is immediately thereafter initialized to chandef-chan (i.e. NULL-chan). This appears to be some sort of cut-n-paste error, since the same assignment is done later (i.e. after chandef has been properly assigned to a non-NULL value). So, let's just remove this brown paper bag typo/thinko... :-) Coverity CID #1309505 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index c9a7d5b5dffc..2823222dea92 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -836,7 +836,7 @@ static inline int ath10k_vdev_setup_sync(struct ath10k *ar) static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id) { struct cfg80211_chan_def *chandef = NULL; - struct ieee80211_channel *channel = chandef-chan; + struct ieee80211_channel *channel; struct wmi_vdev_start_request_arg arg = {}; int ret = 0; -- 2.4.3 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
wireless-testing rebased on v4.2-rc1
Subject says it all... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mwifiex: fix leak of gen_ie storage on exit from mwifiex_del_mgmt_ies
Storage pointed to by gen_ie is allocated with kmalloc, but was never freed. Coverity CID #1271251 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/mwifiex/ie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mwifiex/ie.c b/drivers/net/wireless/mwifiex/ie.c index 23e368c77c08..abf52d25b981 100644 --- a/drivers/net/wireless/mwifiex/ie.c +++ b/drivers/net/wireless/mwifiex/ie.c @@ -479,6 +479,7 @@ int mwifiex_del_mgmt_ies(struct mwifiex_private *priv) ar_ie, priv-assocresp_idx); done: + kfree(gen_ie); kfree(beacon_ie); kfree(pr_ie); kfree(ar_ie); -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] wireless: remove superfluous if statement in regulatory code
Commit eeca9fce1d71 ('cfg80211: Schedule timeout for all CRDA calls') left behind a superfluous check after it removed some earlier code. In reg_process_hint, the test of treatment == REG_REQ_IGNORE || treatment == REG_REQ_ALREADY_SET is superfluous because the code in the if-then branch is identical to the code after the if statement. Coverity CID #1295939 I also removed the unnecessary assignment of treatment in this case, and added a comment reminding any future patch authors to ensure that treatment is properly assigned before it is used after the switch. Signed-off-by: John W. Linville linvi...@tuxdriver.com --- v2 - address comments from Jouni Malinen net/wireless/reg.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index d359e0610198..62d8ea42dbfb 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -2079,10 +2079,7 @@ static void reg_process_hint(struct regulatory_request *reg_request) reg_process_hint_core(reg_request); return; case NL80211_REGDOM_SET_BY_USER: - treatment = reg_process_hint_user(reg_request); - if (treatment == REG_REQ_IGNORE || - treatment == REG_REQ_ALREADY_SET) - return; + reg_process_hint_user(reg_request); return; case NL80211_REGDOM_SET_BY_DRIVER: if (!wiphy) @@ -2099,7 +2096,9 @@ static void reg_process_hint(struct regulatory_request *reg_request) goto out_free; } - /* This is required so that the orig_* parameters are saved */ + /* This is required so that the orig_* parameters are saved. +* NOTE: treatment must be set for any case that reaches here! +*/ if (treatment == REG_REQ_ALREADY_SET wiphy wiphy-regulatory_flags REGULATORY_STRICT_REG) { wiphy_update_regulatory(wiphy, reg_request-initiator); -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mwifiex: avoid freeing improper pointer in mwifiex_set_wowlan_mef_entry
mwifiex_set_wowlan_mef_entry attempts to free a passed-in pointer in case of an error. The only caller (mwifiex_set_mef_filter) passes that pointer as an offset into allocated memory, so any attempt to free that will not be the actual allocated pointer. Address this by changing mwifiex_set_wowlan_mef_entry to not do any free, and to cause mwifiex_set_mef_filter to do the appropriate free if the call to mwifiex_set_wowlan_mef_entry fails. Coverity CID #1295879 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/mwifiex/cfg80211.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c index b15e4c7acbec..3f6762dfc947 100644 --- a/drivers/net/wireless/mwifiex/cfg80211.c +++ b/drivers/net/wireless/mwifiex/cfg80211.c @@ -2954,7 +2954,6 @@ static int mwifiex_set_wowlan_mef_entry(struct mwifiex_private *priv, MWIFIEX_MEF_MAX_BYTESEQ)) { mwifiex_dbg(priv-adapter, ERROR, Pattern not supported\n); - kfree(mef_entry); return -EOPNOTSUPP; } @@ -3036,9 +3035,12 @@ static int mwifiex_set_mef_filter(struct mwifiex_private *priv, mwifiex_set_auto_arp_mef_entry(priv, mef_entry[0]); - if (wowlan-n_patterns || wowlan-magic_pkt) + if (wowlan-n_patterns || wowlan-magic_pkt) { ret = mwifiex_set_wowlan_mef_entry(priv, mef_cfg, mef_entry[1], wowlan); + if (ret) + goto err; + } if (!mef_cfg.criteria) mef_cfg.criteria = MWIFIEX_CRITERIA_BROADCAST | @@ -3048,6 +3050,8 @@ static int mwifiex_set_mef_filter(struct mwifiex_private *priv, ret = mwifiex_send_cmd(priv, HostCmd_CMD_MEF_CFG, HostCmd_ACT_GEN_SET, 0, mef_cfg, true); + +err: kfree(mef_entry); return ret; } -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] wireless: remove superfluous if statement in regulatory code
In reg_process_hint, the test of treatment == REG_REQ_IGNORE || treatment == REG_REQ_ALREADY_SET is superfluous because the code in the if-then branch is identical to the code after the if statement. Coverity CID #1295939 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- net/wireless/reg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index d359e0610198..fe6b0c6cca10 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -2080,9 +2080,6 @@ static void reg_process_hint(struct regulatory_request *reg_request) return; case NL80211_REGDOM_SET_BY_USER: treatment = reg_process_hint_user(reg_request); - if (treatment == REG_REQ_IGNORE || - treatment == REG_REQ_ALREADY_SET) - return; return; case NL80211_REGDOM_SET_BY_DRIVER: if (!wiphy) -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mwifiex: do not short circuit exit from mwifiex_set_mgmt_ies
Without this change, the code simply exits after calling mwifiex_uap_set_head_tail_ies, leving the call to mwifiex_set_mgmt_beacon_data_ies as dead code. Coverity CID #1271292 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/mwifiex/ie.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/mwifiex/ie.c b/drivers/net/wireless/mwifiex/ie.c index 0ba894509413..23e368c77c08 100644 --- a/drivers/net/wireless/mwifiex/ie.c +++ b/drivers/net/wireless/mwifiex/ie.c @@ -409,6 +409,8 @@ int mwifiex_set_mgmt_ies(struct mwifiex_private *priv, int ret; ret = mwifiex_uap_parse_tail_ies(priv, info); + + if (ret) return ret; return mwifiex_set_mgmt_beacon_data_ies(priv, info); -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mac80211: reduce log spam from ieee80211_handle_pwr_constr
This changes a couple of messages from sdata_info to sdata_dbg. This should reduce some log spam, as reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1206468 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- net/mac80211/mlme.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 00103f36dcbf..26053bf2faa8 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -1348,15 +1348,15 @@ static u32 ieee80211_handle_pwr_constr(struct ieee80211_sub_if_data *sdata, */ if (has_80211h_pwr (!has_cisco_pwr || pwr_level_80211h = pwr_level_cisco)) { - sdata_info(sdata, - Limiting TX power to %d (%d - %d) dBm as advertised by %pM\n, - pwr_level_80211h, chan_pwr, pwr_reduction_80211h, - sdata-u.mgd.bssid); + sdata_dbg(sdata, + Limiting TX power to %d (%d - %d) dBm as advertised by %pM\n, + pwr_level_80211h, chan_pwr, pwr_reduction_80211h, + sdata-u.mgd.bssid); new_ap_level = pwr_level_80211h; } else { /* has_cisco_pwr is always true here. */ - sdata_info(sdata, - Limiting TX power to %d dBm as advertised by %pM\n, - pwr_level_cisco, sdata-u.mgd.bssid); + sdata_dbg(sdata, + Limiting TX power to %d dBm as advertised by %pM\n, + pwr_level_cisco, sdata-u.mgd.bssid); new_ap_level = pwr_level_cisco; } -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull-request: wireless-drivers-next 2015-02-07
On Mon, Feb 09, 2015 at 12:13:42PM -0800, David Miller wrote: From: Kalle Valo kv...@codeaurora.org Date: Sat, 07 Feb 2015 13:40:51 +0200 There's a small conflict in drivers/net/wireless/rtlwifi/pci.c, the fix is to leave the two labels like this: schedule_work(rtlpriv-works.lps_change_work); } end: skb = new_skb; no_new: if (rtlpriv-use_new_trx_flow) { That can't be the correct resolution: drivers/net/wireless/rtlwifi/pci.c: In function ‘_rtl_pci_rx_interrupt’: drivers/net/wireless/rtlwifi/pci.c:934:1: warning: label ‘end’ defined but not used [-Wunused-label] So I've removed that label in the merge commit. FWIW, that's the way I have it in wireless-testing as well... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ath5k: document a fall-through case in ath5k_hw_set_opmode
Coverity: CID 114932 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- I'm guessing this is OK, since it seems to work? drivers/net/wireless/ath/ath5k/pcu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c index c60d36aa13e2..bf29da5e90da 100644 --- a/drivers/net/wireless/ath/ath5k/pcu.c +++ b/drivers/net/wireless/ath/ath5k/pcu.c @@ -912,6 +912,7 @@ ath5k_hw_set_opmode(struct ath5k_hw *ah, enum nl80211_iftype op_mode) pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE | (ah-ah_version == AR5K_AR5210 ? AR5K_STA_ID1_PWR_SV : 0); + /* fall through */ case NL80211_IFTYPE_MONITOR: pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE | (ah-ah_version == AR5K_AR5210 ? -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ath9k_htc: remove dead code in error path of ath9k_htc_txcompletion_cb
This clause is conditioned on htc_hdr != NULL, but it will only be NULL when that check is reached. Coverity: CID 114318 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/ath/ath9k/htc_hst.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c index a0ff5b637054..d2408da38c1c 100644 --- a/drivers/net/wireless/ath/ath9k/htc_hst.c +++ b/drivers/net/wireless/ath/ath9k/htc_hst.c @@ -351,11 +351,7 @@ void ath9k_htc_txcompletion_cb(struct htc_target *htc_handle, return; ret: - /* HTC-generated packets are freed here. */ - if (htc_hdr htc_hdr-endpoint_id != ENDPOINT0) - dev_kfree_skb_any(skb); - else - kfree_skb(skb); + kfree_skb(skb); } static void ath9k_htc_fw_panic_report(struct htc_target *htc_handle, -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] iwlwifi: document switch case fall-through in iwl_mvm_send_sta_key
Add a comment indicating that the WLAN_CIPHER_SUITE_WEP104 case falls through to the WLAN_CIPHER_SUITE_WEP40 case in iwl_mvm_send_sta_key. This will document that the lack of a break is intentional. Coverity: CID 1260023 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- This seems to work, so I'm guessing that the fall-through is intentional... drivers/net/wireless/iwlwifi/mvm/sta.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/iwlwifi/mvm/sta.c b/drivers/net/wireless/iwlwifi/mvm/sta.c index d86fe432e51f..c0fc4fc0161b 100644 --- a/drivers/net/wireless/iwlwifi/mvm/sta.c +++ b/drivers/net/wireless/iwlwifi/mvm/sta.c @@ -1196,6 +1196,7 @@ static int iwl_mvm_send_sta_key(struct iwl_mvm *mvm, break; case WLAN_CIPHER_SUITE_WEP104: key_flags |= cpu_to_le16(STA_KEY_FLG_WEP_13BYTES); + /* fall through */ case WLAN_CIPHER_SUITE_WEP40: key_flags |= cpu_to_le16(STA_KEY_FLG_WEP); memcpy(cmd.key + 3, keyconf-key, keyconf-keylen); -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mac80211: uninitialized return val in __ieee80211_sta_handle_tspec_ac_params
Coverity: CID 1260096 Signed-off-by: John W. Linville linvi...@tuxdriver.com --- net/mac80211/mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 2c36c4765f47..837a406a9dd6 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -1643,7 +1643,7 @@ __ieee80211_sta_handle_tspec_ac_params(struct ieee80211_sub_if_data *sdata) { struct ieee80211_local *local = sdata-local; struct ieee80211_if_managed *ifmgd = sdata-u.mgd; - bool ret; + bool ret = false; int ac; if (local-hw.queues IEEE80211_NUM_ACS) -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: changes to Linux wireless maintenance
On Sun, Dec 21, 2014 at 10:50:40AM +0100, Arend van Spriel wrote: The trees work similarly like John's wireless and wireless-next trees, the former only for important bugfixes to -rc releases and the latter for the rest going to the next release. So are you dropping the wireless-testing tree? From earlier IRC discussion I figured that tree was still in demand. I still plan to maintain a version of wireless-testing for some amount of time. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
changes to Linux wireless maintenance
Greetings, Almost 9 years ago, Jeff Garzik wrote a message on LKML detailing the sad state of wireless LANs in the Linux world. The point of his message was So... there it is. We suck. There's hope. No Luke Skywalker in sight.: https://lkml.org/lkml/2006/1/5/671 Shortly thereafter, I became the maintainer for wireless LANs in the Linux kernel: https://lkml.org/lkml/2006/1/18/377 Since then, we have had a number of wireless summit meetings all around the world. Items were discussed, patches were merged, and friendships were made. Over time, we garnered support from a large range of wireless networking vendors. Eventually even other technologies were sending their patches through my trees, and I was consistently ranked amongst the top 10 gate keepers for getting changes into the Linux kernel. In fact, a couple of years ago I even gave a talk on how Linux wireless got better. It has been quite a ride! https://events.linuxfoundation.org/images/stories/pdf/lfcs2012_linville.pdf Nevertheless, I think it is time for some changes. I have been the wireless maintainer for a long time, and I personally would like to develop in a different direction. Plus, I think that Linux will benefit from having some fresh blood involved in more of the maintenance duties. I will be stepping aside to let that happen. The mac80211, bluetooth, and nfc trees have fed through me for some time. I am now asking these trees to send pull request directly to David Miller. Since these trees are managed through git, my hope is that they will not place any significant burden on Dave. As for the wireless driver patches, I have asked Kalle Valo to handle patch review and merge duties for everything under the drivers/net/wireless directory. This will now include not only the ath patches he already manages, but other drivers that don't have trees such as mwifiex, rt2x00, rtlwifi, and others. For consistency, the iwlwifi tree will also be merged through Kalle's new tree. I expect that Kalle will announce any relevant details in a follow-up message. The wireless-testing tree is a resource that some people value. I will continue to provide a wireless-testing tree. Now that tree will feed from the various wireless trees managed by others, probably with some sort of regularly scheduled pulls. Details are still to be determined, but the tree will still exist and will be substantially similar to how it has been so far. I also receive notices of new bug reports for wireless LANs on bugzilla.kernel.org. For now I will continue to triage those reports, so don't ignore me!! :-) Some may ask what I will do now -- I wish I had a specific answer. Immediate plans are to enjoy the coming holidays and my traditional year-end time away from work. After that...well, I'm sure I will find something to do. If you have any suggestions for good uses of my talents, feel free to contact me -- I'm not hard to find! In closing, I hope everyone will support Kalle and the other wireless maintainers at least as much as you have supported me for the past several years. These are good, hard working folks. You are in good hands! Regards, John P.S. Bonus points for anyone that finds a way for me to become a professional retro-computing hobbyist... :-) -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] MAINTAINERS: changes for wireless
http://marc.info/?l=linux-wirelessm=141883202530292w=2 This makes it official... :-) Signed-off-by: John W. Linville linvi...@tuxdriver.com --- MAINTAINERS | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fdffe962a16a..e82d31aeb936 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6603,19 +6603,8 @@ L: net...@vger.kernel.org S: Maintained NETWORKING [WIRELESS] -M: John W. Linville linvi...@tuxdriver.com L: linux-wireless@vger.kernel.org Q: http://patchwork.kernel.org/project/linux-wireless/list/ -T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git -S: Maintained -F: net/mac80211/ -F: net/rfkill/ -F: net/wireless/ -F: include/net/ieee80211* -F: include/linux/wireless.h -F: include/uapi/linux/wireless.h -F: include/net/iw_handler.h -F: drivers/net/wireless/ NETWORKING DRIVERS L: net...@vger.kernel.org @@ -6636,6 +6625,14 @@ F: include/linux/inetdevice.h F: include/uapi/linux/if_* F: include/uapi/linux/netdevice.h +NETWORKING DRIVERS (WIRELESS) +M: Kalle Valo kv...@codeaurora.org +L: linux-wireless@vger.kernel.org +Q: http://patchwork.kernel.org/project/linux-wireless/list/ +T: git git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/ +S: Maintained +F: drivers/net/wireless/ + NETXEN (1/10) GbE SUPPORT M: Manish Chopra manish.cho...@qlogic.com M: Sony Chacko sony.cha...@qlogic.com -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull request: wireless 2014-12-16
Dave, Please pull this batch of fixes intended for the 3.19 stream! For the Bluetooth bits, Johan says: The patches consist of: - Coccinelle warning fix - hci_dev_lock/unlock fixes - Fixes for pending mgmt command handling - Fixes for properly following the force_lesc_support switch - Fix for a Microsoft branded Broadcom adapter - New device id for Atheros AR3012 - Fix for BR/EDR Secure Connections enabling Along with that... Brian Norris avoids leaking some kernel memory contents via printk in brcmsmac. Julia Lawall corrects some misspellings in a few drivers. Larry Finger gives us one more rtlwifi fix to correct a porting oversight. Wei Yongjun fixes a sparse warning in rtlwifi. Please let me know if there are problems! Thanks, John --- The following changes since commit 67e2c3883828b39548cee2091b36656787775d95: Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security (2014-12-14 20:36:37 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git tags/master-2014-12-15 for you to fetch changes up to 9a1dce3a059111a7289680f4b8c0ec4f8736b6ee: rtlwifi: rtl8192ce: Set fw_ready flag (2014-12-15 13:46:20 -0500) Brian Norris (1): brcmsmac: don't leak kernel memory via printk() Fengguang Wu (1): Bluetooth: fix err_cast.cocci warnings Jaganath Kanakkassery (2): Bluetooth: Fix missing hci_dev_lock/unlock in mgmt req_complete() Bluetooth: Fix missing hci_dev_lock/unlock in hci_event Janne Heikkinen (1): Bluetooth: Add USB device 04ca:3010 as Atheros AR3012 Johan Hedberg (5): Bluetooth: Fix calling hci_conn_put too early Bluetooth: Fix incorrect pending cmd removal in pairing_complete() Bluetooth: Fix notifying mgmt power off before flushing connection list Bluetooth: Fix enabling BR/EDR SC when powering on Bluetooth: Fix mgmt response status when removing adapter John W. Linville (1): Merge branch 'for-upstream' of git://git.kernel.org/.../bluetooth/bluetooth-next Julia Lawall (3): zd1211rw: fix misspelling of current function in string hostap_cs: fix misspelling of current function in string rtlwifi: rtl8821ae: fix misspelling of current function in string Larry Finger (1): rtlwifi: rtl8192ce: Set fw_ready flag Marcel Holtmann (4): Bluetooth: Check for force_lesc_support when enabling SMP over BR/EDR Bluetooth: Check for force_lesc_support before rejecting SMP over BR/EDR Bluetooth: Fix generation of non-resolvable private addresses Bluetooth: Fix check for support for page scan related commands Wei Yongjun (1): rtlwifi: rtl8192cu: Fix sparse non static symbol warning drivers/bluetooth/ath3k.c | 2 + drivers/bluetooth/btusb.c | 1 + drivers/net/wireless/brcm80211/brcmsmac/main.c | 2 +- drivers/net/wireless/hostap/hostap_cs.c| 15 ++--- drivers/net/wireless/rtlwifi/rtl8192ce/hw.c| 2 + drivers/net/wireless/rtlwifi/rtl8192cu/hw.c| 2 +- drivers/net/wireless/rtlwifi/rtl8821ae/dm.c| 11 ++-- drivers/net/wireless/zd1211rw/zd_chip.c| 6 +- net/bluetooth/hci_conn.c | 2 +- net/bluetooth/hci_core.c | 60 ++ net/bluetooth/hci_event.c | 20 ++ net/bluetooth/l2cap_core.c | 5 +- net/bluetooth/mgmt.c | 85 ++ net/bluetooth/smp.c| 5 +- 14 files changed, 143 insertions(+), 75 deletions(-) diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c index fce758896280..1ee27ac18de0 100644 --- a/drivers/bluetooth/ath3k.c +++ b/drivers/bluetooth/ath3k.c @@ -87,6 +87,7 @@ static const struct usb_device_id ath3k_table[] = { { USB_DEVICE(0x04CA, 0x3007) }, { USB_DEVICE(0x04CA, 0x3008) }, { USB_DEVICE(0x04CA, 0x300b) }, + { USB_DEVICE(0x04CA, 0x3010) }, { USB_DEVICE(0x0930, 0x0219) }, { USB_DEVICE(0x0930, 0x0220) }, { USB_DEVICE(0x0930, 0x0227) }, @@ -140,6 +141,7 @@ static const struct usb_device_id ath3k_blist_tbl[] = { { USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 }, { USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 }, { USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 }, + { USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 }, { USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 }, { USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 }, { USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 }, diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 31dd24ac9926..19cf2cf22e87 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -167,6 +167,7 @@ static
Re: pull request: bluetooth 2014-12-12
On Fri, Dec 12, 2014 at 07:44:35PM +0200, Johan Hedberg wrote: Hi John, These fixes are intended for 3.19, note that the tree to pull from is bluetooth-next (unlike the subject implies). I'd have normally done a pull request from bluetooth.git, but since these fixes for 3.19 is all we have so far I thought it's simpler if you just pull from our -next tree. The patches consist of: - Coccinelle warning fix - hci_dev_lock/unlock fixes - Fixes for pending mgmt command handling - Fixes for properly following the force_lesc_support switch - Fix for a Microsoft branded Broadcom adapter - New device id for Atheros AR3012 - Fix for BR/EDR Secure Connections enabling Please let me know if there are any issues pulling. Thanks. Johan --- The following changes since commit 5a34bd5f5d8119def4feb1d2b4e3906b71059416: Bluetooth: Enable events for P-256 Public Key and DHKey commands (2014-12-05 18:17:49 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git for-upstream for you to fetch changes up to 9845904fd489288bcf693642c1b31cc463c0b660: Bluetooth: Fix mgmt response status when removing adapter (2014-12-12 13:20:12 +0100) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] wireless-regdb: Update keys and maintainer information
On Fri, Dec 05, 2014 at 10:31:34AM -0600, Seth Forshee wrote: As announced by John [1], I'm taking over maintaintership of the wireless regulatory databse. Make it official by adding my key, removing John's, and updating the Makefile and documentation to reflect the change in maintainer. [1] http://permalink.gmane.org/gmane.linux.kernel.wireless.general/131573 Signed-off-by: Seth Forshee seth.fors...@canonical.com ACK Although, I would have changed In linville we trust to In Seth we trust... ;-) John --- Makefile | 3 +-- debian-example/control | 2 +- linville.key.pub.pem | 9 - sforshee.key.pub.pem | 9 + wireless-regdb.spec| 2 +- 5 files changed, 12 insertions(+), 13 deletions(-) delete mode 100644 linville.key.pub.pem create mode 100644 sforshee.key.pub.pem diff --git a/Makefile b/Makefile index 3d5040d..907ff28 100644 --- a/Makefile +++ b/Makefile @@ -32,7 +32,7 @@ REGDB_AUTHOR ?= $(shell if [ -f $(DISTRO_PRIVKEY) ]; then \ REGDB_PRIVKEY ?= ~/.wireless-regdb-$(REGDB_AUTHOR).key.priv.pem REGDB_PUBKEY ?= $(REGDB_AUTHOR).key.pub.pem -REGDB_UPSTREAM_PUBKEY ?= linville.key.pub.pem +REGDB_UPSTREAM_PUBKEY ?= sforshee.key.pub.pem REGDB_CHANGED = $(shell $(SHA1SUM) -c --status sha1sum.txt /dev/null 21; \ if [ $$? -ne 0 ]; then \ @@ -103,7 +103,6 @@ install: regulatory.bin.5.gz if [ -f .custom ]; then \ install -m 644 -t $(DESTDIR)/$(CRDA_KEY_PATH)/ $(shell cat .custom); \ fi - @# In linville we trust install -m 644 -t $(DESTDIR)/$(CRDA_KEY_PATH)/ $(REGDB_UPSTREAM_PUBKEY) install -m 644 -t $(DESTDIR)/$(CRDA_PATH)/ regulatory.bin install -m 755 -d $(DESTDIR)/$(MANDIR)/man5/ diff --git a/debian-example/control b/debian-example/control index a5b518b..e6e7161 100644 --- a/debian-example/control +++ b/debian-example/control @@ -12,4 +12,4 @@ Suggests: crda Description: The Linux wireless regulatory database This package contains the wireless regulatory database used by all cfg80211 based Linux wireless drivers. The wireless database being - used is maintained by John Linville, the Linux wireless kernel maintainer. + used is maintained by Seth Forshee. diff --git a/linville.key.pub.pem b/linville.key.pub.pem deleted file mode 100644 index 3a2e8d0..000 --- a/linville.key.pub.pem +++ /dev/null @@ -1,9 +0,0 @@ --BEGIN PUBLIC KEY- -MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA1leZcYjTXc4qLq1oN2Ak -8vLP85P5cFTrCpqdSI5W4VOwdaJB4TtaxU2fATcH/A2EsE3h1rOfzI0+fBV9DcOO -qyID+zdILBMb8xK5Zv+78OkBGls/WzvDDVhdmn1TRHvRvmJy7cX1mCT56cnHrZM/ -ZBaFwVfiD9TcqqisyF1sqE5+cMHTWRbxc1+rtojr0eGYrNfK20awlD5KVj6Ejzot -r9EDWAsL1bH/kGfMdnputcyMapLQpRVruO/jEdjSmhAE/sj1tmHcAXBT6j5al4Oa -LiBaWnP++rune7rjimwfzp0549/rupQUM7nAZRDLyzXj3J/KEci6dXtjonBUFqDY -4QIDAQAB --END PUBLIC KEY- diff --git a/sforshee.key.pub.pem b/sforshee.key.pub.pem new file mode 100644 index 000..73d580e --- /dev/null +++ b/sforshee.key.pub.pem @@ -0,0 +1,9 @@ +-BEGIN PUBLIC KEY- +MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAtUDjnCiEOQPyOddmLEE4 +Fax+pYNxJX6QfGjdbz/Z11k4n3xqUsIDKi1+ZvQesxJwIFvUlzI9cYs7GwgXFGth +xFeLlhYc/STVCwn5aBGE+8pRDNFFGdoQRIrZ/nap/WAtGAsolbIt6oiYuNFWIfBT +H/ECb+lGm5NfKJAPrDb6aCNxV1b2zNPffSrZG3NF67onhe96f6XLgMcwNtJT7uys +Hucx8TainGPGZVt/JXVooerTfgBcml7YIBgydwcpEmYeNnPnlwRBN7Gxciv0oSkg +fJZ5CyvQ2N7IbD+T+8XueFIRFRt69uJomef7RhaE48eh5uDSRtXhxF+gZvTaxP+V +HQIDAQAB +-END PUBLIC KEY- diff --git a/wireless-regdb.spec b/wireless-regdb.spec index b76d391..bb648ca 100644 --- a/wireless-regdb.spec +++ b/wireless-regdb.spec @@ -16,7 +16,7 @@ BuildArch: noarch %description This package contains the wireless regulatory database used by all cfg80211 based Linux wireless drivers. The wireless database being -used is maintained by John Linville, the Linux wireless kernel maintainer +used is maintained by Seth Forshee. http://wireless.kernel.org/en/developers/Regulatory/ %prep -- 1.9.1 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT] [3.19] NFC update
On Tue, Dec 02, 2014 at 11:37:49PM +0100, Samuel Ortiz wrote: Hi John, This is the NFC pull request for 3.19. With this one we get: - NFC digital improvements for DEP support: Chaining, NACK and ATN support added. - NCI improvements: Support for p2p target, SE IO operand addition, SE operands extensions to support proprietary implementations, and a few fixes. - NFC HCI improvements: OPEN_PIPE and NOTIFY_ALL_CLEARED support, and SE IO operand addition. - A bunch of minor improvements and fixes for STMicro st21nfcb and st21nfca Thanks in advance for pulling that one in. The following changes since commit 18ca43823f3ce111c6efb8cc90d9f35246527727: mwifiex: add Tx status support for ACTION frames (2014-11-25 14:09:57 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-next.git tags/nfc-next-3.19-1 for you to fetch changes up to e479ce479743984a5d4581749f9aaa9c3bfd65e4: NFC: NCI: Fix max length of General Bytes in ATR_RES (2014-12-02 22:59:28 +0100) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull-request: mac80211-next 2014-12-03
On Wed, Dec 03, 2014 at 08:48:22AM +0100, Johannes Berg wrote: Hi John, Yes, you were right - I must have missed that you merged my other pull request. I hope you can still pull this in time for the next merge window. Unfortunately I can't send a signed tag because I forgot my yubikey at home and thus can't upload anything to kernel.org. I hope you can accept signed pgp email instead. This time I have Felix's no-status rate control work, which will allow drivers to work better with rate control even if they don't have perfect status reporting. In addition to this, a small hwsim fix from Patrik, one of the regulatory patches from Arik, and a number of cleanups and fixes I did myself. Of note is a patch where I disable CFG80211_WEXT so that compatibility is no longer selectable - this is intended as a wake-up call for anyone who's still using it, and is still easily worked around (it's a one-line patch) before we fully remove the code as well in the future. Let me know if there's any problem. johannes The following changes since commit 75769c80e381653994293b5aa5a8cfec50088f9f: mac80211: minstrel_ht: add a small optimization to minstrel_aggr_check (2014-11-19 19:31:07 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git for you to fetch changes up to f027c2aca0cf43e0f15fc8de8841f7b566163d94: mac80211: add ieee80211_tx_status_noskb (2014-11-28 15:01:51 +0100) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
new regulatory database mainteiner -- Seth Forshee
Greetings, As you may know, I have been maintaining the wireless regulatory rules database used by CRDA since the project was started. Although I am not an expert on regulatory law by anyone's estimation, I have maintained this database both through personal trust in those presenting patches and through an abundance of caution about only applying non-controversial changes. In any case, I now find other demands on my time. I have asked Seth Forshee if he would be willing to accept this responsibility from me and Seth has graciously done so. Seth, Luis, and I have been in the process of making the actual technical hand-off over the past several days, and I think everything should be in place soon (if it isn't already there now). This includes ensuring that Seth has the necessary access for publishing wireless-regdb updates on kernel.org, and ensuring that his public signing key is included as part of the CRDA package distribution. I would like to thank Seth for taking this important duty upon himself and I wish him all the best in doing so. I hope that everyone else will do the same! Thanks, John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] MAINTAINERS: orphan rtl8180
Signed-off-by: John W. Linville linvi...@tuxdriver.com --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7ec37a396ffe..e3f40df47513 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7845,11 +7845,10 @@ S: Maintained F: drivers/media/dvb-frontends/rtl2832_sdr* RTL8180 WIRELESS DRIVER -M: John W. Linville linvi...@tuxdriver.com L: linux-wireless@vger.kernel.org W: http://wireless.kernel.org/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git -S: Maintained +S: Orphan F: drivers/net/wireless/rtl818x/rtl8180/ RTL8187 WIRELESS DRIVER -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/10] wil6210 fixes, reroll
I already merged the earlier version. Feel free to send any changes on top, ASAP! On Tue, Dec 02, 2014 at 11:46:28AM +0200, Vladimir Kondratiev wrote: Assorted fixes V2: split single commit into 2, accordingly to input by Joe Perches. re-sending whole series to avoid mis-interpretation. Vladimir Kondratiev (10): wil6210: propagate disconnect reason wil6210: introduce wil_err_ratelimited() wil6210: add handling of RX HTRSH interrupt wil6210: fix recovery after scan timeout wil6210: remove wil_to_pcie_dev() wil6210: configurable vring sizes wil6210: fix warning in pointer arithmetic wil6210: Rate limit ring full error message wil6210: reset flow update wil6210: remove TODO wrt buffer alignment drivers/net/wireless/ath/wil6210/cfg80211.c | 2 +- drivers/net/wireless/ath/wil6210/debug.c | 17 drivers/net/wireless/ath/wil6210/fw.c| 1 - drivers/net/wireless/ath/wil6210/fw_inc.c| 4 +- drivers/net/wireless/ath/wil6210/interrupt.c | 30 +++-- drivers/net/wireless/ath/wil6210/main.c | 63 +--- drivers/net/wireless/ath/wil6210/txrx.c | 11 +++-- drivers/net/wireless/ath/wil6210/wil6210.h | 15 --- drivers/net/wireless/ath/wil6210/wmi.c | 8 ++-- 9 files changed, 114 insertions(+), 37 deletions(-) -- 2.1.0 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: iwlwifi-next 2014-12-02
On Tue, Dec 02, 2014 at 06:05:39PM +, Grumbach, Emmanuel wrote: Hi John, This is a last pull request with content for 3.19. As usual, the details are below. Thanks! The following changes since commit dcad8e4299bf81f8795b44677036dfa490c9fb15: iwlwifi: update the secure mem space and for the CPUs (2014-11-24 08:30:44 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git tags/iwlwifi-next-for-john-2014-12-02 for you to fetch changes up to 61df750cb00b69882ba3acbb82e9368d01119c93: iwlwifi: mvm: Ability to work with packed usniffer image (2014-12-02 16:51:56 +0200) I deprecate here -8.ucode since -9 has been published long ago. Along with that I have a new activity, we have now better a infrastructure for firmware debugging. This will allow to have configurable probes insides the firmware. Luca continues his work on NetDetect, this feature is now complete. All the rest is minor fixes here and there. Pulled... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] wireless/p54: Remove duplicated net2280 header
Did you check the wireless-next tree's git logs? commit a831f20b6d6460640b83644d1c1df6e7e8ca9f68 Author: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Date: Mon Nov 24 11:19:51 2014 +0100 wireless/p54: Remove duplicated net2280 header The usb gadget driver net2280 has exported a header file with the register definition of the net2280 chip. Remove the custom/duplicated header file in favor of that header file in include/linux Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Signed-off-by: John W. Linville linvi...@tuxdriver.com On Mon, Dec 01, 2014 at 11:46:43AM +0100, Ricardo Ribalda Delgado wrote: David Miller has marked the patch as Awaiting Upstream, which I think means that it should be merged through the wireless tree. Any comment from there? On Mon, Nov 24, 2014 at 11:19 AM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: The usb gadget driver net2280 has exported a header file with the register definition of the net2280 chip. Remove the custom/duplicated header file in favor of that header file in include/linux Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/net/wireless/p54/net2280.h | 451 - drivers/net/wireless/p54/p54usb.h | 13 +- 2 files changed, 12 insertions(+), 452 deletions(-) delete mode 100644 drivers/net/wireless/p54/net2280.h diff --git a/drivers/net/wireless/p54/net2280.h b/drivers/net/wireless/p54/net2280.h deleted file mode 100644 index aedfaf2..000 --- a/drivers/net/wireless/p54/net2280.h +++ /dev/null @@ -1,451 +0,0 @@ -#ifndef NET2280_H -#define NET2280_H -/* - * NetChip 2280 high/full speed USB device controller. - * Unlike many such controllers, this one talks PCI. - */ - -/* - * Copyright (C) 2002 NetChip Technology, Inc. (http://www.netchip.com) - * Copyright (C) 2003 David Brownell - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, see http://www.gnu.org/licenses/. - */ - -/*-*/ - -/* NET2280 MEMORY MAPPED REGISTERS - * - * The register layout came from the chip documentation, and the bit - * number definitions were extracted from chip specification. - * - * Use the shift operator ('') to build bit masks, with readl/writel - * to access the registers through PCI. - */ - -/* main registers, BAR0 + 0x */ -struct net2280_regs { - /* offset 0x */ - __le32 devinit; -#define LOCAL_CLOCK_FREQUENCY 8 -#define FORCE_PCI_RESET7 -#define PCI_ID 6 -#define PCI_ENABLE 5 -#define FIFO_SOFT_RESET4 -#define CFG_SOFT_RESET 3 -#define PCI_SOFT_RESET 2 -#define USB_SOFT_RESET 1 -#define M8051_RESET0 - __le32 eectl; -#define EEPROM_ADDRESS_WIDTH 23 -#define EEPROM_CHIP_SELECT_ACTIVE 22 -#define EEPROM_PRESENT 21 -#define EEPROM_VALID 20 -#define EEPROM_BUSY19 -#define EEPROM_CHIP_SELECT_ENABLE 18 -#define EEPROM_BYTE_READ_START 17 -#define EEPROM_BYTE_WRITE_START16 -#define EEPROM_READ_DATA 8 -#define EEPROM_WRITE_DATA 0 - __le32 eeclkfreq; - u32 _unused0; - /* offset 0x0010 */ - - __le32 pciirqenb0; /* interrupt PCI master ... */ -#define SETUP_PACKET_INTERRUPT_ENABLE 7 -#define ENDPOINT_F_INTERRUPT_ENABLE6 -#define ENDPOINT_E_INTERRUPT_ENABLE5 -#define
Re: pull request: bluetooth-next 2014-11-27
On Thu, Nov 27, 2014 at 12:36:06PM +0200, Johan Hedberg wrote: Hi John, Here's one more bluetooth-next pull request for 3.19: - Minor cleanups for ieee802154 mac802154 - Fix for the kernel warning with !TASK_RUNNING reported by Kirill A. Shutemov - Support for another ath3k device - Fix for tracking link key based security level - Device tree bindings for btmrvl + a state update fix - Fix for wrong ACL flags on LE links Please let me know if there are any issues pulling. Thanks. Johan --- The following changes since commit a86c02ea38c53b695209b1181f9e2e18d73eb4e8: Bluetooth: Add support for Broadcom BCM20702A1 variant (2014-11-18 08:32:14 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git for-upstream for you to fetch changes up to f6af675ef5489c69fc3d4faf8c6f477df3cbf8b9: Bluetooth: Automatically flushable packets aren't allowed on LE links (2014-11-27 12:12:27 +0200) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Pull request: ath 20141201
On Mon, Dec 01, 2014 at 02:42:41PM +0200, Kalle Valo wrote: Hi John, here's a pull request I'm hoping still to get to 3.19. The changelog is below. Please let me know if you have any problems. -- Only ath10k changes this time and no major changes. Most visible are: o new debugfs interface for runtime firmware debugging (Yanbo) o fix shared WEP (Sujith) o don't rebuild whenever kernel version changes (Johannes) o lots of refactoring to make it easier to add new hw support (Michal) There's also smaller fixes and improvements with no point of listing here. -- The following changes since commit 47b6308b643302e642ca2a5cb6470926f7e1c428: ath9k: Move roc completion to the offchannel timer (2014-11-17 15:32:17 -0500) are available in the git repository at: git://github.com/kvalo/ath.git for-linville for you to fetch changes up to fe2407a889f7b6530b7e231e7c866f5c5d223657: ath10k: simplify rx ring size/fill calculation (2014-12-01 09:29:27 +0200) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: New FCC requirements and Linux Wifi
On Mon, Dec 01, 2014 at 04:27:25PM -0600, Eric Schultz wrote: All, I work for the prpl Foundation, an open source foundation organized by a number of companies, most related to MIPS. One project we work with externally is the OpenWrt project. Recently one of our members mentioned a new FCC requirement (described in FCC publication 594280) which requires wifi hardware devices to restrict modifications in ways that were not previously required. Some of the suggestions the company had internally for complying would be to use features like Secure Boot and other types of DRM-like mechanisms to prevent routers from being modified. This obviously would be quite bad for the OpenWrt community (and the embedded Linux community as a whole) so we agreed as a group to try to provide hardware companies with a way of complying without harming the community. I'm looking to find individuals (and other companies!) interested in working with myself and the foundation, companies, the OpenWrt community and eventually regulators to provide guidance to hardware companies on how to best comply with these rules. If you're interested in getting involved or just would like to know more, please get in touch with me. We want to make sure that routers and related embedded Linux hardware is hackable and we could use all the help we could get. Thanks and I look forward to working with you, Eric Eric, Obviously, I would be interested in hearing more. I suspect there are others on the list that will be interested as well... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull request: wireless 2014-11-26
Dave, Please pull this little batch of fixes intended for the 3.18 stream... For the iwlwifi one, Emmanuel says: Not all the firmware know how to handle the HOT_SPOT_CMD. Make sure that the firmware will know this command before sending it. This avoids a firmware crash. Along with that, Larry sends a pair of rtlwifi fixes to address some discrepancies from moving drivers out of staging. Larry says: These two patches are needed to fix a regression introduced when driver rtl8821ae was moved from staging to the regular wireless tree. Please let me know if there are problems! Thanks, John --- The following changes since commit a1d69c60c44134f64945bbf6a6dfda22eaf4a214: brcmfmac: don't include linux/unaligned/access_ok.h (2014-11-20 14:46:45 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git tags/master-2014-11-25 for you to fetch changes up to 7d63a5f9b25ba6b130da8eb2d32a72b1462d0249: rtlwifi: Change order in device startup (2014-11-25 14:22:22 -0500) John W. Linville (1): Merge tag 'iwlwifi-for-john-2014-11-23' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Larry Finger (2): rtlwifi: rtl8821ae: Fix 5G detection problem rtlwifi: Change order in device startup Luciano Coelho (1): iwlwifi: mvm: check TLV flag before trying to use hotspot firmware commands drivers/net/wireless/iwlwifi/iwl-fw.h | 2 ++ drivers/net/wireless/iwlwifi/mvm/mac80211.c | 12 +--- drivers/net/wireless/rtlwifi/pci.c | 20 ++-- drivers/net/wireless/rtlwifi/rtl8821ae/hw.c | 5 +++-- 4 files changed, 24 insertions(+), 15 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/iwl-fw.h b/drivers/net/wireless/iwlwifi/iwl-fw.h index 4f6e66892acc..b894a84e8393 100644 --- a/drivers/net/wireless/iwlwifi/iwl-fw.h +++ b/drivers/net/wireless/iwlwifi/iwl-fw.h @@ -155,6 +155,7 @@ enum iwl_ucode_tlv_api { * @IWL_UCODE_TLV_CAPA_QUIET_PERIOD_SUPPORT: supports Quiet Period requests * @IWL_UCODE_TLV_CAPA_DQA_SUPPORT: supports dynamic queue allocation (DQA), * which also implies support for the scheduler configuration command + * @IWL_UCODE_TLV_CAPA_HOTSPOT_SUPPORT: supports Hot Spot Command */ enum iwl_ucode_tlv_capa { IWL_UCODE_TLV_CAPA_D0I3_SUPPORT = BIT(0), @@ -163,6 +164,7 @@ enum iwl_ucode_tlv_capa { IWL_UCODE_TLV_CAPA_WFA_TPC_REP_IE_SUPPORT = BIT(10), IWL_UCODE_TLV_CAPA_QUIET_PERIOD_SUPPORT = BIT(11), IWL_UCODE_TLV_CAPA_DQA_SUPPORT = BIT(12), + IWL_UCODE_TLV_CAPA_HOTSPOT_SUPPORT = BIT(18), }; /* The default calibrate table size if not specified by firmware file */ diff --git a/drivers/net/wireless/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/iwlwifi/mvm/mac80211.c index b62405865b25..b6d2683da3a9 100644 --- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c @@ -2448,9 +2448,15 @@ static int iwl_mvm_roc(struct ieee80211_hw *hw, switch (vif-type) { case NL80211_IFTYPE_STATION: - /* Use aux roc framework (HS20) */ - ret = iwl_mvm_send_aux_roc_cmd(mvm, channel, - vif, duration); + if (mvm-fw-ucode_capa.capa[0] + IWL_UCODE_TLV_CAPA_HOTSPOT_SUPPORT) { + /* Use aux roc framework (HS20) */ + ret = iwl_mvm_send_aux_roc_cmd(mvm, channel, + vif, duration); + goto out_unlock; + } + IWL_ERR(mvm, hotspot not supported\n); + ret = -EINVAL; goto out_unlock; case NL80211_IFTYPE_P2P_DEVICE: /* handle below */ diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c index 61f5d36eca6a..846a2e6e34d8 100644 --- a/drivers/net/wireless/rtlwifi/pci.c +++ b/drivers/net/wireless/rtlwifi/pci.c @@ -2249,6 +2249,16 @@ int rtl_pci_probe(struct pci_dev *pdev, /*like read eeprom and so on */ rtlpriv-cfg-ops-read_eeprom_info(hw); + if (rtlpriv-cfg-ops-init_sw_vars(hw)) { + RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, Can't init_sw_vars\n); + err = -ENODEV; + goto fail3; + } + rtlpriv-cfg-ops-init_sw_leds(hw); + + /*aspm */ + rtl_pci_init_aspm(hw); + /* Init mac80211 sw */ err = rtl_init_core(hw); if (err) { @@ -2264,16 +2274,6 @@ int rtl_pci_probe(struct pci_dev *pdev, goto fail3; } - if (rtlpriv-cfg-ops-init_sw_vars(hw)) { - RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, Can't init_sw_vars\n); - err = -ENODEV; - goto fail3; - } - rtlpriv-cfg-ops-init_sw_leds(hw
Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs
On Tue, Nov 25, 2014 at 02:00:38PM +0100, Arend van Spriel wrote: On 11/25/14 13:12, Arend van Spriel wrote: On 11/24/14 22:50, John W. Linville wrote: Hmmm...I'm not sure why, but this is causing problems for me... ERROR: brcmu_boardrev_str [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined! I am confused as well. I did not have such an issue. The function is provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added it to the include file. Missing something? Also I don't see this issue over here. I will do a clean build on the wireless-next tree and see if I can reproduce this. So I did a fresh checkout of wireless-next/master and applied patch 2 and 3. Here is my build output: $ make M=drivers/net/wireless/brcm80211 modules CC [M] drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/ucode_loader.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/ampdu.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/antsel.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/channel.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/main.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy_shim.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/pmu.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/rate.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/stf.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/aiutils.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phytbl_lcn.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phytbl_n.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_qmath.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/dma.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/brcms_trace_events.o CC [M] drivers/net/wireless/brcm80211/brcmsmac/debug.o LD [M] drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.o CC [M] drivers/net/wireless/brcm80211/brcmutil/utils.o CC [M] drivers/net/wireless/brcm80211/brcmutil/d11.o LD [M] drivers/net/wireless/brcm80211/brcmutil/brcmutil.o Building modules, stage 2. MODPOST 2 modules CC drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.mod.o LD [M] drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko CC drivers/net/wireless/brcm80211/brcmutil/brcmutil.mod.o LD [M] drivers/net/wireless/brcm80211/brcmutil/brcmutil.ko Anything else I should try over here? /home/linville/git/wireless-testing [linville-x1.hq.tuxdriver.com]: make M=drivers/net/wireless/brcm80211 modules Building modules, stage 2. MODPOST 3 modules WARNING: brcmu_boardrev_str [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined! CC drivers/net/wireless/brcm80211/brcmfmac/brcmfmac.mod.o LD [M] drivers/net/wireless/brcm80211/brcmfmac/brcmfmac.ko CC drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.mod.o LD [M] drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko CC drivers/net/wireless/brcm80211/brcmutil/brcmutil.mod.o LD [M] drivers/net/wireless/brcm80211/brcmutil/brcmutil.ko -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] brcmutil: add helper function to format board revision
On Tue, Nov 25, 2014 at 11:01:47AM +0100, Arend van Spriel wrote: On 11/24/14 22:53, John W. Linville wrote: I am holding patches 2-4 until we resolve the brcmu_boardrev_str build thing... Actually, only patch 2 and 3 are related to the build thing. If that is what this is. OK, I won't hold-up #4... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs
On Tue, Nov 25, 2014 at 08:16:17PM +0100, Arend van Spriel wrote: On 11/25/14 20:05, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote: On 11/24/14 22:50, John W. Linville wrote: Hmmm...I'm not sure why, but this is causing problems for me... ERROR: brcmu_boardrev_str [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined! I am confused as well. I did not have such an issue. The function is provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added it to the include file. Missing something? Also I don't see this issue over here. I will do a clean build on the wireless-next tree and see if I can reproduce this. I did a clean build after applying the patches in question, and I still got the same issue at link time. I'll attach my .config for you to try. I think that was too big...trying the compressed version... I received both. I assume he commit mentioned below is without the patches. Regards, Arend FWIW, I am building wireless-testing at commit 733ea24c8c98d99c747b89710e520ac6e9f3951b. John That commit includes all 4 patches. I reverted the last three later in the wireless-testing history. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: iwlwifi-next 2014-11-24
On Mon, Nov 24, 2014 at 04:34:02PM +0200, Emmanuel Grumbach wrote: Hi John, I have a big batch here. New features were unblocked by the merge a few patches in mac80211-next.git and I was away for 2 weeks. I plan to have another pull request for wireless-next before the merge window opens. Details below - please pull. Thanks, The following changes since commit 9e6f3f472c8f95021ad048acc7cd3e40a827f8ce: mwifiex: Add USB8766 support (2014-11-20 16:14:39 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git tags/iwlwifi-next-for-john-2014-11-24 for you to fetch changes up to dcad8e4299bf81f8795b44677036dfa490c9fb15: iwlwifi: update the secure mem space and for the CPUs (2014-11-24 08:30:44 +0200) Major works are CSA and TDLS. On top of that I have a new firmware API for scan and a few rate control improvements. Johannes find a few tricks to improve our CPU utilization and adds support for a new spin of 7265 called 7265D. Along with this a few random things that don't stand out. Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: iwlwifi 2014-11-23
On Sun, Nov 23, 2014 at 09:56:23PM +0200, Emmanuel Grumbach wrote: Hi John, I have a trivial patch for 3.18. details below. Thanks! The following changes since commit 87dd634ae72bb8f6d0dd12f1cbbc67c7da6dba3b: iwlwifi: pcie: fix prph dump length (2014-11-11 07:24:57 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git tags/iwlwifi-for-john-2014-11-23 for you to fetch changes up to 5ac6c72e594471acfa5b00210c51d533a73413ad: iwlwifi: mvm: check TLV flag before trying to use hotspot firmware commands (2014-11-23 21:50:57 +0200) Not all the firmware know how to handle the HOT_SPOT_CMD. Make sure that the firmware will know this command before sending it. This avoids a firmware crash. Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull request: wireless-next 2014-11-21
mac80211: minstrel_ht: add a small optimization to minstrel_aggr_check Fengguang Wu (1): at86rf230: fix simple_return.cocci warnings Fugang Duan (1): Bluetooth: hci-uart-ath: Correct the comments in this driver Hauke Mehrtens (3): b43: fix NULL pointer dereference in b43_phy_copy() bcma: make it possible to specify a IRQ num in bcma_core_irq() bcma: get IRQ numbers from dt Henning Rogge (1): cfg80211: fix nl80211 cmd id in nl80211_send_mpath() Jaganath Kanakkassery (1): Bluetooth: Send mgmt_connected only if state is BT_CONFIG James Cameron (1): mwifiex: simplify ad hoc join capability info Johan Hedberg (21): Bluetooth: Fix sparse warnings in RFCOMM Bluetooth: Fix sparse warning in amp.c Bluetooth: Fix mgmt connected notification Bluetooth: 6lowpan: Remove unnecessary RCU callback Bluetooth: Fix l2cap_sock_teardown_cb lockdep warning Bluetooth: Remove unnecessary hci_dev_lock/unlock in smp.c Bluetooth: Use proper nesting annotation for l2cap_chan lock Bluetooth: Fix L2CAP socket lock nesting level Bluetooth: Fix L2CAP nesting level initialization location Bluetooth: Fix correct nesting for 6lowpan server channel Bluetooth: Fix sending incorrect LE CoC PDU in BT_CONNECT2 state Bluetooth: Add key preference parameter to smp_sufficient_security Bluetooth: Trigger SMP for the appropriate LE CoC errors Bluetooth: Convert LTK list to RCU Bluetooth: Convert IRK list to RCU Bluetooth: Remove unnecessary hdev locking in smp.c Bluetooth: Add debug logs to help track locking issues Bluetooth: Fix clearing remote OOB data through mgmt Bluetooth: Fix BR/EDR-only address checks for remote OOB data Bluetooth: Use shorter rand name for randomizer Bluetooth: Call drain_workqueue() before resetting state Johannes Berg (12): mac80211: add back support for radiotap vendor namespace data mac80211: refactor duplicate detection Merge remote-tracking branch 'wireless-next/master' into mac80211-next mac80211: move skb info band assignment out mac80211: factor out 802.11 header building code mac80211: add function to create data frame template including key cfg80211: allow drivers to support random MAC addresses for scan mac80211: rcu-ify scan and scheduled scan request pointers mac80211: allow drivers to support NL80211_SCAN_FLAG_RANDOM_ADDR mac80211_hwsim: support scanning with random MAC address mac80211-hwsim: remove unnecessary hwname check mac80211: notify drivers on sta rate table changes John W. Linville (8): Merge tag 'mac80211-for-john-2014-11-10' of git://git.kernel.org/.../jberg/mac80211 Merge tag 'iwlwifi-for-john-2014-11-10' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge branch 'for-upstream' of git://git.kernel.org/.../bluetooth/bluetooth-next ath9k_htc: remove return of value in empty definintion of ath9k_htc_deinit_debug Merge branch 'for-linville' of git://github.com/kvalo/ath Merge branch 'for-upstream' of git://git.kernel.org/.../bluetooth/bluetooth-next Merge commit '4e6ce4dc7ce71d0886908d55129d5d6482a27ff9' of git://git.kernel.org/.../linville/wireless Merge tag 'mac80211-next-for-john-2014-11-20' of git://git.kernel.org/.../jberg/mac80211-next Jukka Rissanen (2): mac80211-hwsim: hwname is always known so use the value from wiphy nl80211: Replace interface socket owner attribute with more generic one Kristian Evensen (1): mwifiex: Add USB8766 support Kuba Pawlak (2): Bluetooth: Clear role switch pending flag Bluetooth: Sort switch cases by opcode's numeric value Larry Finger (3): rtlwifi: Fix setting of tx descriptor for new trx flow rtlwifi: Fix errors in descriptor manipulation rtlwifi: rtl8192se: Fix connection problems Liad Kaufman (5): iwlwifi: pcie: fix prph dump length mac80211: add option for setting skb flags before xmit mac80211: retransmit TDLS teardown packet through AP if not ACKed mac80211: add specific-queue flushing support mac80211: synchronously reserve TID per station Luciano Coelho (9): mac80211: fix order of setting ch_switch and drv_pre_channel_switch call mac80211: add device_timestamp to the drv_pre_channel_switch trace cfg80211: add channel switch started notification mac80211: send channel switch started notifications cfg80211/mac80211: allow any interface to send channel switch notifications wlcore: check minimum buffer size in some cmd_send functions wlcore: make wlcore_cmd_send_failsafe() static cfg80211: refactor nl80211_start_sched_scan so it can be reused cfg80211: add wowlan net-detect support Marcel Holtmann (11): Bluetooth: Check status of command complete for HCI_Reset Bluetooth: Print error message
pull request: wireless 2014-11-20
Dave, Please full this little batch of fixes intended for the 3.18 stream! For the mac80211 patch, Johannes says: Here's another last minute fix, for minstrel HT crashing depending on the value of some uninitialised stack. On top of that... Ben Greear fixes an ath9k regression in which a BSSID mask is miscalculated. Dmitry Torokhov corrects an error handling routing in brcmfmac which was checking an unsigned variable for a negative value. Johannes Berg avoids a build problem in brcmfmac for arches where linux/unaligned/access_ok.h and asm/unaligned.h conflict. Mathy Vanhoef addresses another brcmfmac issue so as to eliminate a use-after-free of the URB transfer buffer if a timeout occurs. Please let me know if there are problems! Thanks, John --- The following changes since commit 4e6ce4dc7ce71d0886908d55129d5d6482a27ff9: ath9k: Fix RTC_DERIVED_CLK usage (2014-11-11 16:24:18 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git tags/master-2014-11-20 for you to fetch changes up to a1d69c60c44134f64945bbf6a6dfda22eaf4a214: brcmfmac: don't include linux/unaligned/access_ok.h (2014-11-20 14:46:45 -0500) Ben Greear (1): ath9k: fix regression in bssidmask calculation Dmitry Torokhov (1): brcmfmac: fix error handling of irq_of_parse_and_map Felix Fietkau (1): mac80211: minstrel_ht: fix a crash in rate sorting Johannes Berg (1): brcmfmac: don't include linux/unaligned/access_ok.h John W. Linville (1): Merge tag 'mac80211-for-john-2014-11-18' of git://git.kernel.org/.../jberg/mac80211 Mathy Vanhoef (1): brcmfmac: kill URB when request timed out drivers/net/wireless/ath/ath9k/main.c | 9 ++--- drivers/net/wireless/brcm80211/brcmfmac/of.c | 4 ++-- drivers/net/wireless/brcm80211/brcmfmac/pcie.c | 2 +- drivers/net/wireless/brcm80211/brcmfmac/usb.c | 6 -- net/mac80211/rc80211_minstrel_ht.c | 15 ++- 5 files changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 30c66dfcd7a0..4f18a6be0c7d 100644 --- a/drivers/net/wireless/ath/ath9k/main.c +++ b/drivers/net/wireless/ath/ath9k/main.c @@ -974,9 +974,8 @@ void ath9k_calculate_iter_data(struct ath_softc *sc, struct ath_vif *avp; /* -* Pick the MAC address of the first interface as the new hardware -* MAC address. The hardware will use it together with the BSSID mask -* when matching addresses. +* The hardware will use primary station addr together with the +* BSSID mask when matching addresses. */ memset(iter_data, 0, sizeof(*iter_data)); memset(iter_data-mask, 0xff, ETH_ALEN); @@ -1205,6 +1204,8 @@ static int ath9k_add_interface(struct ieee80211_hw *hw, list_add_tail(avp-list, avp-chanctx-vifs); } + ath9k_calculate_summary_state(sc, avp-chanctx); + ath9k_assign_hw_queues(hw, vif); an-sc = sc; @@ -1274,6 +1275,8 @@ static void ath9k_remove_interface(struct ieee80211_hw *hw, ath_tx_node_cleanup(sc, avp-mcast_node); + ath9k_calculate_summary_state(sc, avp-chanctx); + mutex_unlock(sc-mutex); } diff --git a/drivers/net/wireless/brcm80211/brcmfmac/of.c b/drivers/net/wireless/brcm80211/brcmfmac/of.c index f05f5270fec1..927bffd5be64 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/of.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/of.c @@ -40,8 +40,8 @@ void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev) return; irq = irq_of_parse_and_map(np, 0); - if (irq 0) { - brcmf_err(interrupt could not be mapped: err=%d\n, irq); + if (!irq) { + brcmf_err(interrupt could not be mapped\n); devm_kfree(dev, sdiodev-pdata); return; } diff --git a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c index 8c0632ec9f7a..16fef3382019 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c @@ -19,10 +19,10 @@ #include linux/pci.h #include linux/vmalloc.h #include linux/delay.h -#include linux/unaligned/access_ok.h #include linux/interrupt.h #include linux/bcma/bcma.h #include linux/sched.h +#include asm/unaligned.h #include soc.h #include chipcommon.h diff --git a/drivers/net/wireless/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/brcm80211/brcmfmac/usb.c index dc135915470d..875d1142c8b0 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/usb.c @@ -669,10 +669,12 @@ static int brcmf_usb_dl_cmd(struct brcmf_usbdev_info *devinfo, u8 cmd, goto finalize; } - if (!brcmf_usb_ioctl_resp_wait(devinfo
Re: pull-request: mac80211-next 2014-11-20
On Thu, Nov 20, 2014 at 04:28:59PM +0100, Johannes Berg wrote: Hi John, Here's another relatively large batch of changes - arguably the most important being the VHT fix from Felix :-) Let me know of any problems! johannes The following changes since commit 47b6308b643302e642ca2a5cb6470926f7e1c428: ath9k: Move roc completion to the offchannel timer (2014-11-17 15:32:17 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git tags/mac80211-next-for-john-2014-11-20 for you to fetch changes up to 75769c80e381653994293b5aa5a8cfec50088f9f: mac80211: minstrel_ht: add a small optimization to minstrel_aggr_check (2014-11-19 19:31:07 +0100) It has been a while since my last pull request, so we accumulated another relatively large set of changes: * TDLS off-channel support set from Arik/Liad, with some support patches I did * custom regulatory fixes from Arik * minstrel VHT fix (and a small optimisation) from Felix * add back radiotap vendor namespace support (myself) * random MAC address scanning for cfg80211/mac80211/hwsim (myself) * CSA improvements (Luca) * WoWLAN Net Detect (wake on network found) support (Luca) * and lots of other smaller changes from many people Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [REGRESSION] mwifiex: memory corruption on WEP disassociation
or the handling of the result?) For the moment this workaround fixes the problem for me:(hack patch, probably white space broken) diff --git a/drivers/net/wireless/mwifiex/sta_cmdresp.c b/drivers/net/wireless/mwifiex/sta_cmdresp.c index 577f297..e50c9fe 100644 --- a/drivers/net/wireless/mwifiex/sta_cmdresp.c +++ b/drivers/net/wireless/mwifiex/sta_cmdresp.c @@ -591,6 +591,14 @@ static int mwifiex_ret_802_11_key_material_v1(struct mwifiex_private *priv, memset(priv-aes_key.key_param_set.key, 0, sizeof(key-key_param_set.key)); + + if (le16_to_cpu(resp-size) + (S_DS_GEN + sizeof(key-action) + offsetof(struct mwifiex_ie_type_key_param_set, key))) { + + printk(KERN_WARNING @MF@ %s: ignoring short response\n, __func__); + return 0; + } + priv-aes_key.key_param_set.key_len = key-key_param_set.key_len; memcpy(priv-aes_key.key_param_set.key, key-key_param_set.key, le16_to_cpu(priv-aes_key.key_param_set.key_len)); @@ -624,6 +632,14 @@ static int mwifiex_ret_802_11_key_material_v2(struct mwifiex_private *priv, memset(priv-aes_key_v2.key_param_set.key_params.aes.key, 0, WLAN_KEY_LEN_CCMP); + + if (le16_to_cpu(resp-size) + (S_DS_GEN + sizeof(key_v2-action) + offsetof(struct mwifiex_ie_type_key_param_set_v2, key_params))) { + + printk(KERN_WARNING @MF@ %s: ignoring short response\n, __func__); + return 0; + } + priv-aes_key_v2.key_param_set.key_params.aes.key_len = key_v2-key_param_set.key_params.aes.key_len; len = priv-aes_key_v2.key_param_set.key_params.aes.key_len; Regards, Martin Fuzzey -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: iwlwifi 2014-11-10
On Mon, Nov 10, 2014 at 09:37:16PM -0800, Emmanuel Grumbach wrote: Hi John, This is a pull request for 3.18. More details below. Please pull - thanks! The following changes since commit 31b8b343e019e0a0c57ca9c13520a87f9cab884b: iwlwifi: fix RFkill while calibrating (2014-11-03 15:29:17 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git tags/iwlwifi-for-john-2014-11-10 for you to fetch changes up to 87dd634ae72bb8f6d0dd12f1cbbc67c7da6dba3b: iwlwifi: pcie: fix prph dump length (2014-11-11 07:24:57 +0200) Two fixes here - we weren't updating mac80211 if a scan was cut short by RFKILL which confused cfg80211. As a result, the latter wouldn't allow to run another scan. Liad fixes a small bug in the firmware dump. Emmanuel Grumbach (1): iwlwifi: mvm: abort scan upon RFKILL Liad Kaufman (1): iwlwifi: pcie: fix prph dump length Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ath9k: fix regression in bssidmask calculation
On Tue, Nov 04, 2014 at 03:22:50PM -0800, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com The commit that went into 3.17: ath9k: Summarize hw state per channel context Group and set hw state (opmode, primary_sta, beacon conf) per channel context instead of whole list of vifs. This would allow each channel context to run in different mode (STA/AP). Signed-off-by: Felix Fietkau n...@openwrt.org Signed-off-by: Rajkumar Manoharan rmano...@qti.qualcomm.com Signed-off-by: John W. Linville linvi...@tuxdriver.com broke multi-vif configuration due to not properly calculating the bssid mask. The test case that caught this was: create wlan0 and sta0-4 (6 total), not sure how much that matters. associate all 6 (works fine) disconnect 5 of them, leaving sta0 up Start trying to bring up the other 5 one at a time. It will fail, with iw events looking like this (in these logs, several sta are trying to come up, but symptom is the same with just one) The patch causing the regression made quite a few changes, but the part I think caused this particular problem was not recalculating the bssid mask when adding and removing interfaces. Re-adding those calls fixes my test case. Fix bad comment as well. Signed-off-by: Ben Greear gree...@candelatech.com --- This needs to be reviewed by ath9k driver folks that added the original patch, at least. Any word from the ath9k posse? And, should be considered for 3.17 stable if fix is accepted upstream. drivers/net/wireless/ath/ath9k/main.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index fbf23ac..d2ad9e95 100644 --- a/drivers/net/wireless/ath/ath9k/main.c +++ b/drivers/net/wireless/ath/ath9k/main.c @@ -947,9 +947,8 @@ void ath9k_calculate_iter_data(struct ath_softc *sc, struct ath_vif *avp; /* - * Pick the MAC address of the first interface as the new hardware - * MAC address. The hardware will use it together with the BSSID mask - * when matching addresses. + * The hardware will use primary station addr together with the + * BSSID mask when matching addresses. */ memset(iter_data, 0, sizeof(*iter_data)); memset(iter_data-mask, 0xff, ETH_ALEN); @@ -1169,6 +1168,8 @@ static int ath9k_add_interface(struct ieee80211_hw *hw, list_add_tail(avp-list, avp-chanctx-vifs); } + ath9k_calculate_summary_state(sc, avp-chanctx); + ath9k_assign_hw_queues(hw, vif); an-sc = sc; @@ -1238,6 +1239,8 @@ static void ath9k_remove_interface(struct ieee80211_hw *hw, ath_tx_node_cleanup(sc, avp-mcast_node); + ath9k_calculate_summary_state(sc, avp-chanctx); + mutex_unlock(sc-mutex); } -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: bluetooth-next 2014-11-07
On Fri, Nov 07, 2014 at 11:27:54AM +0200, Johan Hedberg wrote: Hi John Here's another set of patches for 3.19. Most of it is again fixes and cleanups to ieee802154 related code from Alexander Aring. We've also got better handling of hardware error events along with a proper API for HCI drivers to notify the HCI core of such situations. There's also a minor fix for mgmt events as well as a sparse warning fix. The code for sending HCI commands synchronously also gets a fix where we might loose the completion event in the case of very fast HW (particularly easily reproducible with an emulated HCI device). Please let me know if there are any issues pulling. Thanks. Johan --- The following changes since commit 6bc6c49f1e2f3ab1bec05d1c08aad219ab4eb5d0: mwifiex: add cfg80211 dump_survey handler (2014-10-31 16:07:49 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git for-upstream for you to fetch changes up to 56b2c3eea398c772dd895dc62c18cbdd1ba127b1: 6lowpan: move skb_free from error paths in decompression (2014-11-06 22:09:48 +0100) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ath9k_htc: remove return of value in empty definintion of ath9k_htc_deinit_debug
Cc: Oleksij Rempel li...@rempel-privat.de Signed-off-by: John W. Linville linvi...@tuxdriver.com --- drivers/net/wireless/ath/ath9k/htc.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h index b34acdeb1f21..9dde265d3f84 100644 --- a/drivers/net/wireless/ath/ath9k/htc.h +++ b/drivers/net/wireless/ath/ath9k/htc.h @@ -629,7 +629,9 @@ int ath9k_htc_init_debug(struct ath_hw *ah); void ath9k_htc_deinit_debug(struct ath9k_htc_priv *priv); #else static inline int ath9k_htc_init_debug(struct ath_hw *ah) { return 0; }; -static inline void ath9k_htc_deinit_debug(struct ath9k_htc_priv *priv) { return 0; }; +static inline void ath9k_htc_deinit_debug(struct ath9k_htc_priv *priv) +{ +} #endif /* CONFIG_ATH9K_HTC_DEBUGFS */ #endif /* HTC_H */ -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3 3.18] rtlwifi: rtl8192se: Fix connection problems
On Thu, Nov 06, 2014 at 04:46:42PM -0600, Larry Finger wrote: On 11/06/2014 02:45 PM, John W. Linville wrote: On Wed, Nov 05, 2014 at 07:10:54PM -0600, Larry Finger wrote: Changes in the vendor driver were added to rtlwifi, but some updates to rtl8192se were missed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/net/wireless/rtlwifi/rtl8192se/hw.c | 129 +-- drivers/net/wireless/rtlwifi/rtl8192se/phy.c | 8 +- drivers/net/wireless/rtlwifi/rtl8192se/sw.c | 4 + drivers/net/wireless/rtlwifi/rtl8192se/trx.c | 23 + drivers/net/wireless/rtlwifi/rtl8192se/trx.h | 4 + 5 files changed, 100 insertions(+), 68 deletions(-) This looks a bit big for a fix. Could this be broken-up a bit more? Perhaps you could enhance the changelog a bit more? I had used a scatter-gun approach to finding the missing parts, and I did not take the time to see which changes were crucial, and which were not. Now that I knew what it took, I was able to eliminate a lot of the patch that can be deferred for 3.19. The commit message and the changelog for the new version are Changes in the vendor driver were added to rtlwifi, but some updates to rtl8192se were missed, and the driver could neither scan nor connect. There are other changes that will enhance performance, but this minimal set fixes the basic functionality. drivers/net/wireless/rtlwifi/pci.c | 3 ++- drivers/net/wireless/rtlwifi/rtl8192se/hw.c | 7 +-- drivers/net/wireless/rtlwifi/rtl8192se/phy.c | 2 ++ drivers/net/wireless/rtlwifi/rtl8192se/sw.c | 16 4 files changed, 25 insertions(+), 3 deletions(-) Will that be OK? I need to do more testing, but V2 of the patch should be ready for submission by tomorrow. That sounds better, at least. :-) Thanks, Larry! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull request: wireless-next 2014-11-07
cfg80211: avoid using default in interface type switch mac80211: handle RIC data element in reassociation request John W. Linville (4): Merge tag 'for-linville-20141024' of git://github.com/kvalo/ath Merge tag 'iwlwifi-next-for-john-2014-10-29' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge branch 'for-upstream' of git://git.kernel.org/.../bluetooth/bluetooth-next Merge tag 'mac80211-next-for-john-2014-11-04' of git://git.kernel.org/.../jberg/mac80211-next Jouni Malinen (2): cfg80211: Convert del_station() callback to use a param struct cfg80211: Specify frame and reason code for NL80211_CMD_DEL_STATION Jukka Rissanen (7): mac80211-hwsim: Add support for HWSIM_ATTR_DESTROY_RADIO_ON_CLOSE Bluetooth: 6lowpan: Converting rwlocks to use RCU Bluetooth: 6lowpan: Fix lockdep splats Bluetooth: Wrong style spin lock used mac80211-hwsim: Rename CREATE and DESTROY radio to NEW and DEL radio mac80211-hwsim: Provide multicast event for HWSIM_CMD_NEW_RADIO mac80211-hwsim: Provide multicast event for HWSIM_CMD_DEL_RADIO Julien Catalano (1): trivial: net/mac802154: Fix Kconfig typo Kalle Valo (6): ath10k: don't enable interrupts for the diagnostic window ath10k: add diag_read() to hif ops ath10k: add cal_data debugfs file ath10k: add back enum ath10k_bus ath10k: refactor ath10k_init_download_firmware() ath10k: retrieve calibration data from file Karl Beldan (10): mac80211: minstrel_ht: fix MCS_GROUP_RATES usage cfg80211: set the rates mask in connection probes over specified freq mac80211: fix typo in starting baserate for rts_cts_rate_idx mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats mac80211: minstrel_ht: Increase the range of handled rate indexes mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs mac80211: minstrel_ht: include type (cck/ht) in rates flag mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz mac80211: minstrel_ht: use group flags instead of index to display rates mac80211: minstrel_ht: do not always skip ht rates vht_only is true Larry Finger (1): rtlwifi: rtl8821ae: Remove extra semicolons Li RongQing (1): Bluetooth: 6lowpan: remove unnecessary codes in give_skb_to_upper Liad Kaufman (2): mac80211: fix warning on htmldocs for last_tdls_pkt_time iwlwifi: 8000: fix string given to MODULE_FIRMWARE Loic Poulain (1): Bluetooth: HCI H5 peer reset detection Lorenzo Bianconi (2): ath9k: do not overwrite AR_PHY_RADAR_1 MSB ath9k: set pulse_rssi threshold to 15 Luciano Coelho (15): mac80211: return the vif's chandef in ieee80211_cfg_get_channel() nl80211: sanity check the channel switch counter value mac80211: add device_timestamp to the ieee80211_channel_switch struct mac80211: add extended channel switching capability if the driver supports CSA mac80211: add pre_channel_switch driver operation mac80211: add post_channel_switch driver operation mac80211: wait for the first beacon on the new channel after CSA mac80211: allow channel switch with multiple channel contexts iwlwifi: mvm: hold the rtnl when resuming from a d3 test iwlwifi: mvm: split wowlan handling out of the main suspend function iwlwifi: mvm: move the check if associated outside of the iterator for wowlan iwlwifi: mvm: spin off a function to start scan offload iwlwifi: mvm: add debugfs entry to configure netdetect SSIDs iwlwifi: mvm: change the iwl_mvm_d3_iface_iterator into a generic function iwlwifi: mvm: remove unnecessary includes in tt.c Marcel Holtmann (1): Bluetooth: Clear LE white list when resetting controller Martin Townsend (6): 6lowpan: Use skb_cow in IPHC decompression. Bluetooth: Fix missing channel unlock in l2cap_le_credits 6lowpan: remove skb_deliver from IPHC 6lowpan: fix process_data return values bluetooth:6lowpan: use consume_skb when packet processed successfully ieee802154: 6lowpan: rename process_data and lowpan_process_data Matti Gottlieb (1): iwlwifi: mvm: ROC - bug fixes around time events and locking Max Stepanov (1): iwlwifi: mvm: add MVM_FW_BCAST_FILTER_PASS_ALL option Michal Kazior (27): ath10k: workaround fw beaconing bug ath10k: fix tx/rx chainmask init ath10k: remove unused pdev_set_channel command ath10k: deduplicate wmi_channel code ath10k: deduplicate host mem chunk code ath10k: relocate wmi attach/deatch functions ath10k: deduplicate wmi service ready logic ath10k: clean up phyerr code ath10k: unify wmi event function names ath10k: re-work scan start command building ath10k: print wmi version info ath10k: dump hex bytes with dev string prefix ath10k: add debug dump for pci rx ath10k: split wmi
Re: wireless-regdb: Update regulatory rules for New Zealand (NZ) on 5GHz and 60 GHz [UNCLASSIFIED]
On Tue, Oct 28, 2014 at 01:04:10AM +, Peter Gent wrote: Hi, We wish to note the following changes should be made to the wireless regulatory database to reflect some recent changes to the 60 GHz band here in New Zealand. In additional there are some inaccuracies when compared to our current licencing for the 5 GHz Wi-Fi band. The updated entry for New Zealand should read: 5150 MHz - 5250 MHz 80MHz channels, indoor use only at -7.0 dBW EIRP TPC enabled 5250 MHz - 5350 MHz 80 MHz channels, indoor use at -7.0 dBW EIRP, outdoor use at 0 dBW EIRP with DFS and TPC enabled* 5470 MHz - 5725 MHz 80 MHz channels, 0 dBW EIRP with DFS and TPC enabled* 5725 MHz - 5875 MHz 80 MHz channels, 6.0 dBW EIRP with frequency hopping enabled 57000 MHz - 66000 MHz, indoor use only at 13.0 dBW EIRP *if TPC is not enabled, than transmit power must be reduced by 3dB Further information on SRD licencing rules can be found at http://www.rsm.govt.nz/cms/licensees/types-of-licence/general-user-licences/short-range-devices Regards Peter Peter, Thanks for making us aware of this info. I'm sorry that there has been no other response so far. Changes to our regulatory rules database are typically proposed in the form of a patch. This promotes specificity in making such changes. I suspect that you are unfamiliar with this form of change proposal, so I have taken a first whack at it. While I maintain the database, I am not as radio proficient as I perhaps should be. I normally leave writing such patches for others, and wait for some level of agreement to be reached before applying changes. In this case, it is quite likely that I have overlooked something or misinterpreted (or simply misunderstood) your change suggestions. I hope that you and others will take a moment to comment and/or suggest further changes to my proposed changes below. Without some affirmative commentary I will not apply any derivative of the changes specified below. Thanks! John diff --git a/db.txt b/db.txt index 6cf86e15627b..3b9db42309dc 100644 --- a/db.txt +++ b/db.txt @@ -848,12 +848,20 @@ country NP: DFS-JP (5250 - 5330 @ 80), (20), DFS, AUTO-BW (5735 - 5835 @ 80), (20) +# 5150 MHz - 5250 MHz 80MHz channels, indoor use only at -7.0 dBW EIRP TPC enabled +# 5250 MHz - 5350 MHz 80 MHz channels, indoor use at -7.0 dBW EIRP, outdoor use at 0 dBW EIRP with DFS and TPC enabled* +# 5470 MHz - 5725 MHz 80 MHz channels, 0 dBW EIRP with DFS and TPC enabled* +# 5725 MHz - 5875 MHz 80 MHz channels, 6.0 dBW EIRP with frequency hopping enabled +# 57000 MHz - 66000 MHz, indoor use only at 13.0 dBW EIRP +# *if TPC is not enabled, than transmit power must be reduced by 3dB +# http://www.rsm.govt.nz/cms/licensees/types-of-licence/general-user-licences/short-range-devices country NZ: DFS-FCC (2402 - 2482 @ 40), (30) - (5170 - 5250 @ 80), (17), AUTO-BW - (5250 - 5330 @ 80), (24), DFS, AUTO-BW - (5490 - 5730 @ 160), (24), DFS - (5735 - 5835 @ 80), (30) + (5150 - 5250 @ 80), (20), AUTO-BW + (5250 - 5350 @ 80), (20), DFS, AUTO-BW + (5470 - 5725 @ 160), (27), DFS + (5725 - 5875 @ 80), (33) + (57000 - 66000 @ 2160), (40) country OM: DFS-ETSI (2402 - 2482 @ 40), (20) -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] ath9k: Fix RTC_DERIVED_CLK usage
On Thu, Nov 06, 2014 at 10:52:23AM +0530, Sujith Manoharan wrote: From: Miaoqing Pan miaoq...@qca.qualcomm.com Based on the reference clock, which could be 25MHz or 40MHz, AR_RTC_DERIVED_CLK is programmed differently for AR9340 and AR9550. But, when a chip reset is done, processing the initvals sets the register back to the default value. Fix this by moving the code in ath9k_hw_init_pll() to ar9003_hw_override_ini(). Also, do this override for AR9531. What is the effect of having the clock programmed incorrectly? Cc: sta...@vger.kernel.org Signed-off-by: Miaoqing Pan miaoq...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- v2 - Fix author address. drivers/net/wireless/ath/ath9k/ar9003_phy.c | 13 + drivers/net/wireless/ath/ath9k/hw.c | 13 - 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c index 9bdaa0a..2df6d2e 100644 --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c @@ -664,6 +664,19 @@ static void ar9003_hw_override_ini(struct ath_hw *ah) ah-enabled_cals |= TX_CL_CAL; else ah-enabled_cals = ~TX_CL_CAL; + + if (AR_SREV_9340(ah) || AR_SREV_9531(ah) || AR_SREV_9550(ah)) { + if (ah-is_clk_25mhz) { + REG_WRITE(ah, AR_RTC_DERIVED_CLK, 0x17c 1); + REG_WRITE(ah, AR_SLP32_MODE, 0x0010f3d7); + REG_WRITE(ah, AR_SLP32_INC, 0x0001e7ae); + } else { + REG_WRITE(ah, AR_RTC_DERIVED_CLK, 0x261 1); + REG_WRITE(ah, AR_SLP32_MODE, 0x0010f400); + REG_WRITE(ah, AR_SLP32_INC, 0x0001e800); + } + udelay(100); + } } static void ar9003_hw_prog_ini(struct ath_hw *ah, diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index ee9fb52..04ae1f8 100644 --- a/drivers/net/wireless/ath/ath9k/hw.c +++ b/drivers/net/wireless/ath/ath9k/hw.c @@ -870,19 +870,6 @@ static void ath9k_hw_init_pll(struct ath_hw *ah, udelay(RTC_PLL_SETTLE_DELAY); REG_WRITE(ah, AR_RTC_SLEEP_CLK, AR_RTC_FORCE_DERIVED_CLK); - - if (AR_SREV_9340(ah) || AR_SREV_9550(ah)) { - if (ah-is_clk_25mhz) { - REG_WRITE(ah, AR_RTC_DERIVED_CLK, 0x17c 1); - REG_WRITE(ah, AR_SLP32_MODE, 0x0010f3d7); - REG_WRITE(ah, AR_SLP32_INC, 0x0001e7ae); - } else { - REG_WRITE(ah, AR_RTC_DERIVED_CLK, 0x261 1); - REG_WRITE(ah, AR_SLP32_MODE, 0x0010f400); - REG_WRITE(ah, AR_SLP32_INC, 0x0001e800); - } - udelay(100); - } } static void ath9k_hw_init_interrupt_masks(struct ath_hw *ah, -- 2.1.3 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull request: wireless 2014-11-06
Dave, Please pull this batch of fixes intended for the 3.18 stream... For the mac80211 bits, Johannes says: This contains another small set of fixes for 3.18, these are all over the place and most of the bugs are old, one even dates back to the original mac80211 we merged into the kernel. For the iwlwifi bits, Emmanuel says: I fix here two issues that are related to the firmware loading flow. A user reported that he couldn't load the driver because the rfkill line was pulled up while we were running the calibrations. This was happening while booting the system: systemd was restoring the disable wifi settings and that raised an RFKILL interrupt during the calibration. Our driver didn't handle that properly and this is now fixed. Please let me know if there are problems! Thanks, John --- The following changes since commit 75a916e1944fea8347d2245c62567187e4eff9dd: rtlwifi: rtl8192se: Fix firmware loading (2014-10-30 15:00:23 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git tags/master-2014-11-04 for you to fetch changes up to 0c9a67c8f1d2b71a89f66349362412e9bf6becab: Merge tag 'mac80211-for-john-2014-11-04' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211 (2014-11-04 15:56:33 -0500) Emmanuel Grumbach (2): iwlwifi: mvm: initialize the cur_ucode upon boot iwlwifi: fix RFkill while calibrating Felix Fietkau (1): mac80211: flush keys for AP mode on ieee80211_do_stop Johannes Berg (2): mac80211: properly flush delayed scan work on interface removal mac80211: fix use-after-free in defragmentation John W. Linville (2): Merge tag 'iwlwifi-for-john-2014-11-03' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge tag 'mac80211-for-john-2014-11-04' of git://git.kernel.org/.../jberg/mac80211 Junjie Mao (1): mac80211_hwsim: release driver when ieee80211_register_hw fails Luciano Coelho (2): mac80211: use secondary channel offset IE also beacons during CSA mac80211: schedule the actual switch of the station before CSA count 0 drivers/net/wireless/iwlwifi/mvm/fw.c | 10 +- drivers/net/wireless/iwlwifi/mvm/mac80211.c | 1 + drivers/net/wireless/iwlwifi/mvm/mvm.h | 1 + drivers/net/wireless/iwlwifi/mvm/ops.c | 12 +++- drivers/net/wireless/iwlwifi/pcie/trans.c | 4 ++-- drivers/net/wireless/mac80211_hwsim.c | 4 +++- net/mac80211/ibss.c | 2 +- net/mac80211/ieee80211_i.h | 3 +-- net/mac80211/iface.c| 18 -- net/mac80211/mesh.c | 2 +- net/mac80211/mlme.c | 5 +++-- net/mac80211/rx.c | 14 +++--- net/mac80211/spectmgmt.c| 18 ++ 13 files changed, 58 insertions(+), 36 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/mvm/fw.c b/drivers/net/wireless/iwlwifi/mvm/fw.c index e0d9f19650b0..eb03943f8463 100644 --- a/drivers/net/wireless/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/iwlwifi/mvm/fw.c @@ -284,7 +284,7 @@ int iwl_run_init_mvm_ucode(struct iwl_mvm *mvm, bool read_nvm) lockdep_assert_held(mvm-mutex); - if (WARN_ON_ONCE(mvm-init_ucode_complete)) + if (WARN_ON_ONCE(mvm-init_ucode_complete || mvm-calibrating)) return 0; iwl_init_notification_wait(mvm-notif_wait, @@ -334,6 +334,8 @@ int iwl_run_init_mvm_ucode(struct iwl_mvm *mvm, bool read_nvm) goto out; } + mvm-calibrating = true; + /* Send TX valid antennas before triggering calibrations */ ret = iwl_send_tx_ant_cfg(mvm, mvm-fw-valid_tx_ant); if (ret) @@ -358,11 +360,17 @@ int iwl_run_init_mvm_ucode(struct iwl_mvm *mvm, bool read_nvm) MVM_UCODE_CALIB_TIMEOUT); if (!ret) mvm-init_ucode_complete = true; + + if (ret iwl_mvm_is_radio_killed(mvm)) { + IWL_DEBUG_RF_KILL(mvm, RFKILL while calibrating.\n); + ret = 1; + } goto out; error: iwl_remove_notification(mvm-notif_wait, calib_wait); out: + mvm-calibrating = false; if (iwlmvm_mod_params.init_dbg !mvm-nvm_data) { /* we want to debug INIT and we have no NVM - fake */ mvm-nvm_data = kzalloc(sizeof(struct iwl_nvm_data) + diff --git a/drivers/net/wireless/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/iwlwifi/mvm/mac80211.c index 585fe5b7100f..b62405865b25 100644 --- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c @@ -788,6 +788,7 @@ static void iwl_mvm_restart_cleanup(struct iwl_mvm *mvm) mvm-scan_status = IWL_MVM_SCAN_NONE; mvm-ps_disabled = false; + mvm-calibrating = false; /* just in case one
Re: pull-request: mac80211 2014-11-04
On Tue, Nov 04, 2014 at 09:57:21AM +0100, Johannes Berg wrote: John, Here are a few more fixes for 3.18, I hope that's not a problem. johannes --- The following changes since commit 11b2357d5dbce999803e9055f8c09829a8a87db4: mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats (2014-10-20 16:37:01 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git tags/mac80211-for-john-2014-11-04 for you to fetch changes up to b8fff407a180286aa683d543d878d98d9fc57b13: mac80211: fix use-after-free in defragmentation (2014-11-03 14:28:50 +0100) This contains another small set of fixes for 3.18, these are all over the place and most of the bugs are old, one even dates back to the original mac80211 we merged into the kernel. Felix Fietkau (1): mac80211: flush keys for AP mode on ieee80211_do_stop Johannes Berg (2): mac80211: properly flush delayed scan work on interface removal mac80211: fix use-after-free in defragmentation Junjie Mao (1): mac80211_hwsim: release driver when ieee80211_register_hw fails Luciano Coelho (2): mac80211: use secondary channel offset IE also beacons during CSA mac80211: schedule the actual switch of the station before CSA count 0 drivers/net/wireless/mac80211_hwsim.c | 4 +++- net/mac80211/ibss.c | 2 +- net/mac80211/ieee80211_i.h| 3 +-- net/mac80211/iface.c | 18 -- net/mac80211/mesh.c | 2 +- net/mac80211/mlme.c | 5 +++-- net/mac80211/rx.c | 14 +++--- net/mac80211/spectmgmt.c | 18 ++ 8 files changed, 34 insertions(+), 32 deletions(-) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull request: wireless 2014-10-31
(rtlpriv, COMP_ERR, DBG_EMERG, -Can't register mac80211 hw\n); - return; - } else { - rtlpriv-mac80211.mac80211_registered = 1; - } - rtlpci-irq_alloc = 1; - set_bit(RTL_STATUS_INTERFACE_START, rtlpriv-status); - - /*init rfkill */ - rtl_init_rfkill(hw); } static int rtl92s_init_sw_vars(struct ieee80211_hw *hw) @@ -226,8 +209,8 @@ static int rtl92s_init_sw_vars(struct ieee80211_hw *hw) if (!rtlpriv-rtlhal.pfirmware) return 1; - rtlpriv-max_fw_size = RTL8190_MAX_RAW_FIRMWARE_CODE_SIZE; - + rtlpriv-max_fw_size = RTL8190_MAX_FIRMWARE_CODE_SIZE*2 + + sizeof(struct fw_hdr); pr_info(Driver for Realtek RTL8192SE/RTL8191SE\n Loading firmware %s\n, rtlpriv-cfg-fw_name); /* request fw */ @@ -294,6 +277,7 @@ static struct rtl_hal_ops rtl8192se_hal_ops = { .set_bbreg = rtl92s_phy_set_bb_reg, .get_rfreg = rtl92s_phy_query_rf_reg, .set_rfreg = rtl92s_phy_set_rf_reg, + .get_btc_status = rtl_btc_status_false, }; static struct rtl_mod_params rtl92se_mod_params = { diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c index b358ebce8942..672fd3b02835 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c +++ b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c @@ -640,6 +640,9 @@ u32 rtl92se_get_desc(u8 *desc, bool istx, u8 desc_name) case HW_DESC_RXPKT_LEN: ret = GET_RX_STATUS_DESC_PKT_LEN(desc); break; + case HW_DESC_RXBUFF_ADDR: + ret = GET_RX_STATUS_DESC_BUFF_ADDR(desc); + break; default: RT_ASSERT(false, ERR rxdesc :%d not process\n, desc_name); -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. pgprPeqoWtEJP.pgp Description: PGP signature
Re: [PATCH 3/3] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries
On Tue, Oct 28, 2014 at 01:19:12PM +0100, Arend van Spriel wrote: Use the helper to get rid of the file operations per debugfs file. The struct ath9k_softc pointer is set as device driver data to be obtained in the seq_file read operation. Signed-off-by: Arend van Spriel ar...@broadcom.com Acked-by: John W. Linville linvi...@tuxdriver.com -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: bluetooth-next 2014-10-31
On Fri, Oct 31, 2014 at 08:28:03PM +0200, Johan Hedberg wrote: Hi John, Here's the first bluetooth-next pull request for 3.19. The vast majority of patches are for ieee802154 from Alexander Aring with various fixes and cleanups. There are also several LE/SMP fixes as well as improved support for handling LE devices that have lost their pairing information (the patches from Alfonso). Jukka provides a couple of stability fixes for 6lowpan and Szymon conformance fixes for RFCOMM. For the HCI drivers we have one new USB ID for an Acer controller as well as a reset handling fix for H5. Please let me know if there are any issues pulling. Thanks. Johan --- The following changes since commit 61ed53deb1c6a4386d8710dbbfcee8779c381931: Merge tag 'ntb-3.18' of git://github.com/jonmason/ntb (2014-10-19 12:58:22 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git for-upstream for you to fetch changes up to b509c02d0f31639dda90f9b7269668b86c9b25ef: Bluetooth: HCI H5 peer reset detection (2014-10-31 19:54:34 +0200) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: iwlwifi-next 2014-10-29
On Wed, Oct 29, 2014 at 01:48:50PM +0200, Emmanuel Grumbach wrote: Hi John, Here is a pull request for 3.19. More details below. Thanks! The following changes since commit 35a9ad8af0bb0fa3525e6d0d20e32551d226f38e: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next (2014-10-08 21:40:54 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git tags/iwlwifi-next-for-john-2014-10-29 for you to fetch changes up to d9e4d61c5b900f6938b4aa49f25a0db37aeb23b6: iwlwifi: mvm: unref SCAN ref on scan completion (2014-10-29 13:14:41 +0200) The big new thing here is netdetect which allows the firmware to wake up the platform when a specific network is detected. Along with that I have fixes for d3 operation. The usual amount of rate scaling stuff - we now support STBC. The other commit that stands out is Johannes's work on devcoredump. He basically starts to use the standard infrastructure he built. Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] debugfs: adding helper for single seq_file
On Tue, Oct 28, 2014 at 01:19:09PM +0100, Arend van Spriel wrote: The first patch was already posted earlier: Message-ID: 1413043315-22332-1-git-send-email-ar...@broadcom.com This series include changes in driver code to investigate potential code savings. As example used the ath9k driver as it has a fair amount of debugfs files. In this series it changes 7 debugfs entries to use seq_file and the helper function. Below the output of the size utility: text data bss dec hex filename 115968 1225 28 117221 1c9e5 original/ath9k.o 113224 1225 28 114477 1bf2d seq_file/ath9k.o 111024 1225 28 112277 1b695 helper/ath9k.o This series is for 3.19 kernel and applies to the driver-core-next branch of the driver-core repository. If needed the ath9k patches may be dropped for now and I will resubmit them to wireless-next once the debugfs patch has made it into linux-next. Arend van Spriel (3): debugfs: add helper function to create device related seq_file ath: use seq_file api for ath9k debugfs files ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries Greg, If you are happy with the debugfs change then feel free to merge the wireless patches along with it. John drivers/net/wireless/ath/ath9k/ahb.c | 1 + drivers/net/wireless/ath/ath9k/debug.c | 429 +++-- drivers/net/wireless/ath/ath9k/debug.h | 3 +- drivers/net/wireless/ath/ath9k/pci.c | 1 + fs/debugfs/file.c | 54 + include/linux/debugfs.h| 16 +- 6 files changed, 207 insertions(+), 297 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MediaTek WiFi hardware support in upstream kernel
On Mon, Oct 27, 2014 at 07:19:32PM +0100, Oleksij Rempel wrote: Am 27.10.2014 um 16:20 schrieb John W. Linville: On Mon, Oct 27, 2014 at 11:02:00AM +0800, Etna wrote: I am not a developer, but I stumbled upon this just a couple of days ago in the OpenWRT forums: https://forum.openwrt.org/viewtopic.php?id=53215 In short, MediaTek is looking for volunteers to help get their drivers mainlined in the upstream kernels; this includes drivers for their USB and PCI wifi hardware under both the MediaTek and Ralink brands. They are willing to provide chip info, reference driver, dev board, etc and even some degree of sponsorship, apparently subject to their management's approval. In exchange, they require that the volunteers fulfill the following requirements: - skilled in wifi driver development - provide a suitable schedule / roadmap - be able to get the code mainlined in the official linux kernel. Those who are keen on taking up the task can contact the original poster at hua.shao[AT]mediatek.com **Disclaimer: I am in no way related to, or under the employ of MediaTek or Ralink. I am only posting this here because I have a handful of MT wifi chips which I hope to see being supported in the upstream kernel so that I can actually use them under Linux, Well, this is mostly good to see. I hope there is someone that wants to take-up the cause! If someone is interested in working-on the project above but for whatever reason doesn't want to deal with MediaTek on their own, feel free to contact me. I'll try to be helpful however I can. Thanks, John Sounds interesting and as perfect possibility to learn. I would like to do it, but i have two concerns: - i never wrote an wifi driver from scratch. FWIW, I think MediaTek already has some form of drivers. With that said, it might be easier to write new mac80211-based ones than to adapt the existing ones. - i'm seeking for a job. It means if i will find one, this project will get lower priority. No one can ask anything more. If nobody has problems with this two points, then i'm ok. It sounds like we have a volunteer! Let me know if you need any specific help or guidance. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MediaTek WiFi hardware support in upstream kernel
On Mon, Oct 27, 2014 at 11:02:00AM +0800, Etna wrote: I am not a developer, but I stumbled upon this just a couple of days ago in the OpenWRT forums: https://forum.openwrt.org/viewtopic.php?id=53215 In short, MediaTek is looking for volunteers to help get their drivers mainlined in the upstream kernels; this includes drivers for their USB and PCI wifi hardware under both the MediaTek and Ralink brands. They are willing to provide chip info, reference driver, dev board, etc and even some degree of sponsorship, apparently subject to their management's approval. In exchange, they require that the volunteers fulfill the following requirements: - skilled in wifi driver development - provide a suitable schedule / roadmap - be able to get the code mainlined in the official linux kernel. Those who are keen on taking up the task can contact the original poster at hua.shao[AT]mediatek.com **Disclaimer: I am in no way related to, or under the employ of MediaTek or Ralink. I am only posting this here because I have a handful of MT wifi chips which I hope to see being supported in the upstream kernel so that I can actually use them under Linux, Well, this is mostly good to see. I hope there is someone that wants to take-up the cause! If someone is interested in working-on the project above but for whatever reason doesn't want to deal with MediaTek on their own, feel free to contact me. I'll try to be helpful however I can. Thanks, John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] bcma: fix build when CONFIG_OF_ADDRESS is not set
Yes, I have it queued. Things have been delayed due to my recent travels, etc. On Sat, Oct 25, 2014 at 01:36:53PM -0700, Guenter Roeck wrote: On Thu, Oct 09, 2014 at 11:39:41PM +0200, Hauke Mehrtens wrote: Commit 2101e533f41a (bcma: register bcma as device tree driver) introduces a hard dependency on OF_ADDRESS into the bcma driver. OF_ADDRESS is specifically disabled for the sparc architecture. This results in the following error when building sparc64:allmodconfig. drivers/bcma/main.c: In function 'bcma_of_find_child_device': drivers/bcma/main.c:150:3: error: implicit declaration of function 'of_translate_address' Fixes: 2101e533f41a (bcma: register bcma as device tree driver) Reported-by: Guenter Roeck li...@roeck-us.net Signed-off-by: Hauke Mehrtens ha...@hauke-m.de The upstream kernel still does not include this patch, and the sparc64 build is still broken. Is this patch on its way upstream ? Guenter --- drivers/bcma/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c index d1656c2..1000955 100644 --- a/drivers/bcma/main.c +++ b/drivers/bcma/main.c @@ -132,7 +132,7 @@ static bool bcma_is_core_needed_early(u16 core_id) return false; } -#ifdef CONFIG_OF +#if defined(CONFIG_OF) defined(CONFIG_OF_ADDRESS) static struct device_node *bcma_of_find_child_device(struct platform_device *parent, struct bcma_device *core) { -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] wireless-regdb: add regulatory rule for ETSI members on 60GHz band
On Sun, Oct 19, 2014 at 09:49:52AM +0300, Vladimir Kondratiev wrote: On Tuesday, October 14, 2014 02:28:58 PM Xose Vazquez Perez wrote: (57240 - 65880 @ 2160), (40), NO-OUTDOOR should(must) be replaced by: (57000 - 66000 @ 2160), (40) Yes, looks like you are right. I used draft that I don't see on its location any more, and final document indeed says what you wrote. Would someone like to post a patch to that effect? -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull-request: mac80211 2014-10-23
On Thu, Oct 23, 2014 at 08:35:36PM +0200, Johannes Berg wrote: John, Please pull the below changes for the current 3.18 preparations. More details below. Thanks, johannes --- The following changes since commit 35a9ad8af0bb0fa3525e6d0d20e32551d226f38e: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next (2014-10-08 21:40:54 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git tags/mac80211-for-john-2014-10-23 for you to fetch changes up to 11b2357d5dbce999803e9055f8c09829a8a87db4: mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats (2014-10-20 16:37:01 +0200) Here are a few fixes for the wireless stack: one fixes the RTS rate, one for a debugfs file, one to return the correct channel to userspace, a sanity check for a userspace value and the remaining two are just documentation fixes. Fabian Frederick (1): net: rfkill: kernel-doc warning fixes Karl Beldan (2): mac80211: fix typo in starting baserate for rts_cts_rate_idx mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats Liad Kaufman (1): mac80211: fix warning on htmldocs for last_tdls_pkt_time Luciano Coelho (2): mac80211: return the vif's chandef in ieee80211_cfg_get_channel() nl80211: sanity check the channel switch counter value net/mac80211/cfg.c | 2 +- net/mac80211/rate.c| 2 +- net/mac80211/rc80211_minstrel_debugfs.c| 12 +++- net/mac80211/rc80211_minstrel_ht_debugfs.c | 13 - net/mac80211/sta_info.h| 1 + net/rfkill/core.c | 4 ++-- net/wireless/nl80211.c | 10 +- 7 files changed, 29 insertions(+), 15 deletions(-) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] wireless-regdb: Update rules for Australia (AU) to align with class licence
I'm always a bit cautious about merging regdb patches that loosen the rules. Would anyone with more expertise on such regulations care to comment on this one? On Sun, Oct 12, 2014 at 09:56:51PM +1100, Michael Harris wrote: I am not sure where the existing regdb rules for Australia were derived from (perhaps some default template?) but they are a lot more restrictive than the actual class licence requirements. I have updated to the best of my ability according to the Radiocommunications (Low Interference Potential Devices) Class Licence 2000 which can be found here: http://www.acma.gov.au/Industry/Spectrum/Radiocomms-licensing/Class-licences/class-licences There is also a useful FAQ for 2.4GHz WLANs here: http://www.acma.gov.au/Citizen/Consumer-info/My-connected-home/Wireless-local-area-networks/wireless-lans-in-the-24-ghz-band-faqs Signed-off-by: Michael Harris har...@gmail.com --- db.txt | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/db.txt b/db.txt index f0e4312..94c7010 100644 --- a/db.txt +++ b/db.txt @@ -78,12 +78,22 @@ country AT: DFS-ETSI # 60 gHz band channels 1-4, ref: Etsi En 302 567 (57240 - 65880 @ 2160), (40), NO-OUTDOOR +# Reference: Radiocommunications (Low Interference Potential Devices) Class Licence 2000 +# http://www.acma.gov.au/Industry/Spectrum/Radiocomms-licensing/Class-licences/class-licences country AU: - (2402 - 2482 @ 40), (20) - (5170 - 5250 @ 80), (17) - (5250 - 5330 @ 80), (24), DFS - (5490 - 5710 @ 80), (24), DFS - (5735 - 5835 @ 80), (30) + # Item 45A + (2400 - 2483 @ 40), (36) + # Item 44 + (5150 - 5250 @ 80), (23), NO-OUTDOOR + # Item 44A (assuminging no TPC implemented). + # If TPC implemented then 23dBm allowed. + (5250 - 5350 @ 80), (20), NO-OUTDOOR, DFS + # Item 46 (assuming no TPC implemented) + # If TPC implemented then 30dBm allowed + (5470 - 5600 @ 80), (27), DFS + (5650 - 5725 @ 40), (27), DFS + # Item 45B + (5725 - 5850 @ 80), (36) country AW: DFS-ETSI (2402 - 2482 @ 40), (20) -- 1.8.3.1 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: iwlwifi 2014-10-21
On Thu, Oct 23, 2014 at 09:24:33PM +0300, Emmanuel Grumbach wrote: On Thu, Oct 23, 2014 at 8:48 PM, John W. Linville linvi...@tuxdriver.com wrote: I do not have the 3.18-rc1 tag, because Dave doesn't have it yet in the net.git tre. Please rebase. Done - new tag: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git tags/iwlwifi-for-john-2014-10-23 Pulling now... Thanks, John On Tue, Oct 21, 2014 at 12:29:08PM +0300, Emmanuel Grumbach wrote: Hi John, Here is a first pull request for 3.18. This time I chose to work with signed tags instead of signing emails. Let me know if this is an issue for you. Description of the content below. Note that this you haven't updated your trees yet and Linus released 3.18-rc1 already, I decided to base my trees on Linus's tag. Let me know you want me to change this. Thanks! The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1: Linux 3.18-rc1 (2014-10-19 18:08:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git tags/iwlwifi-for-john-2014-10-21 for you to fetch changes up to ae35aee606d0ea5678c75fa058ea6eb048fc1d79: Revert iwlwifi: mvm: treat EAPOLs like mgmt frames wrt rate (2014-10-21 09:00:27 +0300) I revert here a patch that caused interoperability issues. dvm gets a fix for a bug that was reported by many users. Two minor fixes for BT Coex and platform power fix that helps reducing latency when the PCIe link goes to low power states. Emmanuel Grumbach (5): iwlwifi: configure the LTR iwlwifi: mvm: BT Coex - update the MPLUT Boost register value iwlwifi: mvm: BT coex - fix BT prio for probe requests iwlwifi: dvm: drop non VO frames when flushing Revert iwlwifi: mvm: treat EAPOLs like mgmt frames wrt rate Haim Dreyfuss (1): iwlwifi: mvm: Add tx power condition to bss_info_changed_ap_ibss Liad Kaufman (1): iwlwifi: 8000: fix string given to MODULE_FIRMWARE Matti Gottlieb (1): iwlwifi: mvm: ROC - bug fixes around time events and locking drivers/net/wireless/iwlwifi/dvm/mac80211.c | 24 +--- drivers/net/wireless/iwlwifi/iwl-8000.c | 3 ++- drivers/net/wireless/iwlwifi/iwl-trans.h| 2 ++ drivers/net/wireless/iwlwifi/mvm/coex.c | 4 ++-- drivers/net/wireless/iwlwifi/mvm/coex_legacy.c | 4 ++-- drivers/net/wireless/iwlwifi/mvm/fw-api-power.h | 35 ++- drivers/net/wireless/iwlwifi/mvm/fw-api.h | 1 + drivers/net/wireless/iwlwifi/mvm/fw.c | 9 + drivers/net/wireless/iwlwifi/mvm/mac80211.c | 32 +++- drivers/net/wireless/iwlwifi/mvm/ops.c | 1 + drivers/net/wireless/iwlwifi/mvm/scan.c | 3 ++- drivers/net/wireless/iwlwifi/mvm/time-event.c | 2 +- drivers/net/wireless/iwlwifi/mvm/tx.c | 8 ++-- drivers/net/wireless/iwlwifi/pcie/trans.c | 16 +--- 14 files changed, 103 insertions(+), 41 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 12/13] ath5k: update dependencies
On Wed, Oct 22, 2014 at 03:03:50AM +0400, Sergey Ryazanov wrote: - Use config symbol defined in the driver instead of arch specific one for conditional compilation. - Rename the ATHEROS_AR231X config symbol to ATH25. - Fix include (ar231x_platform.h - ath25_platform.h). - Some of AR231x SoCs (e.g. AR2315) have PCI bus support, so remove !PCI dependency, which block AHB support build. Signed-off-by: Sergey Ryazanov ryazanov@gmail.com Cc: Jiri Slaby jirisl...@gmail.com Cc: Nick Kossifidis mickfl...@gmail.com Cc: Luis R. Rodriguez mcg...@do-not-panic.com Cc: linux-wireless@vger.kernel.org Cc: ath5k-de...@lists.ath5k.org Acked-by: John W. Linville linvi...@tuxdriver.com -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1 net-next] net: rfkill: kernel-doc warning fixes
On Thu, Oct 09, 2014 at 11:16:53AM +0200, Johannes Berg wrote: Applied, with a somewhat better changelog. FWIW, I had already merged that one as-is -- sorry! -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull request: wireless-next 2014-10-03
: Fix sparse: cast to restricted __be32 NFC: st21nfca: Fix scripts/checkpatch.pl warnings Missing a blank line after declarations NFC: st21nfcb: Fix scripts/checkpatch.pl error code indent should use tabs where possible NFC: st21nfcb: Convert to use devm_gpio_request_one NFC: st21nfcb: Remove double assignment of .owner in struct device_driver NFC: st21nfcb: Remove useless new line in nfc_err call NFC: st21nfcb: Remove inappropriate kfree on a previously devm_kzalloc pointer NFC: st21nfca: Fix logic when setting session_id NFC: st21nfca: Remove useless new line in nfc_err call NFC: st21nfca: Change nfcid3 generation NFC: st21nfca: Remove useless err == 0 condition NFC: st21nfca: Remove useless IS_ERR(skb) conditions NFC: st21nfca: Add condition to make sure atr_req-length is valid. NFC: st21nfcb: Fix logic when running into i2c read retry NFC: st21nfca: Clean up st21nfca.h macros NFC: st21nfca: Clean up macros alignment NFC: st21nfca: fix WARNING: else is not generally useful after a break or return NFC: st21nfcb: Remove useless headers NFC: st21nfca: Fix few coding style issue NFC: st21nfca: Fix potential skb leaks in NFC-DEP code NFC: st21nfca: Fix recursive fault when doing p2p in target mode. NFC: dts: st21nfcb_i2c: Fix invalid interrupts polarity. NFC: st21nfcb: Fix improper management of -EREMOTEIO error code. NFC: st21nfcb: Fix improper ndlc T2 management NFC: nci: Add support for proprietary RF Protocols NFC: st21nfcb: Add ISO15693 Reader/Writer support NFC: st21nfcb: remove error output NFC: st21nfca: ERR_PTR vs NULL fix NFC: st21nfca: Fix potential double kfree_skb error Emil Goode (1): NFC: st21nfca: Remove double assignment of .owner in struct device_driver Emmanuel Grumbach (1): iwlwifi: mvm: disable BT Co-running by default Eyal Shapira (5): iwlwifi: mvm: choose an initial tx rate based on rssi conditions iwlwifi: mvm: rs: refactor to allow direct rs updating iwlwifi: mvm: limit aggregation size in low latency to 6 iwlwifi: mvm: report all BA notifs to RS iwlwifi: mvm: rs: fix logic in case of multiple TIDs Felix Fietkau (7): ath5k: add missing include for debug code ath9k: use ah-get_mac_revision for all SoC devices if available ath9k_hw: disable hardware ad-hoc flag on ar934x rev 3 Revert ath9k_hw: reduce ANI firstep range for older chips ath9k_hw: reduce ANI spur immunity setting on HT40 extension channel ath9k_hw: fix PLL clock initialization for newer SoC ath9k: fix getting tx duration for dynack Hante Meuleman (5): brcmfmac: On scan timeout do send received results. brcmfmac: Fix sign issue with IOCTL return code in msgbuf. brcmfmac: Avoid usage of GFP_ATOMIC. brcmfmac: Fix crash on cleanup. brcmfmac: Add wowl support for PCIE devices. Hauke Mehrtens (1): bcma: register bcma as device tree driver Ido Yariv (1): iwlwifi: mvm: support cloned tx skbs Joe Perches (1): Bluetooth: Convert bt_level logging functions to return void Johan Hedberg (6): Bluetooth: btusb: Use GFP_KERNEL in btusb_send_frame() Bluetooth: Fix setting correct security level when initiating SMP Bluetooth: Fix reason code used for rejecting SCO connections Bluetooth: Add retransmission effort into SCO parameter table Bluetooth: Rename sco_param_wideband table to esco_param_msbc Bluetooth: Fix lockdep warning with l2cap_chan_connect John W. Linville (5): Merge branch 'master' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge branch 'for-linville' of git://github.com/kvalo/ath Merge tag 'nfc-next-3.18-1' of git://git.kernel.org/.../sameo/nfc-next Merge branch 'for-upstream' of git://git.kernel.org/.../bluetooth/bluetooth-next Merge branch 'for-upstream' of git://git.kernel.org/.../bluetooth/bluetooth-next Jukka Rissanen (8): MAINTAINERS: add maintainer for generic 6LoWPAN Bluetooth: 6lowpan: Make sure skb exists before accessing it Bluetooth: 6lowpan: Ensure header compression does not corrupt IPv6 header Bluetooth: 6lowpan: Enable multicast support Bluetooth: 6lowpan: Memory leak as the skb is not freed Bluetooth: 6lowpan: Avoid memory leak if memory allocation fails Bluetooth: 6lowpan: Return EAGAIN error also for multicast packets Bluetooth: 6lowpan: Check transmit errors for multicast packets Kalle Valo (12): ath10k: make ath10k_wmi_cmd_send() public ath10k: add testmode ath10k: fix parenthesis alignment warning in ath10k_htt_rx_alloc() ath10k: fix checkpatch warnings about parenthesis alignment ath10k: fix use of multiple blank lines ath10k: fix missing a blank line after declarations ath10k: fix space after a cast style errors ath10k: don't use
Re: [PATCH 15/16] ath5k: update dependencies
/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: iwlwifi-next 2014-09-21
On Sun, Sep 21, 2014 at 10:21:00PM +0300, Emmanuel Grumbach wrote: On 09/21/2014 10:15 PM, Emmanuel Grumbach wrote: Hi John, Here is another (last?) pull request for 3.18. I have here a few things that depend on the latest mac80211's changes: RRM, TPC, Quiet Period etc... Eyal keeps improving our rate control and we have a new device ID. This last patch should probably have gone to wireless.git, but at that stage, I preferred to send it to -next and CC stable. Let me know if you have issues! The following changes since commit 6bd2bd27baf12fa0f2e6d611509fc0e1bffb0f97: Merge tag 'mac80211-next-for-john-2014-09-12' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next (2014-09-15 14:51:23 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git master for you to fetch changes up to 908f324b609320a8839211922f8c4946c891d56c: I had to edit one commit message - new HEAD: 48849a4150e353656dc5d207f2a56ebd00484ce6 I'm pulling this now, but I don't plan to push it back out until after Dave pulls my earlier pull request... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Pull request: ath 20140923
On Tue, Sep 23, 2014 at 12:26:58PM +0300, Kalle Valo wrote: Hi John, a new pull request just with ath10k changes this time. Changelog below and please let me know if there are any problems. -- The only new feature is testmode support from me. Ben added a new method to crash the firmware with an assert for debug purposes. As usual, we have lots of smaller fixes from Michal. Matteo fixed a Kconfig dependency with debugfs. I fixed some warnings recently added to checkpatch. -- The following changes since commit 6a5d088a923854569e20eac4f3f569926d5911ec: carl9170: tx: Replace rcu_assign_pointer() with RCU_INIT_POINTER() (2014-08-28 14:50:13 -0400) are available in the git repository at: git://github.com/kvalo/ath.git for-linville for you to fetch changes up to b25f32cb02155d68c690255ba846796a1c248fd3: ath10k: use ether_addr_copy() (2014-09-18 10:47:03 +0300) Pulling now, but I don't plan to push it back out until Dave pulls my earlier batch... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull request: bluetooth-next 2014-09-25
On Thu, Sep 25, 2014 at 02:35:53PM +0300, Johan Hedberg wrote: Hi John, This 3.18 pull request replaces the one I did on Monday (bluetooth-next 2014-09-22, which hasn't been pulled yet). The additions since the last request are: - SCO connection fix for devices not supporting eSCO - Cleanups regarding the SCO establishment logic - Remove unnecessary return value from logging functions - Header compression fix for 6lowpan - Cleanups to the ieee802154/mrf24j40 driver Here's a copy from previous request that this one replaces: Here are some more patches for 3.18. They include various fixes to the btusb HCI driver, a fix for LE SMP, as well as adding Jukka to the MAINTAINERS file for generic 6LoWPAN (as requested by Alexander Aring). I've held on to this pull request a bit since we were waiting for a SCO related fix to get sorted out first. However, since the merge window is getting closer I decided not to wait for it. If we do get the fix sorted out there'll probably be a second small pull request later this week. Please let me know if there are any issues pulling. Thanks. Johan --- The following changes since commit 9a783a139c32a905825ee0aa9597f485ea461f76: Bluetooth: Fix re-setting RPA as expired when deferring update (2014-09-12 18:34:25 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git for-upstream for you to fetch changes up to 565766b087a6d6ff257f5b79c8ceda0188c9169f: Bluetooth: Rename sco_param_wideband table to esco_param_msbc (2014-09-25 10:35:08 +0200) Pulling now, but I don't plan to push it back out until Dave pulls my earlier batch... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] mwifiex: remove unnecessary rx_q lock
I only got 1/3 and 3/3 -- was there a 2/3 posted? On Thu, Sep 25, 2014 at 05:16:42PM +0530, Avinash Patil wrote: SKB lists have their own lock. So this lock is not needed. Signed-off-by: Avinash Patil pat...@marvell.com --- drivers/net/wireless/mwifiex/init.c | 1 - drivers/net/wireless/mwifiex/main.h | 2 -- drivers/net/wireless/mwifiex/pcie.c | 4 drivers/net/wireless/mwifiex/sdio.c | 3 --- 4 files changed, 10 deletions(-) diff --git a/drivers/net/wireless/mwifiex/init.c b/drivers/net/wireless/mwifiex/init.c index f7c97cf..580aa45 100644 --- a/drivers/net/wireless/mwifiex/init.c +++ b/drivers/net/wireless/mwifiex/init.c @@ -447,7 +447,6 @@ int mwifiex_init_lock_list(struct mwifiex_adapter *adapter) spin_lock_init(adapter-cmd_free_q_lock); spin_lock_init(adapter-cmd_pending_q_lock); spin_lock_init(adapter-scan_pending_q_lock); - spin_lock_init(adapter-rx_q_lock); spin_lock_init(adapter-rx_proc_lock); skb_queue_head_init(adapter-usb_rx_data_q); diff --git a/drivers/net/wireless/mwifiex/main.h b/drivers/net/wireless/mwifiex/main.h index 1a9..b5dc78b 100644 --- a/drivers/net/wireless/mwifiex/main.h +++ b/drivers/net/wireless/mwifiex/main.h @@ -763,8 +763,6 @@ struct mwifiex_adapter { struct list_head scan_pending_q; /* spin lock for scan_pending_q */ spinlock_t scan_pending_q_lock; - /* spin lock for RX queue */ - spinlock_t rx_q_lock; /* spin lock for RX processing routine */ spinlock_t rx_proc_lock; struct sk_buff_head usb_rx_data_q; diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c index 1504b16..7e8d9b0 100644 --- a/drivers/net/wireless/mwifiex/pcie.c +++ b/drivers/net/wireless/mwifiex/pcie.c @@ -1233,7 +1233,6 @@ static int mwifiex_pcie_process_recv_data(struct mwifiex_adapter *adapter) struct sk_buff *skb_tmp = NULL; struct mwifiex_pcie_buf_desc *desc; struct mwifiex_pfu_buf_desc *desc2; - unsigned long flags; if (!mwifiex_pcie_ok_to_access_hw(adapter)) mwifiex_pm_wakeup_card(adapter); @@ -1285,10 +1284,7 @@ static int mwifiex_pcie_process_recv_data(struct mwifiex_adapter *adapter) card-rxbd_rdptr, wrptr, rx_len); skb_pull(skb_data, INTF_HEADER_LEN); if (adapter-rx_work_enabled) { - spin_lock_irqsave(adapter-rx_q_lock, flags); skb_queue_tail(adapter-rx_data_q, skb_data); - spin_unlock_irqrestore(adapter-rx_q_lock, -flags); adapter-data_received = true; atomic_inc(adapter-rx_pending); } else { diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c index ea8fc58..db9e4e3 100644 --- a/drivers/net/wireless/mwifiex/sdio.c +++ b/drivers/net/wireless/mwifiex/sdio.c @@ -1039,7 +1039,6 @@ static int mwifiex_decode_rx_packet(struct mwifiex_adapter *adapter, struct sk_buff *skb, u32 upld_typ) { u8 *cmd_buf; - unsigned long flags; __le16 *curr_ptr = (__le16 *)skb-data; u16 pkt_len = le16_to_cpu(*curr_ptr); @@ -1050,9 +1049,7 @@ static int mwifiex_decode_rx_packet(struct mwifiex_adapter *adapter, case MWIFIEX_TYPE_DATA: dev_dbg(adapter-dev, info: --- Rx: Data packet ---\n); if (adapter-rx_work_enabled) { - spin_lock_irqsave(adapter-rx_q_lock, flags); skb_queue_tail(adapter-rx_data_q, skb); - spin_unlock_irqrestore(adapter-rx_q_lock, flags); adapter-data_received = true; atomic_inc(adapter-rx_pending); } else { -- 1.8.1.4 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [RESEND] ath5k: Remove AHB bus support
char name[ATH5K_LED_MAX_NAME_LEN + 1]; const struct pci_device_id *match; if (!ah-pdev) return 0; -#ifdef CONFIG_ATHEROS_AR231X - match = NULL; -#else match = pci_match_id(ath5k_led_devices[0], pdev); -#endif if (match) { __set_bit(ATH_STAT_LEDSOFT, ah-status); ah-led_pin = ATH_PIN(match-driver_data); -- 1.9.3 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 1/2] brcm80211: use container_of to resolve brcms_phy from brcms_phy_pub
*) pih; + struct brcms_phy *pi = container_of(pih, struct brcms_phy, pubpi_ro); *txchain = pi-sh-phytxchain; *rxchain = pi-sh-phyrxchain; @@ -2837,7 +2837,7 @@ u8 wlc_phy_stf_chain_active_get(struct brcms_phy_pub *pih) { s16 nphy_currtemp; u8 active_bitmap; - struct brcms_phy *pi = (struct brcms_phy *) pih; + struct brcms_phy *pi = container_of(pih, struct brcms_phy, pubpi_ro); active_bitmap = (pi-phy_txcore_heatedup) ? 0x31 : 0x33; @@ -2867,7 +2867,7 @@ u8 wlc_phy_stf_chain_active_get(struct brcms_phy_pub *pih) s8 wlc_phy_stf_ssmode_get(struct brcms_phy_pub *pih, u16 chanspec) { - struct brcms_phy *pi = (struct brcms_phy *) pih; + struct brcms_phy *pi = container_of(pih, struct brcms_phy, pubpi_ro); u8 siso_mcs_id, cdd_mcs_id; siso_mcs_id = @@ -2944,7 +2944,7 @@ s8 wlc_phy_upd_rssi_offset(struct brcms_phy *pi, s8 rssi, u16 chanspec) bool wlc_phy_txpower_ipa_ison(struct brcms_phy_pub *ppi) { - struct brcms_phy *pi = (struct brcms_phy *) ppi; + struct brcms_phy *pi = container_of(ppi, struct brcms_phy, pubpi_ro); if (ISNPHY(pi)) return wlc_phy_n_txpower_ipa_ison(pi); diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c index b2d6d6d..5f13662 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c @@ -2865,7 +2865,7 @@ static void wlc_lcnphy_idle_tssi_est(struct brcms_phy_pub *ppi) { bool suspend, tx_gain_override_old; struct lcnphy_txgains old_gains; - struct brcms_phy *pi = (struct brcms_phy *) ppi; + struct brcms_phy *pi = container_of(ppi, struct brcms_phy, pubpi_ro); u16 idleTssi, idleTssi0_2C, idleTssi0_OB, idleTssi0_regvalue_OB, idleTssi0_regvalue_2C; u16 SAVE_txpwrctrl = wlc_lcnphy_get_tx_pwr_ctrl(pi); @@ -3084,7 +3084,7 @@ static void wlc_lcnphy_tx_pwr_ctrl_init(struct brcms_phy_pub *ppi) s32 a1, b0, b1; s32 tssi, pwr, maxtargetpwr, mintargetpwr; bool suspend; - struct brcms_phy *pi = (struct brcms_phy *) ppi; + struct brcms_phy *pi = container_of(ppi, struct brcms_phy, pubpi_ro); suspend = (0 == (bcma_read32(pi-d11core, D11REGOFFS(maccontrol)) MCTL_EN_MAC)); @@ -4348,7 +4348,7 @@ void wlc_lcnphy_tx_power_adjustment(struct brcms_phy_pub *ppi) { s8 index; u16 index2; - struct brcms_phy *pi = (struct brcms_phy *) ppi; + struct brcms_phy *pi = container_of(ppi, struct brcms_phy, pubpi_ro); struct brcms_phy_lcnphy *pi_lcn = pi-u.pi_lcnphy; u16 SAVE_txpwrctrl = wlc_lcnphy_get_tx_pwr_ctrl(pi); if (wlc_lcnphy_tempsense_based_pwr_ctrl_enabled(pi) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c index 93869e8..084f18f 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c @@ -14121,7 +14121,7 @@ static u8 ant_sw_ctrl_tbl_rev8_2057v7_core1[] = { bool wlc_phy_bist_check_phy(struct brcms_phy_pub *pih) { - struct brcms_phy *pi = (struct brcms_phy *) pih; + struct brcms_phy *pi = container_of(pih, struct brcms_phy, pubpi_ro); u32 phybist0, phybist1, phybist2, phybist3, phybist4; if (NREV_GE(pi-pubpi.phy_rev, 16)) @@ -19734,7 +19734,7 @@ void wlc_phy_rxcore_setstate_nphy(struct brcms_phy_pub *pih, u8 rxcore_bitmask) u16 regval; u16 tbl_buf[16]; uint i; - struct brcms_phy *pi = (struct brcms_phy *) pih; + struct brcms_phy *pi = container_of(pih, struct brcms_phy, pubpi_ro); u16 tbl_opcode; bool suspend; @@ -19812,7 +19812,7 @@ void wlc_phy_rxcore_setstate_nphy(struct brcms_phy_pub *pih, u8 rxcore_bitmask) u8 wlc_phy_rxcore_getstate_nphy(struct brcms_phy_pub *pih) { u16 regval, rxen_bits; - struct brcms_phy *pi = (struct brcms_phy *) pih; + struct brcms_phy *pi = container_of(pih, struct brcms_phy, pubpi_ro); regval = read_phy_reg(pi, 0xa2); rxen_bits = (regval 4) 0xf; @@ -21342,7 +21342,7 @@ void wlc_phy_chanspec_set_nphy(struct brcms_phy *pi, u16 chanspec) void wlc_phy_antsel_init(struct brcms_phy_pub *ppi, bool lut_init) { - struct brcms_phy *pi = (struct brcms_phy *) ppi; + struct brcms_phy *pi = container_of(ppi, struct brcms_phy, pubpi_ro); u16 mask = 0xfc00; u32 mc = 0; -- 1.9.1 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull request: wireless 2014-09-23
Dave, Please consider pulling this one last batch of fixes intended for the 3.17 stream! For the NFC bits, Samuel says: Hopefully not too late for a handful of NFC fixes: - 2 potential build failures for ST21NFCA and ST21NFCB, triggered by a depmod dependenyc cycle. - One potential buffer overflow in the microread driver. On top of that... Emil Goode provides a fix for a brcmfmac off-by-one regression which was introduced in the 3.17 cycle. Loic Poulain fixes a polarity mismatch for a variable assignment inside of rfkill-gpio. Wojciech Dubowik prevents a NULL pointer dereference in ath9k. Please let me know if there are problems! Thanks, John --- The following changes since commit dda3b191eb6c5a56d443723dcb71ade60d97c04f: net: rfkill: gpio: Enable module auto-loading for ACPI based switches (2014-09-16 16:09:01 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git tags/master-2014-09-23 for you to fetch changes up to f8adaf0ae978252c9f7e29e96aefcd8fcaf806ba: brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels() (2014-09-23 10:48:26 -0400) Christophe Ricard (2): NFC: st21nfcb: Fix depmod dependency cycle NFC: st21nfca: Fix potential depmod dependency cycle Dan Carpenter (1): NFC: microread: Potential overflows in microread_target_discovered() Emil Goode (1): brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels() John W. Linville (1): Merge tag 'nfc-fixes-3.17-1' of git://git.kernel.org/.../sameo/nfc-fixes Loic Poulain (1): net: rfkill: gpio: Fix clock status Wojciech Dubowik (1): ath9k: Fix NULL pointer dereference on early irq drivers/net/wireless/ath/ath9k/main.c | 2 +- drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 +- drivers/nfc/microread/microread.c | 16 drivers/nfc/st21nfca/Makefile | 5 +++-- drivers/nfc/st21nfcb/Makefile | 5 +++-- net/rfkill/rfkill-gpio.c | 2 +- 6 files changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index e6ac8d2e610c..4b148bbb2bf6 100644 --- a/drivers/net/wireless/ath/ath9k/main.c +++ b/drivers/net/wireless/ath/ath9k/main.c @@ -513,7 +513,7 @@ irqreturn_t ath_isr(int irq, void *dev) * touch anything. Note this can happen early * on if the IRQ is shared. */ - if (test_bit(ATH_OP_INVALID, common-op_flags)) + if (!ah || test_bit(ATH_OP_INVALID, common-op_flags)) return IRQ_NONE; /* shared irq, not for us */ diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c index f3a9804988a6..16a246bfc343 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c @@ -4921,7 +4921,7 @@ static void brcmf_count_20mhz_channels(struct brcmf_cfg80211_info *cfg, struct brcmu_chan ch; int i; - for (i = 0; i = total; i++) { + for (i = 0; i total; i++) { ch.chspec = (u16)le32_to_cpu(chlist-element[i]); cfg-d11inf.decchspec(ch); diff --git a/drivers/nfc/microread/microread.c b/drivers/nfc/microread/microread.c index f868333271aa..963a4a5dc88e 100644 --- a/drivers/nfc/microread/microread.c +++ b/drivers/nfc/microread/microread.c @@ -501,9 +501,13 @@ static void microread_target_discovered(struct nfc_hci_dev *hdev, u8 gate, targets-sens_res = be16_to_cpu(*(u16 *)skb-data[MICROREAD_EMCF_A_ATQA]); targets-sel_res = skb-data[MICROREAD_EMCF_A_SAK]; - memcpy(targets-nfcid1, skb-data[MICROREAD_EMCF_A_UID], - skb-data[MICROREAD_EMCF_A_LEN]); targets-nfcid1_len = skb-data[MICROREAD_EMCF_A_LEN]; + if (targets-nfcid1_len sizeof(targets-nfcid1)) { + r = -EINVAL; + goto exit_free; + } + memcpy(targets-nfcid1, skb-data[MICROREAD_EMCF_A_UID], + targets-nfcid1_len); break; case MICROREAD_GATE_ID_MREAD_ISO_A_3: targets-supported_protocols = @@ -511,9 +515,13 @@ static void microread_target_discovered(struct nfc_hci_dev *hdev, u8 gate, targets-sens_res = be16_to_cpu(*(u16 *)skb-data[MICROREAD_EMCF_A3_ATQA]); targets-sel_res = skb-data[MICROREAD_EMCF_A3_SAK]; - memcpy(targets-nfcid1, skb-data[MICROREAD_EMCF_A3_UID], - skb-data[MICROREAD_EMCF_A3_LEN]); targets-nfcid1_len = skb-data[MICROREAD_EMCF_A3_LEN]; + if (targets-nfcid1_len sizeof
Re: [PATCH] ath: change logging functions to return void
On Tue, Sep 23, 2014 at 07:20:53AM +0300, Kalle Valo wrote: Joe Perches j...@perches.com writes: The return values are not used by callers of these functions so change the functions to return void. Other miscellanea: o add __printf verification to wil6210 logging functions No format/argument mismatches found Signed-off-by: Joe Perches j...@perches.com --- This change is associated to a desire to eventually change printk to return void. drivers/net/wireless/ath/ath10k/debug.c| 18 +- drivers/net/wireless/ath/ath10k/debug.h| 6 +++--- drivers/net/wireless/ath/ath6kl/common.h | 2 +- drivers/net/wireless/ath/ath6kl/debug.c| 28 drivers/net/wireless/ath/ath6kl/debug.h| 13 ++--- For ath6kl and ath10k: Acked-by: Kalle Valo kv...@qca.qualcomm.com drivers/net/wireless/ath/wil6210/debug.c | 14 -- drivers/net/wireless/ath/wil6210/wil6210.h | 7 +-- 7 files changed, 32 insertions(+), 56 deletions(-) John, as this patch also contains a wil6210 change how do you want to handle this? I had presumed that you would merge it through the ath tree, so I deleted it... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT] [3.17] NFC fixes
On Mon, Sep 22, 2014 at 09:55:54PM +0200, Samuel Ortiz wrote: Hi John, Hopefully not too late for a handful of NFC fixes: - 2 potential build failures for ST21NFCA and ST21NFCB, triggered by a depmod dependenyc cycle. - One potential buffer overflow in the microread driver. The following changes since commit 1bd3fa7b8c9b2936c16c6e6452f9cc991c405872: Merge branch 'for-john' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2014-09-04 13:12:02 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-fixes.git tags/nfc-fixes-3.17-1 for you to fetch changes up to 300c627fbc52aa5b2117ca267907ab8d7b990ead: NFC: st21nfca: Fix potential depmod dependency cycle (2014-09-07 23:45:53 +0200) Pulling now... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Comments regarding patch about setting netns for wireless devices
On Thu, Sep 18, 2014 at 11:05:11AM +0300, Vadim Kochan wrote: Hi All, I'd like to get some feedback about the patch: https://patchwork.kernel.org/patch/4890451/ The idea is that currently Linux wireless device is allowed to change the network namespace only by nl80211 API, so RTM_LINK API does not work. So I think that it should be possible to change netns through the RTM_LINK too as generic way to change netns, thats why I tried to solve this in the patch. Thanks, I think Johannes is vacationing right now. I'm sure he will comment when he returns. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] net: rfkill: gpio: Enable module auto-loading for ACPI based switches
I'm merging this to the wireless tree... On Fri, Sep 12, 2014 at 09:49:28PM +0200, Marcel Holtmann wrote: For the ACPI based switches the MODULE_DEVICE_TABLE is missing to export the entries for module auto-loading. Signed-off-by: Marcel Holtmann mar...@holtmann.org --- net/rfkill/rfkill-gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index 02a86a27fd84..5fa54dd78e25 100644 --- a/net/rfkill/rfkill-gpio.c +++ b/net/rfkill/rfkill-gpio.c @@ -163,6 +163,7 @@ static const struct acpi_device_id rfkill_acpi_match[] = { { LNV4752, RFKILL_TYPE_GPS }, { }, }; +MODULE_DEVICE_TABLE(acpi, rfkill_acpi_match); #endif static struct platform_driver rfkill_gpio_driver = { -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 09/28] Remove ATHEROS_AR231X
On Tue, Sep 16, 2014 at 10:26:59PM +0200, Paul Bolle wrote: On Mon, 2014-09-15 at 14:45 -0400, John W. Linville wrote: FYI -- Sergey posted a series to linux-mips on 14 September 2014 that touches the symbol in question. For whatever reason, it is posted there as RFC. Thanks for passing that on. Does this satisfy the interested parties?? In case I qualify as an interested party: resolving this by, in short, making AHB support actually buildable is of course the preferable solution. Whether or not we should drop my patch while waiting for that series to land in linux-next is not my call. But if it hasn't landed by, say, about the time v3.18-rc3 is released I might raise this issue again. I must say that I'm a bit puzzled why people have resisted this rather small cleanup for years. How did having unbuildable AHB support in mainline benefit anyone? Couldn't the revert of this cleanup also be handled out of tree? Note that the revert is only 6 files changed, 3 insertions(+), 294 deletions(-), while the series is 39 files changed, 3911 insertions(+), 10 deletions(-). I think it got added with the notion that the code was coming soon. As you have tried to remove it, the coming soon refrain continued. I'm still inclined to merge your patch. An RFC series posted to another mailing list doesn't really change my mind. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] ath5k: added debugfs file for dumping eeprom
On Tue, Sep 09, 2014 at 03:32:38PM -0400, John W. Linville wrote: The original patch was already merged. To make a change, you need to post a new patch based on the new head of the tree. This one just conflicts with what is already there now. Also, I think all you really need is a #include linux/vmalloc.h. Post a v3 that just adds the #include? Nevermind, Dave M. already merged such a patch in net-next... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] hostap: proc: substitute loops by %*phN
Applying: hostap: proc: substitute loops by %*phN error: patch failed: drivers/net/wireless/hostap/hostap_proc.c:184 error: drivers/net/wireless/hostap/hostap_proc.c: patch does not apply On Fri, Sep 05, 2014 at 05:30:16PM +0300, Andy Shevchenko wrote: For dumping small buffers we may use %*phN specifier instead of custom approach.. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/wireless/hostap/hostap_proc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c index 16a06b6..4e2a7dd9 100644 --- a/drivers/net/wireless/hostap/hostap_proc.c +++ b/drivers/net/wireless/hostap/hostap_proc.c @@ -184,11 +184,9 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v) seq_printf(m, %*pE, bss-ssid_len, bss-ssid); seq_putc(m, '\t'); - for (i = 0; i bss-ssid_len; i++) - seq_printf(m, %02x, bss-ssid[i]); + seq_printf(m, %*phN, (int)bss-ssid_len, bss-ssid); seq_putc(m, '\t'); - for (i = 0; i bss-wpa_ie_len; i++) - seq_printf(m, %02x, bss-wpa_ie[i]); + seq_printf(m, %*phN, (int)bss-wpa_ie_len, bss-wpa_ie); seq_putc(m, '\n'); return 0; } -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mesh Support in brcmsmac
On Tue, Sep 09, 2014 at 12:28:54PM +0200, Arend van Spriel wrote: + linux-wireless On 09/09/14 12:22, chandrika parimoo wrote: Hello, I have broadcom bcm4313 card and am using brcmsmac driver which does not have mesh support currently. I wanted to know if there is a workaround for it? No workaround. I am not familiar with wireless mesh networking. I suppose there are people on the linux-wireless mailing list who know what is needed from a mac80211 driver (like brcmsmac) to enable mesh networking. The main things is the beacons, no? -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 09/28] Remove ATHEROS_AR231X
On Fri, Sep 05, 2014 at 04:02:10PM +0400, Sergey Ryazanov wrote: 2014-09-05 15:33 GMT+04:00 Paul Bolle pebo...@tiscali.nl: Hi Sergey, On Fri, 2014-09-05 at 15:12 +0400, Sergey Ryazanov wrote: 2014-09-05 14:10 GMT+04:00, Paul Bolle pebo...@tiscali.nl: On Wed, 2014-06-18 at 13:46 +0200, Paul Bolle wrote: Having this conversation every rc1 is getting a bit silly. Could Jiri e.a. perhaps set some specific deadline for ATHEROS_AR231X to be submitted? I waited until rc3. Have you seen any activity on this front? If not, should I resend the patch that removes the code in mainline that depends on ATHEROS_AR231X (ie, AHB bus support)? Recent activity always could be found in [1]. Now I finish another one round of cleanups and have a plan to fix several things (you can always find something that you really want to improve). But if you insist I could immediately switch to send upstream mode. And seems that this would be better approach. 1. https://dev.openwrt.org/log/trunk/target/linux/atheros And where can the related PULL requests or patch submissions be found? I have not sent patches yet, since I thought that it would be easier to cleanup them in openwrt tree and then send them upstream. That excuse has worn a bit thin. Perhaps Paul should repost his removal and you can add a revert to the start of your patch series? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iwlwifi no authentication with AP - Re: pull request: wireless-next 2014-09-08
On Tue, Sep 09, 2014 at 09:46:47PM +0200, Oliver Hartkopp wrote: Hello John, all, on my i7 Laptop with iwlwifi the latest net-next does not connect to my access point: [ 10.305284] iwlwifi :02:00.0: L1 Enabled; Disabling L0S [ 10.312179] iwlwifi :02:00.0: Radio type=0x1-0x3-0x1 [ 10.524936] iwlwifi :02:00.0: L1 Enabled; Disabling L0S [ 10.531762] iwlwifi :02:00.0: Radio type=0x1-0x3-0x1 [ 10.614189] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready [ 17.097238] wlan0: authenticate with 84:c9:b2:d5:87:80 [ 17.130120] wlan0: send auth to 84:c9:b2:d5:87:80 (try 1/3) [ 17.922281] wlan0: send auth to 84:c9:b2:d5:87:80 (try 2/3) [ 18.935272] wlan0: send auth to 84:c9:b2:d5:87:80 (try 3/3) [ 19.936236] wlan0: authentication with 84:c9:b2:d5:87:80 timed out [ 21.962337] iwlwifi :02:00.0: fail to flush all tx fifo queues Q 0 [ 21.962348] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 3 [ 21.962413] iwl data: : 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 21.962455] iwlwifi :02:00.0: FH TRBs(0) = 0x [ 21.962491] iwlwifi :02:00.0: FH TRBs(1) = 0x [ 21.962528] iwlwifi :02:00.0: FH TRBs(2) = 0x [ 21.962564] iwlwifi :02:00.0: FH TRBs(3) = 0x [ 21.962600] iwlwifi :02:00.0: FH TRBs(4) = 0x [ 21.962636] iwlwifi :02:00.0: FH TRBs(5) = 0x [ 21.962673] iwlwifi :02:00.0: FH TRBs(6) = 0x [ 21.962709] iwlwifi :02:00.0: FH TRBs(7) = 0x0070402f [ 21.962790] iwlwifi :02:00.0: Q 0 is active and mapped to fifo 3 ra_tid 0x [0,3] [ 21.962869] iwlwifi :02:00.0: Q 1 is active and mapped to fifo 2 ra_tid 0x [0,0] [ 21.962949] iwlwifi :02:00.0: Q 2 is active and mapped to fifo 1 ra_tid 0x [0,0] [ 21.963030] iwlwifi :02:00.0: Q 3 is active and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963109] iwlwifi :02:00.0: Q 4 is active and mapped to fifo 7 ra_tid 0x [48,48] [ 21.963189] iwlwifi :02:00.0: Q 5 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963270] iwlwifi :02:00.0: Q 6 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963350] iwlwifi :02:00.0: Q 7 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963428] iwlwifi :02:00.0: Q 8 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963508] iwlwifi :02:00.0: Q 9 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963588] iwlwifi :02:00.0: Q 10 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963669] iwlwifi :02:00.0: Q 11 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963750] iwlwifi :02:00.0: Q 12 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963829] iwlwifi :02:00.0: Q 13 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963909] iwlwifi :02:00.0: Q 14 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.963988] iwlwifi :02:00.0: Q 15 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.964069] iwlwifi :02:00.0: Q 16 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.964149] iwlwifi :02:00.0: Q 17 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.964228] iwlwifi :02:00.0: Q 18 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 21.964308] iwlwifi :02:00.0: Q 19 is inactive and mapped to fifo 0 ra_tid 0x [0,0] [ 22.116816] wlan0: authenticate with xx:xx:xx:xx:xx:xx [ 22.155887] wlan0: send auth to xx:xx:xx:xx:xx:xx (try 1/3) (..) and again and again ... Mainly this is the changing stuff in the following dmesg output: [ 21.962348] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 3 [ 26.951325] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 6 [ 34.979316] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 9 [ 39.964287] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 12 [ 47.984243] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 15 [ 55.984240] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 18 [ 60.981221] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 21 [ 73.878064] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 24 [ 86.342476] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 27 [ 98.770854] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 30 [ 111.287320] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 33 [ 121.045034] iwlwifi :02:00.0: Current SW read_ptr 0 write_ptr 36 02:00.0 Network controller: Intel Corporation Centrino Advanced-N 6200 (rev 35) Any idea? Regards, Oliver Hopefully the Intel guys are listening. As a hunch, what sort of encryption are you using? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from
pull request: wireless-next 2014-09-08
typedef btuart_info_t Bluetooth: Remove typedefs nsh_t and dtl1_info_t Bluetooth: Remove typedef bt3c_info_t net: wireless: wl1251: Remove unnecessary free_irq cw1200: Introduce the use of devm_kzalloc wireless: wlcore: Use devm_kzalloc atmel_cs: Remove typedef local_info_t orinoco_usb: use USB API functions rather than constants Ido Yariv (2): mac80211: Fix accounting of the tailroom-needed counter mac80211: don't resize skbs needlessly Jade Bilkey (1): ath5k: added debugfs file for dumping eeprom Janusz Dziedzic (1): ath10k: extend debug code for RX path Johan Hedberg (35): Bluetooth: Add convenience function to check for pending power off Bluetooth: Create unified helper function for updating page scan Bluetooth: Disable page scan if all whitelisted devices are connected Bluetooth: Remove redundant check for remote_key_dist Bluetooth: Fix confusion between parent and child channel for 6lowpan Bluetooth: Fix reference counting of global L2CAP channels Bluetooth: Fix __l2cap_no_conn_pending() usage with all channels Bluetooth: Resume BT_CONNECTED state after LE security elevation Bluetooth: Remove special handling of ATT in l2cap_security_cfm() Bluetooth: Refactor l2cap_connect_cfm Bluetooth: Move L2CAP fixed channel creation into l2cap_conn_cfm Bluetooth: Improve fixed channel lookup based on link type Bluetooth: Remove special ATT data channel handling Bluetooth: Move parts of fixed channel initialization to l2cap_add_scid Bluetooth: Call L2CAP teardown callback before clearing chan-conn Bluetooth: Call l2cap_le_conn_ready after notifying channels Bluetooth: Fix using HCI_CONN_LE_SMP_PEND to check for SMP context Bluetooth: Fix hci_update_random_address() error return for no crypto Bluetooth: Fix IRK lookup when tfm_aes is not available Bluetooth: Refactor SMP (de)initialization into separate functions Bluetooth: Move SMP initialization after HCI init Bluetooth: Move SMP (de)initialization to smp.c Bluetooth: Add more L2CAP convenience callbacks Bluetooth: Add SMP L2CAP channel skeleton Bluetooth: Make AES crypto context private to SMP Bluetooth: Convert SMP to use l2cap_chan infrastructure Bluetooth: Use L2CAP resume callback to call smp_distribute_keys Bluetooth: Add public l2cap_conn_shutdown() API to request disconnection Bluetooth: Call l2cap_conn_shutdown() when SMP recv callback fails Bluetooth: Fix double free of SMP data skb Bluetooth: Add SMP-internal timeout callback Bluetooth: Remove unused l2cap_conn-security_timer Bluetooth: Move canceling security_timer into smp_chan_destroy() Bluetooth: Always call smp_distribute_keys() from a workqueue Bluetooth: Make smp_chan_destroy() private to smp.c Johannes Berg (18): mac80211: don't duplicate station QoS capability data mac80211: make ieee80211_vif_use_reserved_switch static cfg80211: clarify BSS probe response vs. beacon data cfg80211: allow passing frame type to cfg80211_inform_bss() iwlwifi: make U-APSD default configurable at compile time iwlwifi: trans: refactor txq_enable arguments iwlwifi: mvm: add some debugging to quota allocation iwlwifi: don't export tracepoints unnecessarily iwlwifi: trans: allow skipping scheduler hardware config iwlwifi: trans: make aggregation explicit for TX queue handling iwlwifi: add Intel Mobile Communications copyright iwlwifi: mvm: correct firmware disassoc command sequence iwlwifi: mvm: clean up FIFO definitions iwlwifi: mvm: clarify stop_count, remove transport_stopped iwlwifi: mvm: use tdls indication from mac80211 iwlwifi: mvm: use iwl_mvm_mac_get_queues_mask() more iwlwifi: mvm: clean up broadcast station handling iwlwifi: mvm: clean up AUX station handling John W. Linville (5): Merge branch 'for-upstream' of git://git.kernel.org/.../bluetooth/bluetooth-next Merge branch 'for-linville' of git://github.com/kvalo/ath Merge tag 'mac80211-next-for-john-2014-08-29' of git://git.kernel.org/.../jberg/mac80211-next Merge branch 'for-john' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge branch 'master' of git://git.kernel.org/.../linville/wireless Kalle Valo (3): ath10k: add ath10k_pci_diag_* helpers ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_fw_crashed_dump() ath10k: print more driver info when firmware crashes Liad Kaufman (1): iwlwifi: mvm: wait for TE notif when protecting TDLS session Loic Poulain (1): Bluetooth: Fix HCI H5 corrupted ack value Luciano Coelho (8): iwlwifi: mvm: reset the temperature when temperature test is disabled iwlwifi: mvm: don't run automatic checks if CT was caused by debugfs iwlwifi: mvm: add debugfs entry
Wireless Networking microconference topic approvals (LPC2014)
All, I have approved the current proposals for the Wireless Networking microconference in Duesseldorf. The current list of topics is available here: http://www.linuxplumbersconf.org/2014/ocw/events/LPC2014/tracks/339 We have a 6 hour slot, and 6 topics approved. I don't think that all of the listed topics need an hour each, so we probably can squeeze in a couple more topics. If you have something to propose, then please click on the submit a proposal link on the page linked above. For more info on proposing topics for LPC2014, you can also go here: http://www.linuxplumbersconf.org/2014/how-to-submit-microconference-discussions-topics/ Thanks, John P.S. I was not able to transfer the suggested topics from the wiki to actual topic proposals without listing myself as the speaker for those proposals. If you are intending to present a topic, please follow the directions above. -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/17] mwifiex updates for 3.17
These don't all seem to be fixes. Do you want me to take them for 3.18? Or do you want to divide this list between fixes and features and post them as different series for 3.17 and 3.18? John On Mon, Sep 01, 2014 at 06:28:48PM +0530, Avinash Patil wrote: This patch series brings in scan enhancement including scan channel gap, support for parsing FW API version from HW_SPEC command response, support for processing RX in work queue and few trivial fixes for SDIO multiport aggregation. Amitkumar Karwar (7): mwifiex: fix a bug in Tx multiport aggregation mwifiex: minor cleanup in multiport aggregation mwifiex: fix left_len calculation issue mwifiex: rename macro and variables related to API revision mwifiex: use firmware API revision from GET_HW_SPEC response mwifiex: remove redundant variable report_scan_result mwifiex: remove low priority scan handling Avinash Patil (9): mwifiex: fix probable memory corruption while processing TDLS frame mwifiex: avoid processing RX packets with invalid length mwifiex: rework internal scan for association mwifiex: support for event done interrupt mwifiex: set passive scan type for scan requests with no ssid mwifiex: bring in scan channel gap feature mwifiex: remove restriction of single channel scan when connected mwifiex: process TX even when scan is ongoing mwifiex: add rx workqueue support Xinming Hu (1): mwifiex: fix 5G association failure after leaving 2.4G IBSS drivers/net/wireless/mwifiex/11n_rxreorder.c | 14 ++ drivers/net/wireless/mwifiex/cfg80211.c | 13 +- drivers/net/wireless/mwifiex/cmdevt.c| 28 ++-- drivers/net/wireless/mwifiex/fw.h| 17 ++- drivers/net/wireless/mwifiex/init.c | 25 +++- drivers/net/wireless/mwifiex/main.c | 194 +-- drivers/net/wireless/mwifiex/main.h | 49 +-- drivers/net/wireless/mwifiex/pcie.c | 37 - drivers/net/wireless/mwifiex/pcie.h | 5 +- drivers/net/wireless/mwifiex/scan.c | 112 ++-- drivers/net/wireless/mwifiex/sdio.c | 28 ++-- drivers/net/wireless/mwifiex/sta_cmd.c | 2 +- drivers/net/wireless/mwifiex/sta_cmdresp.c | 4 +- drivers/net/wireless/mwifiex/sta_ioctl.c | 13 +- drivers/net/wireless/mwifiex/tdls.c | 4 +- 15 files changed, 339 insertions(+), 206 deletions(-) -- 1.8.1.4 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] ath9k patches
I am having a lot of trouble determining which of your series are intended as fixes for the current release (3.17) or updates for the next release (3.18). In this series, several seem like fixes but ath9k: Fix ath_startrecv seems like a cleanup. Would you like to reorganize your patch submissions as fixes vs. features? Or do you want them all to be merged as features for 3.18? John On Wed, Sep 03, 2014 at 01:25:24PM +0530, Sujith Manoharan wrote: From: Sujith Manoharan c_man...@qca.qualcomm.com Various fixes for MCC. Sujith Manoharan (5): ath9k: Fix RX filter calculation ath9k: Fix ath_startrecv() ath9k: Fix COMP_BAR filter ath9k: Fix RX filters in channel contexts ath9k: Fix interface accounting drivers/net/wireless/ath/ath9k/ath9k.h | 7 --- drivers/net/wireless/ath/ath9k/beacon.c | 2 +- drivers/net/wireless/ath/ath9k/debug.c | 2 +- drivers/net/wireless/ath/ath9k/main.c | 20 +--- drivers/net/wireless/ath/ath9k/recv.c | 31 +++ drivers/net/wireless/ath/ath9k/tx99.c | 2 +- drivers/net/wireless/ath/ath9k/wow.c| 2 +- 7 files changed, 36 insertions(+), 30 deletions(-) -- 2.1.0 -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html