Re: [PATCH 2/5] cfg80211: Properly track transmitting and non-transmitting BSS
Hi Sara, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211-next/master] [also build test ERROR on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jouni-Malinen/cfg80211-Parsing-of-Multiple-BSSID-information-in-scanning/20181208-040803 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: i386-randconfig-x011-201848 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): In file included from net/wireless/nl80211.h:9:0, from net/wireless/ibss.c:14: net/wireless/core.h: In function 'cfg80211_hold_bss': >> net/wireless/core.h:184:20: error: inlining failed in call to always_inline >> 'cfg80211_hold_bss': recursive inlining static inline void cfg80211_hold_bss(struct cfg80211_internal_bss *bss) ^ net/wireless/core.h:188:3: note: called from here cfg80211_hold_bss(container_of(bss->transmitted_bss, ^~~~ struct cfg80211_internal_bss, ~ pub)); ~ net/wireless/core.h: In function 'cfg80211_unhold_bss': >> net/wireless/core.h:193:20: error: inlining failed in call to always_inline >> 'cfg80211_unhold_bss': recursive inlining static inline void cfg80211_unhold_bss(struct cfg80211_internal_bss *bss) ^~~ net/wireless/core.h:198:3: note: called from here cfg80211_unhold_bss(container_of(bss->transmitted_bss, ^~ struct cfg80211_internal_bss, ~ pub)); ~ net/wireless/core.h: In function '__cfg80211_clear_ibss.constprop': >> net/wireless/core.h:193:20: error: inlining failed in call to always_inline >> 'cfg80211_unhold_bss': recursive inlining static inline void cfg80211_unhold_bss(struct cfg80211_internal_bss *bss) ^~~ net/wireless/core.h:198:3: note: called from here cfg80211_unhold_bss(container_of(bss->transmitted_bss, ^~ struct cfg80211_internal_bss, ~ pub)); ~ net/wireless/core.h: In function '__cfg80211_ibss_joined': >> net/wireless/core.h:193:20: error: inlining failed in call to always_inline >> 'cfg80211_unhold_bss': recursive inlining static inline void cfg80211_unhold_bss(struct cfg80211_internal_bss *bss) ^~~ net/wireless/core.h:198:3: note: called from here cfg80211_unhold_bss(container_of(bss->transmitted_bss, ^~ struct cfg80211_internal_bss, ~ pub)); ~ >> net/wireless/core.h:184:20: error: inlining failed in call to always_inline >> 'cfg80211_hold_bss': recursive inlining static inline void cfg80211_hold_bss(struct cfg80211_internal_bss *bss) ^ net/wireless/core.h:188:3: note: called from here cfg80211_hold_bss(container_of(bss->transmitted_bss, ^~~~ struct cfg80211_internal_bss, ~ pub)); ~ -- In file included from net/wireless/nl80211.h:9:0, from net/wireless/sme.c:21: net/wireless/core.h: In function 'cfg80211_hold_bss': >> net/wireless/core.h:184:20: error: inlining failed in call to always_inline >> 'cfg80211_hold_bss': recursive inlining static inline void cfg80211_hold_bss(struct cfg80211_internal_bss *bss) ^ net/wireless/core.h:188:3: note: called from here cfg80211_hold_bss(container_of(bss->transmitted_bss, ^~~~ struct cfg80211_internal_bss, ~ pub)); ~ net/wireless/core.h: In function 'cfg80211_unhold_bss': >> net/wireless/core.h:193:20: error: inlining failed in call to always_inline >> 'cfg80211_unhold_bss': recursive inlining static inline void cfg80211_unhold_bss(struct cfg80211_internal_bss *bss) ^~~ net/wireless/core.h:198:3: note: called from here cfg80211_unhold_bss(container_of(bss->transmitted_bss, ^~ struct
Re: [PATCH v3 2/4] staging: wilc1000: validate cfg parameters before scheduling the work
Hi Adham, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.20-rc1 next-20181106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Adham-Abozaeid-microchip-com/staging-wilc1000-validate-input-to-set_wiphy_param-and-return-proper-errors/20181106-120308 smatch warnings: drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:1152 set_wiphy_params() warn: always true condition '(wiphy->retry_short < 256) => (0-255 < 256)' drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:1164 set_wiphy_params() warn: always true condition '(wiphy->retry_long < 256) => (0-255 < 256)' vim +1152 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c 1141 1142 static int set_wiphy_params(struct wiphy *wiphy, u32 changed) 1143 { 1144 int ret; 1145 struct cfg_param_attr cfg_param_val; 1146 struct wilc_priv *priv = wiphy_priv(wiphy); 1147 struct wilc_vif *vif = netdev_priv(priv->dev); 1148 1149 cfg_param_val.flag = 0; 1150 1151 if (changed & WIPHY_PARAM_RETRY_SHORT) { > 1152 if (wiphy->retry_short > 0 && wiphy->retry_short < 256) > { 1153 netdev_dbg(vif->ndev, 1154 "Setting WIPHY_PARAM_RETRY_SHORT %d\n", 1155 wiphy->retry_short); 1156 cfg_param_val.flag |= RETRY_SHORT; 1157 cfg_param_val.short_retry_limit = wiphy->retry_short; 1158 } else { 1159 netdev_err(vif->ndev, "Short retry limit out of range\n"); 1160 return -EINVAL; 1161 } 1162 } 1163 if (changed & WIPHY_PARAM_RETRY_LONG) { > 1164 if (wiphy->retry_long > 0 && wiphy->retry_long < 256) { 1165 netdev_dbg(vif->ndev, 1166 "Setting WIPHY_PARAM_RETRY_LONG %d\n", 1167 wiphy->retry_long); 1168 cfg_param_val.flag |= RETRY_LONG; 1169 cfg_param_val.long_retry_limit = wiphy->retry_long; 1170 } else { 1171 netdev_err(vif->ndev, "Long retry limit out of range\n"); 1172 return -EINVAL; 1173 } 1174 } 1175 if (changed & WIPHY_PARAM_FRAG_THRESHOLD) { 1176 if (wiphy->frag_threshold > 255 && 1177 wiphy->frag_threshold < 7937) { 1178 netdev_dbg(vif->ndev, 1179 "Setting WIPHY_PARAM_FRAG_THRESHOLD %d\n", 1180 wiphy->frag_threshold); 1181 cfg_param_val.flag |= FRAG_THRESHOLD; 1182 cfg_param_val.frag_threshold = wiphy->frag_threshold; 1183 } else { 1184 netdev_err(vif->ndev, 1185 "Fragmentation threshold out of range\n"); 1186 return -EINVAL; 1187 } 1188 } 1189 1190 if (changed & WIPHY_PARAM_RTS_THRESHOLD) { 1191 if (wiphy->rts_threshold > 255) { 1192 netdev_dbg(vif->ndev, 1193 "Setting WIPHY_PARAM_RTS_THRESHOLD %d\n", 1194 wiphy->rts_threshold); 1195 cfg_param_val.flag |= RTS_THRESHOLD; 1196 cfg_param_val.rts_threshold = wiphy->rts_threshold; 1197 } else { 1198 netdev_err(vif->ndev, "RTS threshold out of range\n"); 1199 return -EINVAL; 1200 } 1201 } 1202 1203 ret = wilc_hif_set_cfg(vif, _param_val); 1204 if (ret) 1205 netdev_err(priv->dev, "Error in setting WIPHY PARAMS\n"); 1206 1207 return ret; 1208 } 1209 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH v3] brcmfmac: Add support for getting nvram contents from EFI variables
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.19-rc7 next-20181010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/brcmfmac-Add-support-for-getting-nvram-contents-from-EFI-variables/20181010-211419 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-randconfig-c0-10102322 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c: In function 'brcmf_fw_request_nvram_done': >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:529:44: error: >> passing argument 1 of 'brcmf_fw_nvram_from_efi' from incompatible pointer >> type [-Werror=incompatible-pointer-types] else if ((data = brcmf_fw_nvram_from_efi(cur->path, _len))) ^~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:491:12: note: expected 'size_t * {aka unsigned int *}' but argument is of type 'const char *' static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:529:20: error: >> too many arguments to function 'brcmf_fw_nvram_from_efi' else if ((data = brcmf_fw_nvram_from_efi(cur->path, _len))) ^~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:491:12: note: declared here static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~ cc1: some warnings being treated as errors vim +/brcmf_fw_nvram_from_efi +529 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c 507 508 static int brcmf_fw_request_nvram_done(const struct firmware *fw, void *ctx) 509 { 510 struct brcmf_fw *fwctx = ctx; 511 struct brcmf_fw_item *cur; 512 bool free_bcm47xx_nvram = false; 513 bool kfree_nvram = false; 514 u32 nvram_length = 0; 515 void *nvram = NULL; 516 u8 *data = NULL; 517 size_t data_len; 518 519 brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(fwctx->dev)); 520 521 cur = >req->items[fwctx->curpos]; 522 523 if (fw && fw->data) { 524 data = (u8 *)fw->data; 525 data_len = fw->size; 526 } else { 527 if ((data = bcm47xx_nvram_get_contents(_len))) 528 free_bcm47xx_nvram = true; > 529 else if ((data = brcmf_fw_nvram_from_efi(cur->path, > _len))) 530 kfree_nvram = true; 531 else if (!(cur->flags & BRCMF_FW_REQF_OPTIONAL)) 532 goto fail; 533 } 534 535 if (data) 536 nvram = brcmf_fw_nvram_strip(data, data_len, _length, 537 fwctx->req->domain_nr, 538 fwctx->req->bus_nr); 539 540 if (free_bcm47xx_nvram) 541 bcm47xx_nvram_release_contents(data); 542 if (kfree_nvram) 543 kfree(data); 544 545 release_firmware(fw); 546 if (!nvram && !(cur->flags & BRCMF_FW_REQF_OPTIONAL)) 547 goto fail; 548 549 brcmf_dbg(TRACE, "nvram %p len %d\n", nvram, nvram_length); 550 cur->nv_data.data = nvram; 551 cur->nv_data.len = nvram_length; 552 return 0; 553 554 fail: 555 return -ENOENT; 556 } 557 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 1/4] rt2x00: remove unneeded check
Hi Tomislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.19-rc7 next-20181009] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stanislaw-Gruszka/rt2x00-remove-unneeded-check/20181010-012334 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): drivers/net/wireless/ralink/rt2x00/rt2800lib.c: In function 'rt2800_config_channel_rf3290': drivers/net/wireless/ralink/rt2x00/rt2800lib.c:2881:6: warning: unused variable 'idx' [-Wunused-variable] int idx = rf->channel-1; ^~~ drivers/net/wireless/ralink/rt2x00/rt2800lib.c: In function 'rt2800_config_channel_rf53xx': >> drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3016:20: error: 'idx' >> undeclared (first use in this function) r55_bt_rev[idx]); ^~~ drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3016:20: note: each undeclared identifier is reported only once for each function it appears in vim +/idx +3016 drivers/net/wireless/ralink/rt2x00/rt2800lib.c 0c9e5fb91 drivers/net/wireless/rt2x00/rt2800lib.cStanislaw Gruszka 2013-03-16 2875 a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2876 static void rt2800_config_channel_rf3290(struct rt2x00_dev *rt2x00dev, a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2877 struct ieee80211_conf *conf, a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2878 struct rf_channel *rf, a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2879 struct channel_info *info) a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2880 { 64cc6975c drivers/net/wireless/ralink/rt2x00/rt2800lib.c Tomislav Požega 2018-10-09 @2881 int idx = rf->channel-1; a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2882 u8 rfcsr; a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2883 a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2884 rt2800_rfcsr_write(rt2x00dev, 8, rf->rf1); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2885 rt2800_rfcsr_write(rt2x00dev, 9, rf->rf3); 16d571bb0 drivers/net/wireless/ralink/rt2x00/rt2800lib.c Arnd Bergmann 2017-05-17 2886 rfcsr = rt2800_rfcsr_read(rt2x00dev, 11); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2887 rt2x00_set_field8(, RFCSR11_R, rf->rf2); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2888 rt2800_rfcsr_write(rt2x00dev, 11, rfcsr); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2889 16d571bb0 drivers/net/wireless/ralink/rt2x00/rt2800lib.c Arnd Bergmann 2017-05-17 2890 rfcsr = rt2800_rfcsr_read(rt2x00dev, 49); 7573cb5b4 drivers/net/wireless/rt2x00/rt2800lib.cStanislaw Gruszka 2012-07-09 2891 if (info->default_power1 > POWER_BOUND) 7573cb5b4 drivers/net/wireless/rt2x00/rt2800lib.cStanislaw Gruszka 2012-07-09 2892 rt2x00_set_field8(, RFCSR49_TX, POWER_BOUND); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2893 else a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2894 rt2x00_set_field8(, RFCSR49_TX, info->default_power1); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2895 rt2800_rfcsr_write(rt2x00dev, 49, rfcsr); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2896 884525411 drivers/net/wireless/ralink/rt2x00/rt2800lib.c Stanislaw Gruszka 2016-12-19 2897 rt2800_freq_cal_mode1(rt2x00dev); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2898 a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2899 if (rf->channel <= 14) { a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2900 if (rf->channel == 6) a89534eda
Re: [PATCH v2 1/4] rt2x00: remove unneeded check
Hi Tomislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.19-rc7 next-20181009] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stanislaw-Gruszka/rt2x00-remove-unneeded-check/20181010-012334 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/net/wireless/ralink/rt2x00/rt2800lib.c: In function 'rt2800_config_channel_rf3290': drivers/net/wireless/ralink/rt2x00/rt2800lib.c:2881:6: warning: unused variable 'idx' [-Wunused-variable] int idx = rf->channel-1; ^~~ drivers/net/wireless/ralink/rt2x00/rt2800lib.c: In function 'rt2800_config_channel_rf53xx': >> drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3016:20: error: 'idx' >> undeclared (first use in this function); did you mean 'ida'? r55_bt_rev[idx]); ^~~ ida drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3016:20: note: each undeclared identifier is reported only once for each function it appears in vim +3016 drivers/net/wireless/ralink/rt2x00/rt2800lib.c 0c9e5fb91 drivers/net/wireless/rt2x00/rt2800lib.cStanislaw Gruszka 2013-03-16 2875 a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2876 static void rt2800_config_channel_rf3290(struct rt2x00_dev *rt2x00dev, a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2877 struct ieee80211_conf *conf, a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2878 struct rf_channel *rf, a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2879 struct channel_info *info) a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2880 { 64cc6975c drivers/net/wireless/ralink/rt2x00/rt2800lib.c Tomislav Požega 2018-10-09 @2881 int idx = rf->channel-1; a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2882 u8 rfcsr; a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2883 a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2884 rt2800_rfcsr_write(rt2x00dev, 8, rf->rf1); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2885 rt2800_rfcsr_write(rt2x00dev, 9, rf->rf3); 16d571bb0 drivers/net/wireless/ralink/rt2x00/rt2800lib.c Arnd Bergmann 2017-05-17 2886 rfcsr = rt2800_rfcsr_read(rt2x00dev, 11); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2887 rt2x00_set_field8(, RFCSR11_R, rf->rf2); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2888 rt2800_rfcsr_write(rt2x00dev, 11, rfcsr); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2889 16d571bb0 drivers/net/wireless/ralink/rt2x00/rt2800lib.c Arnd Bergmann 2017-05-17 2890 rfcsr = rt2800_rfcsr_read(rt2x00dev, 49); 7573cb5b4 drivers/net/wireless/rt2x00/rt2800lib.cStanislaw Gruszka 2012-07-09 2891 if (info->default_power1 > POWER_BOUND) 7573cb5b4 drivers/net/wireless/rt2x00/rt2800lib.cStanislaw Gruszka 2012-07-09 2892 rt2x00_set_field8(, RFCSR49_TX, POWER_BOUND); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2893 else a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2894 rt2x00_set_field8(, RFCSR49_TX, info->default_power1); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2895 rt2800_rfcsr_write(rt2x00dev, 49, rfcsr); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2896 884525411 drivers/net/wireless/ralink/rt2x00/rt2800lib.c Stanislaw Gruszka 2016-12-19 2897 rt2800_freq_cal_mode1(rt2x00dev); a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2898 a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2899 if (rf->channel <= 14) { a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2900 if (rf->channel == 6) a89534eda drivers/net/wireless/rt2x00/rt2800lib.cWoody Hung 2012-06-13 2901 rt2800_bbp_write(rt2x00dev, 68, 0x0c); a89534eda
Re: [PATCH] mt76: fix building without CONFIG_MT76x0U
Hi Arnd, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20180926] [cannot apply to v4.19-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/mt76-fix-building-without-CONFIG_MT76x0U/20180927-101346 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "mt76x0_tx_prepare_skb" >> [drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0u.ko] undefined! >> ERROR: "mt76x0_cleanup" >> [drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0u.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 12/12] rtwlan: Kconfig & Makefile
Hi Yan-Hsuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/yhchuang-realtek-com/rtwlan-mac80211-driver-for-Realtek-802-11ac-wireless-network-chips/20180923-065459 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): drivers/net//wireless/realtek/rtwlan/pci.c: In function 'rtw_pci_parse_configuration': >> drivers/net//wireless/realtek/rtwlan/pci.c:1009:2: error: implicit >> declaration of function 'pcie_capability_read_word' >> [-Werror=implicit-function-declaration] pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, _control); ^ drivers/net//wireless/realtek/rtwlan/pci.c: In function 'rtw_pci_declaim': >> drivers/net//wireless/realtek/rtwlan/pci.c:1037:2: error: implicit >> declaration of function 'pci_clear_master' >> [-Werror=implicit-function-declaration] pci_clear_master(pdev); ^~~~ drivers/net//wireless/realtek/rtwlan/pci.c: At top level: drivers/net//wireless/realtek/rtwlan/pci.c:1213:1: warning: data definition has no type or storage class module_pci_driver(rtw_pci_driver); ^ drivers/net//wireless/realtek/rtwlan/pci.c:1213:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] drivers/net//wireless/realtek/rtwlan/pci.c:1213:1: warning: parameter names (without types) in function declaration drivers/net//wireless/realtek/rtwlan/pci.c:1189:26: warning: 'rtw_pci_driver' defined but not used [-Wunused-variable] static struct pci_driver rtw_pci_driver = { ^~ cc1: some warnings being treated as errors vim +/pcie_capability_read_word +1009 drivers/net//wireless/realtek/rtwlan/pci.c d6f77d8d Yan-Hsuan Chuang 2018-09-21 995 d6f77d8d Yan-Hsuan Chuang 2018-09-21 996 static void rtw_pci_parse_configuration(struct rtw_dev *rtwdev, d6f77d8d Yan-Hsuan Chuang 2018-09-21 997 struct pci_dev *pdev) d6f77d8d Yan-Hsuan Chuang 2018-09-21 998 { d6f77d8d Yan-Hsuan Chuang 2018-09-21 999 u16 link_control; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1000 u8 config; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1001 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1002 /* Disable Clk Request */ d6f77d8d Yan-Hsuan Chuang 2018-09-21 1003 pci_write_config_byte(pdev, 0x81, 0); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1004 /* leave D3 mode */ d6f77d8d Yan-Hsuan Chuang 2018-09-21 1005 pci_write_config_byte(pdev, 0x44, 0); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1006 pci_write_config_byte(pdev, 0x04, 0x06); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1007 pci_write_config_byte(pdev, 0x04, 0x07); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1008 d6f77d8d Yan-Hsuan Chuang 2018-09-21 @1009 pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, _control); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1010 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1011 pci_read_config_byte(pdev, 0x98, ); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1012 config |= BIT(4); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1013 pci_write_config_byte(pdev, 0x98, config); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1014 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1015 pci_write_config_byte(pdev, 0x70f, 0x17); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1016 } d6f77d8d Yan-Hsuan Chuang 2018-09-21 1017 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1018 static int rtw_pci_claim(struct rtw_dev *rtwdev, struct pci_dev *pdev) d6f77d8d Yan-Hsuan Chuang 2018-09-21 1019 { d6f77d8d Yan-Hsuan Chuang 2018-09-21 1020 int ret; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1021 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1022 ret = pci_enable_device(pdev); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1023 if (ret) { d6f77d8d Yan-Hsuan Chuang 2018-09-21 1024 rtw_err(rtwdev, "failed to enable pci device\n"); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1025 return ret; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1026 } d6f77d8d Yan-Hsuan Chuang 2018-09-21 1027 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1028 pci_set_master(pdev); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1029 pci_set_drvdata(pdev, rtwdev->hw); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1030 SET_IEEE80211_DEV(rtwdev->hw, >dev); d6f77d8d Yan-Hsuan Chuang 2018-09-21
Re: [PATCH 12/12] rtwlan: Kconfig & Makefile
Hi Yan-Hsuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/yhchuang-realtek-com/rtwlan-mac80211-driver-for-Realtek-802-11ac-wireless-network-chips/20180923-065459 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh All error/warnings (new ones prefixed by >>): drivers/net/wireless/realtek/rtwlan/pci.c: In function 'rtw_pci_io_mapping': >> drivers/net/wireless/realtek/rtwlan/pci.c:880:17: error: implicit >> declaration of function 'pci_iomap'; did you mean 'pcim_iomap'? >> [-Werror=implicit-function-declaration] rtwpci->mmap = pci_iomap(pdev, bar_id, len); ^ pcim_iomap >> drivers/net/wireless/realtek/rtwlan/pci.c:880:15: warning: assignment makes >> pointer from integer without a cast [-Wint-conversion] rtwpci->mmap = pci_iomap(pdev, bar_id, len); ^ drivers/net/wireless/realtek/rtwlan/pci.c: In function 'rtw_pci_io_unmapping': >> drivers/net/wireless/realtek/rtwlan/pci.c:895:3: error: implicit declaration >> of function 'pci_iounmap'; did you mean 'pcim_iounmap'? >> [-Werror=implicit-function-declaration] pci_iounmap(pdev, rtwpci->mmap); ^~~ pcim_iounmap drivers/net/wireless/realtek/rtwlan/pci.c: In function 'rtw_pci_parse_configuration': >> drivers/net/wireless/realtek/rtwlan/pci.c:1009:2: error: implicit >> declaration of function 'pcie_capability_read_word'; did you mean >> 'has_capability_noaudit'? [-Werror=implicit-function-declaration] pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, _control); ^ has_capability_noaudit drivers/net/wireless/realtek/rtwlan/pci.c: In function 'rtw_pci_declaim': >> drivers/net/wireless/realtek/rtwlan/pci.c:1037:2: error: implicit >> declaration of function 'pci_clear_master'; did you mean 'pci_set_master'? >> [-Werror=implicit-function-declaration] pci_clear_master(pdev); ^~~~ pci_set_master drivers/net/wireless/realtek/rtwlan/pci.c: At top level: >> drivers/net/wireless/realtek/rtwlan/pci.c:1213:1: warning: data definition >> has no type or storage class module_pci_driver(rtw_pci_driver); ^ >> drivers/net/wireless/realtek/rtwlan/pci.c:1213:1: error: type defaults to >> 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] >> drivers/net/wireless/realtek/rtwlan/pci.c:1213:1: warning: parameter names >> (without types) in function declaration drivers/net/wireless/realtek/rtwlan/pci.c:1189:26: warning: 'rtw_pci_driver' defined but not used [-Wunused-variable] static struct pci_driver rtw_pci_driver = { ^~ cc1: some warnings being treated as errors vim +880 drivers/net/wireless/realtek/rtwlan/pci.c d6f77d8d Yan-Hsuan Chuang 2018-09-21 864 d6f77d8d Yan-Hsuan Chuang 2018-09-21 865 static int rtw_pci_io_mapping(struct rtw_dev *rtwdev, d6f77d8d Yan-Hsuan Chuang 2018-09-21 866struct pci_dev *pdev) d6f77d8d Yan-Hsuan Chuang 2018-09-21 867 { d6f77d8d Yan-Hsuan Chuang 2018-09-21 868 struct rtw_pci *rtwpci = (struct rtw_pci *)rtwdev->priv; d6f77d8d Yan-Hsuan Chuang 2018-09-21 869 unsigned long len; d6f77d8d Yan-Hsuan Chuang 2018-09-21 870 u8 bar_id = 2; d6f77d8d Yan-Hsuan Chuang 2018-09-21 871 int ret; d6f77d8d Yan-Hsuan Chuang 2018-09-21 872 d6f77d8d Yan-Hsuan Chuang 2018-09-21 873 ret = pci_request_regions(pdev, KBUILD_MODNAME); d6f77d8d Yan-Hsuan Chuang 2018-09-21 874 if (ret) { d6f77d8d Yan-Hsuan Chuang 2018-09-21 875 rtw_err(rtwdev, "failed to request pci regions\n"); d6f77d8d Yan-Hsuan Chuang 2018-09-21 876 return ret; d6f77d8d Yan-Hsuan Chuang 2018-09-21 877 } d6f77d8d Yan-Hsuan Chuang 2018-09-21 878 d6f77d8d Yan-Hsuan Chuang 2018-09-21 879 len = pci_resource_len(pdev, bar_id); d6f77d8d Yan-Hsuan Chuang 2018-09-21 @880 rtwpci->mmap = pci_iomap(pdev, bar_id, len); d6f77d8d Yan-Hsuan Chuang 2018-09-21 881 if (!rtwpci->mmap) { d6f77d8d Yan-Hsuan Chuang 2018-09-21 882 rtw_err(rtwdev, "failed to map pci memory\n"); d6f77d8d Yan-Hsuan Chuang 2018-09-21 883 return -ENOMEM; d6f77d8d Yan-Hsuan Chuang 2018-09-21 884 } d6f77d8d Yan-Hsuan Chuang 2018-09-21 885
Re: [PATCH 19/28] mac80211: support reporting 0-length PSDU in radiotap
Hi Shaul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mac80211-next/master] [also build test WARNING on next-20180831] [cannot apply to v4.19-rc1] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/cfg80211-mac80211-patches-from-our-internal-tree-2018-08-31/20180901-062742 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/srcu.h:175: warning: Function parameter or member 'p' not described in 'srcu_dereference_notrace' include/linux/srcu.h:175: warning: Function parameter or member 'sp' not described in 'srcu_dereference_notrace' include/linux/gfp.h:1: warning: no structured comments found include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4383: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2360: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2360: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' >> include/net/mac80211.h:1180: warning: Enum value 'RX_FLAG_NO_PSDU' not >> described in enum 'mac80211_rx_flags' >> include/net/mac80211.h:1180: warning: Excess enum value >> 'RX_FLAG_RADIOTAP_NO_PSDU' description in 'mac80211_rx_flags' include/net/mac80211.h:978: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:978: warning: Function parameter
Re: [PATCH 07/16] iwlwifi: mvm: support new WoWLAN status FW API
Hi Luca, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20180817] [cannot apply to v4.18] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/iwlwifi-updates-intended-for-v4-20-2018-08-18/20180818-163006 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: parisc-allyesconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=parisc All errors (new ones prefixed by >>): drivers/net/wireless/intel/iwlwifi/mvm/ops.o: In function `iwl_mvm_d0i3_exit_work': >> (.text+0x2eec): undefined reference to `iwl_mvm_send_wowlan_get_status' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 07/16] iwlwifi: mvm: support new WoWLAN status FW API
Hi Luca, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20180817] [cannot apply to v4.18] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/iwlwifi-updates-intended-for-v4-20-2018-08-18/20180818-163006 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: parisc-allmodconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=parisc All errors (new ones prefixed by >>): >> ERROR: "iwl_mvm_send_wowlan_get_status" >> [drivers/net/wireless/intel/iwlwifi/mvm/iwlmvm.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 12/12] mt76: Kconfig and Makefile for mt76x0 driver
Hi Stanislaw, I love your patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.18-rc3 next-20180706] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stanislaw-Gruszka/mt76-add-more-states/20180706-200412 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:253:15: sparse: expression >> using sizeof(void) >> drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:253:15: sparse: expression >> using sizeof(void) drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:282:15: sparse: expression using sizeof(void) drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:282:15: sparse: expression using sizeof(void) drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:325:15: sparse: expression using sizeof(void) drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:325:15: sparse: expression using sizeof(void) drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:354:15: sparse: expression using sizeof(void) drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:354:15: sparse: expression using sizeof(void) >> drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:344:5: sparse: symbol >> 'mt76x0_burst_read_regs' was not declared. Should it be static? drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c:463:13: sparse: expression using sizeof(void) -- >> drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c:88:27: sparse: Variable >> length array is used. -- >> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c:969:34: sparse: expression >> using sizeof(void) >> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c:989:6: sparse: symbol >> 'mt76x0_ant_select' was not declared. Should it be static? -- >> drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:88:21: sparse: expression >> using sizeof(void) drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:97:31: sparse: expression using sizeof(void) >> drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:166:16: sparse: incorrect >> type in return expression (different base types) @@expected unsigned >> short @@got restricted __leunsigned short @@ drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:166:16:expected unsigned short drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:166:16:got restricted __le16 [usertype] >> drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:175:23: sparse: incorrect >> type in assignment (different base types) @@expected restricted __le16 >> [usertype] tx_rate @@got 16 [usertype] tx_rate @@ drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:175:23:expected restricted __le16 [usertype] tx_rate drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:175:23:got unsigned short drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:438:30: sparse: expression using sizeof(void) drivers/net/wireless/mediatek/mt76/mt76x0/mac.c:438:30: sparse: expression using sizeof(void) -- >> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c:93:26: sparse: incorrect type >> in assignment (different base types) @@expected unsigned short >> [unsigned] [usertype] rate_ctl @@got short [unsigned] [usertype] >> rate_ctl @@ drivers/net/wireless/mediatek/mt76/mt76x0/tx.c:93:26:expected unsigned short [unsigned] [usertype] rate_ctl drivers/net/wireless/mediatek/mt76/mt76x0/tx.c:93:26:got restricted __le16 [usertype] tx_rate >> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c:126:27: sparse: expression >> using sizeof(void) Please review and possibly fold the followup patch. vim +253 drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c 9b00fd07 Stanislaw Gruszka 2018-07-06 242 9b00fd07 Stanislaw Gruszka 2018-07-06 243 int mt76x0_write_reg_pairs(struct mt76x0_dev *dev, u32 base, 9b00fd07 Stanislaw Gruszka 2018-07-06 244 const struct mt76_reg_pair *data, int n) 9b00fd07 Stanislaw Gruszka 2018-07-06 245 { 9b00fd07 Stanislaw Gruszka 2018-07-06 246 const int max_vals_per_cmd = INBAND_PACKET_MAX_LEN / 8; 9b00fd07 Stanislaw Gruszka 2018-07-06 247 struct sk_buff *skb; 9b00fd07 Stanislaw Gruszka 2018-07-06 248 int cnt, i, ret; 9b00fd07 Stanislaw Gruszka 2018-07-06 249 9b00fd07 Stanislaw Gruszka 2018-07-06 250 if (!n) 9b00fd07 Stanislaw Gruszka 2018-07-06 251 return 0; 9b00fd07 Stanislaw Gruszka 2018-07-06 252 9b00fd07 Stanislaw Gruszka 2018-07-06 @253 cnt = min(max_vals_per_cmd, n); 9b00fd07 Stanislaw Gruszka 2018-07-06 254 9b00fd07 Stanislaw Gruszka 2018-07-06 255 skb = alloc_skb(cnt * 8 + MT_DMA_HDR_LEN + 4, GFP_KERNEL); 9b00fd07 Stanislaw Gruszka 2018-07-06 256 if (!skb) 9b00fd07 Stanislaw Gruszka 2018-07-06 257 return
[RFC PATCH] mt76: mt76x0_burst_read_regs() can be static
Fixes: c1f1ff1a3d63 ("mt76: Kconfig and Makefile for mt76x0 driver") Signed-off-by: kbuild test robot --- mcu.c |4 ++-- phy.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c b/drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c index aafa3f3..0c9da79 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/mcu.c @@ -341,8 +341,8 @@ int mt76x0_burst_write_regs(struct mt76x0_dev *dev, u32 offset, data + cnt, n - cnt); } -int mt76x0_burst_read_regs(struct mt76x0_dev *dev, u32 base, - struct mt76_reg_pair *data, int n) +static int mt76x0_burst_read_regs(struct mt76x0_dev *dev, u32 base, + struct mt76_reg_pair *data, int n) { const int max_vals_per_cmd = INBAND_PACKET_MAX_LEN / 4 - 1; struct sk_buff *skb; diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c index 0830280..e52a506 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c @@ -986,7 +986,7 @@ mt76x0_rf_init(struct mt76x0_dev *dev) rf_set(dev, MT_RF(0, 4), 0x80); } -void mt76x0_ant_select(struct mt76x0_dev *dev) +static void mt76x0_ant_select(struct mt76x0_dev *dev) { /* Single antenna mode. */ mt76_rmw(dev, MT_WLAN_FUN_CTRL, BIT(5), BIT(6));
Re: [PATCH 11/11] mt76: Kconfig and Makefile for mt76x0 driver
Hi Stanislaw, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.18-rc3 next-20180704] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stanislaw-Gruszka/Add-mt76x0-driver/20180705-150550 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): drivers/net/wireless/mediatek/mt76/mt76x0/phy.c: In function 'mt76x0_phy_set_channel': >> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c:619:6: warning: 'bw' may be >> used uninitialized in this function [-Wmaybe-uninitialized] int bw; ^~ >> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c:350:6: warning: 'rf_band' >> may be used uninitialized in this function [-Wmaybe-uninitialized] u16 rf_band; ^~~ -- >> make[7]: *** No rule to make target >> 'drivers/net/wireless/mediatek/mt76/mt76x0/main.o', needed by >> 'drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.o'. make[7]: Target '__build' not remade because of errors. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 12/19] mt76: add mt76x2_tx_common to mt76x2-common module
Hi Lorenzo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.18-rc3 next-20180629] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/add-mt76x2u-support-to-mt76-driver/20180701-221609 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master smatch warnings: drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c:35 mt76x2_tx() warn: always true condition '(wcid->hw_key_idx != -1) => (0-255 != (-1))' vim +35 drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c 20 21 void mt76x2_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control, 22 struct sk_buff *skb) 23 { 24 struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); 25 struct mt76x2_dev *dev = hw->priv; 26 struct ieee80211_vif *vif = info->control.vif; 27 struct mt76_wcid *wcid = >global_wcid; 28 29 if (control->sta) { 30 struct mt76x2_sta *msta; 31 32 msta = (struct mt76x2_sta *)control->sta->drv_priv; 33 wcid = >wcid; 34 /* sw encrypted frames */ > 35 if (!info->control.hw_key && wcid->hw_key_idx != -1) 36 control->sta = NULL; 37 } 38 39 if (vif && !control->sta) { 40 struct mt76x2_vif *mvif; 41 42 mvif = (struct mt76x2_vif *)vif->drv_priv; 43 wcid = >group_wcid; 44 } 45 46 mt76_tx(>mt76, control->sta, wcid, skb); 47 } 48 EXPORT_SYMBOL_GPL(mt76x2_tx); 49 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH] mac80211: add stop/start logic for software TXQs
Hi Manikanta, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mac80211-next/master] [also build test WARNING on v4.18-rc2 next-20180626] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Manikanta-Pubbisetty/mac80211-add-stop-start-logic-for-software-TXQs/20180626-153410 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) mm/mempool.c:228: warning: Function parameter or member 'pool' not described in 'mempool_init' Error: Cannot open file arch/x86/kernel/cpu/mtrr/main.c Error: Cannot open file arch/x86/kernel/cpu/mtrr/main.c WARNING: kernel-doc 'scripts/kernel-doc -rst -enable-lineno -export arch/x86/kernel/cpu/mtrr/main.c' failed with return code 2 include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2328: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2328: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:977: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info'
Re: [PATCH 2/2] mwifiex: restructure rx_reorder_tbl_lock usage
Hi Ganapathi, I love your patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.18-rc2 next-20180625] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ganapathi-Bhat/mwifiex-replace-rx_pkt_lock-by-rx_reorder_tbl_lock/20180625-175146 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: arm-sama5_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): In file included from include/linux/irqflags.h:16:0, from arch/arm/include/asm/bitops.h:28, from include/linux/bitops.h:38, from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/wait.h:7, from drivers/net//wireless/marvell/mwifiex/decl.h:26, from drivers/net//wireless/marvell/mwifiex/11n_rxreorder.c:20: drivers/net//wireless/marvell/mwifiex/11n_rxreorder.c: In function 'mwifiex_11n_rx_reorder_pkt': >> arch/arm/include/asm/irqflags.h:171:2: warning: 'flags' may be used >> uninitialized in this function [-Wmaybe-uninitialized] asm volatile( ^~~ drivers/net//wireless/marvell/mwifiex/11n_rxreorder.c:155:16: note: 'flags' was declared here unsigned long flags; ^ -- In file included from include/linux/irqflags.h:16:0, from arch/arm/include/asm/bitops.h:28, from include/linux/bitops.h:38, from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/wait.h:7, from drivers/net/wireless/marvell/mwifiex/decl.h:26, from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:20: drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c: In function 'mwifiex_11n_rx_reorder_pkt': >> arch/arm/include/asm/irqflags.h:171:2: warning: 'flags' may be used >> uninitialized in this function [-Wmaybe-uninitialized] asm volatile( ^~~ drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:155:16: note: 'flags' was declared here unsigned long flags; ^ vim +/flags +171 arch/arm/include/asm/irqflags.h 7ad1bcb2 include/asm-arm/irqflags.h Russell King2006-08-27 164 7ad1bcb2 include/asm-arm/irqflags.h Russell King2006-08-27 165 /* 7ad1bcb2 include/asm-arm/irqflags.h Russell King2006-08-27 166 * restore saved IRQ & FIQ state 7ad1bcb2 include/asm-arm/irqflags.h Russell King2006-08-27 167 */ 6fb18ac9 arch/arm/include/asm/irqflags.h Daniel Thompson 2015-06-10 168 #define arch_local_irq_restore arch_local_irq_restore df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 169 static inline void arch_local_irq_restore(unsigned long flags) df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 170 { df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 @171 asm volatile( 55bdd694 arch/arm/include/asm/irqflags.h Catalin Marinas 2010-05-21 172 " msr " IRQMASK_REG_NAME_W ", %0 @ local_irq_restore" df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 173 : df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 174 : "r" (flags) df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 175 : "memory", "cc"); df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 176 } df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 177 :: The code at line 171 was first introduced by commit :: df9ee29270c11dba7d0fe0b83ce47a4d8e8d2101 Fix IRQ flag handling naming :: TO: David Howells :: CC: David Howells --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 1/3] cfg80211: Add support for HE
Hi Luca, I love your patch! Yet something to improve: [auto build test ERROR on mac80211-next/master] [also build test ERROR on next-20180608] [cannot apply to v4.17] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/cfg80211-mac80211-add-support-for-IEEE802-11ax/20180609-065018 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: x86_64-randconfig-x018-201822 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Luca-Coelho/cfg80211-mac80211-add-support-for-IEEE802-11ax/20180609-065018 HEAD a5988005673125579d32941fcb33b0d7c9d79ee5 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): In file included from arch/x86/include/asm/bug.h:83:0, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/linux/uio.h:13, from include/linux/socket.h:8, from include/uapi/linux/if.h:25, from net/wireless/core.c:11: net/wireless/core.c: In function 'wiphy_register': >> net/wireless/core.c:798:23: error: 'const struct >> ieee80211_sband_iftype_data' has no member named 'types'; did you mean >> 'types_mask'? if (WARN_ON(!iftd->types)) ^ include/asm-generic/bug.h:112:25: note: in definition of macro 'WARN_ON' int __ret_warn_on = !!(condition);\ ^ net/wireless/core.c:800:30: error: 'const struct ieee80211_sband_iftype_data' has no member named 'types'; did you mean 'types_mask'? if (WARN_ON(types & iftd->types)) ^ include/asm-generic/bug.h:112:25: note: in definition of macro 'WARN_ON' int __ret_warn_on = !!(condition);\ ^ net/wireless/core.c:807:19: error: 'const struct ieee80211_sband_iftype_data' has no member named 'types'; did you mean 'types_mask'? types |= iftd->types; ^ types_mask vim +798 net/wireless/core.c 666 667 /* 668 * if a wiphy has unsupported modes for regulatory channel enforcement, 669 * opt-out of enforcement checking 670 */ 671 if (wiphy->interface_modes & ~(BIT(NL80211_IFTYPE_STATION) | 672 BIT(NL80211_IFTYPE_P2P_CLIENT) | 673 BIT(NL80211_IFTYPE_AP) | 674 BIT(NL80211_IFTYPE_P2P_GO) | 675 BIT(NL80211_IFTYPE_ADHOC) | 676 BIT(NL80211_IFTYPE_P2P_DEVICE) | 677 BIT(NL80211_IFTYPE_NAN) | 678 BIT(NL80211_IFTYPE_AP_VLAN) | 679 BIT(NL80211_IFTYPE_MONITOR))) 680 wiphy->regulatory_flags |= REGULATORY_IGNORE_STALE_KICKOFF; 681 682 if (WARN_ON((wiphy->regulatory_flags & REGULATORY_WIPHY_SELF_MANAGED) && 683 (wiphy->regulatory_flags & 684 (REGULATORY_CUSTOM_REG | 685 REGULATORY_STRICT_REG | 686 REGULATORY_COUNTRY_IE_FOLLOW_POWER | 687 REGULATORY_COUNTRY_IE_IGNORE 688 return -EINVAL; 689 690 if (WARN_ON(wiphy->coalesce && 691 (!wiphy->coalesce->n_rules || 692 !wiphy->coalesce->n_patterns) && 693 (!wiphy->coalesce->pattern_min_len || 694 wiphy->coalesce->pattern_min_len > 695 wiphy->coalesce->pattern_max_len))) 696 return -EINVAL; 697 698 if (WARN_ON(wiphy->ap_sme_capa && 699 !(wiphy->flags & WIPHY_FLAG_HAVE_AP_SME))) 700 return -EINVAL; 701 702 if (WARN_ON(wiphy->addresses && !wiphy->n_addresses)) 703 return -EINVAL; 704 705 if (WARN_ON(wiphy->addresses && 706 !is_zero_ether_addr(wiphy->perm_addr) && 707 memcmp(wiphy->perm_addr, wiphy->addresses[0].addr, 708 ETH_ALEN))) 709 return -EINVAL; 710 711 if (WARN_ON(wiphy->max_acl_mac_addrs && 712 (!(wiphy->flags & WIPHY_FLAG_HAVE_AP_SME) || 713 !rdev->ops->set_mac_acl))) 714
Re: [PATCH 1/2] cfg80211: last ack singal support in station dump
Hi Balaji, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211-next/master] [cannot apply to v4.17-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Balaji-Pothunoori/cfg80211-mac80211-last-ack-singal-support-in-station-dump/20180527-162750 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: x86_64-randconfig-x000-201821 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Balaji-Pothunoori/cfg80211-mac80211-last-ack-singal-support-in-station-dump/20180527-162750 HEAD 7d4f99704af356d198be9638b571119647e26397 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:11:0, from include/linux/list.h:9, from include/linux/module.h:9, from net//mac80211/sta_info.c:13: net//mac80211/sta_info.c: In function 'sta_set_sinfo': >> net//mac80211/sta_info.c:2314:32: error: >> 'NL80211_STA_INFO_DATA_ACK_SIGNAL_AVG' undeclared (first use in this >> function); did you mean 'NL80211_STA_INFO_ACK_SIGNAL_AVG'? !(sinfo->filled & BIT_ULL(NL80211_STA_INFO_DATA_ACK_SIGNAL_AVG))) { ^ include/linux/bitops.h:8:32: note: in definition of macro 'BIT_ULL' #define BIT_ULL(nr) (1ULL << (nr)) ^~ net//mac80211/sta_info.c:2314:32: note: each undeclared identifier is reported only once for each function it appears in !(sinfo->filled & BIT_ULL(NL80211_STA_INFO_DATA_ACK_SIGNAL_AVG))) { ^ include/linux/bitops.h:8:32: note: in definition of macro 'BIT_ULL' #define BIT_ULL(nr) (1ULL << (nr)) ^~ vim +2314 net//mac80211/sta_info.c c9c5962b5 Johannes Berg2016-03-31 2081 0fdf1493b Johannes Berg2018-05-18 2082 void sta_set_sinfo(struct sta_info *sta, struct station_info *sinfo, 0fdf1493b Johannes Berg2018-05-18 2083bool tidstats) b7ffbd7ef Johannes Berg2014-06-04 2084 { b7ffbd7ef Johannes Berg2014-06-04 2085 struct ieee80211_sub_if_data *sdata = sta->sdata; b7ffbd7ef Johannes Berg2014-06-04 2086 struct ieee80211_local *local = sdata->local; b7ffbd7ef Johannes Berg2014-06-04 2087 u32 thr = 0; c9c5962b5 Johannes Berg2016-03-31 2088 int i, ac, cpu; c9c5962b5 Johannes Berg2016-03-31 2089 struct ieee80211_sta_rx_stats *last_rxstats; c9c5962b5 Johannes Berg2016-03-31 2090 c9c5962b5 Johannes Berg2016-03-31 2091 last_rxstats = sta_get_last_rx_stats(sta); b7ffbd7ef Johannes Berg2014-06-04 2092 b7ffbd7ef Johannes Berg2014-06-04 2093 sinfo->generation = sdata->local->sta_generation; b7ffbd7ef Johannes Berg2014-06-04 2094 225b81898 Johannes Berg2015-01-21 2095 /* do before driver, so beacon filtering drivers have a 225b81898 Johannes Berg2015-01-21 2096 * chance to e.g. just add the number of filtered beacons 225b81898 Johannes Berg2015-01-21 2097 * (or just modify the value entirely, of course) 225b81898 Johannes Berg2015-01-21 2098 */ 225b81898 Johannes Berg2015-01-21 2099 if (sdata->vif.type == NL80211_IFTYPE_STATION) 225b81898 Johannes Berg2015-01-21 2100 sinfo->rx_beacon = sdata->u.mgd.count_beacon_signal; 225b81898 Johannes Berg2015-01-21 2101 2b9a7e1ba Johannes Berg2014-11-17 2102 drv_sta_statistics(local, sdata, >sta, sinfo); 2b9a7e1ba Johannes Berg2014-11-17 2103 319090bf6 Johannes Berg2014-11-17 2104 sinfo->filled |= BIT(NL80211_STA_INFO_INACTIVE_TIME) | 319090bf6 Johannes Berg2014-11-17 2105 BIT(NL80211_STA_INFO_STA_FLAGS) | 319090bf6 Johannes Berg2014-11-17 2106 BIT(NL80211_STA_INFO_BSS_PARAM) | 319090bf6 Johannes Berg2014-11-17 2107 BIT(NL80211_STA_INFO_CONNECTED_TIME) | 976bd9efd Johannes Berg2015-10-16 2108 BIT(NL80211_STA_INFO_RX_DROP_MISC); 976bd9efd Johannes Berg2015-10-16 2109 976bd9efd Johannes Berg2015-10-16 2110 if (sdata->vif.type == NL80211_IFTYPE_STATION) { 976bd9efd Johannes Berg2015-10-16 2111 sinfo->beacon_loss_count = sdata->u.mgd.beacon_loss_count; 976bd9efd Johannes Berg2015-10-16 2112 sinfo->filled |= BIT(NL80211_STA_INFO_BEACON_LOSS); 976bd9efd Johannes Berg
Re: [PATCH 2/3] brcmfmac: handle monitor mode marked msgbuf packets
Hi Rafał, I love your patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.17-rc6 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/brcmfmac-allow-specifying-features-per-firmware-version/20180523-160546 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c:304:30: sparse: expression using sizeof(void) >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c:417:34: sparse: >> incorrect type in assignment (different base types) @@expected >> restricted __le16 [usertype] it_len @@got 6 [usertype] it_len @@ drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c:417:34:expected restricted __le16 [usertype] it_len drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c:417:34:got unsigned long vim +417 drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c 264 265 static netdev_tx_t brcmf_netdev_start_xmit(struct sk_buff *skb, 266 struct net_device *ndev) 267 { 268 int ret; 269 struct brcmf_if *ifp = netdev_priv(ndev); 270 struct brcmf_pub *drvr = ifp->drvr; 271 struct ethhdr *eh; 272 int head_delta; 273 274 brcmf_dbg(DATA, "Enter, bsscfgidx=%d\n", ifp->bsscfgidx); 275 276 /* Can the device send data? */ 277 if (drvr->bus_if->state != BRCMF_BUS_UP) { 278 brcmf_err("xmit rejected state=%d\n", drvr->bus_if->state); 279 netif_stop_queue(ndev); 280 dev_kfree_skb(skb); 281 ret = -ENODEV; 282 goto done; 283 } 284 285 /* Some recent Broadcom's firmwares disassociate STA when they receive 286 * an 802.11f ADD frame. This behavior can lead to a local DoS security 287 * issue. Attacker may trigger disassociation of any STA by sending a 288 * proper Ethernet frame to the wireless interface. 289 * 290 * Moreover this feature may break AP interfaces in some specific 291 * setups. This applies e.g. to the bridge with hairpin mode enabled and 292 * IFLA_BRPORT_MCAST_TO_UCAST set. IAPP packet generated by a firmware 293 * will get passed back to the wireless interface and cause immediate 294 * disassociation of a just-connected STA. 295 */ 296 if (!drvr->settings->iapp && brcmf_skb_is_iapp(skb)) { 297 dev_kfree_skb(skb); 298 ret = -EINVAL; 299 goto done; 300 } 301 302 /* Make sure there's enough writeable headroom */ 303 if (skb_headroom(skb) < drvr->hdrlen || skb_header_cloned(skb)) { > 304 head_delta = max_t(int, drvr->hdrlen - > skb_headroom(skb), 0); 305 306 brcmf_dbg(INFO, "%s: insufficient headroom (%d)\n", 307brcmf_ifname(ifp), head_delta); 308 atomic_inc(>bus_if->stats.pktcowed); 309 ret = pskb_expand_head(skb, ALIGN(head_delta, NET_SKB_PAD), 0, 310 GFP_ATOMIC); 311 if (ret < 0) { 312 brcmf_err("%s: failed to expand headroom\n", 313brcmf_ifname(ifp)); 314 atomic_inc(>bus_if->stats.pktcow_failed); 315 goto done; 316 } 317 } 318 319 /* validate length for ether packet */ 320 if (skb->len < sizeof(*eh)) { 321 ret = -EINVAL; 322 dev_kfree_skb(skb); 323 goto done; 324 } 325 326 eh = (struct ethhdr *)(skb->data); 327 328 if (eh->h_proto == htons(ETH_P_PAE)) 329 atomic_inc(>pend_8021x_cnt); 330 331 /* determine the priority */ 332 if ((skb->priority == 0) || (skb->priority > 7)) 333 skb->priority = cfg80211_classify8021d(skb, NULL); 334 335 ret = brcmf_proto_tx_queue_data(drvr, ifp->ifidx, skb); 336 if (ret < 0) 337 brcmf_txfinalize(ifp, skb, false); 338 339 done: 340 if (ret) { 341 ndev->stats.tx_dropped++; 342 } else { 343
[mac80211-next:master 20/20] net/wireless/nl80211.c:4802:48: sparse: incorrect type in argument 1 (different base types)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 commit: 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 [20/20] cfg80211: release station info tidstats where needed reproduce: # apt-get install sparse git checkout 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> net/wireless/nl80211.c:4802:48: sparse: incorrect type in argument 1 >> (different base types) @@expected struct station_info *sinfo @@got >> struct statiostruct station_info *sinfo @@ net/wireless/nl80211.c:4802:48:expected struct station_info *sinfo net/wireless/nl80211.c:4802:48:got struct station_info [addressable] sinfo net/wireless/nl80211.c:7587:33: sparse: expression using sizeof(void) net/wireless/nl80211.c:7587:33: sparse: expression using sizeof(void) net/wireless/nl80211.c: In function 'nl80211_get_station': net/wireless/nl80211.c:4802:34: error: incompatible type for argument 1 of 'cfg80211_sinfo_release_content' cfg80211_sinfo_release_content(sinfo); ^ In file included from net/wireless/nl80211.c:24:0: include/net/cfg80211.h:5721:20: note: expected 'struct station_info *' but argument is of type 'struct station_info' static inline void cfg80211_sinfo_release_content(struct station_info *sinfo) ^~ vim +4802 net/wireless/nl80211.c 4776 4777 static int nl80211_get_station(struct sk_buff *skb, struct genl_info *info) 4778 { 4779 struct cfg80211_registered_device *rdev = info->user_ptr[0]; 4780 struct net_device *dev = info->user_ptr[1]; 4781 struct station_info sinfo; 4782 struct sk_buff *msg; 4783 u8 *mac_addr = NULL; 4784 int err; 4785 4786 memset(, 0, sizeof(sinfo)); 4787 4788 if (!info->attrs[NL80211_ATTR_MAC]) 4789 return -EINVAL; 4790 4791 mac_addr = nla_data(info->attrs[NL80211_ATTR_MAC]); 4792 4793 if (!rdev->ops->get_station) 4794 return -EOPNOTSUPP; 4795 4796 err = rdev_get_station(rdev, dev, mac_addr, ); 4797 if (err) 4798 return err; 4799 4800 msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); 4801 if (!msg) { > 4802 cfg80211_sinfo_release_content(sinfo); 4803 return -ENOMEM; 4804 } 4805 4806 if (nl80211_send_station(msg, NL80211_CMD_NEW_STATION, 4807 info->snd_portid, info->snd_seq, 0, 4808 rdev, dev, mac_addr, ) < 0) { 4809 nlmsg_free(msg); 4810 return -ENOBUFS; 4811 } 4812 4813 return genlmsg_reply(msg, info); 4814 } 4815 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[mac80211-next:master 20/20] net/wireless/nl80211.c:4802:34: error: incompatible type for argument 1 of 'cfg80211_sinfo_release_content'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 commit: 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 [20/20] cfg80211: release station info tidstats where needed config: x86_64-randconfig-x004-201819 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: git checkout 7ea3e110f2f8ba23f330c2f702f556acd539bcb8 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): net/wireless/nl80211.c: In function 'nl80211_get_station': >> net/wireless/nl80211.c:4802:34: error: incompatible type for argument 1 of >> 'cfg80211_sinfo_release_content' cfg80211_sinfo_release_content(sinfo); ^ In file included from net/wireless/nl80211.c:24:0: include/net/cfg80211.h:5721:20: note: expected 'struct station_info *' but argument is of type 'struct station_info' static inline void cfg80211_sinfo_release_content(struct station_info *sinfo) ^~ vim +/cfg80211_sinfo_release_content +4802 net/wireless/nl80211.c 4776 4777 static int nl80211_get_station(struct sk_buff *skb, struct genl_info *info) 4778 { 4779 struct cfg80211_registered_device *rdev = info->user_ptr[0]; 4780 struct net_device *dev = info->user_ptr[1]; 4781 struct station_info sinfo; 4782 struct sk_buff *msg; 4783 u8 *mac_addr = NULL; 4784 int err; 4785 4786 memset(, 0, sizeof(sinfo)); 4787 4788 if (!info->attrs[NL80211_ATTR_MAC]) 4789 return -EINVAL; 4790 4791 mac_addr = nla_data(info->attrs[NL80211_ATTR_MAC]); 4792 4793 if (!rdev->ops->get_station) 4794 return -EOPNOTSUPP; 4795 4796 err = rdev_get_station(rdev, dev, mac_addr, ); 4797 if (err) 4798 return err; 4799 4800 msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); 4801 if (!msg) { > 4802 cfg80211_sinfo_release_content(sinfo); 4803 return -ENOMEM; 4804 } 4805 4806 if (nl80211_send_station(msg, NL80211_CMD_NEW_STATION, 4807 info->snd_portid, info->snd_seq, 0, 4808 rdev, dev, mac_addr, ) < 0) { 4809 nlmsg_free(msg); 4810 return -ENOBUFS; 4811 } 4812 4813 return genlmsg_reply(msg, info); 4814 } 4815 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] NFC: pn533: don't send USB data off of the stack
Hi Greg, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc5 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Greg-KH/NFC-pn533-don-t-send-USB-data-off-of-the-stack/20180518-100416 config: i386-randconfig-x013-201819 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/nfc/pn533/usb.c: In function 'pn533_usb_send_ack': >> drivers/nfc/pn533/usb.c:163:15: error: invalid operands to binary | (have >> 'struct urb *' and 'int') phy->out_urb |= URB_FREE_BUFFER; ^~ drivers/nfc/pn533/usb.c: In function 'pn533_usb_send_frame': drivers/nfc/pn533/usb.c:180:15: error: invalid operands to binary & (have 'struct urb *' and 'int') phy->out_urb &= ~URB_FREE_BUFFER; ^~ drivers/nfc/pn533/usb.c: In function 'pn533_acr122_poweron_rdr': drivers/nfc/pn533/usb.c:406:15: error: invalid operands to binary | (have 'struct urb *' and 'int') phy->out_urb |= URB_FREE_BUFFER; ^~ vim +163 drivers/nfc/pn533/usb.c 147 148 static int pn533_usb_send_ack(struct pn533 *dev, gfp_t flags) 149 { 150 struct pn533_usb_phy *phy = dev->phy; 151 static const u8 ack[6] = {0x00, 0x00, 0xff, 0x00, 0xff, 0x00}; 152 /* spec 7.1.1.3: Preamble, SoPC (2), ACK Code (2), Postamble */ 153 char *buffer; 154 int rc; 155 156 buffer = kmalloc(sizeof(ack), GFP_KERNEL); 157 if (!buffer) 158 return -ENOMEM; 159 memcpy(buffer, ack, sizeof(ack)); 160 161 phy->out_urb->transfer_buffer = (u8 *)ack; 162 phy->out_urb->transfer_buffer_length = sizeof(ack); > 163 phy->out_urb |= URB_FREE_BUFFER; 164 rc = usb_submit_urb(phy->out_urb, flags); 165 166 return rc; 167 } 168 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 4/8] mwifiex: support sysfs initiated device coredump
Hi Arend, I love your patch! Yet something to improve: [auto build test ERROR on next-20180515] [cannot apply to wireless-drivers-next/master wireless-drivers/master bluetooth-next/master v4.17-rc5 v4.17-rc4 v4.17-rc3 v4.17-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arend-van-Spriel/brcmfmac-coredump-functionality-and-fixes/20180515-233022 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o see include/linux/module.h for more information >> ERROR: "mwifiex_send_cmd" >> [drivers/net/wireless/marvell/mwifiex/mwifiex_usb.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 3/3] net: Dynamically allocate struct station_info
Hi Toke, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.17-rc4 next-20180509] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/wireless-drivers-Dynamically-allocate-struct-station_info/20180510-034416 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-randconfig-x0-05100327 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): net//batman-adv/bat_v_elp.c: In function 'batadv_v_elp_get_throughput': >> net//batman-adv/bat_v_elp.c:113:21: error: request for member >> 'expected_throughput' in something not a structure or union throughput = sinfo.expected_throughput / 100; ^ >> net//batman-adv/bat_v_elp.c:114:20: error: request for member 'filled' in >> something not a structure or union filled = !!(sinfo.filled & BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT)); ^ vim +/expected_throughput +113 net//batman-adv/bat_v_elp.c 69 70 /** 71 * batadv_v_elp_get_throughput() - get the throughput towards a neighbour 72 * @neigh: the neighbour for which the throughput has to be obtained 73 * 74 * Return: The throughput towards the given neighbour in multiples of 100kpbs 75 * (a value of '1' equals to 0.1Mbps, '10' equals 1Mbps, etc). 76 */ 77 static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh) 78 { 79 struct batadv_hard_iface *hard_iface = neigh->if_incoming; 80 struct ethtool_link_ksettings link_settings; 81 struct net_device *real_netdev; 82 struct station_info *sinfo; 83 u32 throughput; 84 bool filled; 85 int ret; 86 87 /* if the user specified a customised value for this interface, then 88 * return it directly 89 */ 90 throughput = atomic_read(_iface->bat_v.throughput_override); 91 if (throughput != 0) 92 return throughput; 93 94 /* if this is a wireless device, then ask its throughput through 95 * cfg80211 API 96 */ 97 if (batadv_is_wifi_hardif(hard_iface)) { 98 if (!batadv_is_cfg80211_hardif(hard_iface)) 99 /* unsupported WiFi driver version */ 100 goto default_throughput; 101 102 real_netdev = batadv_get_real_netdev(hard_iface->net_dev); 103 if (!real_netdev) 104 goto default_throughput; 105 106 sinfo = kzalloc(sizeof(*sinfo), GFP_KERNEL); 107 if (!sinfo) 108 goto default_throughput; 109 110 ret = cfg80211_get_station(real_netdev, neigh->addr, sinfo); 111 112 /* just save these here instead of having complex free logic below */ > 113 throughput = sinfo.expected_throughput / 100; > 114 filled = !!(sinfo.filled & > BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT)); 115 116 kfree(sinfo); 117 118 dev_put(real_netdev); 119 if (ret == -ENOENT) { 120 /* Node is not associated anymore! It would be 121 * possible to delete this neighbor. For now set 122 * the throughput metric to 0. 123 */ 124 return 0; 125 } 126 if (ret || !filled) 127 goto default_throughput; 128 129 return throughput; 130 } 131 132 /* if not a wifi interface, check if this device provides data via 133 * ethtool (e.g. an Ethernet adapter) 134 */ 135 memset(_settings, 0, sizeof(link_settings)); 136 rtnl_lock(); 137 ret = __ethtool_get_link_ksettings(hard_iface->net_dev, _settings); 138 rtnl_unlock(); 139 if (ret == 0) { 140 /* link characteristics might change over time */ 141 if (link_settings.base.duplex == DUPLEX_FULL) 142 hard_iface->bat_v.flags |= BATADV_FULL_DUPLEX; 143 else 144 hard_iface->bat_v.flags &= ~BATADV_FULL_DUPLEX; 145 146 throughput = link_settings.base.speed; 147
Re: [PATCH 3/3] net: Dynamically allocate struct station_info
Hi Toke, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.17-rc4 next-20180509] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/wireless-drivers-Dynamically-allocate-struct-station_info/20180510-034416 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-randconfig-x000-201818 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): net/batman-adv/bat_v_elp.c: In function 'batadv_v_elp_get_throughput': >> net/batman-adv/bat_v_elp.c:113:21: error: 'sinfo' is a pointer; did you mean >> to use '->'? throughput = sinfo.expected_throughput / 100; ^ -> net/batman-adv/bat_v_elp.c:114:20: error: 'sinfo' is a pointer; did you mean to use '->'? filled = !!(sinfo.filled & BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT)); ^ -> vim +113 net/batman-adv/bat_v_elp.c 69 70 /** 71 * batadv_v_elp_get_throughput() - get the throughput towards a neighbour 72 * @neigh: the neighbour for which the throughput has to be obtained 73 * 74 * Return: The throughput towards the given neighbour in multiples of 100kpbs 75 * (a value of '1' equals to 0.1Mbps, '10' equals 1Mbps, etc). 76 */ 77 static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh) 78 { 79 struct batadv_hard_iface *hard_iface = neigh->if_incoming; 80 struct ethtool_link_ksettings link_settings; 81 struct net_device *real_netdev; 82 struct station_info *sinfo; 83 u32 throughput; 84 bool filled; 85 int ret; 86 87 /* if the user specified a customised value for this interface, then 88 * return it directly 89 */ 90 throughput = atomic_read(_iface->bat_v.throughput_override); 91 if (throughput != 0) 92 return throughput; 93 94 /* if this is a wireless device, then ask its throughput through 95 * cfg80211 API 96 */ 97 if (batadv_is_wifi_hardif(hard_iface)) { 98 if (!batadv_is_cfg80211_hardif(hard_iface)) 99 /* unsupported WiFi driver version */ 100 goto default_throughput; 101 102 real_netdev = batadv_get_real_netdev(hard_iface->net_dev); 103 if (!real_netdev) 104 goto default_throughput; 105 106 sinfo = kzalloc(sizeof(*sinfo), GFP_KERNEL); 107 if (!sinfo) 108 goto default_throughput; 109 110 ret = cfg80211_get_station(real_netdev, neigh->addr, sinfo); 111 112 /* just save these here instead of having complex free logic below */ > 113 throughput = sinfo.expected_throughput / 100; 114 filled = !!(sinfo.filled & BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT)); 115 116 kfree(sinfo); 117 118 dev_put(real_netdev); 119 if (ret == -ENOENT) { 120 /* Node is not associated anymore! It would be 121 * possible to delete this neighbor. For now set 122 * the throughput metric to 0. 123 */ 124 return 0; 125 } 126 if (ret || !filled) 127 goto default_throughput; 128 129 return throughput; 130 } 131 132 /* if not a wifi interface, check if this device provides data via 133 * ethtool (e.g. an Ethernet adapter) 134 */ 135 memset(_settings, 0, sizeof(link_settings)); 136 rtnl_lock(); 137 ret = __ethtool_get_link_ksettings(hard_iface->net_dev, _settings); 138 rtnl_unlock(); 139 if (ret == 0) { 140 /* link characteristics might change over time */ 141 if (link_settings.base.duplex == DUPLEX_FULL) 142 hard_iface->bat_v.flags |= BATADV_FULL_DUPLEX; 143 else 144 hard_iface->bat_v.flags &= ~BATADV_FULL_DUPLEX; 145 146 throughput = link_settings.base.speed; 147 if (throughput &&
[mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 57c6cb81717f957fb741f2e4c79bd0e2f4f55910 commit: 52539ca89f365d3db530535fbffa88a3cca4d2ec [12/14] cfg80211: Expose TXQ stats and parameters to userspace config: i386-randconfig-i1-201818 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: git checkout 52539ca89f365d3db530535fbffa88a3cca4d2ec # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/net//wireless/ath/wil6210/debugfs.c: In function 'wil_link_debugfs_show': >> drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size >> of 1600 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ -- drivers/net//wireless/ath/wil6210/wmi.c: In function 'wmi_evt_connect': >> drivers/net//wireless/ath/wil6210/wmi.c:979:1: warning: the frame size of >> 1684 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ -- drivers/net//wireless/quantenna/qtnfmac/event.c: In function 'qtnf_event_handle_sta_assoc': >> drivers/net//wireless/quantenna/qtnfmac/event.c:107:1: warning: the frame >> size of 1616 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ vim +1245 drivers/net//wireless/ath/wil6210/debugfs.c 9eb82d43 Vladimir Kondratiev 2014-06-16 1198 9eb82d43 Vladimir Kondratiev 2014-06-16 1199 /*-link*/ 9eb82d43 Vladimir Kondratiev 2014-06-16 1200 static int wil_link_debugfs_show(struct seq_file *s, void *data) 9eb82d43 Vladimir Kondratiev 2014-06-16 1201 { 9eb82d43 Vladimir Kondratiev 2014-06-16 1202 struct wil6210_priv *wil = s->private; 9eb82d43 Vladimir Kondratiev 2014-06-16 1203 struct station_info sinfo; 9eb82d43 Vladimir Kondratiev 2014-06-16 1204 int i, rc; 9eb82d43 Vladimir Kondratiev 2014-06-16 1205 9eb82d43 Vladimir Kondratiev 2014-06-16 1206 for (i = 0; i < ARRAY_SIZE(wil->sta); i++) { 9eb82d43 Vladimir Kondratiev 2014-06-16 1207 struct wil_sta_info *p = >sta[i]; 9eb82d43 Vladimir Kondratiev 2014-06-16 1208 char *status = "unknown"; 5bd60982 Lior David 2018-02-26 1209 struct wil6210_vif *vif; 5bd60982 Lior David 2018-02-26 1210 u8 mid; 8fe59627 Vladimir Kondratiev 2014-09-10 1211 9eb82d43 Vladimir Kondratiev 2014-06-16 1212 switch (p->status) { 9eb82d43 Vladimir Kondratiev 2014-06-16 1213 case wil_sta_unused: 9eb82d43 Vladimir Kondratiev 2014-06-16 1214 status = "unused "; 9eb82d43 Vladimir Kondratiev 2014-06-16 1215 break; 9eb82d43 Vladimir Kondratiev 2014-06-16 1216 case wil_sta_conn_pending: 9eb82d43 Vladimir Kondratiev 2014-06-16 1217 status = "pending "; 9eb82d43 Vladimir Kondratiev 2014-06-16 1218 break; 9eb82d43 Vladimir Kondratiev 2014-06-16 1219 case wil_sta_connected: 9eb82d43 Vladimir Kondratiev 2014-06-16 1220 status = "connected"; 9eb82d43 Vladimir Kondratiev 2014-06-16 1221 break; 9eb82d43 Vladimir Kondratiev 2014-06-16 1222 } 5bd60982 Lior David 2018-02-26 1223 mid = (p->status != wil_sta_unused) ? p->mid : U8_MAX; 5bd60982 Lior David 2018-02-26 1224 seq_printf(s, "[%d][MID %d] %pM %s\n", 5bd60982 Lior David 2018-02-26 1225 i, mid, p->addr, status); 9eb82d43 Vladimir Kondratiev 2014-06-16 1226 5bd60982 Lior David 2018-02-26 1227 if (p->status != wil_sta_connected) 5bd60982 Lior David 2018-02-26 1228 continue; 5bd60982 Lior David 2018-02-26 1229 5bd60982 Lior David 2018-02-26 1230 vif = (mid < wil->max_vifs) ? wil->vifs[mid] : NULL; 5bd60982 Lior David 2018-02-26 1231 if (vif) { e00243fa Lior David 2018-02-26 1232 rc = wil_cid_fill_sinfo(vif, i, ); 9eb82d43 Vladimir Kondratiev 2014-06-16 1233 if (rc) 9eb82d43 Vladimir Kondratiev 2014-06-16 1234 return rc; 9eb82d43 Vladimir Kondratiev 2014-06-16 1235 9eb82d43 Vladimir Kondratiev 2014-06-16 1236 seq_printf(s, " Tx_mcs = %d\n", sinfo.txrate.mcs); 9eb82d43 Vladimir Kondratiev 2014-06-16 1237 seq_printf(s, " Rx_mcs = %d\n", sinfo.rxrate.mcs); 9eb82d43 Vladimir Kondratiev 2014-06-16 1238 seq_printf(s, " SQ = %d\n", sinfo.signal); 5bd60982 Lior David 2018-02-26 1239 } else { 5bd60982 Lior David 2018-02-26 1240 seq_puts(s, " INVALID MID\n"); 9eb82d43 Vladimir Kondratiev 2014-06-16 1241 } 9eb82d43 Vladimir Kondratiev 2014-06-16 1242 } 9eb82d43 Vladimir Kondratiev 2014-06-16 1243 9eb82d43 Vladimir Kondratiev 2014-06-16 1244 return 0; 9eb82d43 Vladimir Kondratiev
[mac80211-next:master 12/14] htmldocs: include/net/cfg80211.h:3997: warning: Function parameter or member 'txq_limit' not described in 'wiphy'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 57c6cb81717f957fb741f2e4c79bd0e2f4f55910 commit: 52539ca89f365d3db530535fbffa88a3cca4d2ec [12/14] cfg80211: Expose TXQ stats and parameters to userspace reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) >> include/net/cfg80211.h:3997: warning: Function parameter or member >> 'txq_limit' not described in 'wiphy' >> include/net/cfg80211.h:3997: warning: Function parameter or member >> 'txq_memory_limit' not described in 'wiphy' >> include/net/cfg80211.h:3997: warning: Function parameter or member >> 'txq_quantum' not described in 'wiphy' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4269: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2282: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2282: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:955: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.rates' not
[mac80211-next:master 11/11] htmldocs: net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: cc60dbbfed8ff0bd4c530ee48e9e915333a35470 commit: cc60dbbfed8ff0bd4c530ee48e9e915333a35470 [11/11] mac80211: average ack rssi support for data frames reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:955: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083:
Re: [PATCH v3] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter
Hi Sebastian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/ath10k-fix-crash-in-recent-3-5-3-9984-firmware-due-wrong-handling-of-peer_bw_rxnss_override-parameter/20180427-234051 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/net/wireless/ath/ath10k/mac.c: In function 'ath10k_peer_assoc_h_vht': >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11A' not handled in switch [-Wswitch] switch(arg->peer_phymode) { ^~ >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11G' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11B' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11GONLY' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11NA_HT20' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11NG_HT20' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11NA_HT40' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11NG_HT40' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11AC_VHT20' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11AC_VHT40' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11AC_VHT80' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11AC_VHT20_2G' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11AC_VHT40_2G' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_11AC_VHT80_2G' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_UNKNOWN' not handled in switch [-Wswitch] >> drivers/net/wireless/ath/ath10k/mac.c:2534:3: warning: enumeration value >> 'MODE_MAX' not handled in switch [-Wswitch] vim +/MODE_11A +2534 drivers/net/wireless/ath/ath10k/mac.c 2457 2458 static void ath10k_peer_assoc_h_vht(struct ath10k *ar, 2459 struct ieee80211_vif *vif, 2460 struct ieee80211_sta *sta, 2461 struct wmi_peer_assoc_complete_arg *arg) 2462 { 2463 const struct ieee80211_sta_vht_cap *vht_cap = >vht_cap; 2464 struct ath10k_vif *arvif = (void *)vif->drv_priv; 2465 struct cfg80211_chan_def def; 2466 enum nl80211_band band; 2467 const u16 *vht_mcs_mask; 2468 u8 ampdu_factor; 2469 u8 max_nss, vht_mcs; 2470 int i; 2471 2472 if (WARN_ON(ath10k_mac_vif_chan(vif, ))) 2473 return; 2474 2475 if (!vht_cap->vht_supported) 2476 return; 2477 2478 band = def.chan->band; 2479 vht_mcs_mask = arvif->bitrate_mask.control[band].vht_mcs; 2480 2481 if (ath10k_peer_assoc_h_vht_masked(vht_mcs_mask)) 2482 return; 2483 2484 arg->peer_flags |= ar->wmi.peer_flags->vht; 2485 2486 if (def.chan->band == NL80211_BAND_2GHZ) 2487 arg->peer_flags |= ar->wmi.peer_flags->vht_2g; 2488 2489 arg->peer_vht_caps = vht_cap->cap; 2490 2491 ampdu_factor = (vht_cap->cap & 2492 IEEE80211_VHT_CAP_MAX_A_MPDU_LENGTH_EXPONENT_MASK) >> 2493 IEEE80211_VHT_CAP_MAX_A_MPDU_LENGTH_EXPONENT_SHIFT; 2494 2495 /* Workaround: Some Netgear/Linksys 11ac APs set Rx A-MPDU factor to 2496 * zero in VHT IE. Using it would result in degraded throughput. 2497 * arg->peer_max_mpdu at this point contains HT max_mpdu so keep 2498 * it if VHT max_mpdu is smaller. 2499 */ 2500 arg->peer_max_mpdu = max(arg->peer_max_mpdu, 2501
Re: [PATCH 3/3] ath10k: Support ethtool gstats2 API.
Hi Ben, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211/master] [also build test ERROR on v4.17-rc1 next-20180419] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/greearb-candelatech-com/ethtool-Support-ETHTOOL_GSTATS2-command/20180419-105301 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master config: x86_64-randconfig-ne0-04191514 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers/net/wireless/ath/ath10k/mac.c:7706:21: error: >> 'ath10k_debug_get_et_stats2' undeclared here (not in a function) .get_et_stats2 = ath10k_debug_get_et_stats2, ^~ vim +/ath10k_debug_get_et_stats2 +7706 drivers/net/wireless/ath/ath10k/mac.c 7672 7673 static const struct ieee80211_ops ath10k_ops = { 7674 .tx = ath10k_mac_op_tx, 7675 .wake_tx_queue = ath10k_mac_op_wake_tx_queue, 7676 .start = ath10k_start, 7677 .stop = ath10k_stop, 7678 .config = ath10k_config, 7679 .add_interface = ath10k_add_interface, 7680 .remove_interface = ath10k_remove_interface, 7681 .configure_filter = ath10k_configure_filter, 7682 .bss_info_changed = ath10k_bss_info_changed, 7683 .set_coverage_class = ath10k_mac_op_set_coverage_class, 7684 .hw_scan= ath10k_hw_scan, 7685 .cancel_hw_scan = ath10k_cancel_hw_scan, 7686 .set_key= ath10k_set_key, 7687 .set_default_unicast_key= ath10k_set_default_unicast_key, 7688 .sta_state = ath10k_sta_state, 7689 .conf_tx= ath10k_conf_tx, 7690 .remain_on_channel = ath10k_remain_on_channel, 7691 .cancel_remain_on_channel = ath10k_cancel_remain_on_channel, 7692 .set_rts_threshold = ath10k_set_rts_threshold, 7693 .set_frag_threshold = ath10k_mac_op_set_frag_threshold, 7694 .flush = ath10k_flush, 7695 .tx_last_beacon = ath10k_tx_last_beacon, 7696 .set_antenna= ath10k_set_antenna, 7697 .get_antenna= ath10k_get_antenna, 7698 .reconfig_complete = ath10k_reconfig_complete, 7699 .get_survey = ath10k_get_survey, 7700 .set_bitrate_mask = ath10k_mac_op_set_bitrate_mask, 7701 .sta_rc_update = ath10k_sta_rc_update, 7702 .offset_tsf = ath10k_offset_tsf, 7703 .ampdu_action = ath10k_ampdu_action, 7704 .get_et_sset_count = ath10k_debug_get_et_sset_count, 7705 .get_et_stats = ath10k_debug_get_et_stats, > 7706 .get_et_stats2 = ath10k_debug_get_et_stats2, 7707 .get_et_strings = ath10k_debug_get_et_strings, 7708 .add_chanctx= ath10k_mac_op_add_chanctx, 7709 .remove_chanctx = ath10k_mac_op_remove_chanctx, 7710 .change_chanctx = ath10k_mac_op_change_chanctx, 7711 .assign_vif_chanctx = ath10k_mac_op_assign_vif_chanctx, 7712 .unassign_vif_chanctx = ath10k_mac_op_unassign_vif_chanctx, 7713 .switch_vif_chanctx = ath10k_mac_op_switch_vif_chanctx, 7714 .sta_pre_rcu_remove = ath10k_mac_op_sta_pre_rcu_remove, 7715 .sta_statistics = ath10k_sta_statistics, 7716 7717 CFG80211_TESTMODE_CMD(ath10k_tm_cmd) 7718 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 3/3] ath10k: average ack rssi support for data frames
Hi Balaji, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180411] [cannot apply to ath6kl/ath-next v4.16 v4.16-rc7 v4.16-rc6 v4.16] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Balaji-Pothunoori/cfg80211-average-ack-rssi-support-for-data-frames/20180414-115825 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/net/wireless/ath/ath10k/htt_rx.c:236:23: sparse: expression using sizeof(void) drivers/net/wireless/ath/ath10k/htt_rx.c:389:31: sparse: expression using sizeof(void) drivers/net/wireless/ath/ath10k/htt_rx.c:402:39: sparse: expression using sizeof(void) >> drivers/net/wireless/ath/ath10k/htt_rx.c:1911:30: sparse: cast to restricted >> __le16 >> drivers/net/wireless/ath/ath10k/htt_rx.c:1911:28: sparse: incorrect type in >> assignment (different base types) @@expected restricted __le16 >> [usertype] msdu_count @@got unsignedrestricted __le16 [usertype] >> msdu_count @@ drivers/net/wireless/ath/ath10k/htt_rx.c:1911:28:expected restricted __le16 [usertype] msdu_count drivers/net/wireless/ath/ath10k/htt_rx.c:1911:28:got unsigned short [unsigned] [usertype] >> drivers/net/wireless/ath/ath10k/htt_rx.c:1925:29: sparse: restricted __le16 >> degrades to integer drivers/net/wireless/ath/ath10k/htt_rx.c:1927:64: sparse: restricted __le16 degrades to integer >> drivers/net/wireless/ath/ath10k/htt_rx.c:1926:50: sparse: incorrect type in >> assignment (different base types) @@expected unsigned char [unsigned] >> [assigned] [usertype] ack_rssi @@got igned] [usertype] ack_rssi @@ drivers/net/wireless/ath/ath10k/htt_rx.c:1926:50:expected unsigned char [unsigned] [assigned] [usertype] ack_rssi drivers/net/wireless/ath/ath10k/htt_rx.c:1926:50:got restricted __le16 drivers/net/wireless/ath/ath10k/htt_rx.c:1930:64: sparse: restricted __le16 degrades to integer drivers/net/wireless/ath/ath10k/htt_rx.c:1929:50: sparse: incorrect type in assignment (different base types) @@expected unsigned char [unsigned] [assigned] [usertype] ack_rssi @@got igned] [usertype] ack_rssi @@ drivers/net/wireless/ath/ath10k/htt_rx.c:1929:50:expected unsigned char [unsigned] [assigned] [usertype] ack_rssi drivers/net/wireless/ath/ath10k/htt_rx.c:1929:50:got restricted __le16 drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_t2h_msg_handler': drivers/net/wireless/ath/ath10k/htt_rx.c:1886:9: warning: 'msdu_count' may be used uninitialized in this function [-Wmaybe-uninitialized] __le16 msdu_count; ^~ vim +1911 drivers/net/wireless/ath/ath10k/htt_rx.c 1875 1876 static void ath10k_htt_rx_tx_compl_ind(struct ath10k *ar, 1877 struct sk_buff *skb) 1878 { 1879 struct ath10k_htt *htt = >htt; 1880 struct htt_resp *resp = (struct htt_resp *)skb->data; 1881 struct htt_tx_done tx_done = {}; 1882 int status = MS(resp->data_tx_completion.flags, HTT_DATA_TX_STATUS); 1883 __le16 msdu_id; 1884 int i; 1885 bool rssi_enabled; 1886 __le16 msdu_count; 1887 1888 switch (status) { 1889 case HTT_DATA_TX_STATUS_NO_ACK: 1890 tx_done.status = HTT_TX_COMPL_STATE_NOACK; 1891 break; 1892 case HTT_DATA_TX_STATUS_OK: 1893 tx_done.status = HTT_TX_COMPL_STATE_ACK; 1894 break; 1895 case HTT_DATA_TX_STATUS_DISCARD: 1896 case HTT_DATA_TX_STATUS_POSTPONE: 1897 case HTT_DATA_TX_STATUS_DOWNLOAD_FAIL: 1898 tx_done.status = HTT_TX_COMPL_STATE_DISCARD; 1899 break; 1900 default: 1901 ath10k_warn(ar, "unhandled tx completion status %d\n", status); 1902 tx_done.status = HTT_TX_COMPL_STATE_DISCARD; 1903 break; 1904 } 1905 1906 ath10k_dbg(ar, ATH10K_DBG_HTT, "htt tx completion num_msdus %d\n", 1907 resp->data_tx_completion.num_msdus); 1908 1909 if (resp->data_tx_completion.flags2 & HTT_TX_CMPL_FLAG_DATA_RSSI) { 1910 rssi_enabled = true; > 1911 msdu_count = > __le16_to_cpu(resp->data_tx_completion.num_msdus); 1912 } else { 1913 rssi_enabled = false; 1914 } 1915 1916 for (i = 0; i < resp->data_tx_completion.num_msdus; i++) { 1917 msdu_id = resp->data_tx_completion.msdus[i]; 1918 tx_done.msdu_id = __le16_to_cpu(msdu_id); 1919 1920 if (rssi_enabled) { 1921
Re: [PATCH 3/3] ath10k: average ack rssi support for data frames
Hi Balaji, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180411] [cannot apply to ath6kl/ath-next v4.16 v4.16-rc7 v4.16-rc6 v4.16] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Balaji-Pothunoori/cfg80211-average-ack-rssi-support-for-data-frames/20180414-115825 config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_t2h_msg_handler': >> drivers/net/wireless/ath/ath10k/htt_rx.c:1886:9: warning: 'msdu_count' may >> be used uninitialized in this function [-Wmaybe-uninitialized] __le16 msdu_count; ^~ vim +/msdu_count +1886 drivers/net/wireless/ath/ath10k/htt_rx.c 1875 1876 static void ath10k_htt_rx_tx_compl_ind(struct ath10k *ar, 1877 struct sk_buff *skb) 1878 { 1879 struct ath10k_htt *htt = >htt; 1880 struct htt_resp *resp = (struct htt_resp *)skb->data; 1881 struct htt_tx_done tx_done = {}; 1882 int status = MS(resp->data_tx_completion.flags, HTT_DATA_TX_STATUS); 1883 __le16 msdu_id; 1884 int i; 1885 bool rssi_enabled; > 1886 __le16 msdu_count; 1887 1888 switch (status) { 1889 case HTT_DATA_TX_STATUS_NO_ACK: 1890 tx_done.status = HTT_TX_COMPL_STATE_NOACK; 1891 break; 1892 case HTT_DATA_TX_STATUS_OK: 1893 tx_done.status = HTT_TX_COMPL_STATE_ACK; 1894 break; 1895 case HTT_DATA_TX_STATUS_DISCARD: 1896 case HTT_DATA_TX_STATUS_POSTPONE: 1897 case HTT_DATA_TX_STATUS_DOWNLOAD_FAIL: 1898 tx_done.status = HTT_TX_COMPL_STATE_DISCARD; 1899 break; 1900 default: 1901 ath10k_warn(ar, "unhandled tx completion status %d\n", status); 1902 tx_done.status = HTT_TX_COMPL_STATE_DISCARD; 1903 break; 1904 } 1905 1906 ath10k_dbg(ar, ATH10K_DBG_HTT, "htt tx completion num_msdus %d\n", 1907 resp->data_tx_completion.num_msdus); 1908 1909 if (resp->data_tx_completion.flags2 & HTT_TX_CMPL_FLAG_DATA_RSSI) { 1910 rssi_enabled = true; 1911 msdu_count = __le16_to_cpu(resp->data_tx_completion.num_msdus); 1912 } else { 1913 rssi_enabled = false; 1914 } 1915 1916 for (i = 0; i < resp->data_tx_completion.num_msdus; i++) { 1917 msdu_id = resp->data_tx_completion.msdus[i]; 1918 tx_done.msdu_id = __le16_to_cpu(msdu_id); 1919 1920 if (rssi_enabled) { 1921 /* Total no of MSDUs should be even, 1922 * if odd MSDUs are sent firmware fills 1923 * last msdu id with 0x 1924 */ 1925 if (msdu_count & 0x01) 1926 tx_done.ack_rssi = 1927 resp->data_tx_completion.msdus[msdu_count + i + 1]; 1928 else 1929 tx_done.ack_rssi = 1930 resp->data_tx_completion.msdus[msdu_count + i]; 1931 } 1932 /* kfifo_put: In practice firmware shouldn't fire off per-CE 1933 * interrupt and main interrupt (MSI/-X range case) for the same 1934 * HTC service so it should be safe to use kfifo_put w/o lock. 1935 * 1936 * From kfifo_put() documentation: 1937 * Note that with only one concurrent reader and one concurrent 1938 * writer, you don't need extra locking to use these macro. 1939 */ 1940 if (!kfifo_put(>txdone_fifo, tx_done)) { 1941 ath10k_warn(ar, "txdone fifo overrun, msdu_id %d status %d\n", 1942 tx_done.msdu_id, tx_done.status); 1943 ath10k_txrx_tx_unref(htt, _done); 1944 } 1945 } 1946 } 1947 --- 0-DAY kernel test infrastructureOpen Source
Re: [PATCH 2/3] mac80211: average ack rssi support for data frames
Hi Balaji, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180411] [cannot apply to ath6kl/ath-next v4.16 v4.16-rc7 v4.16-rc6 v4.16] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Balaji-Pothunoori/cfg80211-average-ack-rssi-support-for-data-frames/20180414-115825 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:955: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line:
Re: [PATCH v3 4/9] rtlwifi: btcoex: Add 8822b routine to btc interfaces
Hi Ping-Ke, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20180411] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/pkshih-realtek-com/rtlwifi-btcoex-Add-8822b-btcoex-support/20180410-194853 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=alpha Note: the linux-review/pkshih-realtek-com/rtlwifi-btcoex-Add-8822b-btcoex-support/20180410-194853 HEAD d96bfa6717e0ea33a20a978ecb6c52fab18d15d3 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_power_on_setting': >> (.text+0x27bc): undefined reference to `ex_btc8822b1ant_power_on_setting' (.text+0x27c0): undefined reference to `ex_btc8822b1ant_power_on_setting' >> (.text+0x27d8): undefined reference to `ex_btc8822b2ant_power_on_setting' (.text+0x27dc): undefined reference to `ex_btc8822b2ant_power_on_setting' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_pre_load_firmware': >> (.text+0x288c): undefined reference to `ex_btc8822b1ant_pre_load_firmware' (.text+0x2890): undefined reference to `ex_btc8822b1ant_pre_load_firmware' >> (.text+0x28a8): undefined reference to `ex_btc8822b2ant_pre_load_firmware' (.text+0x28ac): undefined reference to `ex_btc8822b2ant_pre_load_firmware' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_init_hw_config': >> (.text+0x2a0c): undefined reference to `ex_btc8822b1ant_init_hw_config' (.text+0x2a10): undefined reference to `ex_btc8822b1ant_init_hw_config' >> (.text+0x2a38): undefined reference to `ex_btc8822b2ant_init_hw_config' (.text+0x2a3c): undefined reference to `ex_btc8822b2ant_init_hw_config' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_init_hw_config_wifi_only': >> (.text+0x2ae4): undefined reference to `ex_hal8822b_wifi_only_hw_config' (.text+0x2ae8): undefined reference to `ex_hal8822b_wifi_only_hw_config' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_init_coex_dm': >> (.text+0x2c2c): undefined reference to `ex_btc8822b1ant_init_coex_dm' (.text+0x2c30): undefined reference to `ex_btc8822b1ant_init_coex_dm' >> (.text+0x2c48): undefined reference to `ex_btc8822b2ant_init_coex_dm' (.text+0x2c4c): undefined reference to `ex_btc8822b2ant_init_coex_dm' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_ips_notify': >> (.text+0x2dbc): undefined reference to `ex_btc8822b1ant_ips_notify' (.text+0x2dc0): undefined reference to `ex_btc8822b1ant_ips_notify' >> (.text+0x2dd8): undefined reference to `ex_btc8822b2ant_ips_notify' (.text+0x2ddc): undefined reference to `ex_btc8822b2ant_ips_notify' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_lps_notify': >> (.text+0x2f3c): undefined reference to `ex_btc8822b1ant_lps_notify' (.text+0x2f40): undefined reference to `ex_btc8822b1ant_lps_notify' >> (.text+0x2f58): undefined reference to `ex_btc8822b2ant_lps_notify' (.text+0x2f5c): undefined reference to `ex_btc8822b2ant_lps_notify' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_scan_notify': >> (.text+0x30bc): undefined reference to `ex_btc8822b1ant_scan_notify' (.text+0x30c0): undefined reference to `ex_btc8822b1ant_scan_notify' >> (.text+0x30d8): undefined reference to `ex_btc8822b2ant_scan_notify' (.text+0x30dc): undefined reference to `ex_btc8822b2ant_scan_notify' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_scan_notify_wifi_only': >> (.text+0x3124): undefined reference to `ex_hal8822b_wifi_only_scannotify' (.text+0x3128): undefined reference to `ex_hal8822b_wifi_only_scannotify' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_connect_notify': >> (.text+0x332c): undefined reference to `ex_btc8822b1ant_connect_notify' (.text+0x3334): undefined reference to `ex_btc8822b1ant_connect_notify' >> (.text+0x3358): undefined reference to `ex_btc8822b2ant_connect_notify' (.text+0x3360): undefined reference to `ex_btc8822b2ant_connect_notify' drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.o: In function `exhalbtc_mediastatus_notify': >> (.text+0x34bc): undefined reference to `ex_btc8822b1ant_media_status_notify'
Re: [PATCH 1/3] ieee80211: Replace bit shifts with the BIT() macro for WLAN_CAPABILITY_*.
Hi Quytelda, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mac80211-next/master] [also build test WARNING on v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Quytelda-Kahja/ieee80211-Replace-bit-shifts-with-the-BIT-macro-for-WLAN_CAPABILITY_/20180325-211645 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: i386-randconfig-s1-03251817 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from drivers/staging/rtl8723bs/include/drv_types.h:33:0, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: >> drivers/staging/rtl8723bs/include/ieee80211.h:444:0: warning: >> "WLAN_CAPABILITY_IBSS" redefined #define WLAN_CAPABILITY_IBSS (1<<1) In file included from include/net/cfg80211.h:23:0, from drivers/staging/rtl8723bs/include/osdep_service_linux.h:50, from drivers/staging/rtl8723bs/include/osdep_service.h:23, from drivers/staging/rtl8723bs/include/drv_types.h:29, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: include/linux/ieee80211.h:1593:0: note: this is the location of the previous definition #define WLAN_CAPABILITY_IBSS BIT(1) In file included from drivers/staging/rtl8723bs/include/drv_types.h:33:0, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: >> drivers/staging/rtl8723bs/include/ieee80211.h:445:0: warning: >> "WLAN_CAPABILITY_CF_POLLABLE" redefined #define WLAN_CAPABILITY_CF_POLLABLE (1<<2) In file included from include/net/cfg80211.h:23:0, from drivers/staging/rtl8723bs/include/osdep_service_linux.h:50, from drivers/staging/rtl8723bs/include/osdep_service.h:23, from drivers/staging/rtl8723bs/include/drv_types.h:29, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: include/linux/ieee80211.h:1603:0: note: this is the location of the previous definition #define WLAN_CAPABILITY_CF_POLLABLE BIT(2) In file included from drivers/staging/rtl8723bs/include/drv_types.h:33:0, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: >> drivers/staging/rtl8723bs/include/ieee80211.h:446:0: warning: >> "WLAN_CAPABILITY_CF_POLL_REQUEST" redefined #define WLAN_CAPABILITY_CF_POLL_REQUEST (1<<3) In file included from include/net/cfg80211.h:23:0, from drivers/staging/rtl8723bs/include/osdep_service_linux.h:50, from drivers/staging/rtl8723bs/include/osdep_service.h:23, from drivers/staging/rtl8723bs/include/drv_types.h:29, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: include/linux/ieee80211.h:1604:0: note: this is the location of the previous definition #define WLAN_CAPABILITY_CF_POLL_REQUEST BIT(3) In file included from drivers/staging/rtl8723bs/include/drv_types.h:33:0, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: >> drivers/staging/rtl8723bs/include/ieee80211.h:447:0: warning: >> "WLAN_CAPABILITY_PRIVACY" redefined #define WLAN_CAPABILITY_PRIVACY (1<<4) In file included from include/net/cfg80211.h:23:0, from drivers/staging/rtl8723bs/include/osdep_service_linux.h:50, from drivers/staging/rtl8723bs/include/osdep_service.h:23, from drivers/staging/rtl8723bs/include/drv_types.h:29, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: include/linux/ieee80211.h:1605:0: note: this is the location of the previous definition #define WLAN_CAPABILITY_PRIVACY BIT(4) In file included from drivers/staging/rtl8723bs/include/drv_types.h:33:0, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: >> drivers/staging/rtl8723bs/include/ieee80211.h:448:0: warning: >> "WLAN_CAPABILITY_SHORT_PREAMBLE" redefined #define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5) In file included from include/net/cfg80211.h:23:0, from drivers/staging/rtl8723bs/include/osdep_service_linux.h:50, from drivers/staging/rtl8723bs/include/osdep_service.h:23, from drivers/staging/rtl8723bs/include/drv_types.h:29, from drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:20: include/linux/ieee80211.h:1606:0: note: this is the location of the previous definition #define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5) In file included from drivers/staging/rtl8723bs/include/drv_types.h:33:0, from
Re: [PATCH] ath10k: fix kernel panic while reading tpc_stats
Hi Tamizh, Thank you for the patch! Yet something to improve: [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Tamizh-chelvam/ath10k-fix-kernel-panic-while-reading-tpc_stats/20180325-093724 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next config: i386-randconfig-h0-03251902 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net/wireless/ath/ath10k/wmi.c: In function 'ath10k_wmi_event_pdev_tpc_config': >> drivers/net/wireless/ath/ath10k/wmi.c:4465:14: error: 'struct ath10k' has no >> member named 'debug' complete(>debug.tpc_complete); ^ vim +4465 drivers/net/wireless/ath/ath10k/wmi.c 4315 4316 void ath10k_wmi_event_pdev_tpc_config(struct ath10k *ar, struct sk_buff *skb) 4317 { 4318 u32 i, j, pream_idx, num_tx_chain; 4319 u8 rate_code[WMI_TPC_RATE_MAX], rate_idx; 4320 u16 pream_table[WMI_TPC_PREAM_TABLE_MAX]; 4321 struct wmi_pdev_tpc_config_event *ev; 4322 struct ath10k_tpc_stats *tpc_stats; 4323 4324 ev = (struct wmi_pdev_tpc_config_event *)skb->data; 4325 4326 tpc_stats = kzalloc(sizeof(*tpc_stats), GFP_ATOMIC); 4327 if (!tpc_stats) 4328 goto exit; 4329 4330 /* Create the rate code table based on the chains supported */ 4331 rate_idx = 0; 4332 pream_idx = 0; 4333 4334 /* Fill CCK rate code */ 4335 for (i = 0; i < 4; i++) { 4336 rate_code[rate_idx] = 4337 ATH10K_HW_RATECODE(i, 0, WMI_RATE_PREAMBLE_CCK); 4338 rate_idx++; 4339 } 4340 pream_table[pream_idx] = rate_idx; 4341 pream_idx++; 4342 4343 /* Fill OFDM rate code */ 4344 for (i = 0; i < 8; i++) { 4345 rate_code[rate_idx] = 4346 ATH10K_HW_RATECODE(i, 0, WMI_RATE_PREAMBLE_OFDM); 4347 rate_idx++; 4348 } 4349 pream_table[pream_idx] = rate_idx; 4350 pream_idx++; 4351 4352 num_tx_chain = __le32_to_cpu(ev->num_tx_chain); 4353 4354 if (num_tx_chain > WMI_TPC_TX_N_CHAIN) { 4355 ath10k_warn(ar, "number of tx chain is %d greater than TPC configured tx chain %d\n", 4356 num_tx_chain, WMI_TPC_TX_N_CHAIN); 4357 goto exit; 4358 } 4359 4360 /* Fill HT20 rate code */ 4361 for (i = 0; i < num_tx_chain; i++) { 4362 for (j = 0; j < 8; j++) { 4363 rate_code[rate_idx] = 4364 ATH10K_HW_RATECODE(j, i, WMI_RATE_PREAMBLE_HT); 4365 rate_idx++; 4366 } 4367 } 4368 pream_table[pream_idx] = rate_idx; 4369 pream_idx++; 4370 4371 /* Fill HT40 rate code */ 4372 for (i = 0; i < num_tx_chain; i++) { 4373 for (j = 0; j < 8; j++) { 4374 rate_code[rate_idx] = 4375 ATH10K_HW_RATECODE(j, i, WMI_RATE_PREAMBLE_HT); 4376 rate_idx++; 4377 } 4378 } 4379 pream_table[pream_idx] = rate_idx; 4380 pream_idx++; 4381 4382 /* Fill VHT20 rate code */ 4383 for (i = 0; i < __le32_to_cpu(ev->num_tx_chain); i++) { 4384 for (j = 0; j < 10; j++) { 4385 rate_code[rate_idx] = 4386 ATH10K_HW_RATECODE(j, i, WMI_RATE_PREAMBLE_VHT); 4387 rate_idx++; 4388 } 4389 } 4390 pream_table[pream_idx] = rate_idx; 4391 pream_idx++; 4392 4393 /* Fill VHT40 rate code */ 4394 for (i = 0; i < num_tx_chain; i++) { 4395 for (j = 0; j < 10; j++) { 4396 rate_code[rate_idx] = 4397 ATH10K_HW_RATECODE(j, i, WMI_RATE_PREAMBLE_VHT); 4398 rate_idx++; 4399 } 4400 } 4401 pream_table[pream_idx] = rate_idx; 4402 pream_idx++; 4403 4404 /* Fill VHT80 rate code */ 4405 for (i = 0; i < num_tx_chain; i++) { 4406 for (j = 0; j < 10; j++) { 4407 rate_code[rate_idx] = 4408 ATH10K_HW_RATECODE(j, i, WMI_RATE_PREAMBLE_VHT); 4409
Re: [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure
Hi Nipun, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nipun-Gupta/dma-mapping-move-dma-configuration-to-bus-infrastructure/20180323-232307 config: score-spct6600_defconfig (attached as .config) compiler: score-elf-gcc (GCC) 4.9.4 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=score All errors (new ones prefixed by >>): init/main.o: In function `try_to_run_init_process': main.c:(.text+0x40): relocation truncated to fit: R_SCORE_24 against `run_init_process' main.c:(.text+0x78): relocation truncated to fit: R_SCORE_24 against `.L36' init/main.o: In function `.L132': main.c:(.text+0x190): relocation truncated to fit: R_SCORE_24 against `.L129' main.c:(.text+0x200): relocation truncated to fit: R_SCORE_24 against `.L132' init/main.o: In function `loglevel': main.c:(.init.text+0xa4): relocation truncated to fit: R_SCORE_24 against `get_option' init/main.o: In function `.L15': main.c:(.init.text+0x110): relocation truncated to fit: R_SCORE_24 against `strcmp' main.c:(.init.text+0x124): relocation truncated to fit: R_SCORE_24 against `parameq' main.c:(.init.text+0x14c): relocation truncated to fit: R_SCORE_24 against `printk' init/main.o: In function `.L31': main.c:(.init.text+0x160): relocation truncated to fit: R_SCORE_24 against `strcmp' init/main.o: In function `.L21': main.c:(.init.text+0x170): relocation truncated to fit: R_SCORE_24 against `.L15' init/main.o: In function `initcall_blacklist': main.c:(.init.text+0x198): additional relocation overflows omitted from the output drivers/base/platform.o: In function `platform_dma_configure': >> platform.c:(.text.platform_dma_configure+0x0): undefined reference to >> `dma_common_configure' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 2/2] drivers: remove force dma flag from buses
Hi Nipun, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nipun-Gupta/dma-mapping-move-dma-configuration-to-bus-infrastructure/20180323-232307 config: i386-randconfig-x014-201811 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers//bcma/main.c: In function 'bcma_of_fill_device': >> drivers//bcma/main.c:210:2: error: too many arguments to function >> 'of_dma_configure' of_dma_configure(>dev, node, false); ^~~~ In file included from include/linux/of_platform.h:12:0, from drivers//bcma/main.c:17: include/linux/of_device.h:110:19: note: declared here static inline int of_dma_configure(struct device *dev, struct device_node *np) ^~~~ vim +/of_dma_configure +210 drivers//bcma/main.c 198 199 static void bcma_of_fill_device(struct device *parent, 200 struct bcma_device *core) 201 { 202 struct device_node *node; 203 204 node = bcma_of_find_child_device(parent, core); 205 if (node) 206 core->dev.of_node = node; 207 208 core->irq = bcma_of_get_irq(parent, core, 0); 209 > 210 of_dma_configure(>dev, node, false); 211 } 212 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 2/2] drivers: remove force dma flag from buses
Hi Nipun, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nipun-Gupta/dma-mapping-move-dma-configuration-to-bus-infrastructure/20180323-232307 config: i386-randconfig-x013-201811 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/base/dma-mapping.c: In function 'dma_common_configure': >> drivers/base/dma-mapping.c:344:9: error: too many arguments to function >> 'of_dma_configure' ret = of_dma_configure(dev, dev->of_node, force_dma); ^~~~ In file included from drivers/base/dma-mapping.c:13:0: include/linux/of_device.h:110:19: note: declared here static inline int of_dma_configure(struct device *dev, struct device_node *np) ^~~~ -- drivers/pci/pci-driver.c: In function 'pci_dma_configure': >> drivers/pci/pci-driver.c:1544:9: error: too many arguments to function >> 'of_dma_configure' ret = of_dma_configure(dev, bridge->parent->of_node, true); ^~~~ In file included from drivers/pci/pci-driver.c:21:0: include/linux/of_device.h:110:19: note: declared here static inline int of_dma_configure(struct device *dev, struct device_node *np) ^~~~ vim +/of_dma_configure +344 drivers/base/dma-mapping.c 332 333 /* 334 * Common configuration to enable DMA API use for a device. 335 * A bus can use this function in its 'dma_configure' callback, if 336 * suitable for the bus. 337 */ 338 int dma_common_configure(struct device *dev, bool force_dma) 339 { 340 enum dev_dma_attr attr; 341 int ret = 0; 342 343 if (dev->of_node) { > 344 ret = of_dma_configure(dev, dev->of_node, force_dma); 345 } else if (has_acpi_companion(dev)) { 346 attr = acpi_get_dma_attr(to_acpi_device_node(dev->fwnode)); 347 if (attr != DEV_DMA_NOT_SUPPORTED) 348 ret = acpi_dma_configure(dev, attr); 349 } 350 351 return ret; 352 } 353 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support
Hi Ben, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ben-Caradoc-Davies/mac80211-add-ieee80211_hw-flag-for-QoS-NDP-support/20180319-170624 config: i386-randconfig-s1-201811 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> net/mac80211/debugfs.c:174:18: error: >> 'IEEE80211_HW_SUPPORTS_SUPPORTS_QOS_NDP' undeclared here (not in a function) #define FLAG(F) [IEEE80211_HW_##F] = #F ^ net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ net/mac80211/debugfs.c:174:18: error: array index in initializer not of integer type #define FLAG(F) [IEEE80211_HW_##F] = #F ^ net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ net/mac80211/debugfs.c:174:18: note: (near initialization for 'hw_flag_names') #define FLAG(F) [IEEE80211_HW_##F] = #F ^ net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ vim +/IEEE80211_HW_SUPPORTS_SUPPORTS_QOS_NDP +174 net/mac80211/debugfs.c 827b1fb4 Johannes Berg 2009-03-13 172 68920c97 Andrey Ryabinin2016-01-20 173 static const char *hw_flag_names[] = { 30686bf7 Johannes Berg 2015-06-02 @174 #define FLAG(F) [IEEE80211_HW_##F] = #F 30686bf7 Johannes Berg 2015-06-02 175 FLAG(HAS_RATE_CONTROL), 30686bf7 Johannes Berg 2015-06-02 176 FLAG(RX_INCLUDES_FCS), 30686bf7 Johannes Berg 2015-06-02 177 FLAG(HOST_BROADCAST_PS_BUFFERING), 30686bf7 Johannes Berg 2015-06-02 178 FLAG(SIGNAL_UNSPEC), 30686bf7 Johannes Berg 2015-06-02 179 FLAG(SIGNAL_DBM), 30686bf7 Johannes Berg 2015-06-02 180 FLAG(NEED_DTIM_BEFORE_ASSOC), 30686bf7 Johannes Berg 2015-06-02 181 FLAG(SPECTRUM_MGMT), 30686bf7 Johannes Berg 2015-06-02 182 FLAG(AMPDU_AGGREGATION), 30686bf7 Johannes Berg 2015-06-02 183 FLAG(SUPPORTS_PS), 30686bf7 Johannes Berg 2015-06-02 184 FLAG(PS_NULLFUNC_STACK), 30686bf7 Johannes Berg 2015-06-02 185 FLAG(SUPPORTS_DYNAMIC_PS), 30686bf7 Johannes Berg 2015-06-02 186 FLAG(MFP_CAPABLE), 30686bf7 Johannes Berg 2015-06-02 187 FLAG(WANT_MONITOR_VIF), 30686bf7 Johannes Berg 2015-06-02 188 FLAG(NO_AUTO_VIF), 30686bf7 Johannes Berg 2015-06-02 189 FLAG(SW_CRYPTO_CONTROL), 30686bf7 Johannes Berg 2015-06-02 190 FLAG(SUPPORT_FAST_XMIT), 30686bf7 Johannes Berg 2015-06-02 191 FLAG(REPORTS_TX_ACK_STATUS), 30686bf7 Johannes Berg 2015-06-02 192 FLAG(CONNECTION_MONITOR), 30686bf7 Johannes Berg 2015-06-02 193 FLAG(QUEUE_CONTROL), 30686bf7 Johannes Berg 2015-06-02 194 FLAG(SUPPORTS_PER_STA_GTK), 30686bf7 Johannes Berg 2015-06-02 195 FLAG(AP_LINK_PS), 30686bf7 Johannes Berg 2015-06-02 196 FLAG(TX_AMPDU_SETUP_IN_HW), 30686bf7 Johannes Berg 2015-06-02 197 FLAG(SUPPORTS_RC_TABLE), 30686bf7 Johannes Berg 2015-06-02 198 FLAG(P2P_DEV_ADDR_FOR_INTF), 30686bf7 Johannes Berg 2015-06-02 199 FLAG(TIMING_BEACON_ONLY), 30686bf7 Johannes Berg 2015-06-02 200 FLAG(SUPPORTS_HT_CCK_RATES), 30686bf7 Johannes Berg 2015-06-02 201 FLAG(CHANCTX_STA_CSA), 30686bf7 Johannes Berg 2015-06-02 202 FLAG(SUPPORTS_CLONED_SKBS), 30686bf7 Johannes Berg 2015-06-02 203 FLAG(SINGLE_SCAN_ON_ALL_BANDS), b98fb44f Arik Nemtsov 2015-06-10 204 FLAG(TDLS_WIDER_BW), 99e7ca44 Emmanuel Grumbach 2015-08-15 205 FLAG(SUPPORTS_AMSDU_IN_AMPDU), 35afa588 Helmut Schaa 2015-09-09 206 FLAG(BEACON_TX_STATUS), 31104891 Johannes Berg 2015-10-22 207 FLAG(NEEDS_UNIQUE_STA_ADDR), 412a6d80 Sara Sharon2015-12-08 208 FLAG(SUPPORTS_REORDERING_BUFFER), c9c5962b Johannes Berg 2016-03-31 209 FLAG(USES_RSS), 6e0456b5 Felix Fietkau 2016-03-03 210 FLAG(TX_AMSDU), 6e0456b5 Felix Fietkau 2016-03-03 211 FLAG(TX_FRAG_LIST), e8a24cd4 Rajkumar Manoharan 2016-09-14 212 FLAG(REPORTS_LOW_ACK), f3fe4e93 Sara Sharon2016-10-18 213 FLAG(SUPPORTS_TX_FRAG), e2fb1b83 Yingying Tang 2017-10-24 214 FLAG(SUPPORTS_TDLS_BUFFER_STA), b9b085d9 Ben Caradoc-Davies 2018-03-19 215 FLAG(SUPPORTS_SUPPORTS_QOS_NDP), 30686bf7 Johannes Berg 2015-06-02 216 #undef FLAG 30686bf7 Johannes Berg 2015-06-02 217 }; 30686bf7 Johannes Berg 2015-06-02 218 :: The code at line 174 was first introduced by commit :: 30686bf7f5b3c30831761e188a6e3cb33580fa48
Re: [PATCH v2] brcmfmac: Add support for getting nvram contents from EFI variables
Hi Hans, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc4] [also build test WARNING on next-20180319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/brcmfmac-Add-support-for-getting-nvram-contents-from-EFI-variables/20180319-164541 config: x86_64-randconfig-x001-201811 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:10:0, from include/linux/list.h:9, from include/linux/dmi.h:5, from drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:17: drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c: In function 'brcmf_fw_request_nvram_done': drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:545:44: error: passing argument 1 of 'brcmf_fw_nvram_from_efi' from incompatible pointer type [-Werror=incompatible-pointer-types] else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^ include/linux/compiler.h:58:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ >> drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:545:8: note: in >> expansion of macro 'if' else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^~ drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:525:12: note: expected 'size_t * {aka long unsigned int *}' but argument is of type 'struct brcmf_fw *' static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~ In file included from include/linux/kernel.h:10:0, from include/linux/list.h:9, from include/linux/dmi.h:5, from drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:17: drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:545:20: error: too many arguments to function 'brcmf_fw_nvram_from_efi' else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^ include/linux/compiler.h:58:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ >> drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:545:8: note: in >> expansion of macro 'if' else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^~ drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:525:12: note: declared here static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~ In file included from include/linux/kernel.h:10:0, from include/linux/list.h:9, from include/linux/dmi.h:5, from drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:17: drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:545:44: error: passing argument 1 of 'brcmf_fw_nvram_from_efi' from incompatible pointer type [-Werror=incompatible-pointer-types] else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^ include/linux/compiler.h:58:42: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ >> drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:545:8: note: in >> expansion of macro 'if' else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^~ drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:525:12: note: expected 'size_t * {aka long unsigned int *}' but argument is of type 'struct brcmf_fw *' static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~ In file included from include/linux/kernel.h:10:0, from include/linux/list.h:9, from include/linux/dmi.h:5, from drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:17: drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:545:20: error: too many arguments to function 'brcmf_fw_nvram_from_efi' else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^ include/linux/compiler.h:58:42: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ >> drivers/net/wireless//broadcom/brcm80211/brcmfmac/firmware.c:545:8: note: in >> expansion of macro 'if' else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^~
Re: [PATCH v2] brcmfmac: Add support for getting nvram contents from EFI variables
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [also build test ERROR on next-20180319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/brcmfmac-Add-support-for-getting-nvram-contents-from-EFI-variables/20180319-164541 config: arm-tegra_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All errors (new ones prefixed by >>): drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c: In function 'brcmf_fw_request_nvram_done': >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:545:44: error: >> passing argument 1 of 'brcmf_fw_nvram_from_efi' from incompatible pointer >> type [-Werror=incompatible-pointer-types] else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^ drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:525:12: note: expected 'size_t * {aka unsigned int *}' but argument is of type 'struct brcmf_fw *' static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:545:20: error: >> too many arguments to function 'brcmf_fw_nvram_from_efi' else if ((data = brcmf_fw_nvram_from_efi(fwctx, _len))) ^~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:525:12: note: declared here static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~ cc1: some warnings being treated as errors vim +/brcmf_fw_nvram_from_efi +545 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c 527 528 static void brcmf_fw_request_nvram_done(const struct firmware *fw, void *ctx) 529 { 530 struct brcmf_fw *fwctx = ctx; 531 bool free_bcm47xx_nvram = false; 532 bool kfree_nvram = false; 533 u32 nvram_length = 0; 534 void *nvram = NULL; 535 u8 *data = NULL; 536 size_t data_len; 537 538 brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(fwctx->dev)); 539 if (fw && fw->data) { 540 data = (u8 *)fw->data; 541 data_len = fw->size; 542 } else { 543 if ((data = bcm47xx_nvram_get_contents(_len))) 544 free_bcm47xx_nvram = true; > 545 else if ((data = brcmf_fw_nvram_from_efi(fwctx, > _len))) 546 kfree_nvram = true; 547 else if (!(fwctx->flags & BRCMF_FW_REQ_NV_OPTIONAL)) 548 goto fail; 549 } 550 551 if (data) 552 nvram = brcmf_fw_nvram_strip(data, data_len, _length, 553 fwctx->domain_nr, fwctx->bus_nr); 554 555 if (free_bcm47xx_nvram) 556 bcm47xx_nvram_release_contents(data); 557 if (kfree_nvram) 558 kfree(data); 559 560 release_firmware(fw); 561 if (!nvram && !(fwctx->flags & BRCMF_FW_REQ_NV_OPTIONAL)) 562 goto fail; 563 564 fwctx->done(fwctx->dev, 0, fwctx->code, nvram, nvram_length); 565 kfree(fwctx); 566 return; 567 568 fail: 569 brcmf_dbg(TRACE, "failed: dev=%s\n", dev_name(fwctx->dev)); 570 release_firmware(fwctx->code); 571 fwctx->done(fwctx->dev, -ENOENT, NULL, NULL, 0); 572 kfree(fwctx); 573 } 574 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support
Hi Ben, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ben-Caradoc-Davies/mac80211-add-ieee80211_hw-flag-for-QoS-NDP-support/20180319-170624 config: i386-randconfig-x013-201811 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): >> net/mac80211/debugfs.c:174:18: error: >> 'IEEE80211_HW_SUPPORTS_SUPPORTS_QOS_NDP' undeclared here (not in a >> function); did you mean 'IEEE80211_HW_SUPPORTS_QOS_NDP'? #define FLAG(F) [IEEE80211_HW_##F] = #F ^ >> net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ >> net/mac80211/debugfs.c:174:18: error: array index in initializer not of >> integer type #define FLAG(F) [IEEE80211_HW_##F] = #F ^ >> net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ net/mac80211/debugfs.c:174:18: note: (near initialization for 'hw_flag_names') #define FLAG(F) [IEEE80211_HW_##F] = #F ^ >> net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ vim +174 net/mac80211/debugfs.c 827b1fb4 Johannes Berg 2009-03-13 172 68920c97 Andrey Ryabinin2016-01-20 173 static const char *hw_flag_names[] = { 30686bf7 Johannes Berg 2015-06-02 @174 #define FLAG(F) [IEEE80211_HW_##F] = #F 30686bf7 Johannes Berg 2015-06-02 175 FLAG(HAS_RATE_CONTROL), 30686bf7 Johannes Berg 2015-06-02 176 FLAG(RX_INCLUDES_FCS), 30686bf7 Johannes Berg 2015-06-02 177 FLAG(HOST_BROADCAST_PS_BUFFERING), 30686bf7 Johannes Berg 2015-06-02 178 FLAG(SIGNAL_UNSPEC), 30686bf7 Johannes Berg 2015-06-02 179 FLAG(SIGNAL_DBM), 30686bf7 Johannes Berg 2015-06-02 180 FLAG(NEED_DTIM_BEFORE_ASSOC), 30686bf7 Johannes Berg 2015-06-02 181 FLAG(SPECTRUM_MGMT), 30686bf7 Johannes Berg 2015-06-02 182 FLAG(AMPDU_AGGREGATION), 30686bf7 Johannes Berg 2015-06-02 183 FLAG(SUPPORTS_PS), 30686bf7 Johannes Berg 2015-06-02 184 FLAG(PS_NULLFUNC_STACK), 30686bf7 Johannes Berg 2015-06-02 185 FLAG(SUPPORTS_DYNAMIC_PS), 30686bf7 Johannes Berg 2015-06-02 186 FLAG(MFP_CAPABLE), 30686bf7 Johannes Berg 2015-06-02 187 FLAG(WANT_MONITOR_VIF), 30686bf7 Johannes Berg 2015-06-02 188 FLAG(NO_AUTO_VIF), 30686bf7 Johannes Berg 2015-06-02 189 FLAG(SW_CRYPTO_CONTROL), 30686bf7 Johannes Berg 2015-06-02 190 FLAG(SUPPORT_FAST_XMIT), 30686bf7 Johannes Berg 2015-06-02 191 FLAG(REPORTS_TX_ACK_STATUS), 30686bf7 Johannes Berg 2015-06-02 192 FLAG(CONNECTION_MONITOR), 30686bf7 Johannes Berg 2015-06-02 193 FLAG(QUEUE_CONTROL), 30686bf7 Johannes Berg 2015-06-02 194 FLAG(SUPPORTS_PER_STA_GTK), 30686bf7 Johannes Berg 2015-06-02 195 FLAG(AP_LINK_PS), 30686bf7 Johannes Berg 2015-06-02 196 FLAG(TX_AMPDU_SETUP_IN_HW), 30686bf7 Johannes Berg 2015-06-02 197 FLAG(SUPPORTS_RC_TABLE), 30686bf7 Johannes Berg 2015-06-02 198 FLAG(P2P_DEV_ADDR_FOR_INTF), 30686bf7 Johannes Berg 2015-06-02 199 FLAG(TIMING_BEACON_ONLY), 30686bf7 Johannes Berg 2015-06-02 200 FLAG(SUPPORTS_HT_CCK_RATES), 30686bf7 Johannes Berg 2015-06-02 201 FLAG(CHANCTX_STA_CSA), 30686bf7 Johannes Berg 2015-06-02 202 FLAG(SUPPORTS_CLONED_SKBS), 30686bf7 Johannes Berg 2015-06-02 203 FLAG(SINGLE_SCAN_ON_ALL_BANDS), b98fb44f Arik Nemtsov 2015-06-10 204 FLAG(TDLS_WIDER_BW), 99e7ca44 Emmanuel Grumbach 2015-08-15 205 FLAG(SUPPORTS_AMSDU_IN_AMPDU), 35afa588 Helmut Schaa 2015-09-09 206 FLAG(BEACON_TX_STATUS), 31104891 Johannes Berg 2015-10-22 207 FLAG(NEEDS_UNIQUE_STA_ADDR), 412a6d80 Sara Sharon2015-12-08 208 FLAG(SUPPORTS_REORDERING_BUFFER), c9c5962b Johannes Berg 2016-03-31 209 FLAG(USES_RSS), 6e0456b5 Felix Fietkau 2016-03-03 210 FLAG(TX_AMSDU), 6e0456b5 Felix Fietkau 2016-03-03 211 FLAG(TX_FRAG_LIST), e8a24cd4 Rajkumar Manoharan 2016-09-14 212 FLAG(REPORTS_LOW_ACK), f3fe4e93 Sara Sharon2016-10-18 213 FLAG(SUPPORTS_TX_FRAG), e2fb1b83 Yingying Tang 2017-10-24 214 FLAG(SUPPORTS_TDLS_BUFFER_STA), b9b085d9 Ben Caradoc-Davies 2018-03-19 @215 FLAG(SUPPORTS_SUPPORTS_QOS_NDP), 30686bf7 Johannes Berg 2015-06-02 216 #undef FLAG 30686bf7 Johannes Berg 2015-06-02 217 }; 30686bf7 Johannes Berg 2015-06-02 218 :: The code at line 174 was first introduced by commit ::
Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support
Hi Ben, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ben-Caradoc-Davies/mac80211-add-ieee80211_hw-flag-for-QoS-NDP-support/20180319-052448 config: i386-randconfig-x013-201811 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:10:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from include/linux/debugfs.h:15, from net/mac80211/debugfs.c:11: net/mac80211/debugfs.c: In function 'hwflags_read': >> include/linux/compiler.h:339:38: error: call to '__compiletime_assert_234' >> declared with attribute error: BUILD_BUG_ON failed: >> ARRAY_SIZE(hw_flag_names) != NUM_IEEE80211_HW_FLAGS _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/compiler.h:319:4: note: in definition of macro '__compiletime_assert' prefix ## suffix();\ ^~ include/linux/compiler.h:339:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~ include/linux/build_bug.h:45:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~ include/linux/build_bug.h:69:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^~~~ >> net/mac80211/debugfs.c:234:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(ARRAY_SIZE(hw_flag_names) != NUM_IEEE80211_HW_FLAGS); ^~~~ -- In file included from include/linux/kernel.h:10:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from include/linux/debugfs.h:15, from net//mac80211/debugfs.c:11: net//mac80211/debugfs.c: In function 'hwflags_read': >> include/linux/compiler.h:339:38: error: call to '__compiletime_assert_234' >> declared with attribute error: BUILD_BUG_ON failed: >> ARRAY_SIZE(hw_flag_names) != NUM_IEEE80211_HW_FLAGS _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/compiler.h:319:4: note: in definition of macro '__compiletime_assert' prefix ## suffix();\ ^~ include/linux/compiler.h:339:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~ include/linux/build_bug.h:45:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~ include/linux/build_bug.h:69:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^~~~ net//mac80211/debugfs.c:234:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(ARRAY_SIZE(hw_flag_names) != NUM_IEEE80211_HW_FLAGS); ^~~~ vim +/__compiletime_assert_234 +339 include/linux/compiler.h 9a8ab1c3 Daniel Santos 2013-02-21 325 9a8ab1c3 Daniel Santos 2013-02-21 326 #define _compiletime_assert(condition, msg, prefix, suffix) \ 9a8ab1c3 Daniel Santos 2013-02-21 327 __compiletime_assert(condition, msg, prefix, suffix) 9a8ab1c3 Daniel Santos 2013-02-21 328 9a8ab1c3 Daniel Santos 2013-02-21 329 /** 9a8ab1c3 Daniel Santos 2013-02-21 330 * compiletime_assert - break build and emit msg if condition is false 9a8ab1c3 Daniel Santos 2013-02-21 331 * @condition: a compile-time constant condition to check 9a8ab1c3 Daniel Santos 2013-02-21 332 * @msg: a message to emit if condition is false 9a8ab1c3 Daniel Santos 2013-02-21 333 * 9a8ab1c3 Daniel Santos 2013-02-21 334 * In tradition of POSIX assert, this macro will break the build if the 9a8ab1c3 Daniel Santos 2013-02-21 335 * supplied condition is *false*, emitting the supplied error message if the 9a8ab1c3 Daniel Santos 2013-02-21 336 * compiler has support to do so. 9a8ab1c3 Daniel Santos 2013-02-21 337 */ 9a8ab1c3 Daniel Santos 2013-02-21 338 #define compiletime_assert(condition, msg) \ 9a8ab1c3 Daniel
[RFC PATCH] brcmfmac: brcmf_fw_request_is_valid() can be static
Fixes: 212cd4371451 ("brcmfmac: pass struct in brcmf_fw_get_firmwares()") Signed-off-by: Fengguang Wu--- firmware.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c index b5f9430..95004db 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c @@ -588,7 +588,7 @@ static void brcmf_fw_request_done(const struct firmware *fw, void *ctx) kfree(fwctx); } -bool brcmf_fw_request_is_valid(struct brcmf_fw_request *req) +static bool brcmf_fw_request_is_valid(struct brcmf_fw_request *req) { struct brcmf_fw_item *item; int i;
Re: [PATCH 07/12] brcmfmac: pass struct in brcmf_fw_get_firmwares()
Hi Arend, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20180309] [cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2 v4.16-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arend-van-Spriel/brcmfmac-data-structure-and-firmware-loading-rework/20180318-065559 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:591:6: sparse: >> symbol 'brcmf_fw_request_is_valid' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 04/12] brcmfmac: allocate struct brcmf_pub instance using wiphy_new()
Hi Arend, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20180309] [cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2 v4.16-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arend-van-Spriel/brcmfmac-data-structure-and-firmware-loading-rework/20180318-065559 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:5144:21: sparse: >> symbol 'brcmf_cfg80211_ops' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[RFC PATCH] brcmfmac: brcmf_cfg80211_ops can be static
Fixes: 6a5eed240a1c ("brcmfmac: allocate struct brcmf_pub instance using wiphy_new()") Signed-off-by: Fengguang Wu--- cfg80211.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index a47fe23..4133d66 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -5141,7 +5141,7 @@ static int brcmf_cfg80211_del_pmk(struct wiphy *wiphy, struct net_device *dev, return brcmf_set_pmk(ifp, NULL, 0); } -struct cfg80211_ops brcmf_cfg80211_ops = { +static struct cfg80211_ops brcmf_cfg80211_ops = { .add_virtual_intf = brcmf_cfg80211_add_iface, .del_virtual_intf = brcmf_cfg80211_del_iface, .change_virtual_intf = brcmf_cfg80211_change_iface,
Re: [PATCH 7/7] staging: wilc1000: use kmemdup to replace kmalloc/memcpy
Hi HariPrasath, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180309] [cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2 v4.16-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/hariprasath-elango-gmail-com/staging-wilc1000-Fix-code-block-alignment/20180316-104440 coccinelle warnings: (new ones prefixed by >>) >> drivers/staging/wilc1000/host_interface.c:943:2-29: alloc with no test, >> possible model on line 995 drivers/staging/wilc1000/host_interface.c:949:2-28: alloc with no test, possible model on line 995 drivers/staging/wilc1000/host_interface.c:958:2-27: alloc with no test, possible model on line 995 vim +943 drivers/staging/wilc1000/host_interface.c c5c77ba18 Johnny Kim 2015-05-11 917 e554a3055 Leo Kim2015-11-19 918 u8 wilc_connected_ssid[6] = {0}; 3ccff3322 Ajay Singh 2018-02-19 919 static s32 handle_connect(struct wilc_vif *vif, 120ae5938 Tony Cho 2015-09-21 920 struct connect_attr *pstrHostIFconnectAttr) c5c77ba18 Johnny Kim 2015-05-11 921 { 31390eec7 Leo Kim2015-10-19 922 s32 result = 0; 173508b82 Ajay Singh 2018-01-30 923 struct wid wid_list[8]; cdbdae15d Ajay Singh 2018-01-30 924 u32 wid_cnt = 0, dummyval = 0; e33ff51ef Ajay Singh 2018-01-30 925 u8 *cur_byte = NULL; 24701563e Ajay Singh 2018-02-20 926 struct join_bss_param *bss_param; 71130e812 Glen Lee 2015-12-21 927 struct host_if_drv *hif_drv = vif->hif_drv; c5c77ba18 Johnny Kim 2015-05-11 928 e554a3055 Leo Kim2015-11-19 929 if (memcmp(pstrHostIFconnectAttr->bssid, wilc_connected_ssid, ETH_ALEN) == 0) { 31390eec7 Leo Kim2015-10-19 930 result = 0; b92f9304a Chris Park 2016-02-22 931 netdev_err(vif->ndev, "Discard connect request\n"); 31390eec7 Leo Kim2015-10-19 932 return result; c5c77ba18 Johnny Kim 2015-05-11 933 } c5c77ba18 Johnny Kim 2015-05-11 934 24701563e Ajay Singh 2018-02-20 935 bss_param = pstrHostIFconnectAttr->params; 24701563e Ajay Singh 2018-02-20 936 if (!bss_param) { b92f9304a Chris Park 2016-02-22 937 netdev_err(vif->ndev, "Required BSSID not found\n"); 31390eec7 Leo Kim2015-10-19 938 result = -ENOENT; 24db713fe Leo Kim2015-09-16 939 goto ERRORHANDLER; c5c77ba18 Johnny Kim 2015-05-11 940 } c5c77ba18 Johnny Kim 2015-05-11 941 91109e113 Leo Kim2015-10-19 942 if (pstrHostIFconnectAttr->bssid) { 788f6fc08 Chaehyun Lim 2016-02-12 @943 hif_drv->usr_conn_req.bssid = kmalloc(6, GFP_KERNEL); 788f6fc08 Chaehyun Lim 2016-02-12 944 memcpy(hif_drv->usr_conn_req.bssid, pstrHostIFconnectAttr->bssid, 6); c5c77ba18 Johnny Kim 2015-05-11 945 } c5c77ba18 Johnny Kim 2015-05-11 946 74ab5e45e Leo Kim2015-10-29 947 hif_drv->usr_conn_req.ssid_len = pstrHostIFconnectAttr->ssid_len; 91109e113 Leo Kim2015-10-19 948 if (pstrHostIFconnectAttr->ssid) { 72216411b Chaehyun Lim 2016-02-12 949 hif_drv->usr_conn_req.ssid = kmalloc(pstrHostIFconnectAttr->ssid_len + 1, GFP_KERNEL); 72216411b Chaehyun Lim 2016-02-12 950 memcpy(hif_drv->usr_conn_req.ssid, 8c8360b3f Leo Kim2015-10-19 951 pstrHostIFconnectAttr->ssid, 8b3c9fa68 Leo Kim2015-10-13 952 pstrHostIFconnectAttr->ssid_len); 72216411b Chaehyun Lim 2016-02-12 953 hif_drv->usr_conn_req.ssid[pstrHostIFconnectAttr->ssid_len] = '\0'; c5c77ba18 Johnny Kim 2015-05-11 954 } c5c77ba18 Johnny Kim 2015-05-11 955 331ed0800 Leo Kim2015-10-29 956 hif_drv->usr_conn_req.ies_len = pstrHostIFconnectAttr->ies_len; 91109e113 Leo Kim2015-10-19 957 if (pstrHostIFconnectAttr->ies) { a3b2f4b91 Leo Kim2015-10-29 958 hif_drv->usr_conn_req.ies = kmalloc(pstrHostIFconnectAttr->ies_len, GFP_KERNEL); a3b2f4b91 Leo Kim2015-10-29 959 memcpy(hif_drv->usr_conn_req.ies, 8c8360b3f Leo Kim2015-10-19 960 pstrHostIFconnectAttr->ies, b59d5c5b5 Leo Kim2015-10-13 961 pstrHostIFconnectAttr->ies_len); c5c77ba18 Johnny Kim 2015-05-11 962 } c5c77ba18 Johnny Kim 2015-05-11 963 a0942c579 Chaehyun Lim 2016-02-12 964 hif_drv->usr_conn_req.security = pstrHostIFconnectAttr->security; 7d0697282 Leo Kim2015-10-29 965 hif_drv->usr_conn_req.auth_type = pstrHostIFconnectAttr->auth_type; 33bfb198f Leo Kim2015-10-29 966
Re: [v8 4/8] rsi: add coex support
Hi Prameela, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.16-rc3 next-20180223] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Amitkumar-Karwar/rsi-add-bluetooth-and-coex-support/20180226-073244 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: x86_64-randconfig-ne0-02261019 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Amitkumar-Karwar/rsi-add-bluetooth-and-coex-support/20180226-073244 HEAD 9c5222af2b3dbf5143bc1fa4dc0af78fcfa3559d builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/net/wireless/rsi/rsi_91x_main.c: In function 'rsi_read_pkt': >> drivers/net/wireless/rsi/rsi_91x_main.c:165:5: error: implicit declaration >> of function 'rsi_coex_recv_pkt' [-Werror=implicit-function-declaration] rsi_coex_recv_pkt(common, frame_desc + offset); ^ drivers/net/wireless/rsi/rsi_91x_main.c: In function 'rsi_91x_init': >> drivers/net/wireless/rsi/rsi_91x_main.c:287:7: error: implicit declaration >> of function 'rsi_coex_attach' [-Werror=implicit-function-declaration] if (rsi_coex_attach(common)) { ^~~ drivers/net/wireless/rsi/rsi_91x_main.c: In function 'rsi_91x_deinit': >> drivers/net/wireless/rsi/rsi_91x_main.c:323:3: error: implicit declaration >> of function 'rsi_coex_detach' [-Werror=implicit-function-declaration] rsi_coex_detach(common); ^~~ cc1: some warnings being treated as errors vim +/rsi_coex_recv_pkt +165 drivers/net/wireless/rsi/rsi_91x_main.c 133 134 /** 135 * rsi_read_pkt() - This function reads frames from the card. 136 * @common: Pointer to the driver private structure. 137 * @rcv_pkt_len: Received pkt length. In case of USB it is 0. 138 * 139 * Return: 0 on success, -1 on failure. 140 */ 141 int rsi_read_pkt(struct rsi_common *common, u8 *rx_pkt, s32 rcv_pkt_len) 142 { 143 u8 *frame_desc = NULL, extended_desc = 0; 144 u32 index, length = 0, queueno = 0; 145 u16 actual_length = 0, offset; 146 struct sk_buff *skb = NULL; 147 148 index = 0; 149 do { 150 frame_desc = _pkt[index]; 151 actual_length = *(u16 *)_desc[0]; 152 offset = *(u16 *)_desc[2]; 153 154 queueno = rsi_get_queueno(frame_desc, offset); 155 length = rsi_get_length(frame_desc, offset); 156 157 /* Extended descriptor is valid for WLAN queues only */ 158 if (queueno == RSI_WIFI_DATA_Q || queueno == RSI_WIFI_MGMT_Q) 159 extended_desc = rsi_get_extended_desc(frame_desc, 160offset); 161 162 switch (queueno) { 163 case RSI_COEX_Q: 164 if (common->coex_mode > 1) > 165 rsi_coex_recv_pkt(common, frame_desc + > offset); 166 else 167 rsi_mgmt_pkt_recv(common, 168(frame_desc + offset)); 169 break; 170 171 case RSI_WIFI_DATA_Q: 172 skb = rsi_prepare_skb(common, 173(frame_desc + offset), 174length, 175extended_desc); 176 if (skb == NULL) 177 goto fail; 178 179 rsi_indicate_pkt_to_os(common, skb); 180 break; 181 182 case RSI_WIFI_MGMT_Q: 183 rsi_mgmt_pkt_recv(common, (frame_desc + offset)); 184 break; 185 186 default: 187 rsi_dbg(ERR_ZONE, "%s: pkt from invalid queue: %d\n", 188 __func__, queueno); 189 goto fail; 190 } 191 192 index += actual_length; 193 rcv_pkt_len -= actual_length; 194 } while (rcv_pkt_len > 0); 195 196 return 0; 197 fail: 198 return -EINVAL; 199 } 200 EXPORT_SYMBOL_GPL(rsi_read_pkt); 201 202 /** 203 * rsi_tx_scheduler_thread() - This
Re: [v8 4/8] rsi: add coex support
Hi Prameela, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.16-rc2 next-20180223] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Amitkumar-Karwar/rsi-add-bluetooth-and-coex-support/20180226-073244 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sh Note: the linux-review/Amitkumar-Karwar/rsi-add-bluetooth-and-coex-support/20180226-073244 HEAD 9c5222af2b3dbf5143bc1fa4dc0af78fcfa3559d builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/net//wireless/rsi/rsi_91x_main.c: In function 'rsi_read_pkt': >> drivers/net//wireless/rsi/rsi_91x_main.c:165:5: error: implicit declaration >> of function 'rsi_coex_recv_pkt'; did you mean 'rsi_read_pkt'? >> [-Werror=implicit-function-declaration] rsi_coex_recv_pkt(common, frame_desc + offset); ^ rsi_read_pkt drivers/net//wireless/rsi/rsi_91x_main.c: In function 'rsi_91x_init': >> drivers/net//wireless/rsi/rsi_91x_main.c:287:7: error: implicit declaration >> of function 'rsi_coex_attach'; did you mean 'driver_attach'? >> [-Werror=implicit-function-declaration] if (rsi_coex_attach(common)) { ^~~ driver_attach drivers/net//wireless/rsi/rsi_91x_main.c: In function 'rsi_91x_deinit': >> drivers/net//wireless/rsi/rsi_91x_main.c:323:3: error: implicit declaration >> of function 'rsi_coex_detach'; did you mean 'rsi_91x_deinit'? >> [-Werror=implicit-function-declaration] rsi_coex_detach(common); ^~~ rsi_91x_deinit cc1: some warnings being treated as errors vim +165 drivers/net//wireless/rsi/rsi_91x_main.c 133 134 /** 135 * rsi_read_pkt() - This function reads frames from the card. 136 * @common: Pointer to the driver private structure. 137 * @rcv_pkt_len: Received pkt length. In case of USB it is 0. 138 * 139 * Return: 0 on success, -1 on failure. 140 */ 141 int rsi_read_pkt(struct rsi_common *common, u8 *rx_pkt, s32 rcv_pkt_len) 142 { 143 u8 *frame_desc = NULL, extended_desc = 0; 144 u32 index, length = 0, queueno = 0; 145 u16 actual_length = 0, offset; 146 struct sk_buff *skb = NULL; 147 148 index = 0; 149 do { 150 frame_desc = _pkt[index]; 151 actual_length = *(u16 *)_desc[0]; 152 offset = *(u16 *)_desc[2]; 153 154 queueno = rsi_get_queueno(frame_desc, offset); 155 length = rsi_get_length(frame_desc, offset); 156 157 /* Extended descriptor is valid for WLAN queues only */ 158 if (queueno == RSI_WIFI_DATA_Q || queueno == RSI_WIFI_MGMT_Q) 159 extended_desc = rsi_get_extended_desc(frame_desc, 160offset); 161 162 switch (queueno) { 163 case RSI_COEX_Q: 164 if (common->coex_mode > 1) > 165 rsi_coex_recv_pkt(common, frame_desc + > offset); 166 else 167 rsi_mgmt_pkt_recv(common, 168(frame_desc + offset)); 169 break; 170 171 case RSI_WIFI_DATA_Q: 172 skb = rsi_prepare_skb(common, 173(frame_desc + offset), 174length, 175extended_desc); 176 if (skb == NULL) 177 goto fail; 178 179 rsi_indicate_pkt_to_os(common, skb); 180 break; 181 182 case RSI_WIFI_MGMT_Q: 183 rsi_mgmt_pkt_recv(common, (frame_desc + offset)); 184 break; 185 186 default: 187 rsi_dbg(ERR_ZONE, "%s: pkt from invalid queue: %d\n", 188 __func__, queueno); 189 goto fail; 190 } 191 192 index += actual_length;
Re: [PATCH v11] ath10k: add LED and GPIO controlling support for various chipsets
Hi Sebastian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.16-rc2 next-20180223] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180226-064849 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sh All warnings (new ones prefixed by >>): In file included from drivers/net/wireless/ath/ath10k/core.c:29:0: >> drivers/net/wireless/ath/ath10k/core.h:815:13: warning: >> 'ath10k_unregister_gpio_chip' used but never defined static void ath10k_unregister_gpio_chip(struct ath10k *ar); ^~~ vim +/ath10k_unregister_gpio_chip +815 drivers/net/wireless/ath/ath10k/core.h 813 814 #if IS_ENABLED(CONFIG_ATH10K_LEDS) && IS_ENABLED(CONFIG_GPIOLIB) > 815 static void ath10k_unregister_gpio_chip(struct ath10k *ar); 816 #else 817 static inline int ath10k_attach_gpio(struct ath10k *ar) 818 { 819 return -ENODEV; 820 } 821 #endif 822 #if IS_ENABLED(CONFIG_ATH10K_LEDS) 823 int ath10k_attach_gpio(struct ath10k *ar); 824 #else 825 static inline void ath10k_unregister_gpio_chip(struct ath10k *ar) 826 { 827 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCHv3 3/3] mac80211: implement cqm rssi check using rx data signal
Hi Tamizh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mac80211-next/master] [also build test WARNING on next-20180223] [cannot apply to v4.16-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Tamizh-chelvam/cfg80211-mac80211-cqm-rssi-config-for-AP-mode/20180224-194110 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/crypto.h:477: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:477: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:477: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' include/linux/crypto.h:477: warning: Function parameter or member 'cra_u.compress' not described in 'crypto_alg' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.prev_bssid' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4197: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2282: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2282: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:959: warning: Function parameter or member 'rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:959: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info'
[RFC PATCH] ath10k: ath10k_register_gpio_chip() can be static
Fixes: 35b91f175b35 ("ath10k: add LED and GPIO controlling support for various chipsets") Signed-off-by: Fengguang Wu--- gpio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/gpio.c b/drivers/net/wireless/ath/ath10k/gpio.c index a760319..e9ce44b 100644 --- a/drivers/net/wireless/ath/ath10k/gpio.c +++ b/drivers/net/wireless/ath/ath10k/gpio.c @@ -81,7 +81,7 @@ static void ath10k_gpio_pin_set(struct gpio_chip *chip, unsigned offset, } /* register GPIO chip */ -int ath10k_register_gpio_chip(struct ath10k *ar) +static int ath10k_register_gpio_chip(struct ath10k *ar) { struct ath10k_gpiocontrol *gpio = ar->gpio;
Re: [PATCH v9] ath10k: add LED and GPIO controlling support for various chipsets
Hi Sebastian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.16-rc2 next-20180223] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180224-185406 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/net/wireless/ath/ath10k/gpio.c:84:5: sparse: symbol >> 'ath10k_register_gpio_chip' was not declared. Should it be Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH v8] ath10k: add LED and GPIO controlling support for various chipsets
Hi Sebastian, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.16-rc2 next-20180223] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180221-134523 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-randconfig-b0-02231423 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net//wireless/ath/ath10k/core.c: In function 'ath10k_attach_led': >> drivers/net//wireless/ath/ath10k/core.c:2331:3: error: implicit declaration >> of function 'ath10k_add_led' [-Werror=implicit-function-declaration] ath10k_add_led(ar, >gpio->wifi_led); ^ cc1: some warnings being treated as errors vim +/ath10k_add_led +2331 drivers/net//wireless/ath/ath10k/core.c 2322 2323 static void ath10k_attach_led(struct ath10k *ar) 2324 { 2325 if (!ar->gpio_attached) { 2326 ar->gpio->wifi_led.active_low = 1; 2327 ar->gpio->wifi_led.gpio = ar->hw_params.led_pin; 2328 ar->gpio->wifi_led.name = ar->gpio->label; 2329 ar->gpio->wifi_led.default_state = LEDS_GPIO_DEFSTATE_KEEP; 2330 > 2331 ath10k_add_led(ar, >gpio->wifi_led); 2332 } 2333 ath10k_reset_led_pin(ar); /* initially we need to configure the led pin to output */ 2334 } 2335 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] ath10k: debugfs support to get final TPC stats for 10.4 variants
Hi Maharaja, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on v4.16-rc2 next-20180221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/mkenna-codeaurora-org/ath10k-debugfs-support-to-get-final-TPC-stats-for-10-4-variants/20180222-110854 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/net/wireless/ath/ath10k/wmi.c:4322:6: sparse: symbol >> 'ath10k_wmi_tpc_config_get_rate_code' was not declared. Should it be >> drivers/net/wireless/ath/ath10k/wmi.c:4660:6: sparse: symbol >> 'ath10k_wmi_event_tpc_final_table' was not declared. Should it be drivers/net/wireless/ath/ath10k/wmi.c:738:10: sparse: Initializer entry defined twice drivers/net/wireless/ath/ath10k/wmi.c:744:10: also defined here Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [v7 4/8] rsi: add coex support
Hi Prameela, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Amitkumar-Karwar/rsi-add-rx-control-block-to-handle-rx-packets-in-USB/20180220-042908 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: x86_64-randconfig-u0-02200743 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Amitkumar-Karwar/rsi-add-rx-control-block-to-handle-rx-packets-in-USB/20180220-042908 HEAD 91a26c73d9fc6d09fa8f4d805af33da46ae4f00d builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): >> ERROR: "rsi_coex_detach" [drivers/net/wireless/rsi/rsi_91x.ko] undefined! >> ERROR: "rsi_coex_recv_pkt" [drivers/net/wireless/rsi/rsi_91x.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] v6 ath10k: add LED and GPIO controlling support for various chipsets
Hi Sebastian, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc2] [also build test ERROR on next-20180219] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/v6-ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180219-185214 config: x86_64-randconfig-s3-02200659 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/net//wireless/ath/ath10k/core.c: In function 'ath10k_unregister_led': >> drivers/net//wireless/ath/ath10k/core.c:2283:36: error: 'struct >> ath10k_gpiocontrol' has no member named 'cdev' led_classdev_unregister(>gpio->cdev); ^~ vim +2283 drivers/net//wireless/ath/ath10k/core.c 2278 2279 static void ath10k_unregister_led(struct ath10k *ar) 2280 { 2281 #ifdef CONFIG_GPIOLIB 2282 if (ar->gpio) > 2283 led_classdev_unregister(>gpio->cdev); 2284 #endif 2285 } 2286 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [v7 5/8] Bluetooth: btrsi: add new rsi bluetooth driver
Hi Prameela, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.16-rc2 next-20180219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Amitkumar-Karwar/rsi-add-rx-control-block-to-handle-rx-packets-in-USB/20180220-042908 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=ia64 All errors (new ones prefixed by >>): In file included from drivers/bluetooth/btrsi.c:21:0: >> include/linux/unaligned/le_byteshift.h:41:19: error: redefinition of >> 'get_unaligned_le16' static inline u16 get_unaligned_le16(const void *p) ^~ In file included from arch/ia64/include/asm/unaligned.h:5:0, from arch/ia64/include/asm/io.h:23, from arch/ia64/include/asm/smp.h:21, from include/linux/smp.h:64, from include/linux/topology.h:33, from include/linux/gfp.h:9, from include/linux/umh.h:4, from include/linux/kmod.h:22, from include/linux/module.h:13, from drivers/bluetooth/btrsi.c:17: include/linux/unaligned/le_struct.h:7:19: note: previous definition of 'get_unaligned_le16' was here static inline u16 get_unaligned_le16(const void *p) ^~ In file included from drivers/bluetooth/btrsi.c:21:0: >> include/linux/unaligned/le_byteshift.h:46:19: error: redefinition of >> 'get_unaligned_le32' static inline u32 get_unaligned_le32(const void *p) ^~ In file included from arch/ia64/include/asm/unaligned.h:5:0, from arch/ia64/include/asm/io.h:23, from arch/ia64/include/asm/smp.h:21, from include/linux/smp.h:64, from include/linux/topology.h:33, from include/linux/gfp.h:9, from include/linux/umh.h:4, from include/linux/kmod.h:22, from include/linux/module.h:13, from drivers/bluetooth/btrsi.c:17: include/linux/unaligned/le_struct.h:12:19: note: previous definition of 'get_unaligned_le32' was here static inline u32 get_unaligned_le32(const void *p) ^~ In file included from drivers/bluetooth/btrsi.c:21:0: >> include/linux/unaligned/le_byteshift.h:51:19: error: redefinition of >> 'get_unaligned_le64' static inline u64 get_unaligned_le64(const void *p) ^~ In file included from arch/ia64/include/asm/unaligned.h:5:0, from arch/ia64/include/asm/io.h:23, from arch/ia64/include/asm/smp.h:21, from include/linux/smp.h:64, from include/linux/topology.h:33, from include/linux/gfp.h:9, from include/linux/umh.h:4, from include/linux/kmod.h:22, from include/linux/module.h:13, from drivers/bluetooth/btrsi.c:17: include/linux/unaligned/le_struct.h:17:19: note: previous definition of 'get_unaligned_le64' was here static inline u64 get_unaligned_le64(const void *p) ^~ In file included from drivers/bluetooth/btrsi.c:21:0: >> include/linux/unaligned/le_byteshift.h:56:20: error: redefinition of >> 'put_unaligned_le16' static inline void put_unaligned_le16(u16 val, void *p) ^~ In file included from arch/ia64/include/asm/unaligned.h:5:0, from arch/ia64/include/asm/io.h:23, from arch/ia64/include/asm/smp.h:21, from include/linux/smp.h:64, from include/linux/topology.h:33, from include/linux/gfp.h:9, from include/linux/umh.h:4, from include/linux/kmod.h:22, from include/linux/module.h:13, from drivers/bluetooth/btrsi.c:17: include/linux/unaligned/le_struct.h:22:20: note: previous definition of 'put_unaligned_le16' was here static inline void put_unaligned_le16(u16 val, void *p) ^~ In file included from drivers/bluetooth/btrsi.c:21:0: >> include/linux/unaligned/le_byteshift.h:61:20: error: redefinition of >> 'put_unaligned_le32' static
Re: [PATCH] v3 ath10k: add LED and GPIO controlling support for various chipsets
Hi Sebastian, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc2] [also build test ERROR on next-20180219] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/v3-ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180219-115402 config: x86_64-federa-25 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/net//wireless/ath/ath10k/core.c: In function 'ath10k_register_gpio_chip': drivers/net//wireless/ath/ath10k/core.c:2208:5: warning: "LINUX_VERSION_CODE" is not defined, evaluates to 0 [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~ drivers/net//wireless/ath/ath10k/core.c:2208:27: warning: "KERNEL_VERSION" is not defined, evaluates to 0 [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~ >> drivers/net//wireless/ath/ath10k/core.c:2208:41: error: missing binary >> operator before token "(" #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^ >> drivers/net//wireless/ath/ath10k/core.c:2211:13: error: 'struct gpio_chip' >> has no member named 'dev' gpio->gchip.dev = ar->dev; ^ vim +2211 drivers/net//wireless/ath/ath10k/core.c 2196 2197 /* register GPIO chip */ 2198 static int ath10k_register_gpio_chip(struct ath10k *ar) 2199 { 2200 struct ath10k_gpiocontrol *gpio; 2201 gpio = kzalloc(sizeof(struct ath10k_gpiocontrol), GFP_KERNEL); 2202 if (!gpio) { 2203 return -1; 2204 } 2205 2206 snprintf(gpio->label, sizeof(gpio->label), "ath10k-%s", 2207 wiphy_name(ar->hw->wiphy)); > 2208 #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) 2209 gpio->gchip.parent = ar->dev; 2210 #else > 2211 gpio->gchip.dev = ar->dev; 2212 #endif 2213 gpio->gchip.base = -1; /* determine base automatically */ 2214 gpio->gchip.ngpio = ar->hw_params.gpio_count; 2215 gpio->gchip.label = gpio->label; 2216 gpio->gchip.direction_input = ath10k_gpio_pin_cfg_input; 2217 gpio->gchip.direction_output = ath10k_gpio_pin_cfg_output; 2218 gpio->gchip.get_direction = ath10k_gpio_pin_get_dir; 2219 gpio->gchip.get = ath10k_gpio_pin_get; 2220 gpio->gchip.set = ath10k_gpio_pin_set; 2221 if (gpiochip_add(>gchip)) { 2223 printk(KERN_ERR "Error while registering gpio chip\n"); 2224 return -1; 2225 } 2226 gpio->gchip.owner = NULL; 2227 ar->gpio = gpio; 2228 gpio->ar = ar; 2229 return 0; 2230 } 2231 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[mac80211:master 6/11] net/mac80211/tx.c:3581:3: error: implicit declaration of function 'sk_pacing_shift_update'; did you mean 'sk_incoming_cpu_update'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master head: 49241828e8ed0b0a3dc73466d5bc562ae90acfd6 commit: 96bd4b9e4a44c6c1da93fd3e48bd8eb1b332584a [6/11] mac80211: Adjust TSQ pacing shift config: x86_64-randconfig-x011-201807 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 96bd4b9e4a44c6c1da93fd3e48bd8eb1b332584a # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): net/mac80211/tx.c: In function '__ieee80211_subif_start_xmit': >> net/mac80211/tx.c:3581:3: error: implicit declaration of function >> 'sk_pacing_shift_update'; did you mean 'sk_incoming_cpu_update'? >> [-Werror=implicit-function-declaration] sk_pacing_shift_update(skb->sk, 8); ^~ sk_incoming_cpu_update Cyclomatic Complexity 5 include/linux/compiler.h:__read_once_size Cyclomatic Complexity 5 include/linux/compiler.h:__write_once_size Cyclomatic Complexity 2 arch/x86/include/asm/bitops.h:set_bit Cyclomatic Complexity 2 arch/x86/include/asm/bitops.h:clear_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:test_and_clear_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:constant_test_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:variable_test_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:fls64 Cyclomatic Complexity 1 include/uapi/linux/byteorder/little_endian.h:__le16_to_cpup Cyclomatic Complexity 1 include/linux/log2.h:__ilog2_u64 Cyclomatic Complexity 1 include/linux/kernel.h:reciprocal_scale Cyclomatic Complexity 1 include/linux/list.h:INIT_LIST_HEAD Cyclomatic Complexity 2 include/linux/list.h:__list_add Cyclomatic Complexity 1 include/linux/list.h:list_add Cyclomatic Complexity 1 include/linux/list.h:list_add_tail Cyclomatic Complexity 1 include/linux/list.h:__list_del Cyclomatic Complexity 2 include/linux/list.h:__list_del_entry Cyclomatic Complexity 1 include/linux/list.h:list_del_init Cyclomatic Complexity 1 include/linux/list.h:list_move Cyclomatic Complexity 1 include/linux/list.h:list_move_tail Cyclomatic Complexity 1 include/linux/list.h:list_empty Cyclomatic Complexity 1 include/asm-generic/getorder.h:__get_order Cyclomatic Complexity 3 include/linux/bitmap.h:bitmap_empty Cyclomatic Complexity 1 include/linux/err.h:ERR_PTR Cyclomatic Complexity 1 include/linux/err.h:IS_ERR Cyclomatic Complexity 3 include/linux/err.h:IS_ERR_OR_NULL Cyclomatic Complexity 1 arch/x86/include/asm/atomic.h:atomic_read Cyclomatic Complexity 1 arch/x86/include/asm/atomic64_64.h:atomic64_add_return Cyclomatic Complexity 5 arch/x86/include/asm/preempt.h:__preempt_count_add Cyclomatic Complexity 5 arch/x86/include/asm/preempt.h:__preempt_count_sub Cyclomatic Complexity 1 include/linux/bottom_half.h:__local_bh_disable_ip Cyclomatic Complexity 1 include/linux/bottom_half.h:local_bh_disable Cyclomatic Complexity 1 include/linux/bottom_half.h:local_bh_enable Cyclomatic Complexity 1 include/linux/lockdep.h:lock_is_held Cyclomatic Complexity 1 include/linux/spinlock.h:spinlock_check Cyclomatic Complexity 1 include/linux/spinlock.h:spin_lock Cyclomatic Complexity 1 include/linux/spinlock.h:spin_lock_bh Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock_bh Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock_irqrestore Cyclomatic Complexity 1 include/linux/rcupdate.h:__rcu_read_lock Cyclomatic Complexity 1 include/linux/rcupdate.h:__rcu_read_unlock Cyclomatic Complexity 1 include/linux/rcupdate.h:rcu_lock_acquire Cyclomatic Complexity 1 include/linux/rcupdate.h:rcu_lock_release Cyclomatic Complexity 1 include/linux/rcupdate.h:rcu_read_lock Cyclomatic Complexity 1 include/linux/rcupdate.h:rcu_read_unlock Cyclomatic Complexity 1 include/linux/jiffies.h:_msecs_to_jiffies Cyclomatic Complexity 3 include/linux/jiffies.h:msecs_to_jiffies Cyclomatic Complexity 1 include/linux/timekeeping.h:ktime_get_ns Cyclomatic Complexity 1 include/linux/timer.h:timer_pending Cyclomatic Complexity 1 include/linux/kasan.h:kasan_kmalloc Cyclomatic Complexity 28 include/linux/slab.h:kmalloc_index Cyclomatic Complexity 1 include/linux/slab.h:kmem_cache_alloc_trace Cyclomatic Complexity 1 include/linux/slab.h:kmalloc_order_trace Cyclomatic Complexity 68 include/linux/slab.h:kmalloc_large Cyclomatic Complexity 5 include/linux/slab.h:kmalloc Cyclomatic Complexity 5 include/linux/slab.h:kmalloc_array Cyclomatic Complexity 1 include/linux/slab.h:kcalloc Cyclomatic Complexity 1 include/linux/refcount.h:refcount_read Cyclomatic Complexity 1 arch/x86/include/asm/checksum_64.h:add32_with_carry Cyclomatic Complexity 1 arch/x86/include/asm/checksum_64.h:csum_add Cyclomatic Complexity 1 include/net/checksum.h:csum_sub
Re: [PATCH 10/13] mac80211: agg-rx: Accept ADDBA request update if timeout did not change
Hi Ilan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mac80211-next/master] [also build test WARNING on v4.16-rc2 next-20180216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/cfg80211-mac80211-patches-from-our-internal-tree-2018-02-16/20180219-114128 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> net/mac80211/agg-rx.c:309:51: sparse: dereference of noderef expression vim +309 net/mac80211/agg-rx.c 230 231 void ___ieee80211_start_rx_ba_session(struct sta_info *sta, 232u8 dialog_token, u16 timeout, 233u16 start_seq_num, u16 ba_policy, u16 tid, 234u16 buf_size, bool tx, bool auto_seq) 235 { 236 struct ieee80211_local *local = sta->sdata->local; 237 struct tid_ampdu_rx *tid_agg_rx; 238 struct ieee80211_ampdu_params params = { 239 .sta = >sta, 240 .action = IEEE80211_AMPDU_RX_START, 241 .tid = tid, 242 .amsdu = false, 243 .timeout = timeout, 244 .ssn = start_seq_num, 245 }; 246 int i, ret = -EOPNOTSUPP; 247 u16 status = WLAN_STATUS_REQUEST_DECLINED; 248 249 if (tid >= IEEE80211_FIRST_TSPEC_TSID) { 250 ht_dbg(sta->sdata, 251 "STA %pM requests BA session on unsupported tid %d\n", 252 sta->sta.addr, tid); 253 goto end; 254 } 255 256 if (!sta->sta.ht_cap.ht_supported) { 257 ht_dbg(sta->sdata, 258 "STA %pM erroneously requests BA session on tid %d w/o QoS\n", 259 sta->sta.addr, tid); 260 /* send a response anyway, it's an error case if we get here */ 261 goto end; 262 } 263 264 if (test_sta_flag(sta, WLAN_STA_BLOCK_BA)) { 265 ht_dbg(sta->sdata, 266 "Suspend in progress - Denying ADDBA request (%pM tid %d)\n", 267 sta->sta.addr, tid); 268 goto end; 269 } 270 271 /* sanity check for incoming parameters: 272 * check if configuration can support the BA policy 273 * and if buffer size does not exceeds max value */ 274 /* XXX: check own ht delayed BA capability?? */ 275 if (((ba_policy != 1) && 276 (!(sta->sta.ht_cap.cap & IEEE80211_HT_CAP_DELAY_BA))) || 277 (buf_size > IEEE80211_MAX_AMPDU_BUF)) { 278 status = WLAN_STATUS_INVALID_QOS_PARAM; 279 ht_dbg_ratelimited(sta->sdata, 280 "AddBA Req with bad params from %pM on tid %u. policy %d, buffer size %d\n", 281 sta->sta.addr, tid, ba_policy, buf_size); 282 goto end; 283 } 284 /* determine default buffer size */ 285 if (buf_size == 0) 286 buf_size = IEEE80211_MAX_AMPDU_BUF; 287 288 /* make sure the size doesn't exceed the maximum supported by the hw */ 289 if (buf_size > sta->sta.max_rx_aggregation_subframes) 290 buf_size = sta->sta.max_rx_aggregation_subframes; 291 params.buf_size = buf_size; 292 293 ht_dbg(sta->sdata, "AddBA Req buf_size=%d for %pM\n", 294 buf_size, sta->sta.addr); 295 296 /* examine state machine */ 297 lockdep_assert_held(>ampdu_mlme.mtx); 298 299 if (test_bit(tid, sta->ampdu_mlme.agg_session_valid)) { 300 if (sta->ampdu_mlme.tid_rx_token[tid] == dialog_token) { 301 ht_dbg_ratelimited(sta->sdata, 302 "updated AddBA Req from %pM on tid %u\n", 303 sta->sta.addr, tid); 304 /* We have no API to update the timeout value in the 305 * driver so reject the timeout update if the timeout 306 * changed. If if did not change, i.e., no real update, 307 * just reply with success. 308 */ > 309 if (sta->ampdu_mlme.tid_rx[tid]->timeout == > timeout)
Re: [PATCH] v4 ath10k: add LED and GPIO controlling support for various chipsets
Hi Sebastian, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc2] [also build test ERROR on next-20180216] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/v4-ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180219-113151 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/net/wireless/ath/ath10k/core.c:2209:41: sparse: not a function drivers/net/wireless/ath/ath10k/core.c:2209:24: sparse: bad constant expression type drivers/net/wireless/ath/ath10k/core.c:2212:20: sparse: no member 'dev' in struct gpio_chip drivers/net/wireless/ath/ath10k/core.c:2281:50: sparse: no member 'cdev' in struct ath10k_gpiocontrol drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_register_gpio_chip': drivers/net/wireless/ath/ath10k/core.c:2209:5: warning: "LINUX_VERSION_CODE" is not defined, evaluates to 0 [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~ drivers/net/wireless/ath/ath10k/core.c:2209:27: warning: "KERNEL_VERSION" is not defined, evaluates to 0 [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~ drivers/net/wireless/ath/ath10k/core.c:2209:41: error: missing binary operator before token "(" #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^ drivers/net/wireless/ath/ath10k/core.c:2212:13: error: 'struct gpio_chip' has no member named 'dev' gpio->gchip.dev = ar->dev; ^ drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_unregister_led': >> drivers/net/wireless/ath/ath10k/core.c:2281:36: error: 'struct >> ath10k_gpiocontrol' has no member named 'cdev' led_classdev_unregister(>gpio->cdev); ^~ vim +2281 drivers/net/wireless/ath/ath10k/core.c 2197 2198 /* register GPIO chip */ 2199 static int ath10k_register_gpio_chip(struct ath10k *ar) 2200 { 2201 struct ath10k_gpiocontrol *gpio; 2202 gpio = kzalloc(sizeof(struct ath10k_gpiocontrol), GFP_KERNEL); 2203 if (!gpio) { 2204 return -1; 2205 } 2206 2207 snprintf(gpio->label, sizeof(gpio->label), "ath10k-%s", 2208 wiphy_name(ar->hw->wiphy)); > 2209 #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) 2210 gpio->gchip.parent = ar->dev; 2211 #else 2212 gpio->gchip.dev = ar->dev; 2213 #endif 2214 gpio->gchip.base = -1; /* determine base automatically */ 2215 gpio->gchip.ngpio = ar->hw_params.gpio_count; 2216 gpio->gchip.label = gpio->label; 2217 gpio->gchip.direction_input = ath10k_gpio_pin_cfg_input; 2218 gpio->gchip.direction_output = ath10k_gpio_pin_cfg_output; 2219 gpio->gchip.get_direction = ath10k_gpio_pin_get_dir; 2220 gpio->gchip.get = ath10k_gpio_pin_get; 2221 gpio->gchip.set = ath10k_gpio_pin_set; 2223 if (gpiochip_add(>gchip)) { 2224 printk(KERN_ERR "Error while registering gpio chip\n"); 2225 return -1; 2226 } 2227 gpio->gchip.owner = NULL; 2228 ar->gpio = gpio; 2229 gpio->ar = ar; 2230 return 0; 2231 } 2232 2233 #ifdef CONFIG_LEDS_CLASS 2234 static void ath10k_led_brightness(struct led_classdev *led_cdev, 2235 enum led_brightness brightness) 2236 { 2237 struct ath10k_gpiocontrol *gpio = container_of(led_cdev, struct ath10k_gpiocontrol, cdev); 2238 struct gpio_led *led = >wifi_led; 2239 if (gpio->ar->state == ATH10K_STATE_ON) { 2240 gpio->gpio_state_pin = (brightness != LED_OFF) ^ led->active_low; 2241 ath10k_wmi_gpio_output(gpio->ar, led->gpio, gpio->gpio_state_pin); 2242 } 2243 } 2244 2245 static int ath10k_add_led(struct ath10k *ar, struct gpio_led *gpioled) 2246 { 2247 int ret; 2248 struct ath10k_gpiocontrol *gpio = ar->gpio; 2249 if (!gpio) 2250 return -1; 2251 gpio->cdev.name = gpioled->name; 2252 gpio->cdev.default_trigger = gpioled->default_trigger; 2253 gpio->cdev.brightness_set = ath10k_led_brightness; 2254 2255 ret = led_classdev_register(wiphy_dev(ar->hw->wiphy), >cdev); 2256 if (ret < 0) 2257 return ret; 2258 2259 return 0; 2260 } 2261 #endif 2262 2263 #endif 2264
Re: [PATCH] [PATCH 1/1] ath10k: add LED and GPIO controlling support for various chipsets
Hi Sebastian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.16-rc1 next-20180216] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180218-141132 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: openrisc-allyesconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All warnings (new ones prefixed by >>): drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_register_gpio_chip': >> drivers/net/wireless/ath/ath10k/core.c:2203:5: warning: "LINUX_VERSION_CODE" >> is not defined [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~ >> drivers/net/wireless/ath/ath10k/core.c:2203:27: warning: "KERNEL_VERSION" is >> not defined [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~ drivers/net/wireless/ath/ath10k/core.c:2203:41: error: missing binary operator before token "(" #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^ drivers/net/wireless/ath/ath10k/core.c:2206:13: error: 'struct gpio_chip' has no member named 'dev' gpio->gchip.dev = ar->dev; ^ vim +/LINUX_VERSION_CODE +2203 drivers/net/wireless/ath/ath10k/core.c 2191 2192 /* register GPIO chip */ 2193 static int ath10k_register_gpio_chip(struct ath10k *ar) 2194 { 2195 struct ath10k_gpiocontrol *gpio; 2196 gpio = kzalloc(sizeof(struct ath10k_gpiocontrol), GFP_KERNEL); 2197 if (!gpio) { 2198 return -1; 2199 } 2200 2201 snprintf(gpio->label, sizeof(gpio->label), "ath10k-%s", 2202 wiphy_name(ar->hw->wiphy)); > 2203 #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) 2204 gpio->gchip.parent = ar->dev; 2205 #else 2206 gpio->gchip.dev = ar->dev; 2207 #endif 2208 gpio->gchip.base = -1; /* determine base automatically */ 2209 gpio->gchip.ngpio = 32; 2210 gpio->gchip.label = gpio->label; 2211 gpio->gchip.direction_input = ath10k_gpio_pin_cfg_input; 2212 gpio->gchip.direction_output = ath10k_gpio_pin_cfg_output; 2213 gpio->gchip.get_direction = ath10k_gpio_pin_get_dir; 2214 gpio->gchip.get = ath10k_gpio_pin_get; 2215 gpio->gchip.set = ath10k_gpio_pin_set; 2216 2217 if (gpiochip_add(>gchip)) { 2218 printk(KERN_ERR "Error while registering gpio chip\n"); 2219 return -1; 2220 } 2221 gpio->gchip.owner = NULL; ar->gpio = gpio; 2223 gpio->ar = ar; 2224 return 0; 2225 } 2226 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] v2 ath10k: add LED and GPIO controlling support for various chipsets
Hi Sebastian, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc1] [also build test ERROR on next-20180216] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/v2-ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180218-134926 config: x86_64-randconfig-x012-201807 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers/net//wireless/ath/ath10k/core.c: In function 'ath10k_register_gpio_chip': >> drivers/net//wireless/ath/ath10k/core.c:2208:5: warning: >> "LINUX_VERSION_CODE" is not defined, evaluates to 0 [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~ >> drivers/net//wireless/ath/ath10k/core.c:2208:27: warning: "KERNEL_VERSION" >> is not defined, evaluates to 0 [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~ >> drivers/net//wireless/ath/ath10k/core.c:2208:41: error: missing binary >> operator before token "(" #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^ >> drivers/net//wireless/ath/ath10k/core.c:2211:13: error: 'struct gpio_chip' >> has no member named 'dev' gpio->gchip.dev = ar->dev; ^ vim +2211 drivers/net//wireless/ath/ath10k/core.c 2196 2197 /* register GPIO chip */ 2198 static int ath10k_register_gpio_chip(struct ath10k *ar) 2199 { 2200 struct ath10k_gpiocontrol *gpio; 2201 gpio = kzalloc(sizeof(struct ath10k_gpiocontrol), GFP_KERNEL); 2202 if (!gpio) { 2203 return -1; 2204 } 2205 2206 snprintf(gpio->label, sizeof(gpio->label), "ath10k-%s", 2207 wiphy_name(ar->hw->wiphy)); > 2208 #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) 2209 gpio->gchip.parent = ar->dev; 2210 #else > 2211 gpio->gchip.dev = ar->dev; 2212 #endif 2213 gpio->gchip.base = -1; /* determine base automatically */ 2214 gpio->gchip.ngpio = ar->hw_params.gpio_count; 2215 gpio->gchip.label = gpio->label; 2216 gpio->gchip.direction_input = ath10k_gpio_pin_cfg_input; 2217 gpio->gchip.direction_output = ath10k_gpio_pin_cfg_output; 2218 gpio->gchip.get_direction = ath10k_gpio_pin_get_dir; 2219 gpio->gchip.get = ath10k_gpio_pin_get; 2220 gpio->gchip.set = ath10k_gpio_pin_set; 2221 if (gpiochip_add(>gchip)) { 2223 printk(KERN_ERR "Error while registering gpio chip\n"); 2224 return -1; 2225 } 2226 gpio->gchip.owner = NULL; 2227 ar->gpio = gpio; 2228 gpio->ar = ar; 2229 return 0; 2230 } 2231 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 13/14] staging: wilc1000: rename Handle_Connect() to avoid camelCase
Hi Ajay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [cannot apply to v4.15 next-20180126] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ajay-Singh/fix-to-remove-unnecessary-parenthesis-typedef-and-avoid-camelCase/20180123-115314 New smatch warnings: drivers/staging/wilc1000/host_interface.c:937 handle_connect() error: potential null dereference 'hif_drv->usr_conn_req.ssid'. (kmalloc returns null) Old smatch warnings: drivers/staging/wilc1000/host_interface.c:514 handle_cfg_param() warn: always true condition '(cfg_param_attr->auth_timeout < 65536) => (0-u16max < 65536)' drivers/staging/wilc1000/host_interface.c:583 handle_cfg_param() warn: always true condition '(cfg_param_attr->rts_threshold < 65536) => (0-u16max < 65536)' drivers/staging/wilc1000/host_interface.c:636 handle_cfg_param() warn: always true condition '(cfg_param_attr->beacon_interval < 65536) => (0-u16max < 65536)' drivers/staging/wilc1000/host_interface.c:677 handle_cfg_param() warn: always true condition '(cfg_param_attr->site_survey_scan_time < 65536) => (0-u16max < 65536)' drivers/staging/wilc1000/host_interface.c:691 handle_cfg_param() warn: always true condition '(cfg_param_attr->active_scan_time < 65536) => (0-u16max < 65536)' drivers/staging/wilc1000/host_interface.c:705 handle_cfg_param() warn: always true condition '(cfg_param_attr->passive_scan_time < 65536) => (0-u16max < 65536)' vim +937 drivers/staging/wilc1000/host_interface.c c5c77ba1 Johnny Kim 2015-05-11 903 e554a305 Leo Kim 2015-11-19 904 u8 wilc_connected_ssid[6] = {0}; cd1931cf Ajay Singh 2018-01-22 905 static s32 handle_connect(struct wilc_vif *vif, 3891285c Ajay Singh 2018-01-22 906struct connect_attr *attr) c5c77ba1 Johnny Kim 2015-05-11 907 { 31390eec Leo Kim 2015-10-19 908 s32 result = 0; 5a99cdf9 Ajay Singh 2018-01-22 909 struct wid wid_list[8]; 7046f41b Ajay Singh 2018-01-22 910 u32 wid_cnt = 0, dummyval = 0; 44ea7461 Ajay Singh 2018-01-22 911 u8 *cur_byte = NULL; 5e18dd82 Ajay Singh 2018-01-22 912 struct join_bss_param *bss_param; 71130e81 Glen Lee 2015-12-21 913 struct host_if_drv *hif_drv = vif->hif_drv; c5c77ba1 Johnny Kim 2015-05-11 914 3891285c Ajay Singh 2018-01-22 915 if (memcmp(attr->bssid, wilc_connected_ssid, ETH_ALEN) == 0) { 31390eec Leo Kim 2015-10-19 916 result = 0; b92f9304 Chris Park 2016-02-22 917 netdev_err(vif->ndev, "Discard connect request\n"); 31390eec Leo Kim 2015-10-19 918 return result; c5c77ba1 Johnny Kim 2015-05-11 919 } c5c77ba1 Johnny Kim 2015-05-11 920 5e18dd82 Ajay Singh 2018-01-22 921 bss_param = attr->params; 5e18dd82 Ajay Singh 2018-01-22 922 if (!bss_param) { b92f9304 Chris Park 2016-02-22 923 netdev_err(vif->ndev, "Required BSSID not found\n"); 31390eec Leo Kim 2015-10-19 924 result = -ENOENT; 24db713f Leo Kim 2015-09-16 925 goto ERRORHANDLER; c5c77ba1 Johnny Kim 2015-05-11 926 } c5c77ba1 Johnny Kim 2015-05-11 927 3891285c Ajay Singh 2018-01-22 928 if (attr->bssid) { 788f6fc0 Chaehyun Lim 2016-02-12 929 hif_drv->usr_conn_req.bssid = kmalloc(6, GFP_KERNEL); 3891285c Ajay Singh 2018-01-22 930 memcpy(hif_drv->usr_conn_req.bssid, attr->bssid, 6); c5c77ba1 Johnny Kim 2015-05-11 931 } c5c77ba1 Johnny Kim 2015-05-11 932 3891285c Ajay Singh 2018-01-22 933 hif_drv->usr_conn_req.ssid_len = attr->ssid_len; 3891285c Ajay Singh 2018-01-22 934 if (attr->ssid) { 3891285c Ajay Singh 2018-01-22 935 hif_drv->usr_conn_req.ssid = kmalloc(attr->ssid_len + 1, GFP_KERNEL); 3891285c Ajay Singh 2018-01-22 936 memcpy(hif_drv->usr_conn_req.ssid, attr->ssid, attr->ssid_len); 3891285c Ajay Singh 2018-01-22 @937 hif_drv->usr_conn_req.ssid[attr->ssid_len] = '\0'; c5c77ba1 Johnny Kim 2015-05-11 938 } c5c77ba1 Johnny Kim 2015-05-11 939 3891285c Ajay Singh 2018-01-22 940 hif_drv->usr_conn_req.ies_len = attr->ies_len; 3891285c Ajay Singh 2018-01-22 941 if (attr->ies) { 3891285c Ajay Singh 2018-01-22 942 hif_drv->usr_conn_req.ies = kmalloc(attr->ies_len, GFP_KERNEL); 3891285c Ajay Singh 2018-01-22 943 memcpy(hif_drv->usr_conn_req.ies, attr->ies, attr->ies_len); c5c77ba1 Johnny Kim 2015-05-11 944 } c5c77ba1 Johnny Kim 2015-05-11 945 3891285c Ajay Singh 2018-01-22 946 hif_drv->usr_conn_req.security = attr->security; 3891285c Ajay Singh
Re: [PATCH v3] mac80211: mesh: fix wrong mesh TTL offset calculation
Hi Peter, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211-next/master] [also build test ERROR on v4.15-rc9 next-20180126] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/peter-oh-bowerswilkins-com/mac80211-mesh-fix-wrong-mesh-TTL-offset-calculation/20180128-042444 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: i386-randconfig-x070-201804 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): net//mac80211/mesh.c: In function 'mesh_fwd_csa_frame': >> net//mac80211/mesh.c:1271:40: error: decrement of member 'mesh_ttl' in >> read-only object elems->mesh_chansw_params_ie->mesh_ttl--; ^~ >> net//mac80211/mesh.c:1272:43: error: assignment of member 'mesh_flags' in >> read-only object elems->mesh_chansw_params_ie->mesh_flags &= ^~ vim +/mesh_ttl +1271 net//mac80211/mesh.c 1256 1257 static int mesh_fwd_csa_frame(struct ieee80211_sub_if_data *sdata, 1258 struct ieee80211_mgmt *mgmt, size_t len, 1259 struct ieee802_11_elems *elems) 1260 { 1261 struct ieee80211_mgmt *mgmt_fwd; 1262 struct sk_buff *skb; 1263 struct ieee80211_local *local = sdata->local; 1264 1265 skb = dev_alloc_skb(local->tx_headroom + len); 1266 if (!skb) 1267 return -ENOMEM; 1268 skb_reserve(skb, local->tx_headroom); 1269 mgmt_fwd = skb_put(skb, len); 1270 > 1271 elems->mesh_chansw_params_ie->mesh_ttl--; > 1272 elems->mesh_chansw_params_ie->mesh_flags &= 1273 ~WLAN_EID_CHAN_SWITCH_PARAM_INITIATOR; 1274 1275 memcpy(mgmt_fwd, mgmt, len); 1276 eth_broadcast_addr(mgmt_fwd->da); 1277 memcpy(mgmt_fwd->sa, sdata->vif.addr, ETH_ALEN); 1278 memcpy(mgmt_fwd->bssid, sdata->vif.addr, ETH_ALEN); 1279 1280 ieee80211_tx_skb(sdata, skb); 1281 return 0; 1282 } 1283 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[mac80211-next:master 3/5] net//wireless/wext-compat.c:1351:9: warning: function returns address of local variable
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 076dc671ee9fa374e77c3d05925dafb75b23a74c commit: c179e91512cab01e83be35a60eaeda0f170a9101 [3/5] cfg80211: wext: don't use static struct config: x86_64-randconfig-x016-01221834 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: git checkout c179e91512cab01e83be35a60eaeda0f170a9101 # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): net//wireless/wext-compat.c: In function 'cfg80211_wireless_stats': >> net//wireless/wext-compat.c:1351:9: warning: function returns address of >> local variable [-Wreturn-local-addr] return ^~~ vim +1351 net//wireless/wext-compat.c 8990646d2 Johannes Berg 2009-07-01 1289 8990646d2 Johannes Berg 2009-07-01 1290 /* Get wireless statistics. Called by /proc/net/wireless and by SIOCGIWSTATS */ 04b0c5c69 Johannes Berg 2011-07-15 1291 static struct iw_statistics *cfg80211_wireless_stats(struct net_device *dev) 8990646d2 Johannes Berg 2009-07-01 1292 { 8990646d2 Johannes Berg 2009-07-01 1293struct wireless_dev *wdev = dev->ieee80211_ptr; f26cbf401 Zhao, Gang2014-04-21 1294struct cfg80211_registered_device *rdev = wiphy_to_rdev(wdev->wiphy); c179e9151 Johannes Berg 2018-01-16 1295struct iw_statistics wstats = {}; c179e9151 Johannes Berg 2018-01-16 1296struct station_info sinfo = {}; c56c5714f Johannes Berg 2009-07-10 1297u8 bssid[ETH_ALEN]; 8990646d2 Johannes Berg 2009-07-01 1298 8990646d2 Johannes Berg 2009-07-01 1299if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_STATION) 8990646d2 Johannes Berg 2009-07-01 1300return NULL; 8990646d2 Johannes Berg 2009-07-01 1301 8990646d2 Johannes Berg 2009-07-01 1302if (!rdev->ops->get_station) 8990646d2 Johannes Berg 2009-07-01 1303return NULL; 8990646d2 Johannes Berg 2009-07-01 1304 c56c5714f Johannes Berg 2009-07-10 1305/* Grab BSSID of current BSS, if any */ c56c5714f Johannes Berg 2009-07-10 1306wdev_lock(wdev); c56c5714f Johannes Berg 2009-07-10 1307if (!wdev->current_bss) { c56c5714f Johannes Berg 2009-07-10 1308wdev_unlock(wdev); 8990646d2 Johannes Berg 2009-07-01 1309return NULL; c56c5714f Johannes Berg 2009-07-10 1310} c56c5714f Johannes Berg 2009-07-10 1311memcpy(bssid, wdev->current_bss->pub.bssid, ETH_ALEN); c56c5714f Johannes Berg 2009-07-10 1312wdev_unlock(wdev); 8990646d2 Johannes Berg 2009-07-01 1313 e35e4d28b Hila Gonen2012-06-27 1314if (rdev_get_station(rdev, dev, bssid, )) 8990646d2 Johannes Berg 2009-07-01 1315return NULL; 8990646d2 Johannes Berg 2009-07-01 1316 8990646d2 Johannes Berg 2009-07-01 1317switch (rdev->wiphy.signal_type) { 8990646d2 Johannes Berg 2009-07-01 1318case CFG80211_SIGNAL_TYPE_MBM: 319090bf6 Johannes Berg 2014-11-17 1319if (sinfo.filled & BIT(NL80211_STA_INFO_SIGNAL)) { 8990646d2 Johannes Berg 2009-07-01 1320int sig = sinfo.signal; 8990646d2 Johannes Berg 2009-07-01 1321 wstats.qual.updated |= IW_QUAL_LEVEL_UPDATED; 8990646d2 Johannes Berg 2009-07-01 1322 wstats.qual.updated |= IW_QUAL_QUAL_UPDATED; 8990646d2 Johannes Berg 2009-07-01 1323 wstats.qual.updated |= IW_QUAL_DBM; 8990646d2 Johannes Berg 2009-07-01 1324 wstats.qual.level = sig; 8990646d2 Johannes Berg 2009-07-01 1325if (sig < -110) 8990646d2 Johannes Berg 2009-07-01 1326sig = -110; 8990646d2 Johannes Berg 2009-07-01 1327else if (sig > -40) 8990646d2 Johannes Berg 2009-07-01 1328sig = -40; 8990646d2 Johannes Berg 2009-07-01 1329 wstats.qual.qual = sig + 110; 8990646d2 Johannes Berg 2009-07-01 1330break; 8990646d2 Johannes Berg 2009-07-01 1331} 8990646d2 Johannes Berg 2009-07-01 1332case CFG80211_SIGNAL_TYPE_UNSPEC: 319090bf6 Johannes Berg 2014-11-17 1333if (sinfo.filled & BIT(NL80211_STA_INFO_SIGNAL)) { 8990646d2 Johannes Berg 2009-07-01 1334 wstats.qual.updated |= IW_QUAL_LEVEL_UPDATED; 8990646d2 Johannes Berg 2009-07-01 1335 wstats.qual.updated |= IW_QUAL_QUAL_UPDATED; 8990646d2 Johannes Berg 2009-07-01 1336 wstats.qual.level = sinfo.signal; 8990646d2 Johannes Berg 2009-07-01 1337 wstats.qual.qual = sinfo.signal; 8990646d2 Johannes Berg 2009-07-01 1338break; 8990646d2 Johannes Berg 2009-07-01 1339} 8990646d2 Johannes Berg 2009-07-01 1340default:
Re: [PATCH 08/11] iwlwifi: mvm: Add debugfs support for FTM initiator fields
Hi Adiel, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.15-rc1 next-20171128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/iwlwifi-updates-intended-for-v4-16-2017-11-25/20171128-205312 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: x86_64-randconfig-x011-201748 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c: In function 'iwl_dbgfs_tof_range_request_write': >> drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c:957:27: error: 'struct >> iwl_tof_range_req_cmd' has no member named 'common_calib' mvm->tof_data.range_req.common_calib = ^ >> drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c:966:27: error: 'struct >> iwl_tof_range_req_cmd' has no member named 'specific_calib' mvm->tof_data.range_req.specific_calib = ^ In file included from include/linux/byteorder/little_endian.h:5:0, from arch/x86/include/uapi/asm/byteorder.h:5, from include/asm-generic/bitops/le.h:6, from arch/x86/include/asm/bitops.h:518, from include/linux/bitops.h:38, from include/linux/kernel.h:11, from include/linux/list.h:9, from drivers/net/wireless/intel/iwlwifi/mvm/mvm.h:71, from drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c:67: drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c: In function 'iwl_dbgfs_tof_range_request_read': drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c:1055:20: error: 'struct iwl_tof_range_req_cmd' has no member named 'common_calib' le16_to_cpu(cmd->common_calib)); ^ include/uapi/linux/byteorder/little_endian.h:36:51: note: in definition of macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ >> drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c:1055:5: note: in >> expansion of macro 'le16_to_cpu' le16_to_cpu(cmd->common_calib)); ^~~ drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c:1057:20: error: 'struct iwl_tof_range_req_cmd' has no member named 'specific_calib' le16_to_cpu(cmd->specific_calib)); ^ include/uapi/linux/byteorder/little_endian.h:36:51: note: in definition of macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c:1057:5: note: in expansion of macro 'le16_to_cpu' le16_to_cpu(cmd->specific_calib)); ^~~ vim +957 drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c 860 861 static ssize_t iwl_dbgfs_tof_range_request_write(struct ieee80211_vif *vif, 862 char *buf, size_t count, 863 loff_t *ppos) 864 { 865 struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); 866 struct iwl_mvm *mvm = mvmvif->mvm; 867 u32 value; 868 int ret = 0; 869 char *data; 870 871 mutex_lock(>mutex); 872 873 data = iwl_dbgfs_is_match("request_id=", buf); 874 if (data) { 875 ret = kstrtou32(data, 10, ); 876 if (ret == 0) 877 mvm->tof_data.range_req.request_id = value; 878 goto out; 879 } 880 881 data = iwl_dbgfs_is_match("initiator=", buf); 882 if (data) { 883 ret = kstrtou32(data, 10, ); 884 if (ret == 0) 885 mvm->tof_data.range_req.initiator = value; 886 goto out; 887 } 888 889 data = iwl_dbgfs_is_match("one_sided_los_disable=", buf); 890 if (data) { 891 ret = kstrtou32(data, 10, ); 892 if (ret == 0) 893 mvm->tof_data.range_req.one_sided_los_disable = value; 894 goto out; 895 } 896 897 data = iwl_dbgfs_is_match("req_timeout=", buf); 898 if (data) { 899 ret = kstrtou32(data, 10, ); 900 if (ret == 0) 901 mvm->tof_data.range_req.req_timeout = value; 902
[PATCH] mt76: fix debugfs_simple_attr.cocci warnings
drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e") CC: Felix FietkauSigned-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! debugfs.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/net/wireless/mediatek/mt76/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/debugfs.c @@ -33,7 +33,8 @@ mt76_reg_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, "0x%08llx\n"); +DEFINE_DEBUGFS_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, +"0x%08llx\n"); static int mt76_queues_read(struct seq_file *s, void *data) @@ -65,8 +66,8 @@ struct dentry *mt76_register_debugfs(str debugfs_create_u8("led_pin", S_IRUSR | S_IWUSR, dir, >led_pin); debugfs_create_u32("regidx", S_IRUSR | S_IWUSR, dir, >debugfs_reg); - debugfs_create_file("regval", S_IRUSR | S_IWUSR, dir, dev, - _regval); + debugfs_create_file_unsafe("regval", S_IRUSR | S_IWUSR, dir, dev, + _regval); debugfs_create_blob("eeprom", S_IRUSR, dir, >eeprom); if (dev->otp.data) debugfs_create_blob("otp", S_IRUSR, dir, >otp);
Re: [PATCH v7 3/3] mt76: add driver code for MT76x2e
Hi Felix, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14 next-20171122] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/dt-bindings-net-add-mt76-wireless-device-binding/20171123-125723 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): drivers/net/wireless/mediatek/mt76/mac80211.c: In function 'mt76_led_init': >> drivers/net/wireless/mediatek/mt76/mac80211.c:111:7: error: implicit >> declaration of function 'of_get_child_by_name' >> [-Werror=implicit-function-declaration] np = of_get_child_by_name(np, "led"); ^~~~ >> drivers/net/wireless/mediatek/mt76/mac80211.c:111:5: warning: assignment >> makes pointer from integer without a cast [-Wint-conversion] np = of_get_child_by_name(np, "led"); ^ >> drivers/net/wireless/mediatek/mt76/mac80211.c:113:8: error: implicit >> declaration of function 'of_property_read_u32' >> [-Werror=implicit-function-declaration] if (!of_property_read_u32(np, "led-sources", _pin)) ^~~~ >> drivers/net/wireless/mediatek/mt76/mac80211.c:115:17: error: implicit >> declaration of function 'of_property_read_bool' >> [-Werror=implicit-function-declaration] dev->led_al = of_property_read_bool(np, "led-active-low"); ^ cc1: some warnings being treated as errors -- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function 'mt76x2_mac_process_rate': >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: >> 'RX_FLAG_SHORTPRE' undeclared (first use in this function) status->flag |= RX_FLAG_SHORTPRE; ^~~~ drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: >> 'RX_FLAG_HT_GF' undeclared (first use in this function) status->flag |= RX_FLAG_HT_GF; ^ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: 'RX_FLAG_HT' >> undeclared (first use in this function) status->flag |= RX_FLAG_HT; ^~ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: 'RX_FLAG_VHT' >> undeclared (first use in this function) status->flag |= RX_FLAG_VHT; ^~~ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: 'struct >> ieee80211_rx_status' has no member named 'vht_nss' status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1; ^~ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: 'RX_FLAG_LDPC' >> undeclared (first use in this function) status->flag |= RX_FLAG_LDPC; ^~~~ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: >> 'RX_FLAG_SHORT_GI' undeclared (first use in this function) status->flag |= RX_FLAG_SHORT_GI; ^~~~ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: >> 'RX_FLAG_STBC_SHIFT' undeclared (first use in this function) status->flag |= 1 << RX_FLAG_STBC_SHIFT; ^~ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: >> 'RX_FLAG_40MHZ' undeclared (first use in this function) status->flag |= RX_FLAG_40MHZ; ^ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: 'struct >> ieee80211_rx_status' has no member named 'vht_flag'; did you mean 'flag'? status->vht_flag |= RX_VHT_FLAG_80MHZ; ^~ >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: >> 'RX_VHT_FLAG_80MHZ' undeclared (first use in this function) status->vht_flag |= RX_VHT_FLAG_80MHZ; ^ coccinelle warnings: (new ones prefixed by >>) >> drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval >> should be defined with DEFINE_DEBUGFS_ATTRIBUTE -- >> drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: >> "ret". Return "0" on line 112 Please review and possibly fold the followup patch. vim +/RX_FLAG_SHORTPRE +49 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c 30 31 static void 32 mt76x2_mac_process_rate(struct ieee80211_rx_status *status, u16 rate) 33 { 34 u8 idx = FIELD_GET(MT_RXWI_RATE_INDEX, rate); 35 36 switch (FIELD_GET(MT_RXWI_RATE_PHY, rate)) { 37 case
[PATCH] mt76: fix returnvar.cocci warnings
drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: "ret". Return "0" on line 112 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e") CC: Felix FietkauSigned-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! mt76x2_main.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/wireless/mediatek/mt76/mt76x2_main.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_main.c @@ -83,7 +83,6 @@ mt76x2_add_interface(struct ieee80211_hw struct mt76x2_dev *dev = hw->priv; struct mt76x2_vif *mvif = (struct mt76x2_vif *) vif->drv_priv; unsigned int idx = 0; - int ret = 0; if (vif->addr[0] & BIT(1)) idx = 1 + (((dev->mt76.macaddr[0] ^ vif->addr[0]) >> 2) & 7); @@ -109,7 +108,7 @@ mt76x2_add_interface(struct ieee80211_hw mvif->group_wcid.hw_key_idx = -1; mt76x2_txq_init(dev, vif->txq); - return ret; + return 0; } static void
Re: [PATCH v7 3/3] mt76: add driver code for MT76x2e
Hi Felix, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14 next-20171122] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/dt-bindings-net-add-mt76-wireless-device-binding/20171123-125723 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=tile All errors (new ones prefixed by >>): drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function 'mt76x2_mac_process_rate': drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: 'RX_FLAG_SHORTPRE' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: 'RX_FLAG_HT_GF' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: 'RX_FLAG_HT' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: 'RX_FLAG_VHT' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: 'struct ieee80211_rx_status' has no member named 'vht_nss' drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: 'RX_FLAG_LDPC' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: 'RX_FLAG_SHORT_GI' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: 'RX_FLAG_STBC_SHIFT' undeclared (first use in this function) drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: 'RX_FLAG_40MHZ' undeclared (first use in this function) >> drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: 'struct >> ieee80211_rx_status' has no member named 'vht_flag' drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: 'RX_VHT_FLAG_80MHZ' undeclared (first use in this function) vim +90 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c 30 31 static void 32 mt76x2_mac_process_rate(struct ieee80211_rx_status *status, u16 rate) 33 { 34 u8 idx = FIELD_GET(MT_RXWI_RATE_INDEX, rate); 35 36 switch (FIELD_GET(MT_RXWI_RATE_PHY, rate)) { 37 case MT_PHY_TYPE_OFDM: 38 if (idx >= 8) 39 idx = 0; 40 41 if (status->band == NL80211_BAND_2GHZ) 42 idx += 4; 43 44 status->rate_idx = idx; 45 return; 46 case MT_PHY_TYPE_CCK: 47 if (idx >= 8) { 48 idx -= 8; > 49 status->flag |= RX_FLAG_SHORTPRE; 50 } 51 52 if (idx >= 4) 53 idx = 0; 54 55 status->rate_idx = idx; 56 return; 57 case MT_PHY_TYPE_HT_GF: 58 status->flag |= RX_FLAG_HT_GF; 59 /* fall through */ 60 case MT_PHY_TYPE_HT: 61 status->flag |= RX_FLAG_HT; 62 status->rate_idx = idx; 63 break; 64 case MT_PHY_TYPE_VHT: 65 status->flag |= RX_FLAG_VHT; 66 status->rate_idx = FIELD_GET(MT_RATE_INDEX_VHT_IDX, idx); 67 status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1; 68 break; 69 default: 70 WARN_ON(1); 71 return; 72 } 73 74 if (rate & MT_RXWI_RATE_LDPC) 75 status->flag |= RX_FLAG_LDPC; 76 77 if (rate & MT_RXWI_RATE_SGI) 78 status->flag |= RX_FLAG_SHORT_GI; 79 80 if (rate & MT_RXWI_RATE_STBC) 81 status->flag |= 1 << RX_FLAG_STBC_SHIFT; 82 83 switch (FIELD_GET(MT_RXWI_RATE_BW, rate)) { 84 case MT_PHY_BW_20: 85 break; 86 case MT_PHY_BW_40: 87 status->flag |= RX_FLAG_40MHZ; 88 break; 89 case MT_PHY_BW_80: > 90 status->vht_flag |= RX_VHT_FLAG_80MHZ; 91 break; 92 default: 93 break; 94 } 95 } 96 ---
Re: [PATCH] wcn36xx: Set BTLE coexistence related configuration values to defaults
Hi Eyal, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14 next-20171114] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ramon-Fried/wcn36xx-Set-BTLE-coexistence-related-configuration-values-to-defaults/20171114-194715 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-randconfig-x019-201746 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> drivers/net/wireless/ath/wcn36xx/main.c:30:33: error: 'WCN36XX_DBG_NONE' >> undeclared here (not in a function) unsigned int wcn36xx_dbg_mask = WCN36XX_DBG_NONE; ^~~~ vim +/WCN36XX_DBG_NONE +30 drivers/net/wireless/ath/wcn36xx/main.c 29 > 30 unsigned int wcn36xx_dbg_mask = WCN36XX_DBG_NONE; 31 module_param_named(debug_mask, wcn36xx_dbg_mask, uint, 0644); 32 MODULE_PARM_DESC(debug_mask, "Debugging mask"); 33 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 1/3] mac80211: Add TXQ scheduling API
Hi Toke, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211/master] [also build test ERROR on v4.14-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/mac80211-Add-TXQ-scheduling-API/20171030-220903 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master config: mips-ip27_defconfig (attached as .config) compiler: mips64-linux-gnuabi64-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=mips Note: the linux-review/Toke-H-iland-J-rgensen/mac80211-Add-TXQ-scheduling-API/20171030-220903 HEAD aa503ef75660b7c9cb9ede292f03047372517d4e builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): >> ERROR: "__ath_tx_queue_tid" [drivers/net/wireless/ath/ath9k/ath9k.ko] >> undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 1/3] mac80211: Add TXQ scheduling API
Hi Toke, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211/master] [also build test ERROR on v4.14-rc7 next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/mac80211-Add-TXQ-scheduling-API/20171030-220903 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master config: x86_64-allyesdebian (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Toke-H-iland-J-rgensen/mac80211-Add-TXQ-scheduling-API/20171030-220903 HEAD aa503ef75660b7c9cb9ede292f03047372517d4e builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/net/wireless/ath/ath9k/recv.o: In function `ath_rx_tasklet': >> recv.c:(.text+0x16bc): undefined reference to `__ath_tx_queue_tid' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] mwifiex: Use put_unaligned_le32
Hi Himanshu, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/mwifiex-Use-put_unaligned_le32/20171007-095017 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: openrisc-allyesconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 5.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): In file included from arch/openrisc/include/asm/unaligned.h:42:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_memmove.h:6:19: error: redefinition of >> 'get_unaligned_be16' static inline u16 get_unaligned_be16(const void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:22:28: note: previous definition of 'get_unaligned_be16' was here static __always_inline u16 get_unaligned_be16(const void *p) ^ In file included from arch/openrisc/include/asm/unaligned.h:42:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_memmove.h:11:19: error: redefinition of >> 'get_unaligned_be32' static inline u32 get_unaligned_be32(const void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:27:28: note: previous definition of 'get_unaligned_be32' was here static __always_inline u32 get_unaligned_be32(const void *p) ^ In file included from arch/openrisc/include/asm/unaligned.h:42:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_memmove.h:16:19: error: redefinition of >> 'get_unaligned_be64' static inline u64 get_unaligned_be64(const void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:32:28: note: previous definition of 'get_unaligned_be64' was here static __always_inline u64 get_unaligned_be64(const void *p) ^ In file included from arch/openrisc/include/asm/unaligned.h:42:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_memmove.h:21:20: error: redefinition of >> 'put_unaligned_be16' static inline void put_unaligned_be16(u16 val, void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:52:29: note: previous definition of 'put_unaligned_be16' was here static __always_inline void put_unaligned_be16(u16 val, void *p) ^ In file included from arch/openrisc/include/asm/unaligned.h:42:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_memmove.h:26:20: error: redefinition of >> 'put_unaligned_be32' static inline void put_unaligned_be32(u32 val, void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:57:29: note: previous definition of 'put_unaligned_be32' was here static __always_inline void put_unaligned_be32(u32 val, void *p) ^ In file included from arch/openrisc/include/asm/unaligned.h:42:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from
Re: [PATCH] mwifiex: Use put_unaligned_le32
Hi Himanshu, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/mwifiex-Use-put_unaligned_le32/20171007-095017 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All errors (new ones prefixed by >>): In file included from arch/xtensa/include/asm/unaligned.h:22:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_struct.h:6:19: error: redefinition of >> 'get_unaligned_be16' static inline u16 get_unaligned_be16(const void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:22:28: note: previous definition of 'get_unaligned_be16' was here static __always_inline u16 get_unaligned_be16(const void *p) ^ In file included from arch/xtensa/include/asm/unaligned.h:22:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_struct.h:11:19: error: redefinition of >> 'get_unaligned_be32' static inline u32 get_unaligned_be32(const void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:27:28: note: previous definition of 'get_unaligned_be32' was here static __always_inline u32 get_unaligned_be32(const void *p) ^ In file included from arch/xtensa/include/asm/unaligned.h:22:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_struct.h:16:19: error: redefinition of >> 'get_unaligned_be64' static inline u64 get_unaligned_be64(const void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:32:28: note: previous definition of 'get_unaligned_be64' was here static __always_inline u64 get_unaligned_be64(const void *p) ^ In file included from arch/xtensa/include/asm/unaligned.h:22:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_struct.h:21:20: error: redefinition of >> 'put_unaligned_be16' static inline void put_unaligned_be16(u16 val, void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:52:29: note: previous definition of 'put_unaligned_be16' was here static __always_inline void put_unaligned_be16(u16 val, void *p) ^ In file included from arch/xtensa/include/asm/unaligned.h:22:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28, from drivers/net//wireless/marvell/mwifiex/cmdevt.c:21: >> include/linux/unaligned/be_struct.h:26:20: error: redefinition of >> 'put_unaligned_be32' static inline void put_unaligned_be32(u32 val, void *p) ^ In file included from drivers/net//wireless/marvell/mwifiex/cmdevt.c:20:0: include/linux/unaligned/access_ok.h:57:29: note: previous definition of 'put_unaligned_be32' was here static __always_inline void put_unaligned_be32(u32 val, void *p) ^ In file included from arch/xtensa/include/asm/unaligned.h:22:0, from include/linux/etherdevice.h:28, from include/linux/ieee80211.h:22, from drivers/net//wireless/marvell/mwifiex/decl.h:28,
[mac80211-next:regulatory 24/24] net/wireless/reg.c:719:6: error: 'CONFIG_CFG80211_EXTRA_REGDB_KEYDIR' undeclared
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git regulatory head: bdf90273d9eb56ce431a1d44a5b6c9257de460a6 commit: bdf90273d9eb56ce431a1d44a5b6c9257de460a6 [24/24] cfg80211: implement regdb signature checking config: x86_64-allyesdebian (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout bdf90273d9eb56ce431a1d44a5b6c9257de460a6 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): net/wireless/reg.c: In function 'load_builtin_regdb_keys': >> net/wireless/reg.c:719:6: error: 'CONFIG_CFG80211_EXTRA_REGDB_KEYDIR' >> undeclared (first use in this function) if (CONFIG_CFG80211_EXTRA_REGDB_KEYDIR[0] != '\0') ^~ net/wireless/reg.c:719:6: note: each undeclared identifier is reported only once for each function it appears in vim +/CONFIG_CFG80211_EXTRA_REGDB_KEYDIR +719 net/wireless/reg.c 702 703 static int __init load_builtin_regdb_keys(void) 704 { 705 builtin_regdb_keys = 706 keyring_alloc(".builtin_regdb_keys", 707KUIDT_INIT(0), KGIDT_INIT(0), current_cred(), 708((KEY_POS_ALL & ~KEY_POS_SETATTR) | 709KEY_USR_VIEW | KEY_USR_READ | KEY_USR_SEARCH), 710KEY_ALLOC_NOT_IN_QUOTA, NULL, NULL); 711 if (IS_ERR(builtin_regdb_keys)) 712 return PTR_ERR(builtin_regdb_keys); 713 714 pr_notice("Loading compiled-in X.509 certificates for regulatory database\n"); 715 716 #ifdef CONFIG_CFG80211_USE_KERNEL_REGDB_KEYS 717 load_keys_from_buffer(shipped_regdb_certs, shipped_regdb_certs_len); 718 #endif > 719 if (CONFIG_CFG80211_EXTRA_REGDB_KEYDIR[0] != '\0') 720 load_keys_from_buffer(extra_regdb_certs, extra_regdb_certs_len); 721 722 return 0; 723 } 724 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] ath10k: Retry pci probe on failure.
Hi Ben, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/greearb-candelatech-com/ath10k-Retry-pci-probe-on-failure/20170930-020608 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All errors (new ones prefixed by >>): >> ERROR: "__bad_udelay" [drivers/net/wireless/ath/ath10k/ath10k_pci.ko] >> undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] PCI MSI: allow alignment restrictions on vector allocation
Hi Daniel, [auto build test ERROR on pci/next] [also build test ERROR on v4.14-rc2] [cannot apply to tip/x86/core next-20170926] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Daniel-Drake/PCI-MSI-allow-alignment-restrictions-on-vector-allocation/20170927-035611 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: i386-randconfig-x000-201739 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): arch/x86/kernel/apic/vector.c: In function 'assign_irq_vector_policy': >> arch/x86/kernel/apic/vector.c:266:25: error: 'struct irq_alloc_info' has no >> member named 'allowed_vectors' allowed_vectors = info->allowed_vectors; ^~ vim +266 arch/x86/kernel/apic/vector.c 252 253 static int assign_irq_vector_policy(int irq, int node, 254 struct apic_chip_data *data, 255 struct irq_alloc_info *info, 256 struct irq_data *irqdata) 257 { 258 unsigned long *allowed_vectors = NULL; 259 260 /* Some MSI interrupts have restrictions on which vector numbers 261 * can be used. 262 */ 263 if (info && 264 (info->type == X86_IRQ_ALLOC_TYPE_MSI || 265 info->type == X86_IRQ_ALLOC_TYPE_MSIX)) > 266 allowed_vectors = info->allowed_vectors; 267 268 if (info && info->mask) 269 return assign_irq_vector(irq, data, info->mask, irqdata, 270 allowed_vectors); 271 if (node != NUMA_NO_NODE && 272 assign_irq_vector(irq, data, cpumask_of_node(node), irqdata, 273allowed_vectors) == 0) 274 return 0; 275 return assign_irq_vector(irq, data, apic->target_cpus(), irqdata, 276 allowed_vectors); 277 } 278 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] mwifiex: add device specific ioctl handler
Hi Xinming, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc1 next-20170922] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Xinming-Hu/mwifiex-add-device-specific-ioctl-handler/20170923-094243 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=tile All errors (new ones prefixed by >>): drivers/net//wireless/marvell/mwifiex/main.c: In function 'mwifiex_do_ioctl': drivers/net//wireless/marvell/mwifiex/main.c:1276:1: error: pasting "MWIFIEX_DBG_" and ""ioctl cmd = 0x%x\n"" does not give a valid preprocessing token >> drivers/net//wireless/marvell/mwifiex/main.c:1276:1: error: 'MWIFIEX_DBG_' >> undeclared (first use in this function) drivers/net//wireless/marvell/mwifiex/main.c:1276:1: note: each undeclared identifier is reported only once for each function it appears in drivers/net//wireless/marvell/mwifiex/main.c:1276:2: error: expected ')' before string constant >> drivers/net//wireless/marvell/mwifiex/main.c:1276:2: error: too few >> arguments to function '_mwifiex_dbg' drivers/net//wireless/marvell/mwifiex/main.h:206:6: note: declared here vim +1276 drivers/net//wireless/marvell/mwifiex/main.c 1267 1268 static int mwifiex_do_ioctl(struct net_device *dev, struct ifreq *req, int cmd) 1269 { 1270 struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev); 1271 int ret; 1272 1273 if (!priv->adapter->mfg_mode) 1274 return -EINVAL; 1275 > 1276 mwifiex_dbg(priv->adapter, "ioctl cmd = 0x%x\n", cmd); 1277 1278 switch (cmd) { 1279 case MWIFIEX_HOSTCMD_IOCTL: 1280 ret = mwifiex_process_host_command(priv, req); 1281 break; 1282 default: 1283 ret = -EINVAL; 1284 break; 1285 } 1286 1287 return ret; 1288 } 1289 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] mwifiex: add device specific ioctl handler
Hi Xinming, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc1 next-20170922] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Xinming-Hu/mwifiex-add-device-specific-ioctl-handler/20170923-094243 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: x86_64-randconfig-x000-201738 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): In file included from drivers/net/wireless/marvell/mwifiex/main.c:22:0: drivers/net/wireless/marvell/mwifiex/main.c: In function 'mwifiex_do_ioctl': drivers/net/wireless/marvell/mwifiex/main.h:209:24: error: pasting "MWIFIEX_DBG_" and ""ioctl cmd = 0x%x\n"" does not give a valid preprocessing token _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__) ^ >> drivers/net/wireless/marvell/mwifiex/main.c:1276:2: note: in expansion of >> macro 'mwifiex_dbg' mwifiex_dbg(priv->adapter, "ioctl cmd = 0x%x\n", cmd); ^~~ >> drivers/net/wireless/marvell/mwifiex/main.h:209:24: error: 'MWIFIEX_DBG_' >> undeclared (first use in this function) _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__) ^ >> drivers/net/wireless/marvell/mwifiex/main.c:1276:2: note: in expansion of >> macro 'mwifiex_dbg' mwifiex_dbg(priv->adapter, "ioctl cmd = 0x%x\n", cmd); ^~~ drivers/net/wireless/marvell/mwifiex/main.h:209:24: note: each undeclared identifier is reported only once for each function it appears in _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__) ^ >> drivers/net/wireless/marvell/mwifiex/main.c:1276:2: note: in expansion of >> macro 'mwifiex_dbg' mwifiex_dbg(priv->adapter, "ioctl cmd = 0x%x\n", cmd); ^~~ >> drivers/net/wireless/marvell/mwifiex/main.c:1276:29: error: expected ')' >> before string constant mwifiex_dbg(priv->adapter, "ioctl cmd = 0x%x\n", cmd); ^ drivers/net/wireless/marvell/mwifiex/main.h:209:38: note: in definition of macro 'mwifiex_dbg' _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__) ^~~~ >> drivers/net/wireless/marvell/mwifiex/main.h:209:2: error: too few arguments >> to function '_mwifiex_dbg' _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__) ^ >> drivers/net/wireless/marvell/mwifiex/main.c:1276:2: note: in expansion of >> macro 'mwifiex_dbg' mwifiex_dbg(priv->adapter, "ioctl cmd = 0x%x\n", cmd); ^~~ drivers/net/wireless/marvell/mwifiex/main.h:206:6: note: declared here void _mwifiex_dbg(const struct mwifiex_adapter *adapter, int mask, ^~~~ vim +209 drivers/net/wireless/marvell/mwifiex/main.h c687a0077 drivers/net/wireless/mwifiex/main.h Zhaoyang Liu 2015-05-12 200 c687a0077 drivers/net/wireless/mwifiex/main.h Zhaoyang Liu 2015-05-12 201 #define MWIFIEX_DEFAULT_DEBUG_MASK (MWIFIEX_DBG_MSG | \ c687a0077 drivers/net/wireless/mwifiex/main.h Zhaoyang Liu 2015-05-12 202 MWIFIEX_DBG_FATAL | \ c687a0077 drivers/net/wireless/mwifiex/main.h Zhaoyang Liu 2015-05-12 203 MWIFIEX_DBG_ERROR) c687a0077 drivers/net/wireless/mwifiex/main.h Zhaoyang Liu 2015-05-12 204 36925e52c drivers/net/wireless/mwifiex/main.h Joe Perches 2015-08-31 205 __printf(3, 4) 36925e52c drivers/net/wireless/mwifiex/main.h Joe Perches 2015-08-31 206 void _mwifiex_dbg(const struct mwifiex_adapter *adapter, int mask, 36925e52c drivers/net/wireless/mwifiex/main.h Joe Perches 2015-08-31 207 const char *fmt, ...); 36925e52c drivers/net/wireless/mwifiex/main.h Joe Perches 2015-08-31 208 #define mwifiex_dbg(adapter, mask, fmt, ...)\ 36925e52c drivers/net/wireless/mwifiex/main.h Joe Perches 2015-08-31 @209 _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__) c687a0077 drivers/net/wireless/mwifiex/main.h Zhaoyang Liu 2015-05-12 210 :: The code at line 209 was first introduced by commit :: 36925e52c5ac9d10a553d1339e13a61bfbdd4ba4 mwifiex: Make mwifiex_dbg a function, reduce object size :: TO: Joe Perches:: CC: Kalle Valo --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 07/10] mac80211: add api to start ba session timer expired flow
Hi Naftali, [auto build test WARNING on linus/master] [also build test WARNING on v4.13-rc3 next-20170804] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/mac80211-patches-from-our-internal-tree-2017-08-05/20170806-053032 reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' >> include/net/mac80211.h:5515: warning: No description found for parameter >> 'bit' >> include/net/mac80211.h:5515: warning: Excess function parameter 'tid' >> description in 'ieee80211_rx_ba_timer_expired' vim +/bit +5515 include/net/mac80211.h 5501 5502 /** 5503 * ieee80211_rx_ba_timer_expired - stop a Rx BA session due to timeout 5504 * 5505 * Some device drivers do not offload AddBa/DelBa negotiation, but handle rx 5506 * buffer reording internally, and therefore also handle the session timer. 5507 * 5508 * Trigger the timeout flow, which sends a DelBa. 5509 * 5510 * @vif: ieee80211_vif pointer from the add_interface callback 5511 * @addr: station mac address 5512 * @tid: the rx tid 5513 */ 5514 void ieee80211_rx_ba_timer_expired(struct ieee80211_vif *vif, > 5515 const u8 *addr, unsigned int bit); 5516 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] mwifiex: p2p: use separate device address
Hi Xinming, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.13-rc3 next-20170804] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Xinming-Hu/mwifiex-p2p-use-separate-device-address/20170805-130855 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: mips-allmodconfig (attached as .config) compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=mips All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:10:0, from include/linux/list.h:8, from include/linux/preempt.h:10, from include/linux/spinlock.h:50, from include/linux/swap.h:4, from include/linux/suspend.h:4, from drivers/net//wireless/marvell/mwifiex/main.c:20: drivers/net//wireless/marvell/mwifiex/main.c: In function 'mwifiex_set_mac_address': include/linux/bitops.h:6:24: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (1UL << (nr)) ^ >> drivers/net//wireless/marvell/mwifiex/main.c:953:14: note: in expansion of >> macro 'BIT' mac_addr |= BIT(MWIFIEX_MAC_LOCAL_ADMIN_BIT); ^~~ vim +/BIT +953 drivers/net//wireless/marvell/mwifiex/main.c 942 943 int mwifiex_set_mac_address(struct mwifiex_private *priv, 944 struct net_device *dev) 945 { 946 int ret; 947 u64 mac_addr; 948 949 if (priv->bss_type != MWIFIEX_BSS_TYPE_P2P) 950 goto done; 951 952 mac_addr = ether_addr_to_u64(priv->curr_addr); > 953 mac_addr |= BIT(MWIFIEX_MAC_LOCAL_ADMIN_BIT); 954 u64_to_ether_addr(mac_addr, priv->curr_addr); 955 956 /* Send request to firmware */ 957 ret = mwifiex_send_cmd(priv, HostCmd_CMD_802_11_MAC_ADDRESS, 958 HostCmd_ACT_GEN_SET, 0, NULL, true); 959 960 if (ret) { 961 mwifiex_dbg(priv->adapter, ERROR, 962 "set mac address failed: ret=%d\n", ret); 963 return ret; 964 } 965 966 done: 967 memcpy(dev->dev_addr, priv->curr_addr, ETH_ALEN); 968 return 0; 969 } 970 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function
Hi Rafał, [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v4.13-rc3 next-20170731] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/firmware-add-more-flexible-request_firmware_async-function/20170801-033319 reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/init.h:1: warning: no structured comments found include/linux/mod_devicetable.h:687: warning: Excess struct/union/enum/typedef member 'ver_major' description in 'fsl_mc_device_id' include/linux/mod_devicetable.h:687: warning: Excess struct/union/enum/typedef member 'ver_minor' description in 'fsl_mc_device_id' kernel/sched/core.c:2080: warning: No description found for parameter 'rf' kernel/sched/core.c:2080: warning: Excess function parameter 'cookie' description in 'try_to_wake_up_local' include/linux/wait.h:555: warning: No description found for parameter 'wq' include/linux/wait.h:555: warning: Excess function parameter 'wq_head' description in 'wait_event_interruptible_hrtimeout' include/linux/wait.h:759: warning: No description found for parameter 'wq_head' include/linux/wait.h:759: warning: Excess function parameter 'wq' description in 'wait_event_killable' include/linux/kthread.h:26: warning: Excess function parameter '...' description in 'kthread_create' kernel/sys.c:1: warning: no structured comments found include/linux/device.h:968: warning: No description found for parameter 'dma_ops' drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found >> drivers/base/firmware_class.c:1: warning: no structured comments found include/linux/iio/iio.h:603: warning: No description found for parameter 'trig_readonly' include/linux/iio/trigger.h:151: warning: No description found for parameter 'indio_dev' include/linux/iio/trigger.h:151: warning: No description found for parameter 'trig' include/linux/device.h:969: warning: No description found for parameter 'dma_ops' drivers/ata/libata-eh.c:1449: warning: No description found for parameter 'link' drivers/ata/libata-eh.c:1449: warning: Excess function parameter 'ap' description in 'ata_eh_done' drivers/ata/libata-eh.c:1590: warning: No description found for parameter 'qc' drivers/ata/libata-eh.c:1590: warning: Excess function parameter 'dev' description in 'ata_eh_request_sense' drivers/mtd/nand/nand_base.c:2751: warning: Excess function parameter 'cached' description in 'nand_write_page' drivers/mtd/nand/nand_base.c:2751: warning: Excess function parameter 'cached' description in 'nand_write_page' arch/s390/include/asm/cmb.h:1: warning: no structured comments found drivers/scsi/scsi_lib.c:1116: warning: No description found for parameter 'rq' drivers/scsi/constants.c:1: warning: no structured comments found include/linux/usb/gadget.h:230: warning: No description found for parameter 'claimed' include/linux/usb/gadget.h:230: warning: No description found for parameter 'enabled' include/linux/usb/gadget.h:412: warning: No description found for parameter 'quirk_altset_not_supp' include/linux/usb/gadget.h:412: warning: No description found for parameter 'quirk_stall_not_supp' include/linux/usb/gadget.h:412: warning: No description found for parameter 'quirk_zlp_not_supp' fs/inode.c:1666: warning: No description found for parameter 'rcu' include/linux/jbd2.h:443: warning: No description found for parameter 'i_transaction' include/linux/jbd2.h:443: warning: No description found for parameter 'i_next_transaction' include/linux/jbd2.h:443: warning: No description found for parameter 'i_list' include/linux/jbd2.h:443: warning: No description found for parameter 'i_vfs_inode' include/linux/jbd2.h:443: warning: No description found for parameter 'i_flags' include/linux/jbd2.h:497: warning: No description found for parameter 'h_rsv_handle' include/linux/jbd2.h:497: warning: No description found for parameter 'h_reserved' include/linux/jbd2.h:497: warning: No description found for parameter 'h_type' include/linux/jbd2.h:497: warning: No description found for parameter 'h_line_no' include/linux/jbd2.h:497: warning: No description found for parameter 'h_start_jiffies' include/linux/jbd2.h:497: warning: No description found for parameter 'h_requested_credits' include/linux/jbd2.h:497: warning: No description found for parameter 'saved_alloc_context' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_chkpt_bhs' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_devname' include/linux/jbd2.h:1050: warning: No description found for parameter 'j_average_commit_time' include/linux/jbd2.h:1050:
Re: [PATCH v2] ath9k: fix more-data flag for buffered multicast packets
Hi Felix, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.13-rc2 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/ath9k-fix-more-data-flag-for-buffered-multicast-packets/20170727-133416 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net//wireless/ath/ath9k/xmit.c: In function 'ath_tx_cabq': >> drivers/net//wireless/ath/ath9k/xmit.c:2454:2: error: implicit declaration >> of function 'ath9k_set_moredata' [-Werror=implicit-function-declaration] ath9k_set_moredata(sc, bf, false); ^~ cc1: some warnings being treated as errors vim +/ath9k_set_moredata +2454 drivers/net//wireless/ath/ath9k/xmit.c 2401 2402 void ath_tx_cabq(struct ieee80211_hw *hw, struct ieee80211_vif *vif, 2403 struct sk_buff *skb) 2404 { 2405 struct ath_softc *sc = hw->priv; 2406 struct ath_tx_control txctl = { 2407 .txq = sc->beacon.cabq 2408 }; 2409 struct ath_tx_info info = {}; 2410 struct ath_buf *bf_tail = NULL; 2411 struct ath_buf *bf; 2412 LIST_HEAD(bf_q); 2413 int duration = 0; 2414 int max_duration; 2415 2416 max_duration = 2417 sc->cur_chan->beacon.beacon_interval * 1000 * 2418 sc->cur_chan->beacon.dtim_period / ATH_BCBUF; 2419 2420 do { 2421 struct ath_frame_info *fi = get_frame_info(skb); 2422 2423 if (ath_tx_prepare(hw, skb, )) 2424 break; 2425 2426 bf = ath_tx_setup_buffer(sc, txctl.txq, NULL, skb); 2427 if (!bf) 2428 break; 2429 2430 bf->bf_lastbf = bf; 2431 ath_set_rates(vif, NULL, bf); 2432 ath_buf_set_rate(sc, bf, , fi->framelen, false); 2433 duration += info.rates[0].PktDuration; 2434 if (bf_tail) 2435 bf_tail->bf_next = bf; 2436 2437 list_add_tail(>list, _q); 2438 bf_tail = bf; 2439 skb = NULL; 2440 2441 if (duration > max_duration) 2442 break; 2443 2444 skb = ieee80211_get_buffered_bc(hw, vif); 2445 } while(skb); 2446 2447 if (skb) 2448 ieee80211_free_txskb(hw, skb); 2449 2450 if (list_empty(_q)) 2451 return; 2452 2453 bf = list_last_entry(_q, struct ath_buf, list); > 2454 ath9k_set_moredata(sc, bf, false); 2455 2456 bf = list_first_entry(_q, struct ath_buf, list); 2457 ath_txq_lock(sc, txctl.txq); 2458 ath_tx_fill_desc(sc, bf, txctl.txq, 0); 2459 ath_tx_txqaddbuf(sc, txctl.txq, _q, false); 2460 TX_STAT_INC(txctl.txq->axq_qnum, queued); 2461 ath_txq_unlock(sc, txctl.txq); 2462 } 2463 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 19/34] brcmfmac: Get rid of chip_priv and core_priv structs
Hi Ian, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.13-rc2 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ian-Molton/brcmfmac-Fix-parameter-order-in-brcmf_sdiod_f0_writeb/20170728-215756 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: parisc-allyesconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=parisc Note: the linux-review/Ian-Molton/brcmfmac-Fix-parameter-order-in-brcmf_sdiod_f0_writeb/20170728-215756 HEAD 279d46b037ee04966f44b25a0ed07c467540c68c builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function 'brcmf_chip_recognition': >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:900:9: error: >> 'KERN_LOG' undeclared (first use in this function) printk(KERN_LOG "found %s chip: BCM%s, rev=%d\n", ^~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:900:9: note: each undeclared identifier is reported only once for each function it appears in >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:900:18: error: >> expected ')' before string constant printk(KERN_LOG "found %s chip: BCM%s, rev=%d\n", ^~~~ vim +/KERN_LOG +900 drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c 880 881 static int brcmf_chip_recognition(struct brcmf_chip *ci) 882 { 883 struct brcmf_core *core; 884 u32 regdata; 885 u32 socitype; 886 int ret; 887 888 /* Get CC core rev 889 * Chipid is assume to be at offset 0 from SI_ENUM_BASE 890 * For different chiptypes or old sdio hosts w/o chipcommon, 891 * other ways of recognition should be added here. 892 */ 893 regdata = ci->ops->read32(ci->ctx, CORE_CC_REG(SI_ENUM_BASE, chipid)); 894 ci->chip = regdata & CID_ID_MASK; 895 ci->chiprev = (regdata & CID_REV_MASK) >> CID_REV_SHIFT; 896 socitype = (regdata & CID_TYPE_MASK) >> CID_TYPE_SHIFT; 897 898 brcmf_chip_name(ci->chip, ci->name, sizeof(ci->name)); 899 > 900 printk(KERN_LOG "found %s chip: BCM%s, rev=%d\n", 901 socitype == SOCI_SB ? "SB" : "AXI", ci->name, ci->chiprev); 902 903 switch(socitype) { 904 case SOCI_SB: 905 906 if (ci->chip != BRCM_CC_4329_CHIP_ID) { 907 brcmf_err("SB chip is not supported\n"); 908 return -ENODEV; 909 } 910 ci->iscoreup = brcmf_chip_sb_iscoreup; 911 ci->coredisable = brcmf_chip_sb_coredisable; 912 ci->resetcore = brcmf_chip_sb_resetcore; 913 914 core = brcmf_chip_add_core(ci, BCMA_CORE_CHIPCOMMON, 915 SI_ENUM_BASE, 0); 916 brcmf_chip_sb_corerev(ci, core); 917 core = brcmf_chip_add_core(ci, BCMA_CORE_SDIO_DEV, 918 BCM4329_CORE_BUS_BASE, 0); 919 brcmf_chip_sb_corerev(ci, core); 920 core = brcmf_chip_add_core(ci, BCMA_CORE_INTERNAL_MEM, 921 BCM4329_CORE_SOCRAM_BASE, 0); 922 brcmf_chip_sb_corerev(ci, core); 923 core = brcmf_chip_add_core(ci, BCMA_CORE_ARM_CM3, 924 BCM4329_CORE_ARM_BASE, 0); 925 brcmf_chip_sb_corerev(ci, core); 926 927 core = brcmf_chip_add_core(ci, BCMA_CORE_80211, 0x18001000, 0); 928 brcmf_chip_sb_corerev(ci, core); 929 break; 930 case SOCI_AXI: 931 ci->iscoreup = brcmf_chip_ai_iscoreup; 932 ci->coredisable = brcmf_chip_ai_coredisable; 933 ci->resetcore = brcmf_chip_ai_resetcore; 934 935 brcmf_chip_dmp_erom_scan(ci); 936 break; 937 default: 938 brcmf_err("chip backplane type %u is not supported\n", 939socitype); 940 return -ENODEV; 941 } 942 943 ret = brcmf_chip_cores_check(ci); 944 if (ret) 945 return ret; 946
[PATCH] brcmfmac: fix semicolon.cocci warnings
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:316:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 4451d20a99c4 ("brcmfmac: Replace function index with function pointer") CC: Ian MoltonSigned-off-by: Fengguang Wu --- bcmsdh.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c @@ -313,7 +313,7 @@ static int brcmf_sdiod_buff_read(struct break; default: BUG(); - }; + } if (err == -ENOMEDIUM) brcmf_sdiod_change_state(sdiodev, BRCMF_SDIOD_NOMEDIUM);
Re: [PATCH 32/34] brcmfmac: Replace function index with function pointer
Hi Ian, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.13-rc2 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ian-Molton/brcmfmac-Fix-parameter-order-in-brcmf_sdiod_f0_writeb/20170728-215756 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:316:2-3: Unneeded >> semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH] ath9k: fix more-data flag for buffered multicast packets
Hi Felix, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.13-rc2 next-20170725] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/ath9k-fix-more-data-flag-for-buffered-multicast-packets/20170726-054105 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All errors (new ones prefixed by >>): drivers/net/wireless/ath/ath9k/xmit.c: In function 'ath_tx_cabq': >> drivers/net/wireless/ath/ath9k/xmit.c:2454:2: error: implicit declaration of >> function 'ath9k_set_moredata' [-Werror=implicit-function-declaration] ath9k_set_moredata(sc, bf, false); ^ cc1: some warnings being treated as errors vim +/ath9k_set_moredata +2454 drivers/net/wireless/ath/ath9k/xmit.c 2401 2402 void ath_tx_cabq(struct ieee80211_hw *hw, struct ieee80211_vif *vif, 2403 struct sk_buff *skb) 2404 { 2405 struct ath_softc *sc = hw->priv; 2406 struct ath_tx_control txctl = { 2407 .txq = sc->beacon.cabq 2408 }; 2409 struct ath_tx_info info = {}; 2410 struct ath_buf *bf_tail = NULL; 2411 struct ath_buf *bf; 2412 LIST_HEAD(bf_q); 2413 int duration = 0; 2414 int max_duration; 2415 2416 max_duration = 2417 sc->cur_chan->beacon.beacon_interval * 1000 * 2418 sc->cur_chan->beacon.dtim_period / ATH_BCBUF; 2419 2420 do { 2421 struct ath_frame_info *fi = get_frame_info(skb); 2422 2423 if (ath_tx_prepare(hw, skb, )) 2424 break; 2425 2426 bf = ath_tx_setup_buffer(sc, txctl.txq, NULL, skb); 2427 if (!bf) 2428 break; 2429 2430 bf->bf_lastbf = bf; 2431 ath_set_rates(vif, NULL, bf); 2432 ath_buf_set_rate(sc, bf, , fi->framelen, false); 2433 duration += info.rates[0].PktDuration; 2434 if (bf_tail) 2435 bf_tail->bf_next = bf; 2436 2437 list_add_tail(>list, _q); 2438 bf_tail = bf; 2439 skb = NULL; 2440 2441 if (duration > max_duration) 2442 break; 2443 2444 skb = ieee80211_get_buffered_bc(hw, vif); 2445 } while(skb); 2446 2447 if (skb) 2448 ieee80211_free_txskb(hw, skb); 2449 2450 if (list_empty(_q)) 2451 return; 2452 2453 bf = list_last_entry(_q, struct ath_buf, list); > 2454 ath9k_set_moredata(sc, bf, false); 2455 2456 ath_txq_lock(sc, txctl.txq); 2457 ath_tx_fill_desc(sc, bf, txctl.txq, 0); 2458 ath_tx_txqaddbuf(sc, txctl.txq, _q, false); 2459 TX_STAT_INC(txctl.txq->axq_qnum, queued); 2460 ath_txq_unlock(sc, txctl.txq); 2461 } 2462 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 2/2] crypto/algapi - make crypto_xor() take separate dst and src arguments
Hi Ard, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.13-rc1 next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-algapi-use-separate-dst-and-src-operands-for-__crypto_xor/20170719-090848 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=powerpc All errors (new ones prefixed by >>): drivers/crypto/vmx/aes_ctr.c: In function 'p8_aes_ctr_final': drivers/crypto/vmx/aes_ctr.c:107:29: warning: passing argument 3 of 'crypto_xor' makes integer from pointer without a cast [-Wint-conversion] crypto_xor(dst, keystream, src, nbytes); ^~~ In file included from include/crypto/scatterwalk.h:19:0, from drivers/crypto/vmx/aes_ctr.c:29: include/crypto/algapi.h:197:20: note: expected 'unsigned int' but argument is of type 'u8 * {aka unsigned char *}' static inline void crypto_xor(u8 *dst, const u8 *src, unsigned int size) ^~ >> drivers/crypto/vmx/aes_ctr.c:107:2: error: too many arguments to function >> 'crypto_xor' crypto_xor(dst, keystream, src, nbytes); ^~ In file included from include/crypto/scatterwalk.h:19:0, from drivers/crypto/vmx/aes_ctr.c:29: include/crypto/algapi.h:197:20: note: declared here static inline void crypto_xor(u8 *dst, const u8 *src, unsigned int size) ^~ vim +/crypto_xor +107 drivers/crypto/vmx/aes_ctr.c 89 90 static void p8_aes_ctr_final(struct p8_aes_ctr_ctx *ctx, 91 struct blkcipher_walk *walk) 92 { 93 u8 *ctrblk = walk->iv; 94 u8 keystream[AES_BLOCK_SIZE]; 95 u8 *src = walk->src.virt.addr; 96 u8 *dst = walk->dst.virt.addr; 97 unsigned int nbytes = walk->nbytes; 98 99 preempt_disable(); 100 pagefault_disable(); 101 enable_kernel_vsx(); 102 aes_p8_encrypt(ctrblk, keystream, >enc_key); 103 disable_kernel_vsx(); 104 pagefault_enable(); 105 preempt_enable(); 106 > 107 crypto_xor(dst, keystream, src, nbytes); 108 crypto_inc(ctrblk, AES_BLOCK_SIZE); 109 } 110 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v1 5/6] uuid: Kill uapi/uuid.h
Hi Andy, [auto build test WARNING on linus/master] [also build test WARNING on v4.13-rc1] [cannot apply to next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/uuid-Convert-rest-users-to-new-API/20170723-022330 config: i386-tinyconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): >> ./usr/include/linux/hyperv.h:71: found __[us]{8,16,32,64} type without >> #include >> ./usr/include/linux/mei.h:93: found __[us]{8,16,32,64} type without #include >> --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API
Hi Andy, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc1] [cannot apply to next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/uuid-Convert-rest-users-to-new-API/20170723-022330 config: i386-tinyconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 Note: the linux-review/Andy-Shevchenko/uuid-Convert-rest-users-to-new-API/20170723-022330 HEAD f8d40b52dfac11e78d56509455812bcfe9962ce0 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): In file included from scripts//mod/file2alias.c:44:0: scripts//mod/../../include/linux/mod_devicetable.h:408:2: error: unknown type name 'guid_t' guid_t guid; ^~ scripts//mod/../../include/linux/mod_devicetable.h:638:2: error: unknown type name 'guid_t' guid_t uuid; ^~ In file included from scripts//mod/file2alias.c:13:0: scripts//mod/file2alias.c: In function 'do_vmbus_entry': >> scripts//mod/file2alias.c:938:49: error: request for member 'b' in something >> not a structure or union sprintf(_name[i], "%02x", TO_NATIVE((guid->b)[i/2])); ^ scripts//mod/modpost.h:92:23: note: in definition of macro 'TO_NATIVE' #define TO_NATIVE(x) (x) ^ scripts//mod/file2alias.c: In function 'do_mei_entry': scripts//mod/file2alias.c:1233:18: error: incompatible type for argument 2 of 'add_uuid' add_uuid(alias, *uuid); ^ scripts//mod/file2alias.c:137:20: note: expected 'uuid_le {aka struct }' but argument is of type 'int' static inline void add_uuid(char *str, uuid_le uuid) ^~~~ vim +/b +938 scripts//mod/file2alias.c b01d9f28 Rusty Russell2007-10-22 923 d2ee52aa K. Y. Srinivasan 2011-08-25 924 /* d2ee52aa K. Y. Srinivasan 2011-08-25 925 * Looks like: vmbus:guid d2ee52aa K. Y. Srinivasan 2011-08-25 926 * Each byte of the guid will be represented by two hex characters d2ee52aa K. Y. Srinivasan 2011-08-25 927 * in the name. d2ee52aa K. Y. Srinivasan 2011-08-25 928 */ d2ee52aa K. Y. Srinivasan 2011-08-25 929 6543becf Andreas Schwab 2013-01-20 930 static int do_vmbus_entry(const char *filename, void *symval, d2ee52aa K. Y. Srinivasan 2011-08-25 931 char *alias) d2ee52aa K. Y. Srinivasan 2011-08-25 932 { d2ee52aa K. Y. Srinivasan 2011-08-25 933 int i; 6543becf Andreas Schwab 2013-01-20 934 DEF_FIELD_ADDR(symval, hv_vmbus_device_id, guid); 6543becf Andreas Schwab 2013-01-20 935 char guid_name[(sizeof(*guid) + 1) * 2]; d2ee52aa K. Y. Srinivasan 2011-08-25 936 6543becf Andreas Schwab 2013-01-20 937 for (i = 0; i < (sizeof(*guid) * 2); i += 2) af3ff643 K. Y. Srinivasan 2015-12-14 @938 sprintf(_name[i], "%02x", TO_NATIVE((guid->b)[i/2])); d2ee52aa K. Y. Srinivasan 2011-08-25 939 d2ee52aa K. Y. Srinivasan 2011-08-25 940 strcpy(alias, "vmbus:"); d2ee52aa K. Y. Srinivasan 2011-08-25 941 strcat(alias, guid_name); d2ee52aa K. Y. Srinivasan 2011-08-25 942 d2ee52aa K. Y. Srinivasan 2011-08-25 943 return 1; d2ee52aa K. Y. Srinivasan 2011-08-25 944 } 6543becf Andreas Schwab 2013-01-20 945 ADD_TO_DEVTABLE("vmbus", hv_vmbus_device_id, do_vmbus_entry); d2ee52aa K. Y. Srinivasan 2011-08-25 946 :: The code at line 938 was first introduced by commit :: af3ff643ea91ba64dd8d0b1cbed54d44512f96cd Drivers: hv: vmbus: Use uuid_le type consistently :: TO: K. Y. Srinivasan:: CC: Greg Kroah-Hartman --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v1 2/6] mei: Switch to use new generic UUID API
Hi Andy, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc1 next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/uuid-Convert-rest-users-to-new-API/20170723-022330 config: i386-randconfig-x019-201730 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 Note: the linux-review/Andy-Shevchenko/uuid-Convert-rest-users-to-new-API/20170723-022330 HEAD f8d40b52dfac11e78d56509455812bcfe9962ce0 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): In file included from scripts/mod/file2alias.c:44:0: >> scripts/mod/../../include/linux/mod_devicetable.h:638:2: error: unknown type >> name 'guid_t' guid_t uuid; ^~ scripts/mod/file2alias.c: In function 'do_mei_entry': >> scripts/mod/file2alias.c:1233:18: error: incompatible type for argument 2 of >> 'add_uuid' add_uuid(alias, *uuid); ^ scripts/mod/file2alias.c:137:20: note: expected 'uuid_le {aka struct }' but argument is of type 'int' static inline void add_uuid(char *str, uuid_le uuid) ^~~~ make[3]: *** [scripts/mod/file2alias.o] Error 1 make[3]: Target '__build' not remade because of errors. make[2]: *** [scripts/mod] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [scripts] Error 2 make[1]: Target 'modules_prepare' not remade because of errors. make: *** [sub-make] Error 2 vim +/guid_t +638 scripts/mod/../../include/linux/mod_devicetable.h 626 627 /** 628 * struct mei_cl_device_id - MEI client device identifier 629 * @name: helper name 630 * @uuid: client GUID 631 * @version: client protocol version 632 * @driver_info: information used by the driver. 633 * 634 * identifies mei client device by GUID and name 635 */ 636 struct mei_cl_device_id { 637 char name[MEI_CL_NAME_SIZE]; > 638 guid_t uuid; 639 __u8version; 640 kernel_ulong_t driver_info; 641 }; 642 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 28/29] brcmfmac: Rename buscore->core for consistency
Hi Ian, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.13-rc1] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ian-Molton/brcmfmac-Fix-parameter-order-in-brcmf_sdiod_f0_writeb/20170718-123057 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: x86_64-randconfig-a0-07201347 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function 'brcmf_sdio_intr_rstatus': >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2470: warning: >> unused variable 'addr' vim +/addr +2470 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c ba89bf19 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-04-27 2466 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2467 static int brcmf_sdio_intr_rstatus(struct brcmf_sdio *bus) 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2468 { 8c62b25e drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c Ian Molton 2017-07-17 2469struct brcmf_core *core = bus->sdio_core; 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 @2470u32 addr; 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2471unsigned long val; 5cbb9c28 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Hante Meuleman 2014-03-06 2472int ret; 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2473 8c62b25e drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c Ian Molton 2017-07-17 2474val = brcmf_sdiod_readl(bus->sdiodev, core->base + __sd_reg(intstatus), ); 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2475bus->sdcnt.f1regdata++; 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2476if (ret != 0) 5cbb9c28 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Hante Meuleman 2014-03-06 2477return ret; 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2478 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2479val &= bus->hostintmask; 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2480atomic_set(>fcstate, !!(val & I_HMB_FC_STATE)); 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2481 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2482/* Clear interrupts */ 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2483if (val) { 8c62b25e drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c Ian Molton 2017-07-17 2484brcmf_sdiod_writel(bus->sdiodev, core->base + __sd_reg(intstatus), 8c62b25e drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c Ian Molton 2017-07-17 2485val, ); 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2486bus->sdcnt.f1regdata++; d3928d09 drivers/net/wireless/brcm80211/brcmfmac/sdio.c Vineet Gupta 2015-07-09 2487atomic_or(val, >intstatus); 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2488} 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2489 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2490return ret; 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2491 } 4531603a drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2012-09-13 2492 :: The code at line 2470 was first introduced by commit :: 4531603a7acb1463ec0b466dcfedc6682e7a1718 brcmfmac: clear status for in-band interrupt in brcmf_sdbrcm_isr :: TO: Franky Lin:: CC: John W. Linville --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 17/21] brcmfmac: HUGE cleanup of IO access functions.
Hi Ian, [auto build test WARNING on wireless-drivers/master] [also build test WARNING on v4.13-rc1 next-20170714] [cannot apply to wireless-drivers-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ian-Molton/net-brcmfmac-Write-function-depends-on-size-of-regs-not-types/20170716-195206 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:283:9-10: WARNING: >> return of 0/1 in function 'brcmf_chip_axi_iscoreup' with return type bool Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] brcmfmac: fix boolreturn.cocci warnings
drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:283:9-10: WARNING: return of 0/1 in function 'brcmf_chip_axi_iscoreup' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: f9996a7ac81f ("brcmfmac: HUGE cleanup of IO access functions.") CC: Ian MoltonSigned-off-by: Fengguang Wu --- chip.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c @@ -280,7 +280,7 @@ static bool brcmf_chip_axi_iscoreup(stru val = brcmf_readl(ci, core->wrapbase + BCMA_IOCTL); if((val & BCMA_IOCTL_FGC) || !(val & BCMA_IOCTL_CLK)) - return 0; + return false; /* Is core in reset? */ val = brcmf_readl(ci, core->wrapbase + BCMA_RESET_CTL);