Re: [PATCH] b43: Add missing MODULE_FIRMWARE()

2017-05-04 Thread Takashi Iwai 
On Thu, 04 May 2017 11:43:14 +0200,
Kalle Valo wrote:
> 
> Takashi Iwai  writes:
> 
> > Some recent firmware entries were forgotten to be added via
> > MODULE_FIRMWARE(), which may result in the non-functional state when
> > the driver is loaded in initrd.
> >
> > Link: http://bugzilla.opensuse.org/show_bug.cgi?id=1037344
> > Signed-off-by: Takashi Iwai 
> 
> With recent you mean three years ago? ;)

Heh, time flies :)

> Some of these were added by
> Rafal (CCed) in commit 15be8e89cdd99 and some in a60f99f75dd35.
> 
> I'll replace the word recent and add:
> 
> Fixes: 15be8e89cdd9 ("b43: add more bcma cores")
> 
> But as this is so old bug I'll queue this to 4.13.

Thanks, it's no urgent fix, obviously.  We just stumbled on this
casually.


Takashi

Re: [PATCH] b43: Add missing MODULE_FIRMWARE()

2017-05-04 Thread Kalle Valo 
Takashi Iwai  writes:

> Some recent firmware entries were forgotten to be added via
> MODULE_FIRMWARE(), which may result in the non-functional state when
> the driver is loaded in initrd.
>
> Link: http://bugzilla.opensuse.org/show_bug.cgi?id=1037344
> Signed-off-by: Takashi Iwai 

With recent you mean three years ago? ;) Some of these were added by
Rafal (CCed) in commit 15be8e89cdd99 and some in a60f99f75dd35.

I'll replace the word recent and add:

Fixes: 15be8e89cdd9 ("b43: add more bcma cores")

But as this is so old bug I'll queue this to 4.13.

-- 
Kalle Valo