RE: [PATCH] mac80211: Fix addition of mesh configuration element
> -Original Message- > From: Johannes Berg [mailto:johan...@sipsolutions.net] > Sent: Monday, January 02, 2017 13:00 > To: Peer, Ilan > Cc: linux-wireless@vger.kernel.org; masashi.ho...@gmail.com > Subject: Re: [PATCH] mac80211: Fix addition of mesh configuration element > > On Mon, 2016-12-26 at 18:17 +0200, Ilan Peer wrote: > > The code was setting the capabilities byte to zero, after it was > > already properly set previously. Fix it. > > > > The bug was found while debugging hwsim mesh tests failures that > > happened in commit 76f43b4 (mac80211: Remove invalid flag operations > > in mesh TSF synchronization). > > > Applied, thanks. > > When you have the commit already, please add a Fixes tag, and also use > 12 hex digits to abbreviate SHA1s please. (I've done that now) > Sure. Thanks. Ilan.
Re: [PATCH] mac80211: Fix addition of mesh configuration element
On Mon, 2016-12-26 at 18:17 +0200, Ilan Peer wrote: > The code was setting the capabilities byte to zero, > after it was already properly set previously. Fix it. > > The bug was found while debugging hwsim mesh tests failures > that happened in commit 76f43b4 (mac80211: Remove invalid flag > operations in mesh TSF synchronization). > Applied, thanks. When you have the commit already, please add a Fixes tag, and also use 12 hex digits to abbreviate SHA1s please. (I've done that now) johannes
Re: [PATCH] mac80211: Fix addition of mesh configuration element
On 2016年12月27日 01:17, Ilan Peer wrote: The code was setting the capabilities byte to zero, after it was already properly set previously. Fix it. The bug was found while debugging hwsim mesh tests failures that happened in commit 76f43b4 (mac80211: Remove invalid flag operations in mesh TSF synchronization). Thanks! Reviewed-by: Masashi Honma
[PATCH] mac80211: Fix addition of mesh configuration element
The code was setting the capabilities byte to zero, after it was already properly set previously. Fix it. The bug was found while debugging hwsim mesh tests failures that happened in commit 76f43b4 (mac80211: Remove invalid flag operations in mesh TSF synchronization). Signed-off-by: Ilan Peer --- net/mac80211/mesh.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c index cc2a63b..9c23172 100644 --- a/net/mac80211/mesh.c +++ b/net/mac80211/mesh.c @@ -279,8 +279,6 @@ int mesh_add_meshconf_ie(struct ieee80211_sub_if_data *sdata, /* Mesh PS mode. See IEEE802.11-2012 8.4.2.100.8 */ *pos |= ifmsh->ps_peers_deep_sleep ? IEEE80211_MESHCONF_CAPAB_POWER_SAVE_LEVEL : 0x00; - *pos++ = 0x00; - return 0; } -- 1.9.1
