Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback
Hello Kalle, On 07/05/2016 09:09 AM, Kalle Valo wrote: > Javier Martinez Canillaswrites: > >> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added >> interface") attempted to fix an issue when a new AP interface is added. >> >> But the patch didn't check the return value of the functions doing the >> firmware calls and returned an error even if the functions didn't fail. >> >> This prevents the network device to be registered properly, so fix it. >> >> Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added >> interface") >> Signed-off-by: Javier Martinez Canillas > > The fixes line should be: > > Fixes: 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") > > I can fix that before I apply the patch. > Sigh, it was a copy and paste error when I copied the SHA-1 from the commit message. Sorry about that and thanks for taking care of this. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback
Javier Martinez Canillaswrites: > The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") attempted to fix an issue when a new AP interface is added. > > But the patch didn't check the return value of the functions doing the > firmware calls and returned an error even if the functions didn't fail. > > This prevents the network device to be registered properly, so fix it. > > Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") > Signed-off-by: Javier Martinez Canillas The fixes line should be: Fixes: 7311ea850079 ("mwifiex: fix AP start problem for newly added interface") I can fix that before I apply the patch. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback
Hi All, On Sat, Jul 2, 2016 at 5:39 AM, Javier Martinez Canillaswrote: > The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") attempted to fix an issue when a new AP interface is added. > > But the patch didn't check the return value of the functions doing the > firmware calls and returned an error even if the functions didn't fail. > > This prevents the network device to be registered properly, so fix it. > > Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") > Signed-off-by: Javier Martinez Canillas Looks correct to me as Dan Carpenter submitted the same fix. Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback
The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface") attempted to fix an issue when a new AP interface is added. But the patch didn't check the return value of the functions doing the firmware calls and returned an error even if the functions didn't fail. This prevents the network device to be registered properly, so fix it. Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface") Signed-off-by: Javier Martinez Canillas--- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index 99e8cf1ad610..5de9f63e2c01 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c @@ -2865,9 +2865,11 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy, ret = mwifiex_send_cmd(priv, HostCmd_CMD_SET_BSS_MODE, HostCmd_ACT_GEN_SET, 0, NULL, true); + if (ret) return ERR_PTR(ret); ret = mwifiex_sta_init_cmd(priv, false, false); + if (ret) return ERR_PTR(ret); mwifiex_setup_ht_caps(>bands[NL80211_BAND_2GHZ]->ht_cap, priv); -- 2.5.5 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html