Re: [PATCH] net: wireless: mediatek: fix mt76 LEDS build error

2018-09-19 Thread Randy Dunlap 
On 9/19/18 9:07 AM, Kalle Valo wrote:
> Kalle Valo  writes:
> 
>> Lorenzo Bianconi  writes:
>>
 From: Randy Dunlap 

 All of the mt76 driver options use its mac80211.o component,
 which uses led interfaces, so each of them should depend on
 LEDS_CLASS.

 Fixes this build error:

 drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init':
 drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined
 reference to `devm_of_led_classdev_register'

 Fixes: 17f1de56df05 ("mt76: add common code shared between multiple 
 chipsets")

>>>
>>> Hi Randy,
>>>
>>> a fix for it has been already proposed by Arnd here:
>>> https://marc.info/?l=linux-wireless=151628136830540=2
>>> but it has not been applied yet
>>
>> Yet? Arnd's patch is not on my queue as it's from last January and Felix
>> had a comment for it:
>>
>> https://patchwork.kernel.org/patch/10173197/
> 
> So what should we do? Arnd hasn't submitted a new patch so should we
> take this one instead?

No.  Arnd, can you resend your patch?

thanks,
-- 
~Randy

Re: [PATCH] net: wireless: mediatek: fix mt76 LEDS build error

2018-09-19 Thread Kalle Valo 
Kalle Valo  writes:

> Lorenzo Bianconi  writes:
>
>>> From: Randy Dunlap 
>>> 
>>> All of the mt76 driver options use its mac80211.o component,
>>> which uses led interfaces, so each of them should depend on
>>> LEDS_CLASS.
>>> 
>>> Fixes this build error:
>>> 
>>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init':
>>> drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined
>>> reference to `devm_of_led_classdev_register'
>>> 
>>> Fixes: 17f1de56df05 ("mt76: add common code shared between multiple 
>>> chipsets")
>>> 
>>
>> Hi Randy,
>>
>> a fix for it has been already proposed by Arnd here:
>> https://marc.info/?l=linux-wireless=151628136830540=2
>> but it has not been applied yet
>
> Yet? Arnd's patch is not on my queue as it's from last January and Felix
> had a comment for it:
>
> https://patchwork.kernel.org/patch/10173197/

So what should we do? Arnd hasn't submitted a new patch so should we
take this one instead?

-- 
Kalle Valo

Re: [PATCH] net: wireless: mediatek: fix mt76 LEDS build error

2018-09-07 Thread Kalle Valo 
Lorenzo Bianconi  writes:

>> From: Randy Dunlap 
>> 
>> All of the mt76 driver options use its mac80211.o component,
>> which uses led interfaces, so each of them should depend on
>> LEDS_CLASS.
>> 
>> Fixes this build error:
>> 
>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init':
>> drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined
>> reference to `devm_of_led_classdev_register'
>> 
>> Fixes: 17f1de56df05 ("mt76: add common code shared between multiple 
>> chipsets")
>> 
>
> Hi Randy,
>
> a fix for it has been already proposed by Arnd here:
> https://marc.info/?l=linux-wireless=151628136830540=2
> but it has not been applied yet

Yet? Arnd's patch is not on my queue as it's from last January and Felix
had a comment for it:

https://patchwork.kernel.org/patch/10173197/

-- 
Kalle Valo

Re: [PATCH] net: wireless: mediatek: fix mt76 LEDS build error

2018-09-07 Thread Lorenzo Bianconi 
> From: Randy Dunlap 
> 
> All of the mt76 driver options use its mac80211.o component,
> which uses led interfaces, so each of them should depend on
> LEDS_CLASS.
> 
> Fixes this build error:
> 
> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_led_init':
> drivers/net/wireless/mediatek/mt76/mac80211.c:119: undefined reference to 
> `devm_of_led_classdev_register'
> 
> Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
> 

Hi Randy,

a fix for it has been already proposed by Arnd here:
https://marc.info/?l=linux-wireless=151628136830540=2
but it has not been applied yet

Regards,
Lorenzo