Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-10 Thread Sudip Mukherjee 
On Thu, Jun 11, 2015 at 12:42:23PM +0900, Chris Park wrote:
 size_t should print using %zu, but here it was use %lu.
 we were getting warning while printing.
thanks, I made it to %lu seeing warning in x86_64 but that started
warning in i386. Not this solves warning in both.

regards
sudip
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] staging: wilc1000: fix warning while printing

2015-06-10 Thread Chris Park 
size_t should print using %zu, but here it was use %lu.
we were getting warning while printing.

Signed-off-by: Chris Park chris.p...@atmel.com
---
 drivers/staging/wilc1000/wilc_spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/wilc_spi.c 
b/drivers/staging/wilc1000/wilc_spi.c
index 6d854fd..a43dc9b 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -404,7 +404,7 @@ static int spi_cmd_complete(uint8_t cmd, uint32_t adr, 
uint8_t *b, uint32_t sz,
 #undef NUM_DUMMY_BYTES
 
if (len2  (sizeof(wb) / sizeof(wb[0]))) {
-   PRINT_ER([wilc spi]: spi buffer size too small (%d) (%lu)\n,
+   PRINT_ER([wilc spi]: spi buffer size too small (%d) (%zu)\n,
 len2, (sizeof(wb) / sizeof(wb[0])));
result = N_FAIL;
return result;
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Sudip Mukherjee 
size_t should print using %zu, but here it was using %d and hence we
were getting warning while printing.

Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---

I think it will be easy to remove the other warnings if all the typedefs
are removed first.

 drivers/staging/wilc1000/wilc_spi.c   | 2 +-
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_spi.c 
b/drivers/staging/wilc1000/wilc_spi.c
index d0e7610..6d854fd 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -404,7 +404,7 @@ static int spi_cmd_complete(uint8_t cmd, uint32_t adr, 
uint8_t *b, uint32_t sz,
 #undef NUM_DUMMY_BYTES
 
if (len2  (sizeof(wb) / sizeof(wb[0]))) {
-   PRINT_ER([wilc spi]: spi buffer size too small (%d) (%d)\n,
+   PRINT_ER([wilc spi]: spi buffer size too small (%d) (%lu)\n,
 len2, (sizeof(wb) / sizeof(wb[0])));
result = N_FAIL;
return result;
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c 
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index e9ab2cb..6fdb0d6 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -638,7 +638,7 @@ static void CfgConnectResult(tenuConnDisconnEvent 
enuConnDisconnEvent,
}
 
 
-   PRINT_D(CFG80211_DBG, Association request info elements length 
= %d\n, pstrConnectInfo-ReqIEsLen);
+   PRINT_D(CFG80211_DBG, Association request info elements length 
= %zu\n, pstrConnectInfo-ReqIEsLen);
 
PRINT_D(CFG80211_DBG, Association response info elements 
length = %d\n, pstrConnectInfo-u16RespIEsLen);
 
@@ -778,7 +778,7 @@ static int WILC_WFI_CfgScan(struct wiphy *wiphy, struct 
cfg80211_scan_request *r
}
 
PRINT_D(CFG80211_DBG, Requested num of scan channel %d\n, 
request-n_channels);
-   PRINT_D(CFG80211_DBG, Scan Request IE len =  %d\n, 
request-ie_len);
+   PRINT_D(CFG80211_DBG, Scan Request IE len =  %zu\n, 
request-ie_len);
 
PRINT_D(CFG80211_DBG, Number of SSIDs %d\n, request-n_ssids);
 
@@ -3316,7 +3316,7 @@ static int WILC_WFI_start_ap(struct wiphy *wiphy, struct 
net_device *dev,
priv = wiphy_priv(wiphy);
PRINT_D(HOSTAPD_DBG, Starting ap\n);
 
-   PRINT_D(HOSTAPD_DBG, Interval = %d \n DTIM period = %d\n Head length = 
%d Tail length = %d\n,
+   PRINT_D(HOSTAPD_DBG, Interval = %d \n DTIM period = %d\n Head length = 
%zu Tail length = %zu\n,
settings-beacon_interval, settings-dtim_period, 
beacon-head_len, beacon-tail_len);
 
s32Error = WILC_WFI_CfgSetChannel(wiphy, settings-chandef);
-- 
1.8.1.2

--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Sudip Mukherjee 
On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
 On 06/02, Sudip Mukherjee wrote:
  size_t should print using %zu, but here it was using %d and hence we
  were getting warning while printing.
  
  Signed-off-by: Sudip Mukherjee su...@vectorindia.org
  ---
  
  I think it will be easy to remove the other warnings if all the typedefs
  are removed first.
  
   drivers/staging/wilc1000/wilc_spi.c   | 2 +-
   drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
   2 files changed, 4 insertions(+), 4 deletions(-)
  
  diff --git a/drivers/staging/wilc1000/wilc_spi.c 
  b/drivers/staging/wilc1000/wilc_spi.c
  index d0e7610..6d854fd 100644
  --- a/drivers/staging/wilc1000/wilc_spi.c
  +++ b/drivers/staging/wilc1000/wilc_spi.c
  @@ -404,7 +404,7 @@ static int spi_cmd_complete(uint8_t cmd, uint32_t adr, 
  uint8_t *b, uint32_t sz,
   #undef NUM_DUMMY_BYTES
   
  if (len2  (sizeof(wb) / sizeof(wb[0]))) {
  -   PRINT_ER([wilc spi]: spi buffer size too small (%d) (%d)\n,
  +   PRINT_ER([wilc spi]: spi buffer size too small (%d) (%lu)\n,
 
 Hi, it seems that the above line should use %zu too. Am I correct or I'm
 missing something?
oops. my mistake. %lu is correct but i missed mentioning the warning
about long unsigned int in the commit message.

regards
sudip
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Konrad Zapalowicz 
On 06/02, Sudip Mukherjee wrote:
 size_t should print using %zu, but here it was using %d and hence we
 were getting warning while printing.
 
 Signed-off-by: Sudip Mukherjee su...@vectorindia.org
 ---
 
 I think it will be easy to remove the other warnings if all the typedefs
 are removed first.
 
  drivers/staging/wilc1000/wilc_spi.c   | 2 +-
  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
  2 files changed, 4 insertions(+), 4 deletions(-)
 
 diff --git a/drivers/staging/wilc1000/wilc_spi.c 
 b/drivers/staging/wilc1000/wilc_spi.c
 index d0e7610..6d854fd 100644
 --- a/drivers/staging/wilc1000/wilc_spi.c
 +++ b/drivers/staging/wilc1000/wilc_spi.c
 @@ -404,7 +404,7 @@ static int spi_cmd_complete(uint8_t cmd, uint32_t adr, 
 uint8_t *b, uint32_t sz,
  #undef NUM_DUMMY_BYTES
  
   if (len2  (sizeof(wb) / sizeof(wb[0]))) {
 - PRINT_ER([wilc spi]: spi buffer size too small (%d) (%d)\n,
 + PRINT_ER([wilc spi]: spi buffer size too small (%d) (%lu)\n,

Hi, it seems that the above line should use %zu too. Am I correct or I'm
missing something?

 - konrad

len2, (sizeof(wb) / sizeof(wb[0])));
   result = N_FAIL;
   return result;
 diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c 
 b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
 index e9ab2cb..6fdb0d6 100644
 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
 +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
 @@ -638,7 +638,7 @@ static void CfgConnectResult(tenuConnDisconnEvent 
 enuConnDisconnEvent,
   }
  
  
 - PRINT_D(CFG80211_DBG, Association request info elements length 
 = %d\n, pstrConnectInfo-ReqIEsLen);
 + PRINT_D(CFG80211_DBG, Association request info elements length 
 = %zu\n, pstrConnectInfo-ReqIEsLen);
  
   PRINT_D(CFG80211_DBG, Association response info elements 
 length = %d\n, pstrConnectInfo-u16RespIEsLen);
  
 @@ -778,7 +778,7 @@ static int WILC_WFI_CfgScan(struct wiphy *wiphy, struct 
 cfg80211_scan_request *r
   }
  
   PRINT_D(CFG80211_DBG, Requested num of scan channel %d\n, 
 request-n_channels);
 - PRINT_D(CFG80211_DBG, Scan Request IE len =  %d\n, 
 request-ie_len);
 + PRINT_D(CFG80211_DBG, Scan Request IE len =  %zu\n, 
 request-ie_len);
  
   PRINT_D(CFG80211_DBG, Number of SSIDs %d\n, request-n_ssids);
  
 @@ -3316,7 +3316,7 @@ static int WILC_WFI_start_ap(struct wiphy *wiphy, 
 struct net_device *dev,
   priv = wiphy_priv(wiphy);
   PRINT_D(HOSTAPD_DBG, Starting ap\n);
  
 - PRINT_D(HOSTAPD_DBG, Interval = %d \n DTIM period = %d\n Head length = 
 %d Tail length = %d\n,
 + PRINT_D(HOSTAPD_DBG, Interval = %d \n DTIM period = %d\n Head length = 
 %zu Tail length = %zu\n,
   settings-beacon_interval, settings-dtim_period, 
 beacon-head_len, beacon-tail_len);
  
   s32Error = WILC_WFI_CfgSetChannel(wiphy, settings-chandef);
 -- 
 1.8.1.2
 
 ___
 devel mailing list
 de...@linuxdriverproject.org
 http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: wilc1000: fix warning while printing

2015-06-02 Thread Sudip Mukherjee 
On Tue, Jun 02, 2015 at 10:58:40AM +0200, Konrad Zapalowicz wrote:
 On 06/02, Sudip Mukherjee wrote:
  On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
   On 06/02, Sudip Mukherjee wrote:
size_t should print using %zu, but here it was using %d and hence we
were getting warning while printing.

Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---

I think it will be easy to remove the other warnings if all the typedefs
are removed first.

 drivers/staging/wilc1000/wilc_spi.c   | 2 +-
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_spi.c 
b/drivers/staging/wilc1000/wilc_spi.c
index d0e7610..6d854fd 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -404,7 +404,7 @@ static int spi_cmd_complete(uint8_t cmd, uint32_t 
adr, uint8_t *b, uint32_t sz,
 #undef NUM_DUMMY_BYTES
 
if (len2  (sizeof(wb) / sizeof(wb[0]))) {
-   PRINT_ER([wilc spi]: spi buffer size too small (%d) 
(%d)\n,
+   PRINT_ER([wilc spi]: spi buffer size too small (%d) 
(%lu)\n,
   
   Hi, it seems that the above line should use %zu too. Am I correct or I'm
   missing something?
  oops. my mistake. %lu is correct but i missed mentioning the warning
  about long unsigned int in the commit message.
 
 Why %lu here and %zu in other places? I mean that it is the same size_t
 or I'm missing something?
no, this is unsigned long int.
The warning here was:
drivers/staging/wilc1000/wilc_spi.c:407:3: warning: format ‘%d’ expects 
argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Wformat]

so size_t used %zu and unsigned long int should use %lu

regards
sudip
 
  - konrad
 
  regards
  sudip
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html