Re: [PATCH 05/11 V2] rtlwifi: btcoexist: Change logging in halbtc8192e2ant.c (fwd)

2017-02-01 Thread Julia Lawall
Indeed, there are the four cases where the then and else branches are the
same.  Is it generated code?

julia

-- Forwarded message --
Date: Thu, 2 Feb 2017 06:10:01 +0800
From: kbuild test robot 
To: kbu...@01.org
Cc: Julia Lawall 
Subject: Re: [PATCH 05/11 V2] rtlwifi: btcoexist: Change logging in
halbtc8192e2ant.c

In-Reply-To: <20170120212716.29887-6-larry.fin...@lwfinger.net>

Hi Larry,

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on v4.10-rc6 next-20170201]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Larry-Finger/rtlwifi-Various-updates/20170202-045716
base:   
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git 
master
:: branch date: 72 minutes ago
:: commit date: 73 minutes ago

>> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c:2186:11-13: 
>> WARNING: possible condition with no effect (if == else)
   drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c:2208:11-13: 
WARNING: possible condition with no effect (if == else)
   drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c:2232:11-13: 
WARNING: possible condition with no effect (if == else)
   drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c:2254:11-13: 
WARNING: possible condition with no effect (if == else)

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 2e5b0b84cf4c19a9b761ecbfbcbec52ac35f39da
vim +2186 drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c

2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2170 if (!coex_dm->auto_tdma_adjust) {
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2171 coex_dm->auto_tdma_adjust = true;
2e5b0b84 drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2017-02-01  2172 RT_TRACE(rtlpriv, COMP_BT_COEXIST, 
DBG_LOUD,
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2173  "[BTCoex], first run 
TdmaDurationAdjust()!!\n");
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2174 if (sco_hid) {
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2175 if (tx_pause) {
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2176 if (max_interval == 1) {
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2177 
halbtc8192e2ant_ps_tdma(btcoexist,
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2178 
NORMAL_EXEC,
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2179 
true, 13);
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2180 
coex_dm->tdma_adj_type = 13;
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2181 } else if (max_interval 
== 2) {
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2182 
halbtc8192e2ant_ps_tdma(btcoexist,
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2183 
NORMAL_EXEC,
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2184 
true, 14);
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2185 
coex_dm->tdma_adj_type = 14;
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04 @2186 } else if (max_interval 
== 3) {
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2187 
halbtc8192e2ant_ps_tdma(btcoexist,
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 2014-09-04  2188 
NORMAL_EXEC,
2187e9a2 drivers/net/wireless/rtlwifi/btcoexist/halbtc8192e2ant.c Larry 
Finger 20

Re: [PATCH 05/11 V2] rtlwifi: btcoexist: Change logging in halbtc8192e2ant.c (fwd)

2017-02-01 Thread Larry Finger

On 02/01/2017 04:19 PM, Julia Lawall wrote:

Indeed, there are the four cases where the then and else branches are the
same.  Is it generated code?



I am at least two coding groups removed from the original authors. I have no 
idea how the code was generated. I will fix the problems.


Larry