Re: [PATCH 1/2] brcmfmac: Log chip id and revision

[Arend van Spriel]

On 16-06-17 15:14, Hans de Goede wrote:
> For debugging some problems, it is useful to know the chip revision
> add a brcmf_info message logging this.
> 
> Signed-off-by: Hans de Goede 
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c 
> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> index e03450059b06..4ed40c94bda9 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> @@ -4214,6 +4214,8 @@ struct brcmf_sdio *brcmf_sdio_probe(struct 
> brcmf_sdio_dev *sdiodev)
>   if (ret)
>   goto fail;
>  
> + brcmf_info("Loading firmware %s for chip %08x rev %08x\n",
> +sdiodev->fw_name, bus->ci->chip, bus->ci->chiprev);

I would prefer to have this in brcmf_fw_map_chip_to_name() in
firmware.c, ie.:

brcmf_info("mapping chip %x(%d) rev %d\n", chip, chip, chiprev);

That way it will be done for all host-interfaces.

Regards,
Arend

[PATCH 1/2] brcmfmac: Log chip id and revision

[Hans de Goede]

For debugging some problems, it is useful to know the chip revision
add a brcmf_info message logging this.

Signed-off-by: Hans de Goede 
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c 
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index e03450059b06..4ed40c94bda9 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -4214,6 +4214,8 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev 
*sdiodev)
if (ret)
goto fail;
 
+   brcmf_info("Loading firmware %s for chip %08x rev %08x\n",
+  sdiodev->fw_name, bus->ci->chip, bus->ci->chiprev);
ret = brcmf_fw_get_firmwares(sdiodev->dev, BRCMF_FW_REQUEST_NVRAM,
 sdiodev->fw_name, sdiodev->nvram_name,
 brcmf_sdio_firmware_callback);
-- 
2.13.0