Re: [PATCH 1/2] brmc80211: dont use jiffies for BSS TSF
On Mon, Dec 22, 2014 at 3:26 PM, Arend van Spriel ar...@broadcom.com wrote: On 12/22/14 14:14, Johannes Berg wrote: On Mon, 2014-12-22 at 14:13 +0100, Arend van Spriel wrote: On 12/22/14 13:58, Johannes Berg wrote: By the way - I know now that the proprietary Broadcom driver has the same bug, to the point where this is apparently getting encoded into the Android framework. I urge you to fix this issue there as well. If an absolute last updated timestamp is needed (and last seen [ms] ago isn't sufficient) then new API will be needed. Sorry, seem to have missed the original patches somehow. Guess because it says *brmc*80211. No no - it's a looong time ago and was also applied a long time ago. It just reared it's head again in another place. Found the commit in git log. So you mean the proprietary DHD driver or Android bcmdhd still uses host timestamp. I agree it should be fixed, but I may need some good arguments to convince my co-workers. So what kind of issues are rearing their (ugly) heads? supplicant issues? Basically the Android framework is using the TSF from the scan results as a timestamp for when the BSS was seen. In Android LL a new CTS test was added to verify these values. This of course means the CTS test fails for every vendor besides BRCM :) It seems the framework knows it's a driver bug, since in the java code they explicitly name the variable tsf, before assigning it to the scan result timestamp.. Arik -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] brmc80211: dont use jiffies for BSS TSF
By the way - I know now that the proprietary Broadcom driver has the same bug, to the point where this is apparently getting encoded into the Android framework. I urge you to fix this issue there as well. If an absolute last updated timestamp is needed (and last seen [ms] ago isn't sufficient) then new API will be needed. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] brmc80211: dont use jiffies for BSS TSF
On 12/22/14 13:58, Johannes Berg wrote: By the way - I know now that the proprietary Broadcom driver has the same bug, to the point where this is apparently getting encoded into the Android framework. I urge you to fix this issue there as well. If an absolute last updated timestamp is needed (and last seen [ms] ago isn't sufficient) then new API will be needed. Sorry, seem to have missed the original patches somehow. Guess because it says *brmc*80211. Regards, Arend -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] brmc80211: dont use jiffies for BSS TSF
On Mon, 2014-12-22 at 14:13 +0100, Arend van Spriel wrote: On 12/22/14 13:58, Johannes Berg wrote: By the way - I know now that the proprietary Broadcom driver has the same bug, to the point where this is apparently getting encoded into the Android framework. I urge you to fix this issue there as well. If an absolute last updated timestamp is needed (and last seen [ms] ago isn't sufficient) then new API will be needed. Sorry, seem to have missed the original patches somehow. Guess because it says *brmc*80211. No no - it's a looong time ago and was also applied a long time ago. It just reared it's head again in another place. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] brmc80211: dont use jiffies for BSS TSF
On 12/22/14 14:14, Johannes Berg wrote: On Mon, 2014-12-22 at 14:13 +0100, Arend van Spriel wrote: On 12/22/14 13:58, Johannes Berg wrote: By the way - I know now that the proprietary Broadcom driver has the same bug, to the point where this is apparently getting encoded into the Android framework. I urge you to fix this issue there as well. If an absolute last updated timestamp is needed (and last seen [ms] ago isn't sufficient) then new API will be needed. Sorry, seem to have missed the original patches somehow. Guess because it says *brmc*80211. No no - it's a looong time ago and was also applied a long time ago. It just reared it's head again in another place. Found the commit in git log. So you mean the proprietary DHD driver or Android bcmdhd still uses host timestamp. I agree it should be fixed, but I may need some good arguments to convince my co-workers. So what kind of issues are rearing their (ugly) heads? supplicant issues? Regards, Arend -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
