Re: [PATCH 1/2] nl80211: Use signed function for a signed variable

2017-03-16 Thread Johannes Berg 
On Thu, 2017-03-16 at 10:57 +0900, Masashi Honma wrote:
> The rssi_threshold is defined as s32.
> 
Doesn't really matter much, but does seem nicer - applied.

johannes

[PATCH 1/2] nl80211: Use signed function for a signed variable

2017-03-15 Thread Masashi Honma 
The rssi_threshold is defined as s32.

Signed-off-by: Masashi Honma 
---
 net/wireless/nl80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index b15903b..bd5959f 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -5714,7 +5714,7 @@ static int nl80211_get_mesh_config(struct sk_buff *skb,
   cur_params.dot11MeshGateAnnouncementProtocol) ||
nla_put_u8(msg, NL80211_MESHCONF_FORWARDING,
   cur_params.dot11MeshForwarding) ||
-   nla_put_u32(msg, NL80211_MESHCONF_RSSI_THRESHOLD,
+   nla_put_s32(msg, NL80211_MESHCONF_RSSI_THRESHOLD,
cur_params.rssi_threshold) ||
nla_put_u32(msg, NL80211_MESHCONF_HT_OPMODE,
cur_params.ht_opmode) ||
-- 
2.7.4