Re: [PATCH 107/113] rtl8xxxu: Use define for REG_PWR_DATA bits
Kalle Valo writes: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen >> >> Use the bit define rather than hard code the value for REG_PWR_DATA bits. >> >> Signed-off-by: Jes Sorensen > > [...] > >> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h >> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h >> @@ -135,7 +135,7 @@ >> #define EFUSE_ACCESS_DISABLE 0x00/* RTL8723 only */ >> >> #define REG_PWR_DATA0x0038 >> -#define PWR_DATA_EEPRPAD_RFE_CTRL_ENBIT(11) >> +#define PWR_DATA_EEPRPAD_RFE_CTRL_EN BIT(11) > > Again the two spaces. Is your editor adding them automatically or what? As in the previous email, this is for bit defines, matching the register. The above just made it consistent with the rest of the code. Jes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 107/113] rtl8xxxu: Use define for REG_PWR_DATA bits
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Use the bit define rather than hard code the value for REG_PWR_DATA bits. > > Signed-off-by: Jes Sorensen [...] > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h > @@ -135,7 +135,7 @@ > #define EFUSE_ACCESS_DISABLE0x00/* RTL8723 only */ > > #define REG_PWR_DATA 0x0038 > -#define PWR_DATA_EEPRPAD_RFE_CTRL_EN BIT(11) > +#define PWR_DATA_EEPRPAD_RFE_CTRL_ENBIT(11) Again the two spaces. Is your editor adding them automatically or what? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 107/113] rtl8xxxu: Use define for REG_PWR_DATA bits
From: Jes Sorensen Use the bit define rather than hard code the value for REG_PWR_DATA bits. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c index b5ab899..c7984ab 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c @@ -5996,7 +5996,7 @@ static void rtl8723b_enable_rf(struct rtl8xxxu_priv *priv) rtl8xxxu_write8(priv, 0x0067, val8); val32 = rtl8xxxu_read32(priv, REG_PWR_DATA); - val32 |= BIT(11); + val32 |= PWR_DATA_EEPRPAD_RFE_CTRL_EN; rtl8xxxu_write32(priv, REG_PWR_DATA, val32); /* diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h index a055362..e0b9ea3 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h @@ -135,7 +135,7 @@ #define EFUSE_ACCESS_DISABLE 0x00/* RTL8723 only */ #define REG_PWR_DATA 0x0038 -#define PWR_DATA_EEPRPAD_RFE_CTRL_EN BIT(11) +#define PWR_DATA_EEPRPAD_RFE_CTRL_EN BIT(11) #define REG_CAL_TIMER 0x003c #define REG_ACLK_MON 0x003e -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
