Re: [PATCH v2] ath10k: remove unused variable 'id' in ath10k_pci_tx_pipe_cleanup()

2015-06-09 Thread Kalle Valo
Raja Mani rm...@qti.qualcomm.com writes:

 mete_data is extracted from ce descriptor and stored in variable 'id'.
 later, id is not used anywhere in the same function.

 Fixes: d84a512dca23 (ath10k: remove transfer_id from
 ath10k_hif_cb::tx_completion)

 Signed-off-by: Raja Mani rm...@qti.qualcomm.com

Thanks, applied.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2] ath10k: remove unused variable 'id' in ath10k_pci_tx_pipe_cleanup()

2015-06-02 Thread Raja Mani
mete_data is extracted from ce descriptor and stored in variable 'id'.
later, id is not used anywhere in the same function.

Fixes: d84a512dca23 (ath10k: remove transfer_id from
ath10k_hif_cb::tx_completion)

Signed-off-by: Raja Mani rm...@qti.qualcomm.com
---

V2 changes:
  - added original commit msg detail in commit log which 
introduced this unused variable.

 drivers/net/wireless/ath/ath10k/pci.c |3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/pci.c 
b/drivers/net/wireless/ath/ath10k/pci.c
index 969a123..bbc349a 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1275,7 +1275,6 @@ static void ath10k_pci_tx_pipe_cleanup(struct 
ath10k_pci_pipe *pci_pipe)
struct ath10k_ce_ring *ce_ring;
struct ce_desc *ce_desc;
struct sk_buff *skb;
-   unsigned int id;
int i;
 
ar = pci_pipe-hif_ce_state;
@@ -1299,8 +1298,6 @@ static void ath10k_pci_tx_pipe_cleanup(struct 
ath10k_pci_pipe *pci_pipe)
continue;
 
ce_ring-per_transfer_context[i] = NULL;
-   id = MS(__le16_to_cpu(ce_desc[i].flags),
-   CE_DESC_FLAGS_META_DATA);
 
ar_pci-msg_callbacks_current.tx_completion(ar, skb);
}
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html