Re: [v2, 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

[Kalle Valo]

Ben Greear  wrote:
> From: Ben Greear 
> 
> Otherwise, the txrx-compl-task may access some bad memory?
> 
> Signed-off-by: Ben Greear 

Thanks, 2 patches applied to ath-next branch of ath.git:

de0170beaa88 ath10k: ensure txrx-compl-task is stopped when cleaning htt-tx
6d68f7900d25 ath10k: ensure peer_map references are cleaned up

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/8727831/

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

[Mohammed Shafi Shajakhan]

> >
> >On Fri, Apr 01, 2016 at 02:12:08PM -0700, gree...@candelatech.com wrote:
> >>From: Ben Greear 
> >>
> >>Otherwise, the txrx-compl-task may access some bad memory?
> >
> >good to mention when this happens, will be helpful ifsome one recreates
> >the issue and matches your call trace
> 
> The backtraces were all over the place because the driver was writing to
> memory after it was freed, so I am not sure they are worth while.  I'm sure I 
> posted
> some to the mailing lists around the time where I was working on this, but 
> since
> I was fighting several different problems, hard to know exactly what was what.

[shafi] sure Ben, lets wait for the comments from ath10k reviewers.

> 
> Thanks,
> Ben
> 
> >>Signed-off-by: Ben Greear 
> >>---
> >>  drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >>diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c 
> >>b/drivers/net/wireless/ath/ath10k/htt_tx.c
> >>index 07b960e..58e88d3 100644
> >>--- a/drivers/net/wireless/ath/ath10k/htt_tx.c
> >>+++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
> >>@@ -376,6 +376,8 @@ void ath10k_htt_tx_free(struct ath10k_htt *htt)
> >>  {
> >>int size;
> >>
> >>+   tasklet_kill(>txrx_compl_task);
> >>+
> >>idr_for_each(>pending_tx, ath10k_htt_tx_clean_up_pending, htt->ar);
> >>idr_destroy(>pending_tx);
> >>
> >>--
> >>2.4.3
> >
> >regards,
> >shafi
> >
> >>
> >>
> >>___
> >>ath10k mailing list
> >>ath...@lists.infradead.org
> >>http://lists.infradead.org/mailman/listinfo/ath10k
> >
> >___
> >ath10k mailing list
> >ath...@lists.infradead.org
> >http://lists.infradead.org/mailman/listinfo/ath10k
> >
> 
> -- 
> Ben Greear 
> Candela Technologies Inc  http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

[Ben Greear]

On 05/09/2016 11:48 PM, Mohammed Shafi Shajakhan wrote:

Hi Ben,

On Fri, Apr 01, 2016 at 02:12:08PM -0700, gree...@candelatech.com wrote:

From: Ben Greear 

Otherwise, the txrx-compl-task may access some bad memory?


good to mention when this happens, will be helpful ifsome one recreates
the issue and matches your call trace


The backtraces were all over the place because the driver was writing to
memory after it was freed, so I am not sure they are worth while.  I'm sure I 
posted
some to the mailing lists around the time where I was working on this, but since
I was fighting several different problems, hard to know exactly what was what.

Thanks,
Ben


Signed-off-by: Ben Greear 
---
  drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c 
b/drivers/net/wireless/ath/ath10k/htt_tx.c
index 07b960e..58e88d3 100644
--- a/drivers/net/wireless/ath/ath10k/htt_tx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
@@ -376,6 +376,8 @@ void ath10k_htt_tx_free(struct ath10k_htt *htt)
  {
int size;

+   tasklet_kill(>txrx_compl_task);
+
idr_for_each(>pending_tx, ath10k_htt_tx_clean_up_pending, htt->ar);
idr_destroy(>pending_tx);

--
2.4.3


regards,
shafi




___
ath10k mailing list
ath...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k


___
ath10k mailing list
ath...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k



--
Ben Greear 
Candela Technologies Inc  http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

[Mohammed Shafi Shajakhan]

Hi Ben,

On Fri, Apr 01, 2016 at 02:12:08PM -0700, gree...@candelatech.com wrote:
> From: Ben Greear 
> 
> Otherwise, the txrx-compl-task may access some bad memory?

good to mention when this happens, will be helpful ifsome one recreates
the issue and matches your call trace

> 
> Signed-off-by: Ben Greear 
> ---
>  drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c 
> b/drivers/net/wireless/ath/ath10k/htt_tx.c
> index 07b960e..58e88d3 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_tx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
> @@ -376,6 +376,8 @@ void ath10k_htt_tx_free(struct ath10k_htt *htt)
>  {
>   int size;
>  
> + tasklet_kill(>txrx_compl_task);
> +
>   idr_for_each(>pending_tx, ath10k_htt_tx_clean_up_pending, htt->ar);
>   idr_destroy(>pending_tx);
>  
> -- 
> 2.4.3

regards,
shafi

> 
> 
> ___
> ath10k mailing list
> ath...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

[greearb]

From: Ben Greear 

Otherwise, the txrx-compl-task may access some bad memory?

Signed-off-by: Ben Greear 
---
 drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c 
b/drivers/net/wireless/ath/ath10k/htt_tx.c
index 07b960e..58e88d3 100644
--- a/drivers/net/wireless/ath/ath10k/htt_tx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
@@ -376,6 +376,8 @@ void ath10k_htt_tx_free(struct ath10k_htt *htt)
 {
int size;
 
+   tasklet_kill(>txrx_compl_task);
+
idr_for_each(>pending_tx, ath10k_htt_tx_clean_up_pending, htt->ar);
idr_destroy(>pending_tx);
 
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html